[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

JonasToth added inline comments. Comment at: clang-tidy/performance/ForRangeCopyCheck.cpp:50 + const auto VarType = Var->getType(); + if (std::find_if(WhiteListTypes.begin(), WhiteListTypes.end(), + [&](llvm::StringRef WhiteListType) { balogha

[PATCH] D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler

peter.smith updated this revision to Diff 167955. peter.smith added a comment. Updated diff to add more tests, including some that use -mlittle-endian when the target is big-endian. https://reviews.llvm.org/D52784 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/linux-as.c Index: test/Dri

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

zturner added a comment. Canyou add a test that demonstrates that multiple input files on the command line will print all of them? Also does this really need to be a cc1 arg? Why not just print it in the driver? https://reviews.llvm.org/D52773 _

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

zturner added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; steveire wrote: > hans

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

rnk accepted this revision. rnk added a comment. I support continuing our practice of being silent by default, and not implementing anything like the noisy default version banner printing that MSVC does, or this filename printing. I think setting this flag is something for cmake or the VS integ

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

sidorovd added a comment. @Anastasia , since there is a problem I described, wouldn't you mind if I stay with the first iteration of the patch (adding the extension to OpenCLExtensions.def) and after we'll investigate what is wrong with -cl-ext approach? https://reviews.llvm.org/D51402 ___

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. //Ping Ping// Repository: rC Clang https://reviews.llvm.org/D52058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r343602 - clang-format: better handle statement macros

Author: typz Date: Tue Oct 2 09:37:51 2018 New Revision: 343602 URL: http://llvm.org/viewvc/llvm-project?rev=343602&view=rev Log: clang-format: better handle statement macros Summary: Some macros are used in the body of function, and actually contain the trailing semicolon: they should thus be

[PATCH] D33440: clang-format: better handle statement macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL343602: clang-format: better handle statement macros (authored by Typz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D33440?vs=158308&id=167

[PATCH] D52675: [clang] Properly apply attributes on explicit instantiations of static data members

rnk accepted this revision. rnk added a comment. This code dates back to https://reviews.llvm.org/rL187762, which added this check. I think it should always pass for a variable template, but it fails for an explicit instantiation of a static data member of a class template. I think it's correct

[PATCH] D52412: OpenCL: Mark printf format string argument

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Sorry I missed this somehow. https://reviews.llvm.org/D52412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:755 +if (It->is(tok::l_paren)) { + while ((++It)->isNot(tok::r_paren)) { +assert(It->isNot(tok::eof) && donat.nagy wrote: > I fear that this doe

[PATCH] D52787: [analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions as parameter

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, xazax.hun, whisperity. I intend to add a new flag `macro-expnasions-as-events`, and unfortunately I'll only be able to convert the macro p

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:5286 -static bool TryOCLZeroQueueInitialization(Sema &S, - InitializationSequence &Sequence, - QualType DestType, -

[PATCH] D52787: [analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions as parameter

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fair enough! Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:306-307 + const FIDMap& FM, + const Preprocessor &PP, +

[PATCH] D52789: [clangd] Dex: FALSE iterator, peephole optimizations, fix AND bug

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric. The FALSE iterator will be used in a followup patch to fix a logic bug in Dex (currently, tokens that don't have posting lists in the in

[PATCH] D52377: [HIP] Support early finalization of device code for -fno-gpu-rdc

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D52377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h

Anastasia added a comment. Does it mean we should close https://reviews.llvm.org/D32896? Would it make sense to keep this value as Clang implementation and if vendors need to change this they can `undef` it and redefine a new value. Would this work? Repository: rC Clang https://reviews.llv

[clang-tools-extra] r343608 - [clangd] Don't make check-clangd as a dependency in check-clang-tools

Author: hokein Date: Tue Oct 2 10:22:11 2018 New Revision: 343608 URL: http://llvm.org/viewvc/llvm-project?rev=343608&view=rev Log: [clangd] Don't make check-clangd as a dependency in check-clang-tools Summary: check-clang-tools will run check-clangd first, and then run the rest tests. If clangd

[PATCH] D52781: [clangd] Don't make check-clangd as a dependency in check-clang-tools

This revision was automatically updated to reflect the committed changes. Closed by commit rL343608: [clangd] Don't make check-clangd as a dependency in check-clang-tools (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D52598: [OpenCL] Fixed address space cast in C style cast of C++ parsing

Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2283 + const QualType &SrcType, + const QualType &DestType) { + // OpenCL v1 s6.5: Casting a pointer to address space A to a pointer to --

[clang-tools-extra] r343610 - Revert r343589 "[clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC"

Author: rnk Date: Tue Oct 2 10:31:43 2018 New Revision: 343610 URL: http://llvm.org/viewvc/llvm-project?rev=343610&view=rev Log: Revert r343589 "[clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC" Declaring a field with the same name as a type causes GCC to error out: D

[PATCH] D52791: [Diagnostics] Check for misleading variable declarations

xbolva00 created this revision. xbolva00 added a reviewer: rsmith. Herald added a subscriber: cfe-commits. void foo() { char* a, b; // warn that b is not a pointer type as someone may expect } Fixes PR39150 (also I see a request for this checker on GCC Bugzilla) Repository: rC Clang http

[PATCH] D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h

sidorovd added a comment. In https://reviews.llvm.org/D52658#1252744, @Anastasia wrote: > Does it mean we should close https://reviews.llvm.org/D32896? Yes In https://reviews.llvm.org/D52658#1252744, @Anastasia wrote: > Would it make sense to keep this value as Clang implementation and if ven

Re: [clang-tools-extra] r343589 - [clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC

I reverted this in r343610 because I noticed many bots were failing to build after this change. Declaring the field `Corpus Corpus;` upsets GCC. I considered trying to pick a different field name, but I wasn't able to come up with one I liked, so I'm punting it back to you. =/ On Tue, Oct 2, 2018

[PATCH] D52791: [Diagnostics] Check for misleading variable declarations

xbolva00 updated this revision to Diff 167978. xbolva00 added a comment. - Avoid possible crash https://reviews.llvm.org/D52791 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaStmt.cpp test/Sema/misleading-var-type-decl.c Index: test/Sema/misleading-var-type-decl.c ==

[PATCH] D52787: [analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions as parameter

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:306-307 + const FIDMap& FM, + const Preprocessor &PP, + AnalyzerOptions &AnOpts) { + ReportPiece(o, P, FM, PP, AnOpts, /*in

r343611 - [HIP] Support early finalization of device code for -fno-gpu-rdc

Author: yaxunl Date: Tue Oct 2 10:48:54 2018 New Revision: 343611 URL: http://llvm.org/viewvc/llvm-project?rev=343611&view=rev Log: [HIP] Support early finalization of device code for -fno-gpu-rdc This patch renames -f{no-}cuda-rdc to -f{no-}gpu-rdc and keeps the original options as aliases. Whe

[PATCH] D52377: [HIP] Support early finalization of device code for -fno-gpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rC343611: [HIP] Support early finalization of device code for -fno-gpu-rdc (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D52377 Files: include/clang/Basic/LangOpti

[PATCH] D52533: [test] Use --sysroot instead of -B in print-multi-directory.c

mstorsjo added a comment. Ping @jroelofs or someone else willing to have a look Repository: rC Clang https://reviews.llvm.org/D52533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D52791: [Diagnostics] Check for misleading variable declarations

erik.pilkington added a comment. Thanks for working on this! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:318-320 +def warn_misleading_var_type_decl : Warning< + "misleading variable declaration, supposed to be a pointer type instead ?">, + InGroup>; ---

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

steveire updated this revision to Diff 167984. steveire added a comment. Add docs Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 Files: clang-query/Query.cpp clang-query/QueryParser.cpp unittests/clang-query/QueryParserTest.cpp Index: unittests/clang-query/QueryPa

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

steveire added a comment. In https://reviews.llvm.org/D52746#1252455, @aaron.ballman wrote: > Please update `HelpQuery::run()` to print out the new mnemonic (it's the > *only* form of public documentation we have for clang-query currently). Good point, thanks! Repository: rCTE Clang Tools

[PATCH] D52791: [Diagnostics] Check for misleading variable declarations

xbolva00 updated this revision to Diff 167985. xbolva00 added a comment. - Addressed review comments https://reviews.llvm.org/D52791 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaStmt.cpp test/Sema/misleading-pointer-decl.c Index: test/Sema/misleading-pointer-decl.c ===

[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

steveire updated this revision to Diff 167987. steveire added a comment. use cxx_range_for Repository: rC Clang https://reviews.llvm.org/D52751 Files: lib/ASTMatchers/Dynamic/Parser.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp Index: unittests/ASTMatchers/Dynamic/ParserTest.cpp ===

[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

steveire marked an inline comment as done. steveire added inline comments. Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:188-190 + for (size_t i = 0, e = Sema.Errors.size(); i != e; ++i) { +EXPECT_EQ("", Sema.Errors[i]); + } aaron.ballman wrote:

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

steveire added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; zturner wrote: > ztur

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

boga95 updated this revision to Diff 167991. boga95 marked 7 inline comments as done. https://reviews.llvm.org/D52281 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp clang-tidy/modernize/Replac

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

zturner added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; steveire wrote: > ztur

[PATCH] D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149)

JonasToth added inline comments. Comment at: clang-tidy/utils/ExprSequence.cpp:103 for (const Stmt *Parent : getParentStmts(S, Context)) { +// For statements that have multiple parents, make sure we're using the +// parent that lies within the sub-tree under Root.

[PATCH] D52742: [analyzer][PlistMacroExpansion] Part 1.: New expand-macros flag

Szelethus updated this revision to Diff 167992. Szelethus retitled this revision from "[analyzer][WIP] Add macro expansions to the plist output" to "[analyzer][PlistMacroExpansion] Part 1.: New expand-macros flag". Szelethus edited the summary of this revision. Szelethus removed reviewers: xazax.

[PATCH] D52794: [analyzer][PlistMacroExpansion] Part 2.: Retrieving the macro name and primitive expansion

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, rnkovacs, dkrupp, whisperity, martong, baloghadamsoftware. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, xazax.hun. Szelethus added a dependency: D52742: [analyzer][PlistMacroExpansion]

r343618 - [OpenMP][NVPTX] Simplify codegen for orphaned parallel, NFCI.

Author: hahnfeld Date: Tue Oct 2 12:12:54 2018 New Revision: 343618 URL: http://llvm.org/viewvc/llvm-project?rev=343618&view=rev Log: [OpenMP][NVPTX] Simplify codegen for orphaned parallel, NFCI. Worker threads fork off to the compiler generated worker function directly after entering the kernel

r343617 - [OpenMP] Simplify code for reductions on distribute directives, NFC.

Author: hahnfeld Date: Tue Oct 2 12:12:47 2018 New Revision: 343617 URL: http://llvm.org/viewvc/llvm-project?rev=343617&view=rev Log: [OpenMP] Simplify code for reductions on distribute directives, NFC. Only need to care about the 'distribute simd' case, all other composite directives are handle

[PATCH] D52731: [OpenMP] Simplify code for reductions on distribute directives, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343617: [OpenMP] Simplify code for reductions on distribute directives, NFC. (authored by Hahnfeld, committed by ). Repository: rC Clang https://reviews.llvm.org/D52731 Files: lib/CodeGen/CGStmtOpen

[PATCH] D52732: [OpenMP][NVPTX] Simplify codegen for orphaned parallel, NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343618: [OpenMP][NVPTX] Simplify codegen for orphaned parallel, NFCI. (authored by Hahnfeld, committed by ). Repository: rC Clang https://reviews.llvm.org/D52732 Files: lib/CodeGen/CGOpenMPRuntimeNV

[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

lebedev.ri added inline comments. Comment at: lib/Parse/ParseStmt.cpp:237 +SourceLocation SemiLocation = ConsumeToken(); +if (!HasLeadingEmptyMacro && getCurScope()->isCompoundStmtScope() && +!SemiLocation.isMacroID()) { rsmith wrote: > I'm a litt

[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

lebedev.ri updated this revision to Diff 168000. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Thank you for taking a look! - Move it into `ParseCompoundStatementBody()`, thus fixing false-positives with `case X: ;` e.g. - Rename to `-Wextra-semi-stmt` - Add `-Wempty-i

RE: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

Hi Eric, One of the tests you added in this commit is causing a failure on the PS4 Windows bot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20347/steps/test/logs/stdio: FAIL: Extra Tools Unit Tests :: clangd/./ClangdTests.exe/ClangdTests.PreambleVF

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

lebedev.ri added a comment. @rsmith Ping. Though, https://reviews.llvm.org/D50901 is less controversial, so maybe best to start there.. Repository: rC Clang https://reviews.llvm.org/D50250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r343620 - [analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions as parameter

Author: szelethus Date: Tue Oct 2 12:27:34 2018 New Revision: 343620 URL: http://llvm.org/viewvc/llvm-project?rev=343620&view=rev Log: [analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions as parameter I intend to add a new flag macro-expnasions-as-events, and unfortuna

[PATCH] D52787: [analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions as parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rC343620: [analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions… (authored by Szelethus, committed by ). Repository: rC Clang https://reviews.llvm.org/D52787 Files: lib/Stati

[PATCH] D52787: [analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions as parameter

Szelethus added a comment. I'll probably do something with this parameter spaghetti, it bothers me too, but maybe in a separate patch :) Repository: rC Clang https://reviews.llvm.org/D52787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52733: [OpenMP][NVPTX] Avoid data sharing if in parallel region

Hahnfeld added a comment. In https://reviews.llvm.org/D52733#1251421, @ABataev wrote: > It might lead to increased register pressure, isn't it? Currently, I'm trying > to emit the code that can be optimized out and, thus, may decrease the > register pressure. That's why I tried to reduce the nu

[PATCH] D52733: [OpenMP][NVPTX] Avoid data sharing if in parallel region

ABataev added a comment. In https://reviews.llvm.org/D52733#1252963, @Hahnfeld wrote: > In https://reviews.llvm.org/D52733#1251421, @ABataev wrote: > > > It might lead to increased register pressure, isn't it? Currently, I'm > > trying to emit the code that can be optimized out and, thus, may de

[PATCH] D52796: [clangd] Simplify Dex query tree logic and fix missing-posting-list bug

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric. The bug being fixed: when a posting list doesn't exist in the index, it was previously just dropped from the query rather than being tre

[PATCH] D52733: [OpenMP][NVPTX] Avoid data sharing if in parallel region

Hahnfeld added a comment. In https://reviews.llvm.org/D52733#1252966, @ABataev wrote: > In https://reviews.llvm.org/D52733#1252963, @Hahnfeld wrote: > > > In https://reviews.llvm.org/D52733#1251421, @ABataev wrote: > > > > > It might lead to increased register pressure, isn't it? Currently, I'm

[clang-tools-extra] r343622 - Reland r343589 "[clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC""

Author: sammccall Date: Tue Oct 2 12:59:23 2018 New Revision: 343622 URL: http://llvm.org/viewvc/llvm-project?rev=343622&view=rev Log: Reland r343589 "[clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC"" This reverts commit r343610. Modified: clang-tools-extra/trunk

[clang-tools-extra] r343623 - [clangd] Try to fix windows buildbot after r343576

Author: ioeric Date: Tue Oct 2 13:00:32 2018 New Revision: 343623 URL: http://llvm.org/viewvc/llvm-project?rev=343623&view=rev Log: [clangd] Try to fix windows buildbot after r343576 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20347/steps/test/logs/s

Re: [clang-tools-extra] r343589 - [clangd] Dex: add Corpus factory for iterators, rename, fold constant. NFC

Oops, thanks! This one always gets me. I couldn't think of a good name either, but here qualifying the type (dex::Corpus) should work. Re-landed as r343622 On Tue, Oct 2, 2018 at 7:34 PM Reid Kleckner wrote: > I reverted this in r343610 because I noticed many bots were failing to > build after t

Re: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

Hi Douglas, Thanks for letting me know! The test seemed to be too strict for windows. r343623 is an attempt to fix. If it still doesn't work, feel free to revert the commits, and I'll re-investigate on Thursday. - Eric On Tue, Oct 2, 2018 at 9:25 PM wrote: > Hi Eric, > > One of the tests you a

[PATCH] D52798: [cl-compat] Change /JMC from unsupported to ignored.

zturner created this revision. zturner added reviewers: rnk, thakis. Herald added subscribers: JDevlieghere, aprantl. This command line option doesn't really affect generated code, only generated debug info, and it's set by default in newer versions of VS, so it's annoying to have to turn it off

[PATCH] D52798: [cl-compat] Change /JMC from unsupported to ignored.

rnk added a comment. lgtm Can you file a bug about implementing /JMC and link it from the commit message? https://reviews.llvm.org/D52798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

lebedev.ri added inline comments. Comment at: clang-tidy/performance/ForRangeCopyCheck.cpp:50 + const auto VarType = Var->getType(); + if (std::find_if(WhiteListTypes.begin(), WhiteListTypes.end(), + [&](llvm::StringRef WhiteListType) { JonasT

[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:164 +def ExtraSemiStmt : DiagGroup<"extra-semi-stmt">; +def EmptyInitStatement : DiagGroup<"empty-init-stmt">; def ExtraSemi : DiagGroup<"extra-semi", [CXX98CompatExtraSemi, I thin

[PATCH] D52798: [cl-compat] Change /JMC from unsupported to ignored.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL343629: [cl-compat] Change /JMC from unsupported to ignored. (authored by zturner, committed by ). Herald added a subscrib

r343629 - [cl-compat] Change /JMC from unsupported to ignored.

Author: zturner Date: Tue Oct 2 13:42:36 2018 New Revision: 343629 URL: http://llvm.org/viewvc/llvm-project?rev=343629&view=rev Log: [cl-compat] Change /JMC from unsupported to ignored. A tracking bug for actually implementing this in clang-cl is at https://bugs.llvm.org/show_bug.cgi?id=39156.

[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

lebedev.ri updated this revision to Diff 168017. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. - Moved `-Wempty-init-stmt` into `-Wextra-semi-stmt` - Moved `-Wextra-semi-stmt` out of `-Wextra-semi` - Tentatively enabled `-Wextra-semi-stmt` in `-Wextra` (and removed `-We

[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

lebedev.ri added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:167-168 + CXX11ExtraSemi, + ExtraSemiStmt, + EmptyInitStatement]>; -

[PATCH] D52800: Java import sorting in clang-format

SamMaier created this revision. Herald added subscribers: cfe-commits, mgrang, mgorny, srhines. This is for https://bugs.chromium.org/p/chromium/issues/detail?id=768983 - however it will be useful for anyone using clang-format for Java, not just Chromium. Repository: rC Clang https://review

r343631 - [analyzer] Fix symbol discovery in nonloc::LocAsInteger values.

Author: dergachev Date: Tue Oct 2 13:48:12 2018 New Revision: 343631 URL: http://llvm.org/viewvc/llvm-project?rev=343631&view=rev Log: [analyzer] Fix symbol discovery in nonloc::LocAsInteger values. Doesn't do much despite sounding quite bad, but fixes an exotic test case where liveness of a non

[PATCH] D52667: [analyzer] Fix conversion from LocAsInteger to Loc symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343631: [analyzer] Fix symbol discovery in nonloc::LocAsInteger values. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D52667 Files: lib/StaticAnalyzer/Core/SV

r343632 - [analyzer] Promote StdCLibraryFunctionsChecker to the apiModeling category.

Author: dergachev Date: Tue Oct 2 13:50:40 2018 New Revision: 343632 URL: http://llvm.org/viewvc/llvm-project?rev=343632&view=rev Log: [analyzer] Promote StdCLibraryFunctionsChecker to the apiModeling category. Because all our languages are C-based, there's no reason to enable this checker only

[PATCH] D52722: [analyzer] Move StdCLibraryFunctions to apiModeling

This revision was automatically updated to reflect the committed changes. Closed by commit rL343632: [analyzer] Promote StdCLibraryFunctionsChecker to the apiModeling category. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

lebedev.ri updated this revision to Diff 168020. lebedev.ri added a comment. Slightly improved test coverage for macros in `extra-semi-resulting-in-nullstmt-in-init-statement.cpp` Repository: rC Clang https://reviews.llvm.org/D52695 Files: docs/ReleaseNotes.rst include/clang/Basic/Diagn

[PATCH] D52727: [clang-tidy] White List Option for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

JonasToth added a comment. True Am 02.10.2018 um 22:28 schrieb Roman Lebedev via Phabricator: > lebedev.ri added inline comments. > > > Comment at: clang-tidy/performance/ForRangeCopyCheck.cpp:50 > + const auto VarType = Var->getType(); > + if (std::find_if(WhiteListTypes.

[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

lebedev.ri added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:770 +NullPointerArithmetic, +ExtraSemiStmt ]>; I'm really unsure of this. Maybe this should only be `EmptyInitStatement`. Repository: rC Clang https://reviews.ll

r343636 - [analyzer] [tests] Allow specifying entire -analyze-config on the command line, make sure it's always propagated

Author: george.karpenkov Date: Tue Oct 2 14:19:23 2018 New Revision: 343636 URL: http://llvm.org/viewvc/llvm-project?rev=343636&view=rev Log: [analyzer] [tests] Allow specifying entire -analyze-config on the command line, make sure it's always propagated Differential Revision: https://reviews.l

[PATCH] D52756: [analyzer] Fix crash in exploded graph dumping

This revision was automatically updated to reflect the committed changes. Closed by commit rC343635: [analyzer] Fix crash in exploded graph dumping (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D52756?vs=

r343635 - [analyzer] Fix crash in exploded graph dumping

Author: george.karpenkov Date: Tue Oct 2 14:19:01 2018 New Revision: 343635 URL: http://llvm.org/viewvc/llvm-project?rev=343635&view=rev Log: [analyzer] Fix crash in exploded graph dumping By allocating new DeclStmt to ASTContext Differential Revision: https://reviews.llvm.org/D52756 Modified:

[PATCH] D52801: [analyzer] [tests] Allow specifying entire -analyze-config on the command line, make sure it's always propagated

This revision was automatically updated to reflect the committed changes. Closed by commit rC343636: [analyzer] [tests] Allow specifying entire -analyze-config on the command line… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: h

[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from some naming and style convention nits, LGTM. Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:151 Sema.parse(" Foo ( Bar ( 17), Baz( \n \"

[PATCH] D52752: [clang-query] Add comment token handling

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit. Comment at: clang-query/QueryParser.cpp:42 +End = Begin; +return StringRef(Begin, 0); + } This is just re

[PATCH] D52804: [analyzer] NFC: RetainCountChecker: Avoid dumping symbols during normal operation.

NoQ created this revision. NoQ added reviewers: dcoughlin, george.karpenkov. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. The checker was trying to produce a separate `ProgramPointTag` for every dead symbol it cleans up, so

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52804: [analyzer] NFC: RetainCountChecker: Avoid dumping symbols during normal operation.

george.karpenkov added a comment. This should also prevent leaks. Repository: rC Clang https://reviews.llvm.org/D52804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r342827 - Fix modules build with shared library.

On Mon, Oct 1, 2018 at 4:58 PM Richard Smith wrote: > On Mon, 1 Oct 2018 at 16:10, George Karpenkov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi Richard, >> >> On Oct 1, 2018, at 2:50 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >> This looks like

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

aaron.ballman added a comment. In https://reviews.llvm.org/D52398#1251894, @aaronpuchert wrote: > @delesley Any objections to this? > > It's certainly useful for our code base, because our `assert`-like macros use > `__builtin_expect`, but I'm not sure if that applies to the general public. I

[clang-tools-extra] r343637 - [clangd] Temporarily disable VFS stats cache test for windows.

Author: ioeric Date: Tue Oct 2 14:47:41 2018 New Revision: 343637 URL: http://llvm.org/viewvc/llvm-project?rev=343637&view=rev Log: [clangd] Temporarily disable VFS stats cache test for windows. Modified: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp Modified: clang-tools-extra/t

Re: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

It didn't seem to work. I have temporarily disabled the test for windows (r343637). On Tue, Oct 2, 2018 at 10:05 PM Eric Liu wrote: > Hi Douglas, > > Thanks for letting me know! The test seemed to be too strict for windows. > r343623 is an attempt to fix. If it still doesn't work, feel free to r

r343641 - Remove spurious assertion in -Wdocumentation

Author: rnk Date: Tue Oct 2 15:23:27 2018 New Revision: 343641 URL: http://llvm.org/viewvc/llvm-project?rev=343641&view=rev Log: Remove spurious assertion in -Wdocumentation Some code in OpenCV uses interesting doxygen directives that make it so we don't see any tokens inside a @note, despite th

[PATCH] D52806: [python] Support overriding library path via environment

mgorny created this revision. mgorny added reviewers: jbcoe, arphaman, frutiger. Support a new CLANG_LIBRARY_PATH environment variable within the Python bindings. This variable can be used to force the bindings to load libclang.* from a specific directory without having to explicitly read the pat

[PATCH] D52806: [python] Support overriding library path via environment

mgorny updated this revision to Diff 168042. mgorny added a comment. (also included README update) https://reviews.llvm.org/D52806 Files: bindings/python/README.txt bindings/python/clang/cindex.py Index: bindings/python/clang/cindex.py =

r343643 - [analyzer] [tests] Hotfix: missing space

Author: george.karpenkov Date: Tue Oct 2 15:31:44 2018 New Revision: 343643 URL: http://llvm.org/viewvc/llvm-project?rev=343643&view=rev Log: [analyzer] [tests] Hotfix: missing space Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trunk/utils/analyzer/SATestBuild.py URL: ht

[PATCH] D52800: Java import sorting in clang-format

mgrang added inline comments. Comment at: lib/Format/Format.cpp:1856 + } + std::sort(Indices.begin(), Indices.end(), [&](unsigned LHSI, unsigned RHSI) { +// Negating IsStatic to push static imports above non-static imports. Please use llvm::sort instead

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

mgrang abandoned this revision. mgrang added a comment. Will abandon this patch since I have implementations of these which I will upstream soon. https://reviews.llvm.org/D51204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D52807: [COFF, ARM64] Add _InterlockedCompareExchangePointer_nf intrinsic

mgrang created this revision. mgrang added reviewers: rnk, mstorsjo, compnerd, TomTan, haripul. Herald added subscribers: jfb, chrib, kristof.beyls. Repository: rC Clang https://reviews.llvm.org/D52807 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/ms-intr

[PATCH] D52808: [cland] Dex: fix/simplify trigram generation

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, ilya-biryukov. 1. Instead of a$$ for a short-query trigram, just use a 2. Generate more short-query trigrams, e.g. "AbcDefGhi" now yields "d" and "ag".

[PATCH] D52807: [COFF, ARM64] Add _InterlockedCompareExchangePointer_nf intrinsic

rnk added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3003 + case Builtin::BI_InterlockedCompareExchangePointer: + case Builtin::BI_InterlockedCompareExchangePointer_nf: { llvm::Type *RTy; Is the no fence version really equivalent to this seq_cs

[PATCH] D52808: [cland] Dex: fix/simplify trigram generation

sammccall updated this revision to Diff 168049. sammccall added a comment. Update comment, revert unintended change Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52808 Files: clangd/index/dex/Trigram.cpp clangd/index/dex/Trigram.h unittests/clangd/DexTests.cpp Index: un

<    1   2   3   >