Szelethus added inline comments.
================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:306-307
+ const FIDMap& FM,
+ const Preprocessor &PP,
+ AnalyzerOptions &AnOpts) {
+ ReportPiece(o, P, FM, PP, AnOpts, /*indent*/ 4, /*depth*/ 0,
----------------
NoQ wrote:
> Maybe just make this function non-`static` instead of passing members around
> manually?
That would probably be super-invasive for this file, from what I'm seeing. I
might end up doing that, but this would mean pretty much a complete refactoring.
To be honest, almost all functions here should be a method, the output stream,
`FIDMap`, `Preprocessor`, `AnalyzerOptions` could all be left out.
Repository:
rC Clang
https://reviews.llvm.org/D52787
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
