aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a minor nit. ================ Comment at: clang-query/QueryParser.cpp:42 + End = Begin; + return StringRef(Begin, 0); + } ---------------- This is just returning an empty `StringRef`, isn't it? Might as well return `StringRef()` through the default constructor for clarity. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52752 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
