Author: sylvestre
Date: Sat Sep 22 00:39:44 2018
New Revision: 342801
URL: http://llvm.org/viewvc/llvm-project?rev=342801&view=rev
Log:
update the links to use https
Modified:
cfe/trunk/www/get_started.html
Modified: cfe/trunk/www/get_started.html
URL:
http://llvm.org/viewvc/llvm-project/cf
Author: sylvestre
Date: Sat Sep 22 00:41:09 2018
New Revision: 342802
URL: http://llvm.org/viewvc/llvm-project?rev=342802&view=rev
Log:
use the current url for bugzilla
Modified:
cfe/trunk/www/cxx_status.html
cfe/trunk/www/get_involved.html
cfe/trunk/www/menu.html.incl
Modified: cfe/
mate1214 created this revision.
mate1214 added reviewers: NoQ, george.karpenkov, dcoughlin.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin,
szepet, mgorny.
Add StackSizeChecker to StaticAnalyzer
This checker can be used to warn about potential stack overflows
steveire added a comment.
@JonasToth Sorry, I don't know what's unclear. I'm so surprised by your
question that I think maybe I'm missing something. I thought the commit message
and the patch itself are clear. Am I missing something?
Currently you can only build clang-tidy if you build the stat
lebedev.ri added a comment.
`#ifdef` hell is usually messy and is a source of problems.
May i ask what is the motivation for this change?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52334
___
cfe-commits mailing list
cfe-commits@
Szelethus added a comment.
Hi!
Always great to see a new checker! I've started working in this project little
over half a year ago, so I don't claim to be an expert, read my remarks as
such! It'll be some time before I go through the entire code, but so far here
are the things that caught my e
JonasToth added a comment.
In https://reviews.llvm.org/D52334#1242811, @steveire wrote:
> @JonasToth Sorry, I don't know what's unclear. I'm so surprised by your
> question that I think maybe I'm missing something. I thought the commit
> message and the patch itself are clear. Am I missing some
JonasToth added inline comments.
Comment at: unittests/Analysis/ExprMutationAnalyzerTest.cpp:156
EXPECT_THAT(mutatedBy(Results, AST.get()), ElementsAre("x.mf()"));
+
+ AST = tooling::buildASTFromCode(
shuaiwang wrote:
> JonasToth wrote:
> > JonasToth wrote:
>
steveire added a comment.
> But that clang-tidy is deactivated totally makes that impossible :)
Yes. That should be clear by reading the patch.
> Some of the clang-tidy stuff relies on Analysis/* from clang as well, e.g.
> the CFG class. Is this still included in builds with CSA off?
The `Anal
JonasToth added a comment.
>> Some of the clang-tidy stuff relies on Analysis/* from clang as well, e.g.
>> the CFG class. Is this still included in builds with CSA off?
>
> The `Analysis` includes are ifdef'd out in the patch. Have you read the patch?
Yes I did read the patch. `bugprone-use-af
wgml marked 6 inline comments as done.
wgml added inline comments.
Comment at: clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:52
+const NamespaceContextVec &Namespaces) {
+ std::ostringstream Result;
+ bool First = true;
aaron.ballman wrote:
> wgml wr
wgml updated this revision to Diff 166602.
wgml marked an inline comment as done.
wgml added a comment.
Updated signature of `concatNamespaces`.
https://reviews.llvm.org/D52136
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp
clang-tidy/moder
Szelethus added subscribers: rnkovacs, baloghadamsoftware.
Szelethus added a comment.
I think the idea for a checker like this is great! I left some inline comments,
but most of them are minor nits. I have some general remarks to make however:
- Your code lacks comments, especially a nice docume
steveire added a comment.
Thanks, that at least makes it more obvious where you are getting confused.
See `tools/clang/lib/CMakeLists.txt`. It contains:
add_subdirectory(Analysis)
...
===
if(CLANG_ENABLE_STATIC_ANALYZER)
add_subdirectory(StaticAnalyzer)
endif()
1. That is: Analysis and St
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StackSizeChecker.cpp:104
+ ProgramStateRef State = C.getState();
+ auto StackLevels = State->get();
+ if (length(StackLevels) != countPredecessors(C))
Szelethus wrote:
> It isn't obvious
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StackSizeChecker.cpp:19
+#include "clang/AST/StmtCXX.h"
+#include "clang/StaticAnalyzer/Checkers/StackUsageMeasuringVisitor.h"
+#include "clang/StaticAnalyzer/Core/AnalyzerOptions.h"
Szeleth
boga95 updated this revision to Diff 166604.
https://reviews.llvm.org/D52281
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp
clang-tidy/modernize/ReplaceGenericFunctorCallCheck.h
docs/Release
lebedev.ri added a comment.
Without seeing the full picture (i.e. what you want to do with the clang-tidy
check) it is hard to tell,
but are you *very* sure all this logic should be in
`clang/lib/StaticAnalyzer/`, and not in `clang/lib/Analysis/` ?
Repository:
rC Clang
https://reviews.llvm.
EricWF added inline comments.
Herald added a subscriber: libcxx-commits.
Comment at: lib/abi/x86_64-unknown-linux-gnu.v1.abilist:1195
{'name': '_ZNSt3__16__clocEv', 'is_defined': True, 'type': 'FUNC'}
+{'name': '_ZNSt3__16__itoa8__u64toaEmPc', 'is_defined': True, 'type': 'FUNC'}
EricWF added a comment.
In https://reviews.llvm.org/D45179#1241721, @lebedev.ri wrote:
> In https://reviews.llvm.org/D45179#1225911, @EricWF wrote:
>
> > I don't think it ever landed. I'll try to get it in this week.
>
>
> What does this need?
> Is there some changes missing still?
> Or this si
lebedev.ri added a comment.
In https://reviews.llvm.org/D45179#1242896, @EricWF wrote:
> In https://reviews.llvm.org/D45179#1241721, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D45179#1225911, @EricWF wrote:
> >
> > > I don't think it ever landed. I'll try to get it in this week.
> >
> >
craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.
Herald added a subscriber: cfe-commits.
Previously we used a select and the zero_undef=true intrinsic. In -O2 this
pattern will get optimized to zero_undef=false. But in -O0 this optimization
won't happen. This re
lichray created this revision.
lichray added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, ldionne, christof.
They are introduced in r338479; their Linux ABI changes are recorded in r338486.
TODO: Record the Mac OS X ABI changes.
Repository:
rCXX libc++
https://reviews.llvm.o
EricWF accepted this revision.
EricWF added a comment.
@lebedev.ri Sure, be my guest. It frees me up to do reviews. Thank you.
I just finished running the test suite, so it should be good to go.
https://reviews.llvm.org/D45179
___
cfe-commits maili
lebedev.ri commandeered this revision.
lebedev.ri removed a reviewer: lebedev.ri.
lebedev.ri added a comment.
In https://reviews.llvm.org/D45179#1242915, @EricWF wrote:
> @lebedev.ri Sure, be my guest. It frees me up to do reviews. Thank you.
Np.
> I just finished running the test suite, so it
shuaiwang added inline comments.
Comment at: unittests/Analysis/ExprMutationAnalyzerTest.cpp:156
EXPECT_THAT(mutatedBy(Results, AST.get()), ElementsAre("x.mf()"));
+
+ AST = tooling::buildASTFromCode(
JonasToth wrote:
> shuaiwang wrote:
> > JonasToth wrote:
>
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks
Repository:
rCXX libc++
https://reviews.llvm.org/D52391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX342808: [libc++] Add _LIBCPP_ENABLE_NODISCARD and
_LIBCPP_NODISCARD_EXT to allow pre… (authored by lebedevri, committed by ).
Herald added subscribers: libcxx-commits, ldionne.
Repository:
rCXX libc++
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342808: [libc++] Add _LIBCPP_ENABLE_NODISCARD and
_LIBCPP_NODISCARD_EXT to allow pre… (authored by lebedevri, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45179?vs=154724&id=166607
ldionne created this revision.
ldionne added a reviewer: EricWF.
Herald added subscribers: cfe-commits, dexonsmith, chrib, christof.
Repository:
rUNW libunwind
https://reviews.llvm.org/D52393
Files:
libunwind/src/Registers.hpp
Index: libunwind/src/Registers.hpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX342810: Document new symbols for __u64toa and __u32toa
(authored by lichray, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52391?vs=166605&id=166610#toc
Repository:
rCXX libc++
ldionne updated this revision to Diff 166613.
ldionne added a comment.
Remove the change to the Darwin ABI list file, which was meant for a different
commit.
Repository:
rCXX libc++
https://reviews.llvm.org/D52394
Files:
libcxx/lib/abi/CMakeLists.txt
Index: libcxx/lib/abi/CMakeLists.txt
ldionne created this revision.
ldionne added reviewers: dim, EricWF.
Herald added subscribers: libcxx-commits, cfe-commits, dexonsmith, christof,
krytarowski, mgorny, emaste.
ldionne updated this revision to Diff 166613.
ldionne added a comment.
Remove the change to the Darwin ABI list file, whic
Author: ldionne
Date: Sat Sep 22 11:18:34 2018
New Revision: 342811
URL: http://llvm.org/viewvc/llvm-project?rev=342811&view=rev
Log:
[libunwind][NFC] Suppress unused parameter warnings
Reviewers: EricWF
Subscribers: christof, chrib, dexonsmith, cfe-commits
Differential Revision: https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342811: [libunwind][NFC] Suppress unused parameter warnings
(authored by ldionne, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52393?vs=166
JonasToth added a comment.
In https://reviews.llvm.org/D52334#1242881, @steveire wrote:
> Thanks, that at least makes it more obvious where you are getting confused.
>
> See `tools/clang/lib/CMakeLists.txt`. It contains:
>
> add_subdirectory(Analysis)
> # ...
> if(CLANG_ENABLE_STATIC_ANALYZ
Author: ctice
Date: Sat Sep 22 11:25:58 2018
New Revision: 342812
URL: http://llvm.org/viewvc/llvm-project?rev=342812&view=rev
Log:
Fix codemodels.c test case (only test mcmodel=medium on X86).
aarch64 testing is broken because "medium" is not a valid
code-model on aarch64, and codemodels.c tests
JonasToth added a comment.
TDD, thats ok ;)
Am 22.09.2018 um 19:37 schrieb Shuai Wang via Phabricator:
> shuaiwang added inline comments.
>
>
> Comment at: unittests/Analysis/ExprMutationAnalyzerTest.cpp:156
>
> EXPECT_THAT(mutatedBy(Results, AST.get()), ElementsAre("x.mf()
aaronpuchert created this revision.
aaronpuchert added reviewers: aaron.ballman, delesley.
Herald added a subscriber: cfe-commits.
When passing by reference, we check if the reference is const-qualified
and if it isn't, we demand an exclusive lock. Unlike checking const
qualifiers on member functi
ldionne created this revision.
ldionne added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, cfe-commits, dexonsmith, christof.
This is the counterpart for https://reviews.llvm.org/D50130 and
https://reviews.llvm.org/D52391 on Darwin.
Repository:
rCXX libc++
https://reviews.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342813: [libcxx] Fix the definition of the check-cxx-abilist
target on Darwin (authored by ldionne, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
JonasToth added inline comments.
Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:70
+ if (MFunctor && MFunctor->isTypeDependent()) {
+const auto *Paren = static_cast(MFunctor->getCallee());
+const auto *BinOp =
Eugene.Zelenko wrote:
>
dim added a comment.
Ah, sorry about that! I should have realized this, but my CMake-fu is weak. :)
Repository:
rL LLVM
https://reviews.llvm.org/D52394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
devnexen added a comment.
ping :)
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:275
+os << "sizeof(" << DstName << ")";
+ else
+os << "sizeof()";
Why can't this `else if` case be folded into the `strlcpy` case? There are lots
aaronpuchert added a comment.
> Any changes should always be done by adding or removing entries from the
> FactSet, not by mutating the underlying FactEntries.
To make that clearer in the code, I made `FactEntry`s immutable that are
managed by `FactManager` in https://reviews.llvm.org/rC342787.
Author: aaronpuchert
Date: Sat Sep 22 14:56:16 2018
New Revision: 342823
URL: http://llvm.org/viewvc/llvm-project?rev=342823&view=rev
Log:
Eliminate some unneeded signed/unsigned conversions
No functional change is intended, but generally this should be a bit
more safe.
Modified:
cfe/trunk/i
ldionne created this revision.
ldionne added reviewers: phosek, EricWF.
Herald added subscribers: libcxx-commits, cfe-commits, dexonsmith, christof,
mgorny.
The ABI version used by libc++ is a configuration option just like any other
configuration option. It is a knob that can be used by vendors
Author: maskray
Date: Sat Sep 22 15:49:38 2018
New Revision: 342825
URL: http://llvm.org/viewvc/llvm-project?rev=342825&view=rev
Log:
[Index] Fix header guard naming
Modified:
cfe/trunk/include/clang/Index/USRGeneration.h
Modified: cfe/trunk/include/clang/Index/USRGeneration.h
URL:
http://l
kristina marked 3 inline comments as done.
kristina added a comment.
Want to see what @rnk has to say about this before landing it since he wrote
the original code and if my understanding of `common` vs `dso_local` is
accurate or not since I don't have much experience with the Windows specific
aaronpuchert created this revision.
aaronpuchert added reviewers: aaron.ballman, delesley.
Herald added subscribers: cfe-commits, kristina.
When people are really sure they'll get the lock they sometimes use
__builtin_expect. It's also used by some assertion implementations.
Asserting that try-loc
ldionne added a comment.
In https://reviews.llvm.org/D45639#1242444, @phosek wrote:
> In https://reviews.llvm.org/D45639#1193112, @ldionne wrote:
>
> > @phosek I don't understand how you can expect code compiled with new
> > headers to link against an old dylib, unless you're setting the target
ldionne updated this revision to Diff 166621.
ldionne added a comment.
Clarify that version 2 of the ABI is _currently_ unstable, it is not _the_
unstable version.
Repository:
rCXX libc++
https://reviews.llvm.org/D52397
Files:
libcxx/CMakeLists.txt
libcxx/include/__config
Index: libcx
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM and has been committed -- you can close this.
https://reviews.llvm.org/D47395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
kristina added a comment.
I think on Darwin it would **not** make sense to have `libc++fs.a` ship in
`libc++.dylib` especially considering that it ends up in the dyld cache and
that has a lot of other implications. It would make sense to ship it as a
separate library, perhaps as part of the SDK
ldionne added a comment.
In https://reviews.llvm.org/D45639#1243017, @kristina wrote:
> I think on Darwin it would **not** make sense to have `libc++fs.a` ship in
> `libc++.dylib` especially considering that it ends up in the dyld cache and
> that has a lot of other implications. It would make
Author: ericwf
Date: Sat Sep 22 17:48:05 2018
New Revision: 342827
URL: http://llvm.org/viewvc/llvm-project?rev=342827&view=rev
Log:
Fix modules build with shared library.
r341994 caused clangAnalysis to pull all of the AST matchers
library into clang. Due to inline key functions in the headers,
trong created this revision.
trong added reviewers: srhines, nickdesaulniers.
Herald added a reviewer: javed.absar.
Herald added subscribers: jfb, kristof.beyls.
Making X[8-15,18] registers call-saved is used to support
CONFIG_ARM64_LSE_ATOMICS in Linux kernel.
Signed-off-by: Tri Vo
Repository
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, dblaikie.
Currently, we do not check for enumerators that shadow other enumerators as
part of -Wshadow, but gcc does provide such a diagnostic for this case. This
is intended to catch shadowing issues like:
enum E1{e
devnexen added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:275
+os << "sizeof(" << DstName << ")";
+ else
+os << "sizeof()";
MaskRay wrote:
> Why can't this `else if` case be folded into the `strlcpy` cas
MaskRay created this revision.
MaskRay added reviewers: EricWF, mclow.lists.
Herald added subscribers: libcxx-commits, cfe-commits, ldionne, christof.
If ptr is a null pointer, no action shall occur.
Repository:
rCXX libc++
https://reviews.llvm.org/D52401
Files:
src/new.cpp
Index: src/ne
MaskRay updated this revision to Diff 166625.
MaskRay edited the summary of this revision.
MaskRay added a comment.
.
Repository:
rCXX libc++
https://reviews.llvm.org/D52401
Files:
src/new.cpp
Index: src/new.cpp
===
--- src/
devnexen updated this revision to Diff 166626.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
63 matches
Mail list logo
