JonasToth added a comment. In https://reviews.llvm.org/D52334#1242811, @steveire wrote:
> @JonasToth Sorry, I don't know what's unclear. I'm so surprised by your > question that I think maybe I'm missing something. I thought the commit > message and the patch itself are clear. Am I missing something? > > Currently you can only build clang-tidy if you build the static analyzer. > > This patch fixes that so that even if you do not build the static analyzer, > you can build clang-tidy. That is the purpose of this patch, as in the title. > > Am I missing something? Or did I misunderstand your comment? Sorry for formulating it unclear. I was curious if you could currently break the clang-tidy builds if you deactivate building CSA and that it might result in some dangling stuff or build errors. But that clang-tidy is deactivated totally makes that impossible :) I agree with @lebedev.ri that `#ifdef` in code might be a problem because its not constantly checked if the build still works if the analyzer is turned off and you might get bitrot. Some of the clang-tidy stuff relies on `Analysis/*` from clang as well, e.g. the CFG class. Is this still included in builds with CSA off? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
