dberris created this revision.
dberris added reviewers: mboerger, tejohnson.
Add a test and ensure that we propagate the
-fxray-instrumentation-bundle flag from the driver invocation to the
-cc1 options.
https://reviews.llvm.org/D52342
Files:
clang/include/clang/Basic/XRayInstr.h
clang/lib/
yvvan added a comment.
You're right actually. The fix is much simpler than I expected :)
https://reviews.llvm.org/D52261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yvvan updated this revision to Diff 166407.
yvvan added a comment.
Provide CorrectedBase = Base for C code
https://reviews.llvm.org/D52261
Files:
lib/Parse/ParseExpr.cpp
test/CodeCompletion/member-access.c
Index: test/CodeCompletion/member-access.c
pirama abandoned this revision.
pirama added a comment.
Herald added subscribers: libcxx-commits, jfb.
This file is not built for WIN32.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D48742
___
cfe-commits mailing list
cfe-commits@lists.ll
JonasToth added a comment.
Do builds even work properly if the CSA is not build right now?
Comment at: clang-tidy/tool/CMakeLists.txt:32
clangTidyModernizeModule
- clangTidyMPIModule
clangTidyObjCModule
Is the MPI module remove from the list of available
lebedev.ri added inline comments.
Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:27-32
+ // template
+ // void f(T func) {
+ // func();
+ // ^~~
+ // ::std::invoke(func, 1)
+ Finder->addMatcher(callExpr(has(declRefExpr())).bind("functor"), thi
baloghadamsoftware added a comment.
I still wonder what true positives could we get without checking the size? No
real-life types come to my mind with size of a pointer but really expensive
copy operations. What could be so really expensive when copying a single
machine world?
Repository:
r
Anastasia added inline comments.
Comment at: lib/Sema/Sema.cpp:1856
+std::string Sema::getOpenCLExtensionsFromDeclExtMap(FunctionDecl *FD) {
+ if (!OpenCLDeclExtMap.empty())
sidorovd wrote:
> Anastasia wrote:
> > Is this function to be used for both `OpenCLDec
AlexeySachkov added inline comments.
Comment at: include/clang/Basic/OpenCLExtensionTypes.def:27
+
+INTEL_SGAVC_TYPE(mce_payload_t, McePayload)
+INTEL_SGAVC_TYPE(ime_payload_t, ImePayload)
Anastasia wrote:
> AlexeySotkin wrote:
> > Anastasia wrote:
> > > AlexeySa
lebedev.ri added a comment.
In https://reviews.llvm.org/D52315#1241487, @baloghadamsoftware wrote:
> I still wonder what true positives could we get without checking the size? No
> real-life types come to my mind with size of a pointer but really expensive
> copy operations. What could be so re
mboerger accepted this revision.
mboerger added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D52342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
dberris updated this revision to Diff 166410.
dberris added a comment.
Move the test to the driver, more appropriate location.
https://reviews.llvm.org/D52342
Files:
clang/include/clang/Basic/XRayInstr.h
clang/lib/Driver/XRayArgs.cpp
clang/test/Driver/XRay/xray-instrumentation-bundles-fla
mboerger accepted this revision.
mboerger added a comment.
LGTM
https://reviews.llvm.org/D52342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev added a comment.
@sammccall thank you for the comments, I'll improve it. @ilya-biryukov also
provided valuable feedback and suggested that the code looks complicated now.
We also discussed different compression approach which would require storing
`Head`s and `Payload`s separately so t
Author: dberris
Date: Fri Sep 21 01:32:49 2018
New Revision: 342715
URL: http://llvm.org/viewvc/llvm-project?rev=342715&view=rev
Log:
[XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1
Summary:
Add a test and ensure that we propagate the
-fxray-instrumentation-bundle flag from the driv
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342715: [XRay][clang] Propagate
-fxray-instrumentation-bundle to -cc1 (authored by dberris, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52342?vs=166410&id=166412#toc
Repository:
ioeric added a comment.
In https://reviews.llvm.org/D52273#1241281, @sammccall wrote:
> This seems very clever, but extremely complicated - you've implemented much
> of C++'s conversion logic, it's not clear to me which parts are actually
> necessary to completion quality.
> (Honestly this app
ioeric added a comment.
Could you move the corresponding tests from clangd to sema?
Comment at: lib/Sema/SemaCodeComplete.cpp:3063
+CodeCompletionString *
+CodeCompletionResult::CreateCodeCompletionString(ASTContext &Ctx,
+ Prepro
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342717: [CodeGen] Add to emitted DebugLoc information about
coverage when it's required (authored by calixte, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49916?vs=164860&id=166416
kristina created this revision.
kristina added reviewers: rnk, echristo, clang, rjmccall.
Herald added a subscriber: cfe-commits.
Attempt to unbreak behavior caused by https://reviews.llvm.org/D44491 resulting
in inability to build standalone/unbridged CoreFoundation on an ELF target with
`-fcon
SjoerdMeijer added a comment.
(I am now picking this up, and will try to progress this patch and also
https://reviews.llvm.org/D50179)
> Do you expect that the regression tests will be affected by the TargetParser
> fixes?
No, and that's exactly the reason why it would be nice to get this in.
sidorovd updated this revision to Diff 166425.
sidorovd added a comment.
getOpenCLExtensionsFromTypeExtMap was added
https://reviews.llvm.org/D52292
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/Sema.cpp
lib/Sema/SemaOverload.cpp
test/SemaOpenCL/
AlexeySachkov updated this revision to Diff 166423.
AlexeySachkov added a comment.
Updated patch with new functionality and tests
https://reviews.llvm.org/D51484
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/OperationKinds.def
include/clang/AST/Type.h
SjoerdMeijer added a comment.
Ah, and just for your info, the proposal was just sent to the dev list:
http://lists.llvm.org/pipermail/llvm-dev/2018-September/126346.html
Repository:
rC Clang
https://reviews.llvm.org/D50229
___
cfe-commits mailin
kristina added a comment.
Does appear to work properly:
cfstring:002AC640 off_2AC640 dq offset
__CFConstantStringClassReference
cfstring:002AC640 ; DATA
XREF: skipDTD+19D↑o
cfstring:002AC640
SjoerdMeijer updated this revision to Diff 166439.
SjoerdMeijer retitled this revision from "+fp16fml feature for ARM and AArch64"
to "[ARM][AArch64] Add feature +fp16fml".
SjoerdMeijer edited the summary of this revision.
SjoerdMeijer added a comment.
Added FIXMEs.
https://reviews.llvm.org/D50
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM!
https://reviews.llvm.org/D52261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: yvvan
Date: Fri Sep 21 04:23:22 2018
New Revision: 342721
URL: http://llvm.org/viewvc/llvm-project?rev=342721&view=rev
Log:
[CodeComplete] Generate completion fix-its for C code as well
Current completion fix-its approach does not provide OtherOpBase for C code.
But we can easily proceed
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342721: [CodeComplete] Generate completion fix-its for C
code as well (authored by yvvan, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52261
Files:
lib/Parse/ParseExpr.cpp
test/C
lebedev.ri added a comment.
In https://reviews.llvm.org/D45179#1225911, @EricWF wrote:
> I don't think it ever landed. I'll try to get it in this week.
What does this need?
Is there some changes missing still?
Or this simply needs to be committed (and bots watched?)
https://reviews.llvm.org/D
takuto.ikuta updated this revision to Diff 166448.
takuto.ikuta edited the summary of this revision.
takuto.ikuta added a comment.
Remove unnecessary willHaveBody check condition
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Opt
takuto.ikuta updated this revision to Diff 166450.
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Driver/CLCompatOptions.td
clang/lib/Driver/ToolChains/Clang.cpp
clang/lib/Frontend/CompilerInvoc
kbobyrev updated this revision to Diff 166453.
kbobyrev marked 9 inline comments as done.
kbobyrev added a comment.
I addressed the easiest issues. I'll try to implement separate storage
structure for `Head`s and `Payload`s which would potentially make the
implementation cleaner and easier to un
ioeric added a comment.
In https://reviews.llvm.org/D52300#1241754, @kbobyrev wrote:
> Also, I'll refine https://reviews.llvm.org/D52047 a little bit and I believe
> that is should be way easier to understand performance + memory consumption
> once we have these benchmarks in. Both @ioeric and
lebedev.ri added a comment.
In https://reviews.llvm.org/D52300#1241776, @ioeric wrote:
> In https://reviews.llvm.org/D52300#1241754, @kbobyrev wrote:
>
> > Also, I'll refine https://reviews.llvm.org/D52047 a little bit and I
> > believe that is should be way easier to understand performance + me
riccibruno added a comment.
In https://reviews.llvm.org/D52268#1241033, @rjmccall wrote:
> `LinkageComputer` isn't actually persisted anywhere, right? And there's
> maybe one computer active at once? So this compression is theoretically
> saving one pointer of stack space but forcing a bunch
kbobyrev updated this revision to Diff 166462.
kbobyrev marked 4 inline comments as done.
kbobyrev added a comment.
Use `llvm::Expected`, cleanup the patch.
https://reviews.llvm.org/D52047
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/clangd/index/Serializa
Author: brunoricci
Date: Fri Sep 21 05:53:22 2018
New Revision: 342729
URL: http://llvm.org/viewvc/llvm-project?rev=342729&view=rev
Log:
[AST] Various optimizations + refactoring in DeclarationName(Table)
Introduce the following optimizations in DeclarationName(Table):
1. Store common kinds inl
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342729: [AST] Various optimizations + refactoring in
DeclarationName(Table) (authored by brunoricci, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52267
Files:
include/clang/AST/Dec
Hahnfeld added a comment.
IMO the current logic makes sense for the end user, prioritizing the
environment guess over default paths. I think the tests should be fixed using
`--cuda-path-ignore-env`, I remember I added this parameter to fix the failing
tests when I wrote the code.
Repository:
Author: ioeric
Date: Fri Sep 21 06:04:57 2018
New Revision: 342730
URL: http://llvm.org/viewvc/llvm-project?rev=342730&view=rev
Log:
[clangd] Remember to serialize symbol origin in YAML.
Modified:
clang-tools-extra/trunk/clangd/index/SymbolYAML.cpp
clang-tools-extra/trunk/unittests/clangd
Author: brunoricci
Date: Fri Sep 21 06:11:39 2018
New Revision: 342731
URL: http://llvm.org/viewvc/llvm-project?rev=342731&view=rev
Log:
[AST][NFC] Remove a superfluous enum in ObjCMethodDeclBitfields added in r338641
I originally added this enum to avoid including Basic/IdentifierTable.h
in AST/
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:81
+// Same for the next "benchmark".
+// FIXME(kbobyrev): Should this be separated into the BackingMemorySize
+// (underlying SymbolSlab size) and Symbol Index (MemIndex/Dex) overh
kbobyrev created this revision.
kbobyrev added a reviewer: ioeric.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
`Dex` should utilize `FuzzyFindRequest.RestrictForCodeCompletion` flags and
omit symbols not meant for code completion wh
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:27
+Token(Token::Kind::Sentinel, "Restricted For Code Completion");
+static const Token NotRestrictedForCodeCompletion =
+Token(Token::Kind::Sentinel, "Not Restricted For Code Completion"
lebedev.ri added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:81
+// Same for the next "benchmark".
+// FIXME(kbobyrev): Should this be separated into the BackingMemorySize
+// (underlying SymbolSlab size) and Symbol Index (MemIndex/Dex) ove
patricklyster created this revision.
patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice,
kkwli0, hfinkel, gtbercea.
patricklyster added projects: clang, OpenMP.
Herald added subscribers: cfe-commits, jfb, guansong, jholewinski.
Add support for new OMP5.0 `requires` dire
Author: jfb
Date: Fri Sep 21 06:54:09 2018
New Revision: 342734
URL: http://llvm.org/viewvc/llvm-project?rev=342734&view=rev
Log:
NFC: deduplicate isRepeatedBytePattern from clang to LLVM's isBytewiseValue
Summary:
This code was in CGDecl.cpp and really belongs in LLVM. It happened to have
isByt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342734: NFC: deduplicate isRepeatedBytePattern from clang to
LLVM's isBytewiseValue (authored by jfb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.o
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D52359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: brunoricci
Date: Fri Sep 21 07:03:32 2018
New Revision: 342735
URL: http://llvm.org/viewvc/llvm-project?rev=342735&view=rev
Log:
[AST][NFC] DeclarationName.h : add missing parentheses to silence warnings
Some bots are complaining about missing parentheses in assertions added in
r342729: [
kbobyrev updated this revision to Diff 166474.
kbobyrev marked an inline comment as done.
kbobyrev edited the summary of this revision.
kbobyrev added a comment.
`RestirctForCodeCompletion` and `!RestrictForCodeCompletion` are not mutually
exclusive.
https://reviews.llvm.org/D52357
Files:
cl
jkorous abandoned this revision.
jkorous added a comment.
Allright, I will remove destructor from clangd completion results which solves
this particular issue.
Also good point about return type being used in ranking - I incorrectly assumed
it's just a presentational matter.
Repository:
rC C
baloghadamsoftware created this revision.
baloghadamsoftware added reviewers: alexfh, aaron.ballman, flx.
baloghadamsoftware added a project: clang-tools-extra.
baloghadamsoftware added a comment.
This is an alternative approach to https://reviews.llvm.org/D52315.
The three checks mentioned in t
baloghadamsoftware added a comment.
This is an alternative approach to https://reviews.llvm.org/D52315.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
probinson added a comment.
Do we generate the .dwo file directly these days? If not, I can imagine
wanting to avoid the overhead of the objcopy hack; as long as the linker is
smart enough not to bother with the .debug_*.dwo sections this seems like a
build-time win.
https://reviews.llvm.org/
Author: abataev
Date: Fri Sep 21 07:22:53 2018
New Revision: 342738
URL: http://llvm.org/viewvc/llvm-project?rev=342738&view=rev
Log:
[OPENMP][NVPTX] Enable support for lastprivates in SPMD constructs.
Previously we could not use lastprivates in SPMD constructs, patch
allows supporting lastprivat
grimar added a comment.
We want to take the benefit that debug fission provides, but keep the debug
information in the objects.
That is a bit less intrusive way than using regular split dwarf flow.
For a regular build and debug cycle that allows the linker to do minimal
processing of the .debug
lebedev.ri added a reviewer: lebedev.ri.
lebedev.ri added a comment.
Better, but these blacklists need to be config options, not random hardcoded
globs.
See e.g. `google-runtime-references.WhiteListTypes`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52360
Author: calixte
Date: Fri Sep 21 02:17:06 2018
New Revision: 342717
URL: http://llvm.org/viewvc/llvm-project?rev=342717&view=rev
Log:
[CodeGen] Add to emitted DebugLoc information about coverage when it's required
Summary:
Some lines have a hit counter where they should not have one.
Cleanup stuf
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:184
+ // Filter symbols which are not indexed for code completion.
+ if (Req.RestrictForCodeCompletion)
---
kbobyrev updated this revision to Diff 166481.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
- Be more explicit about the nature of "benchmarks" with memory tracking logic
via `State::SetLabel(...)`.
- Force single iteration for "benchmarks" with memory usage tracking
- Add
kbobyrev updated this revision to Diff 166482.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D52357
Files:
clang-tools-extra/clangd/index/dex/Dex.cpp
clang-tools-extra/unittests/clangd/DexTests.cpp
Index: clang-tools-extra/unittests/clangd/DexTests.cpp
kbobyrev closed this revision.
kbobyrev added a comment.
I think this one is addressed in the VByte patch, so I'm closing this revision
in order to prevent conflicts between these two.
https://reviews.llvm.org/D52084
___
cfe-commits mailing list
cf
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/PostingList.cpp:29
+ DecompressedChunk = ChunkIndex->decompress();
+ InnerIndex = begin(DecompressedChunk);
+}
sammccall wrote:
> nit: we generally use members (Decompres
Author: abataev
Date: Fri Sep 21 07:55:26 2018
New Revision: 342741
URL: http://llvm.org/viewvc/llvm-project?rev=342741&view=rev
Log:
[OPENMP] Disable emission of the class with vptr if they are not used in
target constructs.
Prevent compilation of the classes with the virtual tables when
compili
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I really like this idea in general, thank you for proposing this patch!
Comment at: clang/include/clang/Basic/Fea
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Whoops, that acceptance was accidental. Pretending I want changes just to make
it clear in Phab. :-)
Repository:
rC Clang
https://reviews.llvm.org/D52339
___
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:78
+static void DexQueries(benchmark::State &State) {
+ const auto Dex = buildDex();
Why did we move this benchmark (`DexQueries`)? It seems unnecessary.
===
sammccall added a comment.
In https://reviews.llvm.org/D52300#1241754, @kbobyrev wrote:
> I addressed the easiest issues. I'll try to implement separate storage
> structure for `Head`s and `Payload`s which would potentially make the
> implementation cleaner and easier to understand (and also mo
tejohnson added a comment.
Note that if you add a line like:
"Depends on https://reviews.llvm.org/D52322"; in the summary that Phabricator
will automatically link the two in the right way.
Comment at: lib/CodeGen/CodeGenModule.cpp:569
+ .Default(~0u);
+if
sammccall requested changes to this revision.
sammccall added a comment.
This revision now requires changes to proceed.
This change does several things, and I think most of them need further thought.
Can we discuss Monday?
Comment at: clang-tools-extra/clangd/benchmarks/IndexB
jfb added a comment.
I think we should consider proposing this to the C committee. @aaron.ballman I
can help Erik write the paper, would you be able to present it? Too tight for
the upcoming meeting, but I'm guessing we have *plenty* of time for ++C17.
Repository:
rC Clang
https://reviews.l
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
When no scope qualifier is specified, allow completing index symbols
from any scope and insert proper automatically. This is still experime
aaron.ballman added a comment.
In https://reviews.llvm.org/D52339#1242086, @jfb wrote:
> I think we should consider proposing this to the C committee. @aaron.ballman
> I can help Erik write the paper, would you be able to present it? Too tight
> for the upcoming meeting, but I'm guessing we hav
cmtice marked an inline comment as done.
cmtice added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:569
+ .Default(~0u);
+if ((CM != ~0u) && (CM != ~1u)) {
+ llvm::CodeModel::Model codeModel =
static_cast(CM);
tejohnson wro
cmtice updated this revision to Diff 166492.
cmtice edited the summary of this revision.
cmtice added a comment.
Move include statement from CodeGenModule.h to CodeGenModule.cpp
Remove incorrect "default" case statement.
Add test for "tiny" code model.
https://reviews.llvm.org/D52323
Files:
jfb added a comment.
In https://reviews.llvm.org/D52339#1242103, @aaron.ballman wrote:
> In https://reviews.llvm.org/D52339#1242086, @jfb wrote:
>
> > I think we should consider proposing this to the C committee.
> > @aaron.ballman I can help Erik write the paper, would you be able to
> > prese
aaron.ballman added a comment.
In https://reviews.llvm.org/D52339#1242118, @jfb wrote:
> In https://reviews.llvm.org/D52339#1242103, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D52339#1242086, @jfb wrote:
> >
> > > I think we should consider proposing this to the C committee.
> > > @
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Parse/ParseTemplate.cpp:949-950
GreaterThanIsOperatorScope G(GreaterThanIsOperator, false);
-if (Tok.isNot(tok::greater) && Tok.isNot(tok::
grimar added a comment.
To summarise:
- It shares most of the benefits with the .dwo solution.
- Unlike .dwo, there is no need to split the file and it is friendlier to other
tools (ccache, distcc, etc)
- But unlike .dwo a distributed build system has to copy larger .o files.
https://reviews.l
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:27-32
+ // template
+ // void f(T func) {
+ // func();
+ // ^~~
+ // ::std::invoke(func, 1)
+ Finder->addMatcher(callExpr(has(declRefExpr())).bind("functor"),
Author: tra
Date: Fri Sep 21 10:29:33 2018
New Revision: 342749
URL: http://llvm.org/viewvc/llvm-project?rev=342749&view=rev
Log:
[CUDA] Ignore uncallable functions when we check for usual deallocators.
Previously clang considered function variants from both sides of
compilation and that resulted
pirama created this revision.
pirama added reviewers: EricWF, srhines, mstorsjo.
Herald added subscribers: libcxx-commits, ldionne, christof.
Mark it as unused to avoid -Wunused-parameter.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
Files:
src/private_typeinfo.cpp
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342749: [CUDA] Ignore uncallable functions when we check for
usual deallocators. (authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
erik.pilkington added a comment.
In https://reviews.llvm.org/D52339#1242126, @aaron.ballman wrote:
> In https://reviews.llvm.org/D52339#1242118, @jfb wrote:
>
> > In https://reviews.llvm.org/D52339#1242103, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D52339#1242086, @jfb wrote:
>
Author: jfb
Date: Fri Sep 21 10:38:41 2018
New Revision: 342750
URL: http://llvm.org/viewvc/llvm-project?rev=342750&view=rev
Log:
[NFC] remove unused variable
It was causing a warning.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
UR
tra updated this revision to Diff 166509.
tra added a comment.
Added '>=' and '>>=' to the list of tokens that may indicate the end of the
empty template argument list.
https://reviews.llvm.org/D52321
Files:
clang/lib/Parse/ParseTemplate.cpp
clang/test/Parser/cuda-kernel-call-c++11.cu
cla
erik.pilkington added inline comments.
Comment at: clang/include/clang/Basic/Features.def:90
FEATURE(objc_default_synthesize_properties, LangOpts.ObjC2)
-FEATURE(objc_fixed_enum, LangOpts.ObjC2)
+FEATURE(objc_fixed_enum, true)
FEATURE(objc_instancetype, LangOpts.ObjC2)
aaron.ballman added a comment.
In https://reviews.llvm.org/D52339#1242202, @erik.pilkington wrote:
> From the last line in the paper, it seems that C++ compatibility is a goal of
> the paper (or at least a consideration). We should probably think about this
> if/when the final wording gets acce
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D52323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: tra
Date: Fri Sep 21 10:46:28 2018
New Revision: 342752
URL: http://llvm.org/viewvc/llvm-project?rev=342752&view=rev
Log:
[CUDA] Fixed parsing of optional template-argument-list.
We need to consider all tokens that start with '>' when
we're checking for the end of an empty template argume
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342752: [CUDA] Fixed parsing of optional
template-argument-list. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52321?vs=166509&id=166512#toc
Repository:
rC Clan
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D52268#1241793, @riccibruno wrote:
> In https://reviews.llvm.org/D52268#1241033, @rjmccall wrote:
>
> > `LinkageComputer` isn't actually persisted anywhere, righ
rjmccall added a comment.
In https://reviews.llvm.org/D52339#1242241, @aaron.ballman wrote:
> In https://reviews.llvm.org/D52339#1242202, @erik.pilkington wrote:
>
> > From the last line in the paper, it seems that C++ compatibility is a goal
> > of the paper (or at least a consideration). We sh
mclow.lists added a comment.
This seems like overkill to me; why not add `(void) use_strcmp` right before
line 67 instead?
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
erik.pilkington added a comment.
> There's no reason to make this an `ObjC2`-only feature; we should probably
> eliminate that distinction throughout the compiler.
Sure, I was just writing a proposal to do that:
http://lists.llvm.org/pipermail/cfe-dev/2018-September/059468.html
Repository:
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
LGTM too.
Thanks again!
Repository:
rC Clang
https://reviews.llvm.org/D52268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
gromer updated this revision to Diff 166521.
gromer marked 2 inline comments as done.
https://reviews.llvm.org/D51812
Files:
B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp
Index: B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp
==
1 - 100 of 161 matches
Mail list logo
