klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1307
+ (Style.BraceWrapping.BeforeLambdaBody && Current.Next != nullptr &&
+Current.Next->is(TT_LambdaLSquare)));
State.Stack.back().IsInsideObjCArrayLiteral =
klimek w
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D51259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
klimek added inline comments.
Comment at: lib/ASTMatchers/Dynamic/Parser.cpp:362
+bool Parser::parseBindID(std::string &BindID, TokenInfo &CloseToken) {
+ // Parse .bind("foo")
CloseToken seems to not be used afterwards either here or in the follow-up
patch?
ilya-biryukov added a comment.
Thanks for the cleanups, mostly NITs from my side.
Comment at: clangd/ClangdServer.cpp:81
- SymbolIndex &index() const { return *MergedIndex; }
+ SymbolIndex &index() { return *MergedIndex; }
Maybe return `const SymbolIndex&
On Mon, Aug 6, 2018 at 4:47 PM Gabor Marton via Phabricator <
revi...@reviews.llvm.org> wrote:
> martong added a comment.
>
> Ping.
>
> Manuel, I still don't see how could we apply `match(anyOf(node),
> hasDescendant(node))` to the problem of general subtree traversal.
> (I'd like to have support
stryku updated this revision to Diff 162630.
stryku added a comment.
Added missing semicolon.
https://reviews.llvm.org/D50766
Files:
lib/Sema/SemaChecking.cpp
test/SemaCXX/warn-unsequenced-cxx17.cpp
test/SemaCXX/warn-unsequenced.cpp
Index: test/SemaCXX/warn-unsequenced.cpp
=
Build bots have been broken all day, so I'm trying a speculative fix in
r340727. If this doesn't work, i'll just revert all of this.
On Sun, Aug 26, 2018 at 3:51 PM Chandler Carruth
wrote:
> FYI, test cases also seem to need updating:
>
> http://lab.llvm.org:8011/builders/clang-ppc64le-linux/bui
Author: chandlerc
Date: Mon Aug 27 01:49:20 2018
New Revision: 340727
URL: http://llvm.org/viewvc/llvm-project?rev=340727&view=rev
Log:
Try to fix this clang driver test case after r340709.
If any of the bots complain about this, I'll just revert. This test case
is essentially trying to test the
kbobyrev created this revision.
kbobyrev added a reviewer: ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
kbobyrev edited the summary of this revision.
Stop using `$$$` (empty) trigram and generating a posting list with a
ilya-biryukov added a comment.
Sorry for chiming in, wanted to add my 2 cents to the conversation.
In https://reviews.llvm.org/D50462#1206203, @vsapsai wrote:
> What about having a mode that treats missing header as non-fatal error?
> Because I believe there are cases where there is no sense to
Dmitry.Kozhevnikov added a comment.
When lookin through the list of the fatal errors, I think there are different
categories:
1. "Scary" ones - "module was relocated", "invalid vfs overlay file", we
probably shouldn't try to recover from it
2. "User" errors (include not found, too many errors)
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Currently, a symbol can have only one #include header attached, which
might not work well if the symbol can be imported via different #incl
ioeric added a comment.
@sammccall The code still needs cleanup but should be useful for providing
high-level feedback, which I would like to get before moving further. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
_
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D51287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
Herald added a subscriber: kadircet.
Clangd has way better editor support compared to the ad-hoc integration I
created before and we should point users to Clangd mentioning that they could
still use standalone tool
kbobyrev updated this revision to Diff 162643.
kbobyrev added a comment.
Add missing `_` after the link.
https://reviews.llvm.org/D51292
Files:
clang-tools-extra/docs/clang-rename.rst
Index: clang-tools-extra/docs/clang-rename.rst
Author: omtcyfz
Date: Mon Aug 27 02:47:50 2018
New Revision: 340729
URL: http://llvm.org/viewvc/llvm-project?rev=340729&view=rev
Log:
[clangd] Use TRUE iterator instead of complete posting list
Stop using `$$$` (empty) trigram and generating a posting list with all
items. Since TRUE iterator is a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340729: [clangd] Use TRUE iterator instead of complete
posting list (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5128
Merged to 7.0 in r340730.
On Wed, Aug 22, 2018 at 3:11 AM, Stephen Kelly via cfe-commits
wrote:
> Author: steveire
> Date: Tue Aug 21 18:11:18 2018
> New Revision: 340376
>
> URL: http://llvm.org/viewvc/llvm-project?rev=340376&view=rev
> Log:
> Update the docs for using LLVM toolset in Visual Stu
hans added a comment.
Anastasia: will you commit this to the branch, or would like me to do it?
https://reviews.llvm.org/D51212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Since the clangd-dev is intended to be the place for clangd-related
discussions, we should point
owenpan created this revision.
owenpan added reviewers: djasper, klimek, sammccall.
Herald added a subscriber: cfe-commits.
See https://bugs.llvm.org/show_bug.cgi?id=38713
Repository:
rC Clang
https://reviews.llvm.org/D51294
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/F
ilya-biryukov added a comment.
The memory usage looks good. Some NITs and a major consideration wrt to the
implementation of merging occurences from dynamic and static index.
Comment at: clangd/index/FileIndex.cpp:48
+ if (TopLevelDecls) { // index main AST, set occurrence
ioeric updated this revision to Diff 162650.
ioeric added a comment.
- minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
clangd/index/Index.cpp
clangd/index/Index.h
clangd/index/Merg
aaron.ballman added a comment.
I'm not opposed to the changes here, but I am wondering what the benefits are
to splitting this off into its own function?
Comment at: clang-query/tool/ClangQuery.cpp:61
+int runCommandsInFile(const char* exeName, std::string const& fileName,
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/docs/clang-rename.rst:28
+:program:`clang-rename` infrastructure to handle renaming requests. Because of
+much better editor integration and support, it is advised to use
+:program:`clangd-rename` as part of :prog
melver updated this revision to Diff 162653.
melver marked 4 inline comments as done.
melver added a comment.
Many thanks! PTAL.
Repository:
rC Clang
https://reviews.llvm.org/D51036
Files:
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/NamespaceEndCommentsFixer.cpp
lib/For
melver added inline comments.
Comment at: lib/Format/Format.cpp:1312
auto &Line = *AnnotatedLines[i];
if (Line.startsWith(tok::kw_namespace) ||
+ Line.startsWith(tok::kw_inline, tok::kw_namespace) ||
owenpan wrote:
> sammccall wrote:
> > th
ioeric added inline comments.
Comment at: lib/Basic/SourceManager.cpp:1626
+if (FileContentCache->OrigEntry == SourceFile) {
+ if (Callback(FileID::get(I)))
+return true;
Should we check `FileID::get(I)` is valid?
Comment at: l
v.g.vassilev created this revision.
v.g.vassilev added reviewers: rsmith, akyrtzi.
Herald added a subscriber: cfe-commits.
Our internal clients implement parsing cache based on FileID. In order for the
Preprocessor to reenter the cached FileID it needs to reset its
NumCreatedFIDsForFileID.
Alte
ilya-biryukov added a comment.
Just noticed I'm not on the reviewers list, sorry for chiming in without
invitation. Was really excited about the change :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51279
___
cfe-commits mailin
Szelethus updated this revision to Diff 162658.
Szelethus marked 5 inline comments as done.
Szelethus added a comment.
Actually, the note messages were incorrect as in this case the static and
dynamic type of the object differs.
https://reviews.llvm.org/D50892
Files:
lib/StaticAnalyzer/Check
vmaksimo created this revision.
vmaksimo added reviewers: bader, Anastasia, AlexeySotkin.
vmaksimo created this object with edit policy "Only User: vmaksimo (Viktoria
Maximova)".
Herald added a subscriber: cfe-commits.
Given the following kernel:
__kernel void foo()
{
double d;
double4 dd;
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
https://reviews.llvm.org/D51297
Files:
clang-tools-extra/docs/clangd-vim.rst
clang-tools-ext
ilya-biryukov added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:202
+"Like changing an arrow(->) member access to dot(.) member access."),
+llvm::cl::init(clangd::CodeCompleteOptions().IncludeFixIts));
+
sammccall wrote:
> ilya-biryukov wr
kbobyrev planned changes to this revision.
kbobyrev added a comment.
I need to
- Complete last two sections
- Make sure everything is rendered as expected
- Proof-read the text
https://reviews.llvm.org/D51297
___
cfe-commits mailing list
cfe-commit
ilya-biryukov added a comment.
Do we want to keep the docs for different editors separate or do we want to put
them all into a single page in case we add more editors?
I would vouch for keeping them on a single page, but that's not a strong
opinion. Wonder what other people think?
https://revi
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: ioeric.
This allows to run clang tools in parallel on a subset of files in the
repository.
Repository:
rC Clang
https://reviews.llvm.org/D51298
Files:
include/clang/Tooling/AllTUsExecution.h
lib/Tooling/AllTUsExecution.
kbobyrev added a comment.
In https://reviews.llvm.org/D51297#1214297, @ilya-biryukov wrote:
> Do we want to keep the docs for different editors separate or do we want to
> put them all into a single page in case we add more editors?
> I would vouch for keeping them on a single page, but that's
kristof.beyls accepted this revision.
kristof.beyls added a comment.
I'm not an expert on many of the areas touched by this patch, but it looks fine
from me from a high-level point-of-view, modulo a few nits I have on a few
comments.
Comment at: clang/lib/Driver/ToolChains/Ar
ioeric added a comment.
In https://reviews.llvm.org/D51297#1214297, @ilya-biryukov wrote:
> Do we want to keep the docs for different editors separate or do we want to
> put them all into a single page in case we add more editors?
> I would vouch for keeping them on a single page, but that's no
JonasToth added a comment.
Very nice! Switching to clangd means that YCM is not necessary anymore?
https://reviews.llvm.org/D51297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev added inline comments.
Comment at: clang/docs/ClangFormat.rst:97
+Clangd Integration
+==
ioeric wrote:
> We could recomend formatting with clangd in clangd doc, but advertising here
> seems a bit odd. I'd suggest dropping this.
>
> An
v.g.vassilev updated this revision to Diff 162663.
v.g.vassilev added a comment.
Add parens.
https://reviews.llvm.org/D51295
Files:
include/clang/Basic/SourceManager.h
Index: include/clang/Basic/SourceManager.h
===
--- include/
aaron.ballman added inline comments.
Comment at: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp:30-32
+ anyOf(has(expr(hasType(
+substTemplateTypeParmType().bind("templ_type",
+anything()),
This is a stra
kjteske created this revision.
Herald added a subscriber: cfe-commits.
Expose the C bindings for clang_Type_getNumTemplateArguments()
and clang_Type_getTemplateArgumentAsType() in the python API.
Repository:
rC Clang
https://reviews.llvm.org/D51299
Files:
bindings/python/clang/cindex.py
ilya-biryukov added a comment.
In https://reviews.llvm.org/D51297#1214313, @kbobyrev wrote:
> In https://reviews.llvm.org/D51297#1214297, @ilya-biryukov wrote:
>
> > Do we want to keep the docs for different editors separate or do we want to
> > put them all into a single page in case we add mor
ABataev added a comment.
In https://reviews.llvm.org/D51177#1213079, @echristo wrote:
> Should we just have them mean the same thing and change it based on target?
I reused the same debug info level support in clang, but in LLVM they have
different processing and I'm not sure that they are abs
johannes added a comment.
In https://reviews.llvm.org/D34329#1213667, @sylvestre.ledru wrote:
> @arphaman @johannes Is that normal that clang-diff isn't installed by cmake?
> (like clang-format?)
Yes, we did not add that. I don't know if anyone would use it.
Repository:
rL LLVM
https://re
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
As rightly pointed out by @NoQ, `nonloc::LazyCompoundVal`s were only used to
acquire a constructed object
AlexeySachkov created this revision.
AlexeySachkov added reviewers: Anastasia, yaxunl.
Emit warning for multiple access qualifiers if they do not conflict.
Patch by Alexey Bader
Repository:
rC Clang
https://reviews.llvm.org/D51302
Files:
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaType.cpp
greened added a comment.
Ping. It's been well over a month now. What's the best way to get this
reviewed?
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: nico
Date: Mon Aug 27 07:23:50 2018
New Revision: 340743
URL: http://llvm.org/viewvc/llvm-project?rev=340743&view=rev
Log:
fix comment typo
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/U
kbobyrev added a comment.
In https://reviews.llvm.org/D51297#1214321, @JonasToth wrote:
> Very nice! Switching to clangd means that YCM is not necessary anymore?
Hi! Yeah, basically I wanted to follow up on the mailing list after I get some
docs in, but you found this earlier :)
The good thin
JonasToth added a comment.
Very nice :)
I will try to get it running for vim 8.0 on ubuntu 18.04 (hopefully this
week!) and share if i had success :)
Am 27.08.2018 um 16:57 schrieb Kirill Bobyrev via Phabricator:
> kbobyrev added a comment.
>
> In https://reviews.llvm.org/D51297#1214321, @Jona
mstorsjo abandoned this revision.
mstorsjo added a comment.
This isn't needed now any longer, when https://reviews.llvm.org/D50917 has
landed.
Repository:
rC Clang
https://reviews.llvm.org/D43184
___
cfe-commits mailing list
cfe-commits@lists.ll
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay.
This patch introduces iterator cost concept to improve the performance of Dex
query iter
kbobyrev planned changes to this revision.
kbobyrev added a comment.
It's probably better to roll out proximity path boosting & actual two-stage
filtering before rolling this out.
https://reviews.llvm.org/D51310
___
cfe-commits mailing list
cfe-com
Author: omtcyfz
Date: Mon Aug 27 08:38:49 2018
New Revision: 340749
URL: http://llvm.org/viewvc/llvm-project?rev=340749&view=rev
Log:
[docs] Mention clangd-dev in clangd documentation
Since the clangd-dev is intended to be the place for clangd-related
discussions, we should point new users to thi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340749: [docs] Mention clangd-dev in clangd documentation
(authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51293?vs=16264
simark created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric,
ilya-biryukov.
This is a work in progress patch to support an eventual "get type
hierarchy" request that does not exist in the LSP today. I only plan to
support getting parent types (i.e. ba
kbobyrev added inline comments.
Comment at: clang-tools-extra/docs/clang-rename.rst:28
+:program:`clang-rename` infrastructure to handle renaming requests. Because of
+much better editor integration and support, it is advised to use
+:program:`clangd-rename` as part of :program:`
Author: marshall
Date: Mon Aug 27 09:07:01 2018
New Revision: 340752
URL: http://llvm.org/viewvc/llvm-project?rev=340752&view=rev
Log:
Mark P0556 as 'in progress'
Modified:
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/trunk/www/cxx2a_status.html
URL:
http://llvm.org/viewvc/llvm-proj
gtbercea created this revision.
gtbercea added reviewers: Hahnfeld, ABataev, caomhin.
Herald added subscribers: cfe-commits, guansong.
When offloading to a device and using the powerpc64le version of the auxiliary
triple, the _CALL_ELF macro is not set correctly to 2 resulting in the attempt
to
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM. Can you add a comment to `InitializePredefinedAuxMacros` explaining that
the macro is used in `gnu/stubs.h` and add a check to the test?
Repository:
rC Clang
https://reviews.llvm
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added a subscriber: jfb.
This greatly reduces the time to read 'compile_commands.json'.
For Chromium on my machine it's now 5 secs vs 30 secs before the
change.
Repository:
rC Clang
https://reviews.llvm.org
jfb requested changes to this revision.
jfb added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:201
+
+ CommandTraits computeTraits() const {
+CommandTraits Result;
It's not clear
ilya-biryukov added inline comments.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:440
Result.emplace_back(std::move(Command));
- if (Result.back().Type == types::TY_INVALID)
-Result.pop_back();
We can't look at 'Type' at this p
ilya-biryukov updated this revision to Diff 162699.
ilya-biryukov added a comment.
- Add a comment
- Use std::call_once to compute the lazy value
Repository:
rC Clang
https://reviews.llvm.org/D51314
Files:
lib/Tooling/InterpolatingCompilationDatabase.cpp
Index: lib/Tooling/InterpolatingCo
vsk added inline comments.
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2254
Res |= SanitizerKind::Function;
+ if (!isTargetMacOS() || !isMacosxVersionLT(10, 9))
+Res |= SanitizerKind::Vptr;
delcypher wrote:
> Could we apply De'Morgan's rule here an
ilya-biryukov updated this revision to Diff 162701.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Remove computeTraits, put the body inside a lambda
Repository:
rC Clang
https://reviews.llvm.org/D51314
Files:
lib/Tooling/InterpolatingCompilationDatabase.c
ilya-biryukov added inline comments.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:201
+
+ CommandTraits computeTraits() const {
+CommandTraits Result;
jfb wrote:
> It's not clear to me that this entire function is safe to call from multiple
ilya-biryukov updated this revision to Diff 162702.
ilya-biryukov added a comment.
- Remove #include , it is not used anymore
Repository:
rC Clang
https://reviews.llvm.org/D51314
Files:
lib/Tooling/InterpolatingCompilationDatabase.cpp
Index: lib/Tooling/InterpolatingCompilationDatabase.cp
dexonsmith added a comment.
In https://reviews.llvm.org/D51240#1213358, @davidxl wrote:
> Re "Why not":
>
> The common use model of instrumentation based PGO and SamplePGO are quite
> different. The former usually uses 'fresh' profile that matches the source.
> If there are massive code refact
jfb added inline comments.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:124
+// A CompileCommand that can be applied to another file. Any instance of this
+// object is invalid after std::move() from it.
struct TransferableCommand {
This comment
Author: omtcyfz
Date: Mon Aug 27 10:26:43 2018
New Revision: 340759
URL: http://llvm.org/viewvc/llvm-project?rev=340759&view=rev
Log:
Cleanup after rL340729
Modified:
clang-tools-extra/trunk/unittests/clangd/DexIndexTests.cpp
Modified: clang-tools-extra/trunk/unittests/clangd/DexIndexTests.c
Thanks!
On Mon, Aug 27, 2018 at 1:50 AM Chandler Carruth wrote:
>
> Build bots have been broken all day, so I'm trying a speculative fix in
> r340727. If this doesn't work, i'll just revert all of this.
>
> On Sun, Aug 26, 2018 at 3:51 PM Chandler Carruth wrote:
>>
>> FYI, test cases also seem t
gtbercea updated this revision to Diff 162708.
gtbercea added a comment.
Add test.
Repository:
rC Clang
https://reviews.llvm.org/D51312
Files:
lib/Frontend/InitPreprocessor.cpp
test/Preprocessor/aux-triple.c
Index: test/Preprocessor/aux-triple.c
leonardchan updated this revision to Diff 162711.
leonardchan marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D51229
Files:
include/clang/Basic/Attr.td
lib/AST/TypePrinter.cpp
lib/Sema/SemaType.cpp
Index: lib/Sema/SemaType.cpp
Author: leonardchan
Date: Mon Aug 27 10:57:29 2018
New Revision: 340765
URL: http://llvm.org/viewvc/llvm-project?rev=340765&view=rev
Log:
[Sema/Attribute] Make types declared with address_space an AttributedType
Currently an address_space is stored in a qualifier. This makes any type
declared wit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340765: [Sema/Attribute] Make types declared with
address_space an AttributedType (authored by leonardchan, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51229
Files:
include/clang/
On 2018-08-27, Rui Ueyama via Phabricator wrote:
ruiu added a comment.
If this piece of code used to be working correctly, there is another piece of code that
adds `-flavor ld` to the command line. But if that's the case, this change wouldn't work
because it constructs something like "ld.lld -
Author: kbarton
Date: Mon Aug 27 12:53:19 2018
New Revision: 340770
URL: http://llvm.org/viewvc/llvm-project?rev=340770&view=rev
Log:
[PPC] Remove Darwin support from POWER backend.
This patch removes uses of the Darwin ABI for PowerPC related test cases. This
is the first step in removing Darwin
vsk updated this revision to Diff 162732.
vsk added a comment.
Address some review feedback.
I'm not sure whether iOS 4 is really supported anymore. There are a handful of
code paths in the driver which handle that target, so I've added in a version
check for it.
https://reviews.llvm.org/D512
Author: gbercea
Date: Mon Aug 27 13:16:20 2018
New Revision: 340772
URL: http://llvm.org/viewvc/llvm-project?rev=340772&view=rev
Log:
[OpenMP][NVPTX] Use appropriate _CALL_ELF macro when offloading
Summary: When offloading to a device and using the powerpc64le version of the
auxiliary triple, th
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340772: [OpenMP][NVPTX] Use appropriate _CALL_ELF macro when
offloading (authored by gbercea, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51312?vs=162708&id=162734#toc
Repository
vsk added a comment.
Ping.
https://reviews.llvm.org/D50927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie added inline comments.
Comment at: test/Driver/debug-options.c:259
//
+// This tests asserts that "-glineinfo-only" "-g0" disables debug info.
+// GLIO_NO: "-cc1"
'lineinfo' seems like two words - the inconsistency with 'line-tables' seems
like it'd be
hamzasood created this revision.
hamzasood added reviewers: rnk, hokein, sammccall.
Herald added a subscriber: cfe-commits.
This patch fixes the handling of clang-cl options in
`InterpolatingCompilationDatabase`.
They were previously ignored completely, which led to a lot of bugs:
- Additional o
rnk added inline comments.
Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:182-184
+ if (Arg->getOption().matches(driver::options::OPT_driver_mode)) {
+// Process --driver-mode.
+IsCLMode = std::strcmp(Arg->getValue(), "cl") == 0;
---
rsmith added a comment.
I would prefer that we use the location of the capture-default as the location
of all the implicitly captured fields, rather than using an invalid location.
Comment at: clang/lib/Sema/SemaDecl.cpp:10689
- S.DiagRuntimeBehavior(DRE->getBeginLoc(),
Author: rsmith
Date: Mon Aug 27 14:41:50 2018
New Revision: 340778
URL: http://llvm.org/viewvc/llvm-project?rev=340778&view=rev
Log:
Fix ODR violation: namespace-scope helpers should not be declared 'static'.
Modified:
libcxx/trunk/include/variant
Modified: libcxx/trunk/include/variant
URL:
nickdesaulniers updated this revision to Diff 162752.
nickdesaulniers added a comment.
- explicitly mention extern inline
Repository:
rC Clang
https://reviews.llvm.org/D51190
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
=
NoQ updated this revision to Diff 162755.
NoQ added a comment.
Address comments.
https://reviews.llvm.org/D50855
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnalyzer/Core/ExprEngine.cpp
test/Analysis/temporaries.cpp
Index: test/Analysis/temporaries.cpp
=
efriedma edited reviewers, added: efriedma, rsmith, thakis; removed:
eli.friedman, krememek, ddunbar, lattner.
efriedma added a comment.
What is this change actually solving? Even if the typedef is actually
redundant, it shouldn't cause a compiler error: redundant typedefs are allowed
in the l
efriedma added a comment.
Thanks for taking the time to write documentation.
The phrase "C89 convention" is misleading; the original ISO C standard doesn't
define the inline keyword at all. Maybe something along the lines of "GNU
inline extension". And maybe mention it's the default with -std
nickdesaulniers updated this revision to Diff 162761.
nickdesaulniers added a comment.
- s/c89/GNU inline extension/g and mention -std=gnu89/-fgnu89-inline
Repository:
rC Clang
https://reviews.llvm.org/D51190
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Index: inc
hamzasood updated this revision to Diff 162762.
hamzasood added a comment.
Thanks, I've changed it so that the driver mode is calculated first.
I've also extended the unit test to include the various `--driver-mode`
combinations.
https://reviews.llvm.org/D51321
Files:
lib/Tooling/Interpolati
vsk added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:10689
- S.DiagRuntimeBehavior(DRE->getBeginLoc(), DRE,
+ S.DiagRuntimeBehavior(DRE->getBeginOrDeclLoc(), DRE,
S.PDiag(diag)
rsmith wrote:
> I'm a bit surpr
1 - 100 of 117 matches
Mail list logo
