[PATCH] D50672: [ASTImporter] Change the return result of Decl import to Optional

balazske added a comment. This change is in conflict with our similar patch to introduce error handling in `ASTImporter`. That patch would be a much bigger one, because (almost) every import can fail, return of every `Import` (not only Decl) is changed from `X` to `Expected`. After every import

[PATCH] D50645: [clangd] Show non-instantiated decls in signatureHelp

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Comment at: clangd/CodeComplete.cpp:721 + // would get 'std::basic_string'). + if (auto Func = Candidate.getFunction()) { +if (auto Pattern = Fu

r339651 - [X86] Lowering addus/subus intrinsics to native IR

Author: tkrupa Date: Tue Aug 14 01:01:38 2018 New Revision: 339651 URL: http://llvm.org/viewvc/llvm-project?rev=339651&view=rev Log: [X86] Lowering addus/subus intrinsics to native IR Summary: This is the patch that lowers x86 intrinsics to native IR in order to enable optimizations. Reviewers:

[PATCH] D46892: [X86] Lowering addus/subus intrinsics to native IR (Clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rC339651: [X86] Lowering addus/subus intrinsics to native IR (authored by tkrupa, committed by ). Changed prior to commit: https://reviews.llvm.org/D46892?vs=159461&id=160523#toc Repository: rC Clang

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

thopre added a comment. Hi George, This commit seems to be causing some testsuite regression on Armv8 (both Aarch64 and ARM) architectures: http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/5450 http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/5625 Best regards, T

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

JonasToth added inline comments. Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:5 + +void DirectAcess(){ + absl::strings_internal::InternalFunction(); Please run clang-format over the test code as well. The braces here in `FriendUsage` miss a space.

[PATCH] D50689: [clangd] NFC: Improve Dex Iterators debugging traits

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. https://reviews.llvm.org/D50689 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp clang-tools-extra/clangd/i

r339653 - [analyzer][UninitializedObjectChecker] Void pointers are casted back to their dynamic type in note message

Author: szelethus Date: Tue Aug 14 01:20:51 2018 New Revision: 339653 URL: http://llvm.org/viewvc/llvm-project?rev=339653&view=rev Log: [analyzer][UninitializedObjectChecker] Void pointers are casted back to their dynamic type in note message Differential Revision: https://reviews.llvm.org/D4922

[PATCH] D49228: [analyzer][UninitializedObjectChecker] Void pointer objects are casted back to their dynmic type in note message

This revision was automatically updated to reflect the committed changes. Closed by commit rC339653: [analyzer][UninitializedObjectChecker] Void pointers are casted back to their… (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D49228?vs=159918&id=16052

[PATCH] D50691: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

mstorsjo created this revision. mstorsjo added reviewers: phosek, rnk, compnerd, smeenai. Herald added subscribers: ldionne, mgorny. This option should be available if LIBCXX_ENABLE_SHARED is enabled, not LIBCXX_ENABLE_STATIC, since the option is about linking shard libraries. This fixes a typo

[PATCH] D50691: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

mstorsjo added a comment. @hans I think this should be merged to 7.0, if reviewers agree with the change. Repository: rCXX libc++ https://reviews.llvm.org/D50691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet updated this revision to Diff 160531. kadircet marked 7 inline comments as done. kadircet added a comment. - Polished API. - Resolved discussions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50502 Files: clangd/CMakeLists.txt clangd/Cancellation.cpp clangd/Can

r339655 - [analyzer] Made a buildbot happy.

Author: szelethus Date: Tue Aug 14 01:38:35 2018 New Revision: 339655 URL: http://llvm.org/viewvc/llvm-project?rev=339655&view=rev Log: [analyzer] Made a buildbot happy. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp Modified: cfe/trunk/lib/Sta

[PATCH] D50691: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

hans added a comment. In https://reviews.llvm.org/D50691#1198514, @mstorsjo wrote: > @hans I think this should be merged to 7.0, if reviewers agree with the > change. Okay, I'll keep an eye on it. Repository: rCXX libc++ https://reviews.llvm.org/D50691 _

Re: r338934 - [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

Merged to 7.0 in r339660. On Sat, Aug 4, 2018 at 1:12 AM, Volodymyr Sapsai via cfe-commits wrote: > Author: vsapsai > Date: Fri Aug 3 16:12:37 2018 > New Revision: 338934 > > URL: http://llvm.org/viewvc/llvm-project?rev=338934&view=rev > Log: > [Preprocessor] Allow libc++ to detect when aligned

[PATCH] D50645: [clangd] Show non-instantiated decls in signatureHelp

ilya-biryukov updated this revision to Diff 160536. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Use 'auto*' instead of 'auto' Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50645 Files: clangd/CodeComplete.cpp unittests/clangd/CodeComple

[PATCH] D50645: [clangd] Show non-instantiated decls in signatureHelp

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:721 + // would get 'std::basic_string'). + if (auto Func = Candidate.getFunction()) { +if (auto Pattern = Func->getTemplateInstantiationPattern()) hokein wrote: > nit: auto

[libcxx] r339661 - Merging r339431:

Author: hans Date: Tue Aug 14 02:13:39 2018 New Revision: 339661 URL: http://llvm.org/viewvc/llvm-project?rev=339661&view=rev Log: Merging r339431: r339431 | ldionne | 2018-08-10 15:24:56 +0200 (Fri, 10 Aug 2018) | 16 lines

Re: [libcxx] r339431 - [libc++] Enable aligned allocation based on feature test macro, irrespective of standard

Merged to 7.0 in r339661. On Fri, Aug 10, 2018 at 3:24 PM, Louis Dionne via cfe-commits wrote: > Author: ldionne > Date: Fri Aug 10 06:24:56 2018 > New Revision: 339431 > > URL: http://llvm.org/viewvc/llvm-project?rev=339431&view=rev > Log: > [libc++] Enable aligned allocation based on feature te

r339662 - [XRay][clang] Add more test cases of -fxray-modes= (NFC)

Author: dberris Date: Tue Aug 14 02:16:37 2018 New Revision: 339662 URL: http://llvm.org/viewvc/llvm-project?rev=339662&view=rev Log: [XRay][clang] Add more test cases of -fxray-modes= (NFC) This confirms expectations for multiple values provided through the driver when selecting specific modes a

Re: r339597 - Enforce instantiation of template multiversion functions

Merged to 7.0 in r339663. On Mon, Aug 13, 2018 at 8:33 PM, Erich Keane via cfe-commits wrote: > Author: erichkeane > Date: Mon Aug 13 11:33:20 2018 > New Revision: 339597 > > URL: http://llvm.org/viewvc/llvm-project?rev=339597&view=rev > Log: > Enforce instantiation of template multiversion funct

[PATCH] D50627: [clangd] Add a testcase for empty preamble.

hokein added a comment. In https://reviews.llvm.org/D50627#1196988, @ilya-biryukov wrote: > Maybe also add a test for find-definition that was broken before? (non-empty > preamble -> empty preamble -> bad gotodef that goes to included file instead > of the local variable) > To have a regressio

[PATCH] D50695: [clangd] Always use the latest preamble

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, javed.absar. Fix an inconsistent behavior of using `LastBuiltPreamble`/`NewPreamble` in TUScheduler (see the test for details), AST should always use NewPreamble. Thi

[clang-tools-extra] r339665 - [clangd] Show non-instantiated decls in signatureHelp

Author: ibiryukov Date: Tue Aug 14 02:36:32 2018 New Revision: 339665 URL: http://llvm.org/viewvc/llvm-project?rev=339665&view=rev Log: [clangd] Show non-instantiated decls in signatureHelp Summary: To avoid producing very verbose output in substitutions involving typedefs, e.g. T -> std::vecto

[PATCH] D50645: [clangd] Show non-instantiated decls in signatureHelp

This revision was automatically updated to reflect the committed changes. Closed by commit rL339665: [clangd] Show non-instantiated decls in signatureHelp (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50645 Files

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

simoncook requested changes to this revision. simoncook added a comment. This revision now requires changes to proceed. Herald added a subscriber: PkmX. I've tested this, regression tests involving linking now mostly pass as crt0 can now be found, but it seems that system headers are still being

[PATCH] D50438: [clangd] Sort GoToDefinition results.

hokein updated this revision to Diff 160544. hokein marked 3 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50438 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp Index: unittests/clangd/XRefs

r339667 - Add a stub mangling for ObjC selectors in the Microsoft ABI.

Author: theraven Date: Tue Aug 14 03:04:36 2018 New Revision: 339667 URL: http://llvm.org/viewvc/llvm-project?rev=339667&view=rev Log: Add a stub mangling for ObjC selectors in the Microsoft ABI. This mangling is used only for outlined SEH finally blocks, which have internal linkage. This fixes

r339668 - [gnu-objc] Make selector order deterministic.

Author: theraven Date: Tue Aug 14 03:05:25 2018 New Revision: 339668 URL: http://llvm.org/viewvc/llvm-project?rev=339668&view=rev Log: [gnu-objc] Make selector order deterministic. Summary: This probably fixes PR35277, though there may be other sources of nondeterminism (this was the only case of

[PATCH] D50559: [gnu-objc] Make selector order deterministic.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339668: [gnu-objc] Make selector order deterministic. (authored by theraven, committed by ). Changed prior to commit: https://reviews.llvm.org/D50559?vs=160312&id=160545#toc Repository: rC Clang htt

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

yroux added a comment. Notice that the affected bots run two times the test cases where one execution passes and one fails, as you can see in (search Analysis/plist-macros.cpp for instance): http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/5450/steps/ninja%20check%201/logs/stdio

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

hokein added a comment. Looks mostly good. Comment at: test/clang-tidy/abseil-duration-division.cpp:58 + // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration objects + // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return + // absl::FDivDuration(t1, t

[PATCH] D50630: [AST] Update/correct the static_asserts for the bit-fields in Type

riccibruno added a comment. I actually have patches for TemplateSpecializationType, PackExpansionType, DependentTemplateSpecializationType and SubstTemplateTypeParmPackType which move the unsigned to the bit-fields in Type. The same could be done for the others I suppose. This assume that the bit

Fwd: patch file for bug 38557

Hi, Attached is the patch file for Bug 38557 ( https://bugs.llvm.org/show_bug.cgi?id=38557). Thanks, Owen Index: UnwrappedLineParser.cpp === --- UnwrappedLineParser.cpp (revision 339102) +++ UnwrappedLineParser.cpp (working copy) @@

[PATCH] D50641: [clangd][test] Fix exit messages in tests

jkorous added a comment. I think that by introducing different codepath for testing purposes we might end up with fewer bugs in tests but the actual production code could become less tested. Actually, even the -lit-test itself might be not the theoretically most correct approach but I do see th

Re: Fwd: patch file for bug 38557

Do you have a phabricator account? Otherwise I will create a revision for you (ofc mentioning your name in the commit message) for review. Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits: > Hi, > > Attached is the patch file for Bug 38557 > (https://bugs.llvm.org/show_bug.cgi?id=38557). >

[PATCH] D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

JonasToth created this revision. JonasToth added reviewers: hokein, krasimir, djasper, klimek. The Bug was reported and fixed by Owen Pan. Repository: rC Clang https://reviews.llvm.org/D50697 Files: UnwrappedLineParser.cpp Index: UnwrappedLineParser.cpp ==

[PATCH] D49798: [ASTImporter] Adding some friend function related unittests.

balazske updated this revision to Diff 160548. balazske added a comment. - Corrected the code in tests. Repository: rC Clang https://reviews.llvm.org/D49798 Files: unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp ==

[PATCH] D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

JonasToth updated this revision to Diff 160550. JonasToth added a comment. Using git for the diff, add testcase Repository: rC Clang https://reviews.llvm.org/D50697 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

Re: Fwd: patch file for bug 38557

Hi Owen, thank you for your patch. I created a revision for it to pass review: https://reviews.llvm.org/D50697 If you do have an phabricator account you can take over, otherwise we can get it into trunk for you :) All the best, Jonas Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits: > H

[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

martong marked 5 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2872 Importer.MapImported(D, FoundField); +// In case of a FieldDecl of a ClassTemplateSpecializationDecl, the +// initializer of a FieldDecl migh

[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

martong marked 3 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4551 + for (auto *FromField : D->fields()) +Importer.Import(FromField); + martong wrote: > a_sidorin wrote: > > The result of import is unche

[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

martong updated this revision to Diff 160552. martong added a comment. - Add new test - Fix indentation Repository: rC Clang https://reviews.llvm.org/D50451 Files: include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTImporter.cpp lib/ASTMatchers/ASTMatchersInternal.cpp unittests/AST/AS

[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4550 + // in the "From" context, but not in the "To" context. + for (auto *FromField : D->fields()) +Importer.Import(FromField); martong wrote: > a_sidorin wrote: > > Importing a

[PATCH] D50699: Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan created this revision. owenpan added a project: clang. See bug report https://bugs.llvm.org/show_bug.cgi?id=38525 for more details. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp Index: lib/Format/ContinuationIndenter.cpp =

[PATCH] D50700: [clangd] Generate better incomplete bigrams for the Dex index

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. Currently, the query trigram generator would simply yield `u_p` trigram for the `u_p` query. This is not optimal, sin

[PATCH] D50700: [clangd] Generate better incomplete bigrams for the Dex index

kbobyrev updated this revision to Diff 160555. kbobyrev added a comment. Treat leading underscores as additional signals and don't extract two heads in that case. https://reviews.llvm.org/D50700 Files: clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/index/dex/Trigra

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:1317 + for (auto *D : FromRD->decls()) { +Decl *ToD = Importer.GetAlreadyImportedOrNull(D); +assert(ToRD == ToD->getDeclContext() && ToRD->containsDecl(ToD)); Is it sure that `ToD` will n

[PATCH] D50699: Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan added a comment. Test case: F6937162: BreakBeforeBinaryOperators.cpp Repository: rC Clang https://reviews.llvm.org/D50699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D50702: [clangd] NFC: Cleanup clangd help message

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. Add missed space, fix a typo. https://reviews.llvm.org/D50702 Files: clang-tools-extra/clangd/tool/ClangdMain.cpp

[PATCH] D50702: [clangd] NFC: Cleanup clangd help message

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D50702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

hiraditya added a comment. Herald added a subscriber: ldionne. Any updates on this one? I like @mclow.lists idea of removing it from __locale. Repository: rCXX libc++ https://reviews.llvm.org/D47987 ___ cfe-commits mailing list cfe-commits@lists.

[clang-tools-extra] r339673 - [clangd] NFC: Cleanup clangd help message

Author: omtcyfz Date: Tue Aug 14 05:00:39 2018 New Revision: 339673 URL: http://llvm.org/viewvc/llvm-project?rev=339673&view=rev Log: [clangd] NFC: Cleanup clangd help message Add missed space, fix a typo. Reviewed by: ioeric Differential Revision: https://reviews.llvm.org/D50702 Modified:

[PATCH] D50702: [clangd] NFC: Cleanup clangd help message

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE339673: [clangd] NFC: Cleanup clangd help message (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D50702?vs=160557&id=160558#toc Repository: rCTE Clang Tools

Re: Fwd: patch file for bug 38557

Hi Jonas, Thank you very much! I just created a phabricator account and created a revision for another bug (https://reviews.llvm.org/D50699). I don't know exactly how to add my test case like you did for me, so I just uploaded it. I also added the reviewers listed by bugs.llvm.org. How do I "take

[PATCH] D50699: Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

JonasToth added a comment. Please create the diffs with full context (git diff -U 999) and add an test-case. Repository: rC Clang https://reviews.llvm.org/D50699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

hiraditya added a comment. In https://reviews.llvm.org/D50699#1198770, @owenpan wrote: > Test case: > F6937162: BreakBeforeBinaryOperators.cpp Please add a testcase in the source and add checks to verify the changes. Repository: rC Clang https://reviews

[PATCH] D50672: [ASTImporter] Change the return result of Decl import to Optional

martong added a comment. Hi Aleksei, Thank you for this patch. With Balazs, we are working on something similar, but with a different, fine grained error value mechanism. Unfortunately we were not aware of that you have been working on error handling, and we didn't say that we are working on er

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan updated this revision to Diff 160561. owenpan added a comment. Updated patch created by "svn diff --diff-cmd=diff -x -U99" Repository: rC Clang https://reviews.llvm.org/D50699 Files: ContinuationIndenter.cpp Index: ContinuationIndenter.cpp

[PATCH] D50672: [ASTImporter] Change the return result of Decl import to Optional

martong added a comment. > Do you think we can hold back this patch for a few days until Balazs prepares > the Expected based version? Then I think we could compare the patches and > we could merge the best from the two of them. I mean, once Balazs is also ready, then we can create a combined p

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

JonasToth added a comment. In https://reviews.llvm.org/D50699#1198813, @owenpan wrote: > Updated patch created by "svn diff --diff-cmd=diff -x -U99" The patch seems not to be in the correct path (the `lib/Format` thing is missing). Could you check that again? If you plan to add more patche

[PATCH] D50674: [libc++] Add missing #include in C11 features tests

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. Good catch! Repository: rCXX libc++ https://reviews.llvm.org/D50674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160562. hugoeg marked an inline comment as done. https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/abseil/NoInternalDepsCheck.h docs/Rel

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan updated this revision to Diff 160564. owenpan added a comment. Updated the patch to include lib/Format path prefix. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp Index: lib/Format/ContinuationIndenter.cpp =

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

hans added a comment. In https://reviews.llvm.org/D50652#1197775, @rnk wrote: > I'd prefer not to do this, since internal_linkage generates smaller, more > debuggable code by default. IIUC, this is what we had before though, so it's a conservative "revert to safety" approach until a better so

[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

ldionne added a comment. In https://reviews.llvm.org/D50341#1198339, @vsapsai wrote: > What about defining a feature for unsupported configurations? I've tried > > if '__cpp_aligned_new' not in macros or \ > intMacroValue(macros['__cpp_aligned_new']) < 201606: > self.config.avai

[libcxx] r339675 - [libc++] Add missing #include in C11 features tests

Author: ldionne Date: Tue Aug 14 06:29:17 2018 New Revision: 339675 URL: http://llvm.org/viewvc/llvm-project?rev=339675&view=rev Log: [libc++] Add missing #include in C11 features tests Summary: These #includes are quite important, since otherwise any #if TEST_STD_VER > 14 && defined(TEST_HA

[PATCH] D50674: [libc++] Add missing #include in C11 features tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL339675: [libc++] Add missing #include in C11 features tests (authored by ldionne, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50674?vs=160

[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. Workspace Symbol implementation was introduced in https://reviews.llvm.org/D44882 and should be complete now. https

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

hans added a comment. If we think the symbol/string table size increase is acceptable for most user's, I suppose Chromium could just do -D_LIBCPP_HIDE_FROM_ABI=_LIBCPP_ALWAYS_INLINE to get back the old behaviour and unblock us? And this could also be suggested in the release notes as a work-

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

ldionne added a comment. In https://reviews.llvm.org/D50652#1198885, @hans wrote: > Oh, or could we do > > -D_LIBCPP_HIDE_FROM_ABI= > > > and just get regular odr linkage for these functions? No, you do need to use `_LIBCPP_HIDDEN _LIBCPP_ALWAYS_INLINE` because of the issue described in htt

r339678 - [OpenCL] Add test for constant sampler argument

Author: svenvh Date: Tue Aug 14 06:56:52 2018 New Revision: 339678 URL: http://llvm.org/viewvc/llvm-project?rev=339678&view=rev Log: [OpenCL] Add test for constant sampler argument Modified: cfe/trunk/test/SemaOpenCL/sampler_t.cl Modified: cfe/trunk/test/SemaOpenCL/sampler_t.cl URL: http://

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

ldionne added a comment. In https://reviews.llvm.org/D50652#1198893, @ldionne wrote: > In https://reviews.llvm.org/D50652#1198885, @hans wrote: > > > Oh, or could we do > > > > -D_LIBCPP_HIDE_FROM_ABI= > > > > > > and just get regular odr linkage for these functions? > > > No, you do need to us

[PATCH] D50337: [clangd] DexIndex implementation prototype

kbobyrev updated this revision to Diff 160576. kbobyrev added a comment. Don't separate the logic for "long" and "short" queries: https://reviews.llvm.org/D50517 (https://reviews.llvm.org/rCTE339548) introduced incomplete trigrams which can be used on for "short" queries, too. https://reviews.

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan updated this revision to Diff 160577. owenpan added a comment. Added a test case. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea added a comment. Thanks @Hahnfeld for your suggestions. Unfortunately doing the lowering in the backend one would need to replace the math function calls with calls to libdevice function calls. I have not been able to do that in an elegant way. Encoding the interface to libdevice is ju

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia updated this revision to Diff 160582. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst docs/clang-tidy

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia added inline comments. Comment at: test/clang-tidy/abseil-duration-division.cpp:58 + // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration objects + // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return + // absl::FDivDuration(t1, t2);}

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

ilya-biryukov added a comment. Sorry for missing this one. The biggest concern that I have is about the thread-safety of the API, it's too easy to misuse from multiple threads at this point. We should define thread-safety guarantees for `TaskHandle` and `CancellationToken` and make sure they'r

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good from my side. I will commit for you if other reviewers have no further comments. https://reviews.llvm.org/D50389 ___ cfe-comm

[PATCH] D50707: NFC: Enforce good formatting across multiple clang-tools-extra files

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous. This patch improves readability of multiple files in clang-tools-extra and enforces LLVM Coding Guidelines. https://reviews.

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea added a comment. Just to address any generality concerns: This patch fixes the problem of calling libdevice math functions for all platform combinations. It ensures that the OpenMP NVPTX target region will NOT call any host math functions (which ever host that may be) IF equivalent dev

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. Could somebody verify that the `DISPATCHER_CONTEXT` struct is defined in `` for the Win8 and Win10 SDKs? I can't install them right now. Repository: rUNW libunwind https://reviews.llvm.org/D50564 ___ cfe-commits mailing

[PATCH] D50707: NFC: Enforce good formatting across multiple clang-tools-extra files

ioeric added a comment. Fixing header guards and file comments is fine, but I'm not a fan of reformatting-only changes in source code as they tends to make `git blame` harder. https://reviews.llvm.org/D50707 ___ cfe-commits mailing list cfe-commit

[PATCH] D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

owenpan updated this revision to Diff 160591. owenpan added a comment. Updated the test case. Repository: rC Clang https://reviews.llvm.org/D50697 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D50641: [clangd][test] Fix exit messages in tests

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Many thanks for fixing this. Adding some failure monitoring seems like a nice idea. On the other hand, polluting every test with stderr redirection doesn't look like a nice

[PATCH] D50641: [clangd][test] Fix exit messages in tests

ilya-biryukov added a comment. Haven't noticed Alex's comments, sorry for a duplicate suggestion about exiting with failure error code Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50641 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D50691: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D50691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D50709: [clang-doc] Fix unused var

juliehockett created this revision. juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. https://reviews.llvm.org/D50709 Files: clang-tools-extra/clang-doc/Mapper.cpp Index: clang-tools-extra/clang-doc/Mapper.cpp ===

[PATCH] D50403: [clang-format]AlignConsecutiveAssignments

PDoakORNL added a comment. So it's been a week, is there an owner for clang/lib/Format? Repository: rC Clang https://reviews.llvm.org/D50403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D50709: [clang-doc] Fix unused var

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Looks like NFC. https://reviews.llvm.org/D50709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea updated this revision to Diff 160598. gtbercea added a comment. Herald added a subscriber: jholewinski. Add __NO_MATH_INLINES macro for the NVPTX toolchain to prevent any host assembly from seeping onto the device. Repository: rC Clang https://reviews.llvm.org/D47849 Files: inclu

[clang-tools-extra] r339685 - [clang-doc] Fix unused variable

Author: juliehockett Date: Tue Aug 14 08:38:59 2018 New Revision: 339685 URL: http://llvm.org/viewvc/llvm-project?rev=339685&view=rev Log: [clang-doc] Fix unused variable Differential Revision: https://reviews.llvm.org/D50709 Modified: clang-tools-extra/trunk/clang-doc/Mapper.cpp Modified:

[PATCH] D50709: [clang-doc] Fix unused var

This revision was automatically updated to reflect the committed changes. Closed by commit rL339685: [clang-doc] Fix unused variable (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50709?vs=160593&id=160600#t

[PATCH] D50711: [AST] Pack the unsigned of PackExpansionType into Type

riccibruno created this revision. riccibruno added reviewers: rsmith, rjmccall, erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The bit-fields of Type have enough space for the `unsigned NumExpansions` of PackExpansionType Repository: rC Clang https://re

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191 +void templated_thrower() { throw T{}(); } +// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type 'int' is not derived from 'std::exception' + J

[PATCH] D50712: [AST] Pack the unsigned of DependentTemplateSpecializationType into Type

riccibruno created this revision. riccibruno added reviewers: rsmith, rjmccall, erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The bit-fields of `Type` have enough space for the member `unsigned NumArgs` of DependentTemplateSpecializationType Repository:

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

lewis-revill updated this revision to Diff 160602. lewis-revill added a comment. Fixed this issue by adding -nostdsysteminc to the Clang target options, preventing the frontend from generating additional include paths. Repository: rC Clang https://reviews.llvm.org/D50246 Files: lib/Driver

[PATCH] D50713: [AST] Pack the unsigned of SubstTemplateTypeParmPackType into Type

riccibruno created this revision. riccibruno added reviewers: rsmith, rjmccall, erichkeane. riccibruno added a project: clang. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, chrib, kristof.beyls. The bit-fields of `Type` have enough space for the member `unsigned NumA

[PATCH] D50707: NFC: Enforce good formatting across multiple clang-tools-extra files

kbobyrev updated this revision to Diff 160605. kbobyrev added a comment. I have updated the patch so that it only affects comments, header guards and inserts few newlines. Actual source code is not affected so that `git blame` log could be less cryptic. https://reviews.llvm.org/D50707 Files:

  1   2   3   >