martong marked 3 inline comments as done. martong added inline comments.
================ Comment at: lib/AST/ASTImporter.cpp:4551 + for (auto *FromField : D->fields()) + Importer.Import(FromField); + ---------------- martong wrote: > a_sidorin wrote: > > The result of import is unchecked here and below. Is it intentional? > Yes, that is intentional. We plan to refactor all ASTImporter functions to > provide a proper error handling mechanism, and in that change we would like > to enforce the check of all import functions. > Unfortunately, currently we already have many places where we do not check > the return value of import. Actually, having proper error handling is just one thing, the other more important reason why we don't check the result of the import here, because we don't want to stop merging other fields/functions if one merge failed. If one merge failed, other merge operations still could be successful. Repository: rC Clang https://reviews.llvm.org/D50451 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
