hokein added a comment. In https://reviews.llvm.org/D50627#1196988, @ilya-biryukov wrote:
> Maybe also add a test for find-definition that was broken before? (non-empty > preamble -> empty preamble -> bad gotodef that goes to included file instead > of the local variable) > To have a regression test against similar failures. I think this patch is in a good scope (for empty preamble). I'd leave it as it is. The failure of GoTodefinition test is caused by an inconsistent behavior of using `lastBuiltPreamble`/`NewPreamble` in TUScheduler, I will send out a separate patch fixing it (based on our discussion). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
