[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

phosek added a comment. This has been breaking our bots since it has landed (both Linux and macOS ones), here's a log: https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8939527016533487696%2F%2B%2Fsteps%2Fclang%2F0%2Fsteps%2Fcheck-clang%2F0%2Fstdout In our Clan

[PATCH] D49899: Force test/Driver/fuchsia.c(pp) to use lld

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

kito-cheng added a comment. Herald added subscribers: rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, jrtc27. ping, Alex, could you commit that? Repository: rC Clang https://reviews.llvm.org/D46822 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

ilya-biryukov added a comment. Just a few nits left. Comment at: clangd/ClangdLSPServer.cpp:422 +std::move(Entry.second.workingDirectory), +llvm::sys::path::filename(File), +std::move(Entry.second.compilati

[PATCH] D49871: Improve support of PDB as an external layout source

This revision was automatically updated to reflect the committed changes. Closed by commit rL338353: Improve support of PDB as an external layout source (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D498

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

ilya-biryukov added a comment. In https://reviews.llvm.org/D49833#1181651, @malaperle wrote: > Was there any objection to this patch? It would have been nice to have this > before the branching. Sorry for the delay, somehow missed this update in my inbox. In https://reviews.llvm.org/D49833#11

[PATCH] D50043: [RISCV] RISC-V using -fuse-init-array by default

kito-cheng created this revision. kito-cheng added reviewers: asb, apazos. Herald added subscribers: cfe-commits, rkruppe, rogfer01, shiva0217, fedor.sergeev. RISC-V target using -fuse-init-array even for bare-mental target. Repository: rC Clang https://reviews.llvm.org/D50043 Files: lib/

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

Thanks a lot for looking into this! You are right, the change in SemaAccess seemed to have done the job to fix the protected member bug in specific. I think I made the change in SemaCodeComplete before SemaAccess and didn't realized the previous one was unnecessary to fix the tests. I think the ac

[PATCH] D49991: [clangd] Do not build AST if no diagnostics were requested

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ioeric. Herald added subscribers: jfb, arphaman, jkorous, MaskRay, javed.absar. After r338256, clangd stopped reporting diagnostics if WantDiags::No request is followed by a WantDiags::Yes request but the AST can be reused. Rep

[PATCH] D50047: [compiler-rt] [test] Use approximate comparison on float types

erceg95 created this revision. erceg95 added reviewers: compnerd, scanon, mgorny. Herald added a subscriber: dberris. We are resubmitting this patch (https://reviews.llvm.org/D28862) as it still causes this test of fail on Ubuntu 18.04 , Ubuntu GLIBC 2.27-3ubuntu1. https://reviews.llvm.org/D500

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

I actually tried to pass the correct derived scope to CodeCompletionDeclConsumer on construction, it was not a lot of code and I think this should fix the problem you're describing. I'll send a patch. On Tue, Jul 31, 2018 at 11:33 AM Eric Liu wrote: > Thanks a lot for looking into this! > > You

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ioeric added a comment. Overall LG, just a suggestion to make the code a bit easier to follow. Comment at: clangd/TUScheduler.cpp:379 + +if (DiagsWereReported) { // Take a shortcut and don't build the AST if neither the inputs nor the The implicit co

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov updated this revision to Diff 158201. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Added a comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50045 Files: clangd/TUScheduler.cpp unittests/clangd/TUSchedulerTests.cpp Ind

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:379 + +if (DiagsWereReported) { // Take a shortcut and don't build the AST if neither the inputs nor the ioeric wrote: > The implicit condition here is that we can reuse AST and di

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

lebedev.ri created this revision. lebedev.ri added reviewers: rjmccall, rsmith, erichkeane. https://reviews.llvm.org/rC337815 / https://reviews.llvm.org/D49508 had to cannibalize one bit of `CastExprBitfields::BasePathSize` in order to squeeze `PartOfExplicitCast` boolean. That reduced the maxim

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan updated this revision to Diff 158211. yvvan added a comment. Restore missing tests https://reviews.llvm.org/D49794 Files: include/clang-c/Index.h include/clang/Basic/Diagnostic.h include/clang/Basic/DiagnosticOptions.def include/clang/Driver/Options.td lib/Basic/DiagnosticIDs.cp

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

lassi.niemisto added a comment. My project team would also highly appreciate if this got implemented. Currently working around the issue by post-formatting the clang-formatted files with uncrustify and filtering it so that it only touches lines starting with #. Repository: rL LLVM https://r

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

sfantao added a comment. Hi Doru, Thanks for updating the patch. I've a few comments below. Comment at: include/clang/Driver/Compilation.h:312 + /// \param skipBundler - bool value set once by the driver. + void setSkipOffloadBundler(bool skipBundler); + gtb

r338360 - Fix linux-header-search.cpp with CLANG_DEFAULT_CXX_STDLIB

Author: hahnfeld Date: Tue Jul 31 04:36:14 2018 New Revision: 338360 URL: http://llvm.org/viewvc/llvm-project?rev=338360&view=rev Log: Fix linux-header-search.cpp with CLANG_DEFAULT_CXX_STDLIB This configuration was broken after r338294 because Clang might be configured to always use libc++. Mod

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

Hahnfeld added a comment. I fixed `linux-header-search.cpp` by adding `-stdlib=libstdc++` in r338360 because I was seeing the same failure and that's what agreed to do in these cases. If you can verify that it fixes your problems, I think it's safe to add `-rtlib=libgcc` to the other test. Re

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

ilya-biryukov added inline comments. Comment at: include/clang/Driver/Options.td:1745 HelpText<"remap file source paths in debug info">; +def fsuppress_non_errors_from_included_files : Flag<["-"], "fsuppress-non-errors-from-included-files">, + Group, Flags<[CC1Option]>; --

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov updated this revision to Diff 158216. ilya-biryukov added a comment. - Moved early return into the CanReuseAST branch Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50045 Files: clangd/TUScheduler.cpp unittests/clangd/TUSchedulerTests.cpp Index: unittests/cla

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:379 + +if (DiagsWereReported) { // Take a shortcut and don't build the AST if neither the inputs nor the ilya-biryukov wrote: > ioer

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clangd/TUScheduler.cpp:381 + DiagsWereReported = PrevDiagsWereReported; + if (DiagsWereReported) { +// Take a shortcut and don't report the

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- added a comment. The state of this patch: - user interface is as agreed-upon, giving end-users the capability to filter out floats and ints as it makes sense for their code base - code is clean - documentation is up to date - default ignore lists are sensible There is one outstandin

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:381 + DiagsWereReported = PrevDiagsWereReported; + if (DiagsWereReported) { +// Take a shortcut and don't report the diagnostics, since they s

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov updated this revision to Diff 158217. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Check for PrevDiagsWereReported Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50045 Files: clangd/TUScheduler.cpp unittests/clangd/TUSchedul

r338353 - Improve support of PDB as an external layout source

Author: aleksandr.urakov Date: Tue Jul 31 01:27:06 2018 New Revision: 338353 URL: http://llvm.org/viewvc/llvm-project?rev=338353&view=rev Log: Improve support of PDB as an external layout source Summary: This patch improves support of PDB as an external layout source in the next cases: - Multipl

Re: r338239 - [mips64][clang] Provide the signext attribute for i32 return values

I missed to include the changes to tests affected by that commit. I've included them in r338246. Regards, Stefan From: Friedman, Eli Sent: 30 July 2018 21:22:45 To: Stefan Maksimovic; cfe-commits@lists.llvm.org Subject: Re: r338239 - [mips64][clang] Provide th

[clang-tools-extra] r338361 - [clangd] Report diagnostics even if WantDiags::No AST was reused

Author: ibiryukov Date: Tue Jul 31 04:47:52 2018 New Revision: 338361 URL: http://llvm.org/viewvc/llvm-project?rev=338361&view=rev Log: [clangd] Report diagnostics even if WantDiags::No AST was reused Summary: After r338256, clangd stopped reporting diagnostics if WantDiags::No request is followe

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan added a comment. I already mentioned in the review inherited by this one that this way covers also loaded plugins with different consumers. So let's assume that driver loads clang-tidy and some other plugins and runs over each file in the project. It makes sense not to include clang-tidy d

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

This revision was automatically updated to reflect the committed changes. Closed by commit rL338361: [clangd] Report diagnostics even if WantDiags::No AST was reused (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D49918: [clang-tidy] Sequence declaration in while statement before the condition

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG modulo outstanding comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49918 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D47267: [UnrollAndJam] Add unroll_and_jam pragma handling

dmgreen updated this revision to Diff 158219. dmgreen added a comment. Rebase. Michael, you happy with this part? The pragma clang loop part is off in https://reviews.llvm.org/D47320. Let me know if/when I should do something with that. https://reviews.llvm.org/D47267 Files: include/clang/

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

avt77 updated this revision to Diff 158221. avt77 added a comment. Herald added a subscriber: eraman. Accordingly to efriedma suggestion I removed start/stopFrontendTimer where it's possible and inserted FrontendTimeRAII in several new places. As result the patch becomes bigger and bigger. And a

r338366 - clang-format: try to make the doc for ConstructorInitializerAllOnOneLineOrOnePerLine more clear

Author: hans Date: Tue Jul 31 05:42:02 2018 New Revision: 338366 URL: http://llvm.org/viewvc/llvm-project?rev=338366&view=rev Log: clang-format: try to make the doc for ConstructorInitializerAllOnOneLineOrOnePerLine more clear PR38080 complained that the "OnePerLine" case wasn't previously shown

[PATCH] D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp.

a.elovikov created this revision. a.elovikov added reviewers: emmettneyman, erichkeane. I don't have the whole list of GCC binaries available so I determined the exact version where the warning disappeared via: https://github.com/gcc-mirror/gcc/blob/gcc-4_9_0-release/gcc/cp/typeck.c#L6863 https:/

[PATCH] D49865: Inform the AST of #pragma FENV_ACCESS use

kpn updated this revision to Diff 158229. kpn added a comment. Thanks for the fast turnaround! I don't have commit access, can I get you to commit it for me? And can I get you to put my email address in the commit message? I'll start looking at Sema like you said. https://reviews.llvm.org/D4

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

ilya-biryukov added a comment. In https://reviews.llvm.org/D49794#1182078, @yvvan wrote: > I already mentioned in the review inherited by this one that this way covers > also loaded plugins with different consumers. So let's assume that driver > loads clang-tidy and some other plugins and runs

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan added a comment. And we already saw, that -isystem is not the best choice for that. And by the way - clang-tidy has this filtering in consumer which does not exist in it's plugin-mode so it spits all system diagnostics all the time... https://reviews.llvm.org/D49794 __

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

erichkeane added a comment. Its not that it needs to be 'at least 9 bits', IMO 9 bits was too small as well. What I'd prefer to this solution is similar to what John McCall said on PR38356: Add the size to the trailing allocated space. Check out the 'create' methods for all of these, and make

[PATCH] D49991: [clangd] Do not build AST if no diagnostics were requested

ilya-biryukov updated this revision to Diff 158234. ilya-biryukov added a comment. - Rebase onto head Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49991 Files: clangd/TUScheduler.cpp Index: clangd/TUScheduler.cpp ===

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

JonasToth added a comment. In https://reviews.llvm.org/D49114#1182071, @0x8000- wrote: > The state of this patch: > > - user interface is as agreed-upon, giving end-users the capability to filter > out floats and ints as it makes sense for their code base > - code is clean > - documentation

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea marked 3 inline comments as done. gtbercea added a comment. Answers to comments. Comment at: include/clang/Driver/Compilation.h:312 + /// \param skipBundler - bool value set once by the driver. + void setSkipOffloadBundler(bool skipBundler); + sfanta

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan added a comment. Anyways, if c++ part does not seem relevant I'm fine if we only have libclang part from https://reviews.llvm.org/D48116. BTW I don't remember if you answered something to my suggestion of adding flag -ithird-party as an alternative to -isystem which does not lock files an

[PATCH] D42762: Rewrite the VS Integration Scripts

hans added a comment. Thanks for pushing this through! Will you upload the vsix to the marketplace? (Use the llvm-vs-code-extensi...@google.com account, which despite the name is also used for the clang-format vs plugin etc.) Then I can update the docs to point at it. Repository: rC Clang

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

ilya-biryukov added a comment. In https://reviews.llvm.org/D49794#1182220, @yvvan wrote: > And we already saw, that -isystem is not the best choice for that. Are you referring to the file-locking on Windows? Any other reasons why the -isystem trick might be non-ideal? > And by the way - clang

[PATCH] D47618: __c11_atomic_load's _Atomic can be const

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM from OpenCL side! Thanks! Repository: rC Clang https://reviews.llvm.org/D47618 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang-tools-extra] r338378 - [clangd] Do not build AST if no diagnostics were requested

Author: ibiryukov Date: Tue Jul 31 06:45:37 2018 New Revision: 338378 URL: http://llvm.org/viewvc/llvm-project?rev=338378&view=rev Log: [clangd] Do not build AST if no diagnostics were requested Summary: It can be removed from the cache before the first access anyway, so building it can be a wast

[PATCH] D49991: [clangd] Do not build AST if no diagnostics were requested

This revision was automatically updated to reflect the committed changes. Closed by commit rL338378: [clangd] Do not build AST if no diagnostics were requested (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49991

[PATCH] D50060: [clang-tidy] add all clang-tidy modules to plugin

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun, mgorny, srhines. This patch addresses PR38359 and adds all existing clang-tidy modules to the plugin that can be used together with libclang. Repository:

[PATCH] D50060: [clang-tidy] add all clang-tidy modules to plugin

JonasToth added a comment. I reordered the anchoring list to be in alphabetical order as well! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan added a comment. In https://reviews.llvm.org/D49794#1182272, @ilya-biryukov wrote: > In https://reviews.llvm.org/D49794#1182220, @yvvan wrote: > > > And we already saw, that -isystem is not the best choice for that. > > > Are you referring to the file-locking on Windows? > Any other reaso

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

This revision was automatically updated to reflect the committed changes. Closed by commit rC338385: [RISCV] Add driver for riscv32-unknown-elf baremetal target (authored by xbolva00, committed by ). Repository: rC Clang https://reviews.llvm.org/D46822 Files: lib/Driver/CMakeLists.txt lib

r338385 - [RISCV] Add driver for riscv32-unknown-elf baremetal target

Author: xbolva00 Date: Tue Jul 31 07:21:46 2018 New Revision: 338385 URL: http://llvm.org/viewvc/llvm-project?rev=338385&view=rev Log: [RISCV] Add driver for riscv32-unknown-elf baremetal target Summary: This patch adds a driver for the baremetal RISC-V target (i.e. riscv32-unknown-elf). For ref

[PATCH] D50068: [AArch64][ARM] Add Armv8.4-A tests

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: samparker, olista01, john.brawn, ab, t.p.northover. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. This adds tests for Armv8.4-A, and also some v8.2 and v8.3 tests that were missed in previou

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

ilya-biryukov added a comment. In https://reviews.llvm.org/D49794#1182296, @yvvan wrote: > Clang tidy is not only a standalone tool but also a plugin. It's almost never > used this way (but we do that in Qt Creator to combine it with Clazy) and it > also seems that some of the recent checks are

[PATCH] D50060: [clang-tidy] add all clang-tidy modules to plugin

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D49953: [compiler-rt] Add a routine to specify the mode used when creating profile dirs.

mattd updated this revision to Diff 158272. mattd added a comment. - Renamed the test output and test directory to clean up the more specific test example. https://reviews.llvm.org/D49953 Files: lib/profile/InstrProfilingUtil.c lib/profile/InstrProfilingUtil.h test/profile/instrprof-set-

[PATCH] D50060: [clang-tidy] add all clang-tidy modules to plugin

JonasToth updated this revision to Diff 158278. JonasToth added a comment. - rebase Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50060 Files: clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp Index: clang-tidy/plugin/ClangTidyPlugin.cpp =

[clang-tools-extra] r338393 - [clang-tidy] add all clang-tidy modules to plugin

Author: jonastoth Date: Tue Jul 31 08:23:49 2018 New Revision: 338393 URL: http://llvm.org/viewvc/llvm-project?rev=338393&view=rev Log: [clang-tidy] add all clang-tidy modules to plugin Summary: This patch addresses PR38359 and adds all existing clang-tidy modules to the plugin that can be used t

[PATCH] D50060: [clang-tidy] add all clang-tidy modules to plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL338393: [clang-tidy] add all clang-tidy modules to plugin (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50060 Files:

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 158282. JonasToth added a comment. rebase to master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index: test/clang-tidy/hicpp-e

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 158284. JonasToth added a comment. Herald added subscribers: kbarton, mgorny, nemanjai. rebase to master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguideli

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 158285. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCheck.cpp clang-ti

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 158286. JonasToth added a comment. correct rebase. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index: test/clang-tidy/hicpp-ex

[PATCH] D48436: [analyzer][UninitializedObjectChecker] Fixed a false negative by no longer filtering out certain constructor calls

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:681-689 +Optional OtherObject = +getObjectVal(OtherCtor, Context); +if (!OtherObject) + continue; + +// If the CurrentObject is a field of OtherObject,

[PATCH] D49890: Clang-Tidy Export Problem

alexfh added a comment. Could you describe the specific problem you're solving and provide an example? As mentioned by others, a test would be very welcome as well. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 ___ cfe-commi

[PATCH] D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp.

erichkeane added inline comments. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:152 typedef void (*func)(int*, int*, int*, int); - func f = reinterpret_cast(EE->getPointerToFunction(EntryFunc)); +#if defined(__GNUC__) && ((__GNUC__ == 4) && (__GNUC_MINOR__

[PATCH] D49953: [compiler-rt] Add a routine to specify the mode used when creating profile dirs.

mattd updated this revision to Diff 158298. mattd added a comment. - Simplify the test case, let the compiler join the literals for us. https://reviews.llvm.org/D49953 Files: lib/profile/InstrProfilingUtil.c lib/profile/InstrProfilingUtil.h test/profile/instrprof-set-dir-mode.c test/pro

Re: r338321 - Fix use of uninitialized variable in r338299

I think this version is right; the FieldOffset for OpenCL here will be 2 * getTypeSize(IntTy). The final `FieldOffset += FieldSize` that was moved only applies to the non-OpenCL "__descriptor" field. Scott On 2018-07-30 19:22, Eric Christopher wrote: Is 0 right for FieldOffset for OpenCL here

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle added a comment. @simark would you mind finishing this patch and committing it? I won't be able to finish it given that I started it at a different company, etc. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49833 ___ cf

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz updated this revision to Diff 158302. Typz added a comment. Herald added a subscriber: acoomans. rebase Repository: rC Clang https://reviews.llvm.org/D32478 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Conti

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

ioeric added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.cpp:49 +template +int isChildMergeNecessary(std::vector &Children, T &ChildToMerge) { + for (unsigned long I = 0; I < Children.size(); I++) { The function name doesn't describe

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz created this revision. Typz added reviewers: krasimir, djasper, klimek. Herald added a subscriber: acoomans. When multiple ternary operators are chained, e.g. like an if/else-if/ else-if/.../else sequence, clang-format will keep aligning the colon with the question mark, which increases the i

r338399 - [OPENMP] Prevent problems with linking of the static variables.

Author: abataev Date: Tue Jul 31 09:40:15 2018 New Revision: 338399 URL: http://llvm.org/viewvc/llvm-project?rev=338399&view=rev Log: [OPENMP] Prevent problems with linking of the static variables. No need to change the linkage, we can avoid the problem using special variable. That points to the

[PATCH] D49865: Inform the AST of #pragma FENV_ACCESS use

kpn updated this revision to Diff 158307. kpn added a comment. Replace accidentally lost comment. https://reviews.llvm.org/D49865 Files: include/clang/AST/Expr.h include/clang/Basic/LangOptions.h include/clang/Basic/TokenKinds.def include/clang/Parse/Parser.h include/clang/Sema/Sema.h

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

simark added a comment. In https://reviews.llvm.org/D49833#1182615, @malaperle wrote: > @simark would you mind finishing this patch and committing it? I won't be > able to finish it given that I started it at a different company, etc. Yes, I'll take it over, thanks for getting it started. Re

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. Notes: - I choose not to add an option to enable this behavior, as I think of it as just another way clang-format can (better) format the code; but I can one if needed - Currently, it relies on another patch (https://reviews.llvm.org/D32478), which supports aligning the w

[PATCH] D33440: clang-format: better handle statement macros

Typz updated this revision to Diff 158308. Typz marked an inline comment as done. Typz added a comment. Herald added a subscriber: acoomans. Regenerate documentation Repository: rC Clang https://reviews.llvm.org/D33440 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h

[PATCH] D37813: clang-format: better handle namespace macros

Typz updated this revision to Diff 158309. Typz added a comment. Herald added a subscriber: acoomans. Regeneration documentation Repository: rC Clang https://reviews.llvm.org/D37813 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

lebedev.ri updated this revision to Diff 158311. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. - Store/prepend it into `llvm::TrailingObjects<>` - Use `unsigned short` - Assert that the storage is at least large enough to be compliant with implimits

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

lebedev.ri added inline comments. Comment at: test/CodeGenCXX/castexpr-basepathsize-threshold.cpp:1 +// RUN: %clang_cc1 %s -emit-llvm -o - + erichkeane wrote: > First, most of this test can be further simplified. Second, I'd like to see > a test that actually t

[PATCH] D43183: clang-format: introduce `CaseBlockIndent` to control indent in switch

Typz updated this revision to Diff 158313. Typz added a comment. Herald added a subscriber: acoomans. Regenerate documentation Repository: rC Clang https://reviews.llvm.org/D43183 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/U

[PATCH] D49918: [clang-tidy] Sequence declaration in while statement before the condition

mboehme updated this revision to Diff 158314. mboehme added a comment. Add support for switch statement. While I'm here, also add support for the init statement in an if statement. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49918 Files: clang-tidy/utils/ExprSequence.cpp

[PATCH] D49918: [clang-tidy] Sequence declaration in while statement before the condition

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang-tidy/utils/ExprSequence.cpp:147 return TheIfStmt->getCond(); +} else if (const auto *TheWhileStmt = dyn_cast(Parent)) { + // While statement: If a variable is declared ins

[PATCH] D47267: [UnrollAndJam] Add unroll_and_jam pragma handling

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Sema/SemaStmtAttr.cpp:183 {nullptr, nullptr}}; - for (const auto *I : Attrs) { [nit] unrelated whitespace

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

erichkeane added inline comments. Comment at: include/clang/AST/Expr.h:2791 +public: + using BasePathSizeTy = unsigned short; + static_assert(std::numeric_limits::max() >= 16384, I'll let @rjmccall comment here, but I think I'd be willing to give up 2 more byt

[PATCH] D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types

elsteveogrande added a comment. hi @rsmith have a look and let me know if this change looks sensible :) Please make sure I have the right mental model for inheritance in the module case Repository: rC Clang https://reviews.llvm.org/D38320 ___ c

[PATCH] D50029: [COFF, ARM64] Enable SEH for ARM64 Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL338405: [COFF, ARM64] Enable SEH for ARM64 Windows (authored by mgrang, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50029?vs=158147&id=158

r338405 - [COFF, ARM64] Enable SEH for ARM64 Windows

Author: mgrang Date: Tue Jul 31 10:42:05 2018 New Revision: 338405 URL: http://llvm.org/viewvc/llvm-project?rev=338405&view=rev Log: [COFF, ARM64] Enable SEH for ARM64 Windows Reviewers: rnk, mstorsjo, ssijaric, haripul, TomTan Reviewed By: rnk Subscribers: kristof.beyls, chrib, cfe-commits Di

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

erichkeane added inline comments. Comment at: include/clang/AST/Expr.h:2805 + } + BasePathSizeTy &BasePathSize(); + erichkeane wrote: > Why is this a reference? This seems odd... It seems that the const-cast > magic above shouldn't be necessary either. Lookin

[PATCH] D50088: [Sema] Dig through AutoTypes that have been deduced to an undeduced AutoType in Type::isUndeducedType

erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. Herald added a subscriber: dexonsmith. Clang used to error out on the attached test case because we deduced an auto type to an undeduced auto type in the template-id G. This caused Sema::CheckNonTypeTemplateParamete

[PATCH] D50089: [DWARF v4] Suppressing the __debug_ranges section when there are no ranges

wolfgangp created this revision. wolfgangp added reviewers: aprantl, JDevlieghere, dblaikie. One of the clang tests in debuginfo-tests (apple-accel.cpp) insists on checking for the existence of the __debug_ranges section (it requires darwin) even for trivial code which doesn't need any range lis

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

lebedev.ri added inline comments. Comment at: include/clang/AST/Expr.h:2791 +public: + using BasePathSizeTy = unsigned short; + static_assert(std::numeric_limits::max() >= 16384, erichkeane wrote: > I'll let @rjmccall comment here, but I think I'd be willing to

[libcxx] r338411 - Introduce a new test macro TEST_HAS_C11_FEATURES which is set when the underlying C library has C11 features. In C++17, we use those features. <__config> defines a similar macro, _L

Author: marshall Date: Tue Jul 31 11:23:57 2018 New Revision: 338411 URL: http://llvm.org/viewvc/llvm-project?rev=338411&view=rev Log: Introduce a new test macro TEST_HAS_C11_FEATURES which is set when the underlying C library has C11 features. In C++17, we use those features. <__config> defines

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

efriedma added a comment. Please don't commit patches on behalf of someone else if the author hasn't specifically requested it. There might be some issue which the author forgot to note on the review. Repository: rC Clang https://reviews.llvm.org/D46822 _

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

lebedev.ri updated this revision to Diff 158344. lebedev.ri marked 6 inline comments as done. lebedev.ri added a comment. Address some of @erichkeane review notes. Repository: rC Clang https://reviews.llvm.org/D50050 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/c

r338413 - [OPENMP] Change linkage of offloading symbols to support dropping

Author: abataev Date: Tue Jul 31 11:27:42 2018 New Revision: 338413 URL: http://llvm.org/viewvc/llvm-project?rev=338413&view=rev Log: [OPENMP] Change linkage of offloading symbols to support dropping offload targets. Changed the linkage of omp_offloading.img_start. and omp_offloading.img_end. sy

  1   2   3   >