[PATCH] D50047: [compiler-rt] [test] Use approximate comparison on float types

[Luka Ercegovcevic via Phabricator via cfe-commits]

erceg95 created this revision.
erceg95 added reviewers: compnerd, scanon, mgorny.
Herald added a subscriber: dberris.

We are resubmitting this patch (https://reviews.llvm.org/D28862) as it still 
causes this test of fail on Ubuntu 18.04 , Ubuntu GLIBC 2.27-3ubuntu1.


https://reviews.llvm.org/D50047

Files:
  test/builtins/Unit/divsc3_test.c


Index: test/builtins/Unit/divsc3_test.c
===================================================================
--- test/builtins/Unit/divsc3_test.c
+++ test/builtins/Unit/divsc3_test.c
@@ -15,6 +15,7 @@
 #include "int_lib.h"
 #include <math.h>
 #include <complex.h>
+#include <stdbool.h>
 #include <stdio.h>
 
 // REQUIRES: c99-complex
@@ -50,6 +51,25 @@
     return non_zero;
 }
 
+// check for equality assuming that both real and imaginary parts
+// can differ by exactly 1 representable value, in order to handle
+// different levels of accuracy on 32-bit x86
+static bool approx_equal(float _Complex a, float _Complex b) {
+    if (a != b) {
+        float ra = __real__ a;
+        float ia = __imag__ a;
+        float rb = __real__ b;
+        float ib = __imag__ b;
+
+        if (ra != rb && nextafterf(ra, rb) != rb)
+            return false;
+        if (ia != ib && nextafterf(ia, ib) != ib)
+            return false;
+    }
+
+    return true;
+}
+
 int test__divsc3(float a, float b, float c, float d)
 {
     float _Complex r = __divsc3(a, b, c, d);
@@ -103,7 +123,7 @@
             {
             float _Complex z = (a * c + b * d) / (c * c + d * d)
                              + (b * c - a * d) / (c * c + d * d) * _Complex_I;
-            if (r != z)
+            if (!approx_equal(r, z))
                 return 1;
             }
             break;



Index: test/builtins/Unit/divsc3_test.c
===================================================================
--- test/builtins/Unit/divsc3_test.c
+++ test/builtins/Unit/divsc3_test.c
@@ -15,6 +15,7 @@
 #include "int_lib.h"
 #include <math.h>
 #include <complex.h>
+#include <stdbool.h>
 #include <stdio.h>
 
 // REQUIRES: c99-complex
@@ -50,6 +51,25 @@
     return non_zero;
 }
 
+// check for equality assuming that both real and imaginary parts
+// can differ by exactly 1 representable value, in order to handle
+// different levels of accuracy on 32-bit x86
+static bool approx_equal(float _Complex a, float _Complex b) {
+    if (a != b) {
+        float ra = __real__ a;
+        float ia = __imag__ a;
+        float rb = __real__ b;
+        float ib = __imag__ b;
+
+        if (ra != rb && nextafterf(ra, rb) != rb)
+            return false;
+        if (ia != ib && nextafterf(ia, ib) != ib)
+            return false;
+    }
+
+    return true;
+}
+
 int test__divsc3(float a, float b, float c, float d)
 {
     float _Complex r = __divsc3(a, b, c, d);
@@ -103,7 +123,7 @@
             {
             float _Complex z = (a * c + b * d) / (c * c + d * d)
                              + (b * c - a * d) / (c * c + d * d) * _Complex_I;
-            if (r != z)
+            if (!approx_equal(r, z))
                 return 1;
             }
             break;

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits