r338230 - PR38355 Prevent infinite recursion when checking initializer lifetime if

Author: rsmith Date: Mon Jul 30 00:19:54 2018 New Revision: 338230 URL: http://llvm.org/viewvc/llvm-project?rev=338230&view=rev Log: PR38355 Prevent infinite recursion when checking initializer lifetime if an initializer is self-referential. Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/t

[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.h:106 CachingCompilationDb CDB; + InMemoryCompilationDb InMemoryCDB; This code starts to be a little hard to follow. Could we extract it into an external class that encapsulates this l

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

avt77 added inline comments. Comment at: lib/Sema/SemaLambda.cpp:1447 +getFrontendFunctionTimeCtx()->startFrontendTimer( +{LSI.CallOperator, 0.0}); + } efriedma wrote: > This seems sort of late? You're starting the timer after the body has > alread

[PATCH] D49862: [clang-tidy] Fix a crash in fuchsia-multiple-inheritance

ilya-biryukov added a comment. Sorry for sending this in instead of waiting for https://reviews.llvm.org/D49158 to land, I hadn't noticed it earlier Repository: rL LLVM https://reviews.llvm.org/D49862 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D49840: [AST] Add MatchFinder::matchSubtree

steveire added a comment. In https://reviews.llvm.org/D49840#1176405, @klimek wrote: > Usually we use match(anyOf(node), hasDescendant(node)). Or did I > misunderstand what you want? See http://lists.llvm.org/pipermail/cfe-dev/2018-July/058625.html for a bug that prevents this working. Repo

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

krasimir updated this revision to Diff 157925. krasimir added a comment. - Address comments Repository: rC Clang https://reviews.llvm.org/D49797 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp unittests/Form

Re: [PATCH] D49840: [AST] Add MatchFinder::matchSubtree

On Mon, Jul 30, 2018 at 10:02 AM Stephen Kelly via Phabricator < revi...@reviews.llvm.org> wrote: > steveire added a comment. > > In https://reviews.llvm.org/D49840#1176405, @klimek wrote: > > > Usually we use match(anyOf(node), hasDescendant(node)). Or did I > misunderstand what you want? > > > S

r338232 - [clang-format] Indent after breaking Javadoc annotated line

Author: krasimir Date: Mon Jul 30 01:45:45 2018 New Revision: 338232 URL: http://llvm.org/viewvc/llvm-project?rev=338232&view=rev Log: [clang-format] Indent after breaking Javadoc annotated line Summary: This patch makes clang-format indent the subsequent lines created by breaking a long javadoc

[PATCH] D49797: [clang-format] Indent after breaking Javadoc annotated line

This revision was automatically updated to reflect the committed changes. Closed by commit rL338232: [clang-format] Indent after breaking Javadoc annotated line (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49797

r338234 - [Analyzer] Iterator Checker Hotfix: Defer deletion of container data until its last iterator is cleaned up

Author: baloghadamsoftware Date: Mon Jul 30 01:52:21 2018 New Revision: 338234 URL: http://llvm.org/viewvc/llvm-project?rev=338234&view=rev Log: [Analyzer] Iterator Checker Hotfix: Defer deletion of container data until its last iterator is cleaned up The analyzer may consider a container region

[PATCH] D48427: [Analyzer] Iterator Checker Hotfix: Defer deletion of container data until its last iterator is cleaned up

This revision was automatically updated to reflect the committed changes. Closed by commit rC338234: [Analyzer] Iterator Checker Hotfix: Defer deletion of container data until its… (authored by baloghadamsoftware, committed by ). Changed prior to commit: https://reviews.llvm.org/D48427?vs=15406

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

jolesiak added a comment. First of all, thanks, Arnaud, for looking into this. Let's address the mentioned bug first. Let's assume that we use `IndentReference = Relative`. I think that this particular formatting bug is local (i.e. can be solved while processing a `@protocol` block). Look at th

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

djasper added a comment. Ok, so IIUC, understanding that @end effective ends a section much like "}" would address the currently observed problems? https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

r338238 - Fix -Wdocumentation warning. NFCI.

Author: rksimon Date: Mon Jul 30 03:07:47 2018 New Revision: 338238 URL: http://llvm.org/viewvc/llvm-project?rev=338238&view=rev Log: Fix -Wdocumentation warning. NFCI. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h URL

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

jolesiak added a comment. In https://reviews.llvm.org/D49580#1179924, @djasper wrote: > Ok, so IIUC, understanding that @end effective ends a section much like "}" > would address the currently observed problems? I think so. https://reviews.llvm.org/D49580

[PATCH] D49289: [mips64][clang] Provide the signext attribute for i32 return values

This revision was automatically updated to reflect the committed changes. Closed by commit rC338239: [mips64][clang] Provide the signext attribute for i32 return values (authored by smaksimovic, committed by ). Repository: rC Clang https://reviews.llvm.org/D49289 Files: lib/CodeGen/TargetIn

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

Thank you for the explanation Chandler. This patch is not on a critical path for me, so I don't mind it taking a while (though it would be nice to fix as this is a also long standing cause of expression evaluation failures in LLDB). I believe that best solution here would be extend the set of cond

r338239 - [mips64][clang] Provide the signext attribute for i32 return values

Author: smaksimovic Date: Mon Jul 30 03:44:46 2018 New Revision: 338239 URL: http://llvm.org/viewvc/llvm-project?rev=338239&view=rev Log: [mips64][clang] Provide the signext attribute for i32 return values Additional info: see r338019. Differential Revision: https://reviews.llvm.org/D49289 Modi

[PATCH] D47154: Try to make builtin address space declarations not useless

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. I missed the addr space casts you added to CodeGenFunction::EmitBuiltinExpr. With those casts it should work. For other downstream address space agnostic languages, e.g. (HCC),

[clang-tools-extra] r338241 - [clangd] Fix a comment. NFC

Author: ibiryukov Date: Mon Jul 30 04:46:25 2018 New Revision: 338241 URL: http://llvm.org/viewvc/llvm-project?rev=338241&view=rev Log: [clangd] Fix a comment. NFC Modified: clang-tools-extra/trunk/clangd/TUScheduler.cpp Modified: clang-tools-extra/trunk/clangd/TUScheduler.cpp URL: http://l

r338245 - [clang-format] Silence -Wdocumentation warnings

Author: krasimir Date: Mon Jul 30 05:22:41 2018 New Revision: 338245 URL: http://llvm.org/viewvc/llvm-project?rev=338245&view=rev Log: [clang-format] Silence -Wdocumentation warnings introduced in r338232 Modified: cfe/trunk/lib/Format/BreakableToken.h Modified: cfe/trunk/lib/Format/Breakab

r338246 - [mips64][clang] Adjust tests to account for changes in r338239

Author: smaksimovic Date: Mon Jul 30 05:27:40 2018 New Revision: 338246 URL: http://llvm.org/viewvc/llvm-project?rev=338246&view=rev Log: [mips64][clang] Adjust tests to account for changes in r338239 Modified: cfe/trunk/test/CodeGen/mips-unsigned-ext-var.c cfe/trunk/test/CodeGen/mips-va

[PATCH] D49986: [ADT] ImmutableList::add parameters are switched

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, dcoughlin, chandlerc. Herald added a subscriber: cfe-commits. Clang side changes, see https://reviews.llvm.org/D49985. Repository: rC Clang https://reviews.llvm.org/D49986 Files: include/clang/StaticAnalyzer

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

mclow.lists added a comment. I am not in favor of this patch. I'm in favor of fixing the problem that Arthur has described, but not like this, for the following reasons: - Conceptually, these are (similar to) "Allocator-based versions of the algorithms proposed in P0040

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

greened added a comment. I think I need an accept before this can proceed. Repository: rC Clang https://reviews.llvm.org/D49898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49075: [NEON] Define fp16 vld and vst intrinsics conditionally

kosarev updated this revision to Diff 157960. kosarev added a comment. Test that the affected intrinsics are not defined in no-fp16 mode. https://reviews.llvm.org/D49075 Files: include/clang/Basic/arm_neon.td test/CodeGen/arm-neon-vld.c test/CodeGen/arm-neon-vst.c test/Sema/arm-no-fp16.

r338252 - [OPENMP] Modify the info about OpenMP support in UsersManual, NFC.

Author: abataev Date: Mon Jul 30 07:44:29 2018 New Revision: 338252 URL: http://llvm.org/viewvc/llvm-project?rev=338252&view=rev Log: [OPENMP] Modify the info about OpenMP support in UsersManual, NFC. Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: htt

[PATCH] D49989: WIP: [CodeGen] Disable aggressive structor optimizations at -O0, take 4

labath created this revision. Herald added subscribers: cfe-commits, aheejin. This version of the patch attempts to mitigate the code size regressions caused by the previous versions of this patch (https://reviews.llvm.org/D46685). It does this by using aliases and C5/https://reviews.llvm.org/D5

[PATCH] D49361: [analyzer] Detect pointers escaped after return statement execution in MallocChecker

rnkovacs updated this revision to Diff 157966. rnkovacs marked an inline comment as done. rnkovacs added a comment. De-duplicate & add comment. https://reviews.llvm.org/D49361 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/inner-pointer.cpp test/Analysis/malloc-free-af

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

I've managed to hack together an implementation of this proposal. I've put it up at so you have an idea of where I'm going with this. It seems to work fine (I've managed to bootstrap clang with it), though I'm not exactly proud of the implementation. Let me know w

[PATCH] D49914: [libc++] Add the _LIBCPP_HIDE_FROM_ABI_AFTER_V1 macro

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This LGTM, but suggests another cleanup. We have a bunch of `_LIBCPP_BUILDING_XXX` macros defined in libcxx/src - do we need them any more now that we have `_LIBCPP_BUILDING_LIBRARY`

r338255 - [CodeComplete] Fix the crash in code completion on access checking

Author: ibiryukov Date: Mon Jul 30 08:19:05 2018 New Revision: 338255 URL: http://llvm.org/viewvc/llvm-project?rev=338255&view=rev Log: [CodeComplete] Fix the crash in code completion on access checking Started crashing in r337453. See the added test case for the crash repro. The fix reverts par

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

Prtially reverted the commit in r338255 to fix a very frequent crash. The code seemed obviously wrong there (calling accessibility checking, passing a possibly unrelated class) and the tests didn't break after reverting it. Let me know if I missed anything. On Thu, Jul 19, 2018 at 3:37 PM Eric Li

[clang-tools-extra] r338256 - [clangd] Do not remove AST from cache if nothing changed

Author: ibiryukov Date: Mon Jul 30 08:30:45 2018 New Revision: 338256 URL: http://llvm.org/viewvc/llvm-project?rev=338256&view=rev Log: [clangd] Do not remove AST from cache if nothing changed We were previously clearing the AST cache if the inputs and the preamble were the same, which is not des

[PATCH] D49991: [clangd] Do not build AST if no diagnostics were requested

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ioeric. Herald added subscribers: arphaman, jkorous, MaskRay, javed.absar. It can be washed out from the cache before first access anyway, so building it can just be a waste of time. Repository: rCTE Clang Tools Extra https:

r338259 - [analyzer] Add support for more invalidating functions in InnerPointerChecker.

Author: rkovacs Date: Mon Jul 30 08:43:45 2018 New Revision: 338259 URL: http://llvm.org/viewvc/llvm-project?rev=338259&view=rev Log: [analyzer] Add support for more invalidating functions in InnerPointerChecker. According to the standard, pointers referring to the elements of a `basic_string` ma

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC338259: [analyzer] Add support for more invalidating functions in InnerPointerChecker. (authored by rkovacs, committed by ). Repository: rC Clang https://reviews.llvm.org/D49656 Files: lib/StaticAna

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

ldionne added a comment. In https://reviews.llvm.org/D49317#1180200, @mclow.lists wrote: > I am not in favor of this patch. > > I'm in favor of fixing the problem that Arthur has described, but not like > this, for the following reasons: > > - Conceptually, these are (similar to) "Allocator-base

[PATCH] D48436: [analyzer][UninitializedObjectChecker] Fixed a false negative by no longer filtering out certain constructor calls

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:681-689 +Optional OtherObject = +getObjectVal(OtherCtor, Context); +if (!OtherObject) + continue; + +// If the CurrentObject is a field of OtherObject,

[clang-tools-extra] r338260 - [clangd] Remove outdated comment. NFC

Author: ibiryukov Date: Mon Jul 30 08:55:13 2018 New Revision: 338260 URL: http://llvm.org/viewvc/llvm-project?rev=338260&view=rev Log: [clangd] Remove outdated comment. NFC Modified: clang-tools-extra/trunk/clangd/ClangdServer.h Modified: clang-tools-extra/trunk/clangd/ClangdServer.h URL:

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

sbc100 added a comment. How do you configure clang to use a different linker? It looks like getDefaultLinker() is hardcoded, but maybe I'm missing something. Repository: rC Clang https://reviews.llvm.org/D49897 ___ cfe-commits mailing list cfe-

r338263 - [analyzer] Add missing state transition in IteratorChecker.

Author: rkovacs Date: Mon Jul 30 09:14:59 2018 New Revision: 338263 URL: http://llvm.org/viewvc/llvm-project?rev=338263&view=rev Log: [analyzer] Add missing state transition in IteratorChecker. After cleaning up program state maps in `checkDeadSymbols()`, a transition should be added to generate

[PATCH] D47417: [analyzer] Add missing state transition in IteratorChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL338263: [analyzer] Add missing state transition in IteratorChecker. (authored by rkovacs, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4741

[PATCH] D47417: [analyzer] Add missing state transition in IteratorChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC338263: [analyzer] Add missing state transition in IteratorChecker. (authored by rkovacs, committed by ). Repository: rC Clang https://reviews.llvm.org/D47417 Files: lib/StaticAnalyzer/Checkers/Iter

[PATCH] D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

scott.linder added a comment. Thank you for taking a look @yaxunl. Should I wait for another reviewer or can I commit this? Repository: rC Clang https://reviews.llvm.org/D49930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D49986: [ADT] ImmutableList::add parameters are switched

george.karpenkov added a comment. I'm a bit confused: does it mean these methods are never called in Clang? Repository: rC Clang https://reviews.llvm.org/D49986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D49058: [analyzer] Move InnerPointerChecker out of alpha

rnkovacs updated this revision to Diff 157987. rnkovacs retitled this revision from "[analyzer] Move DanglingInternalBufferChecker out of alpha" to "[analyzer] Move InnerPointerChecker out of alpha". rnkovacs added a comment. Rebase. https://reviews.llvm.org/D49058 Files: include/clang/Stat

[PATCH] D49058: [analyzer] Move InnerPointerChecker out of alpha

NoQ accepted this revision. NoQ added a comment. Ok, cool! Let's get this done. https://reviews.llvm.org/D49058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Quuxplusone added inline comments. Comment at: include/vector:318 +} +} + Marshall writes: > Instead, we should be writing simple loops that the compiler can optimize > into a call to memcpy if it chooses. Having calls to memcpy in the code paths > makes it

[PATCH] D49953: [compiler-rt] Add a routine to specify the mode used when creating profile dirs.

probinson added a comment. Is it possible/reasonable for the test to call __llvm_profile_recursive_mkdir and then verify the mode of the created directory? The test would have to be flagged as unsupported on Windows but that seems fine. https://reviews.llvm.org/D49953 ___

[PATCH] D48794: [AArch64] Implement execute-only support.

ivanlozano abandoned this revision. ivanlozano added a comment. Alternative solution committed: https://reviews.llvm.org/rL338271 Repository: rC Clang https://reviews.llvm.org/D48794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D49953: [compiler-rt] Add a routine to specify the mode used when creating profile dirs.

mattd added a comment. In https://reviews.llvm.org/D49953#1180466, @probinson wrote: > Is it possible/reasonable for the test to call __llvm_profile_recursive_mkdir > and then verify the mode of the created directory? > The test would have to be flagged as unsupported on Windows but that seems

[PATCH] D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required

dblaikie added a comment. Test coverage? Repository: rC Clang https://reviews.llvm.org/D49916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

mclow.lists added inline comments. Comment at: include/vector:318 +} +} + Quuxplusone wrote: > Marshall writes: > > Instead, we should be writing simple loops that the compiler can optimize > > into a call to memcpy if it chooses. Having calls to memcpy in t

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Quuxplusone added inline comments. Comment at: include/vector:318 +} +} + mclow.lists wrote: > Quuxplusone wrote: > > Marshall writes: > > > Instead, we should be writing simple loops that the compiler can optimize > > > into a call to memcpy if it chooses.

r338279 - [ARM, AArch64]: Use unadjusted alignment when passing composites as arguments

Author: chill Date: Mon Jul 30 10:48:23 2018 New Revision: 338279 URL: http://llvm.org/viewvc/llvm-project?rev=338279&view=rev Log: [ARM, AArch64]: Use unadjusted alignment when passing composites as arguments The "Procedure Call Procedure Call Standard for the ARM® Architecture" (https://static.

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rC338279: [ARM, AArch64]: Use unadjusted alignment when passing composites as arguments (authored by chill, committed by ). Repository: rC Clang https://reviews.llvm.org/D46013 Files: include/clang/AS

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

rsmith accepted this revision. rsmith added a comment. Only comments on documentation and assertions. Feel free to commit once these are addressed to your satisfaction. Comment at: docs/ReleaseNotes.rst:310 + + Just like ``-fsanitize=integer``, these issues are **not** undefi

r338282 - Delete some unreachable AST printing code.

Author: rsmith Date: Mon Jul 30 11:05:19 2018 New Revision: 338282 URL: http://llvm.org/viewvc/llvm-project?rev=338282&view=rev Log: Delete some unreachable AST printing code. Modified: cfe/trunk/lib/AST/TypePrinter.cpp Modified: cfe/trunk/lib/AST/TypePrinter.cpp URL: http://llvm.org/viewvc

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin updated this revision to Diff 158017. aheejin added a comment. Herald added a subscriber: jfb. - Changed the first argument of wake from i8* to i32* Repository: rC Clang https://reviews.llvm.org/D49396 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

mclow.lists added a comment. > I don't think it makes sense to pessimize existing (non-constexpr) users in > C++03-through-C++17 just because someone hypothetically might in > C++2a-or-later want to mutate a std::vector in a constexpr context. That's not the right (implied) question. The corre

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Quuxplusone added a comment. @mclow.lists: Well, anyway, is this pure refactoring acceptable, or would you prefer to keep these helpers inside `allocator_traits` until a better solution to constexpr-memcpy can be invented? Repository: rCXX libc++ https://reviews.llvm.org/D49317 _

[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

arphaman updated this revision to Diff 158024. arphaman marked 6 inline comments as done. arphaman added a comment. Address review comments https://reviews.llvm.org/D49758 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/GlobalCompilationDatabase.cpp clangd/GlobalCompil

[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

arphaman added inline comments. Comment at: clangd/tool/ClangdMain.cpp:170 +static llvm::cl::opt +InMemoryCompileCommands("in-memory-compile-commands", +llvm::cl::desc("Use an in-memory compile commands"), ilya-biryukov wrote: > T

[PATCH] D49997: [libcxx] Fix _LIBCPP_NO_EXCEPTIONS redefined warning

jasonl220 created this revision. jasonl220 added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, ldionne. Fix GCC 7.2.0 redefinition warning when LIBCXX_ENABLE_EXCEPTIONS cmake option is not set. > llvm/projects/libcxx/include/__config:514:0: warn

[PATCH] D49361: [analyzer] Detect pointers escaped after return statement execution in MallocChecker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2488 + + checkPreStmt(S, C); +} Let's do a common sub-function, similarly to how `MallocChecker::checkPointerEscape` and `MallocChecker::checkConstPointerEscape` both call `M

[PATCH] D49999: [Hexagon] Remove fp-contract=fast setting for at O3

bcahoon created this revision. bcahoon added a reviewer: kparzysz. Herald added a subscriber: cfe-commits. Change Hexagon so that the setting for fp-contract is the default setting. This makes Hexagon consistent with all the other targets. Repository: rC Clang https://reviews.llvm.org/D4

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

george.karpenkov requested changes to this revision. george.karpenkov added inline comments. This revision now requires changes to proceed. Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:154 -bool WalkAST::containsBadStrlcpyPattern(const CallExpr *CE) { +bool

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

lebedev.ri updated this revision to Diff 158030. lebedev.ri marked 9 inline comments as done. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. Address last portion of @rsmith review notes. @rsmith, @vsk, @erichkeane - thank you for the review! Repository: rC Clang

[PATCH] D49998: [analyzer] Store ValueDecl in DeclRegion

This revision was automatically updated to reflect the committed changes. Closed by commit rC338286: [analyzer] Store ValueDecl in DeclRegion (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D49998?vs=158027

r338286 - [analyzer] Store ValueDecl in DeclRegion

Author: george.karpenkov Date: Mon Jul 30 11:57:13 2018 New Revision: 338286 URL: http://llvm.org/viewvc/llvm-project?rev=338286&view=rev Log: [analyzer] Store ValueDecl in DeclRegion All use cases of DeclRegion actually have ValueDecl there, and getting the name from declaration comes in very ha

r338288 - [clang][ubsan] Implicit Conversion Sanitizer - integer truncation - clang part

Author: lebedevri Date: Mon Jul 30 11:58:30 2018 New Revision: 338288 URL: http://llvm.org/viewvc/llvm-project?rev=338288&view=rev Log: [clang][ubsan] Implicit Conversion Sanitizer - integer truncation - clang part Summary: C and C++ are interesting languages. They are statically typed, but weak

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

lebedev.ri added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:136-137 + overflow happens (signed or unsigned). + Both of these two issues are handled by ``-fsanitize=implicit-conversion`` + group of checks. - ``-fsanitize=unreachable``: If cont

[PATCH] D48958: [clang][ubsan] Implicit Cast Sanitizer - integer truncation - clang part

This revision was automatically updated to reflect the committed changes. Closed by commit rC338288: [clang][ubsan] Implicit Conversion Sanitizer - integer truncation - clang part (authored by lebedevri, committed by ). Repository: rC Clang https://reviews.llvm.org/D48958 Files: docs/Relea

[PATCH] D49865: Inform the AST of #pragma FENV_ACCESS use

kpn updated this revision to Diff 158036. kpn added a comment. Updated based on review. https://reviews.llvm.org/D49865 Files: include/clang/AST/Expr.h include/clang/Basic/LangOptions.h include/clang/Basic/TokenKinds.def include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Par

[PATCH] D49865: Inform the AST of #pragma FENV_ACCESS use

kpn marked 3 inline comments as done. kpn added inline comments. Comment at: include/clang/Basic/LangOptions.h:273-280 FPOptions() : fp_contract(LangOptions::FPC_Off) {} // Used for serializing. explicit FPOptions(unsigned I) : fp_contract(static_cast(I)) {}

r338290 - Make test/Driver/baremetal.cpp work with linkers other than lld

Author: greened Date: Mon Jul 30 12:08:20 2018 New Revision: 338290 URL: http://llvm.org/viewvc/llvm-project?rev=338290&view=rev Log: Make test/Driver/baremetal.cpp work with linkers other than lld This test fails if clang is configure with, for example, gold as the default linker. It does not ap

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen updated this revision to Diff 158038. timshen marked 2 inline comments as done. timshen added a comment. Update based on comments. https://reviews.llvm.org/D41376 Files: libcxx/include/__config libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/test/std

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen added inline comments. Comment at: libcxx/include/experimental/simd:703 +public: + _Tp __get(size_t __index) const { return (&__storage_)[__index]; }; + void __set(size_t __index, _Tp __val) { (&__storage_)[__index] = __val; } mclow.lists wrote: > Can t

[PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

greened closed this revision. greened added a comment. Committed in 338290. Repository: rC Clang https://reviews.llvm.org/D49898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r338239 - [mips64][clang] Provide the signext attribute for i32 return values

On 7/30/2018 3:44 AM, Stefan Maksimovic via cfe-commits wrote: Author: smaksimovic Date: Mon Jul 30 03:44:46 2018 New Revision: 338239 URL: http://llvm.org/viewvc/llvm-project?rev=338239&view=rev Log: [mips64][clang] Provide the signext attribute for i32 return values Additional info: see r3380

[PATCH] D50002: [coroutines] Fix handling of dependent co_await in StmtProfiler

vitaut created this revision. vitaut added reviewers: rsmith, GorNishanov, EricWF. Herald added subscribers: cfe-commits, modocache. Fix "Invalid operator call kind" error (`llvm_unreachable`) in `DecodeOperatorCall` when compiling the following example with `-emit-pch`: struct S {}; S operat

[PATCH] D50003: Sema: Fix explicit address space cast involving void pointers

yaxunl created this revision. yaxunl added a reviewer: rjmccall. Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destina

[PATCH] D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D49930#1180388, @scott.linder wrote: > Thank you for taking a look @yaxunl. Should I wait for another reviewer or > can I commit this? I think it is OK to land. W

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

mgrang added a comment. I would commit this today unless there any comments. Thanks. https://reviews.llvm.org/D48862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50002: [coroutines] Fix handling of dependent co_await in StmtProfiler

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks. Do you need someone to commit this for you? Repository: rC Clang https://reviews.llvm.org/D50002 ___ cfe-commits mailing l

[PATCH] D50002: [coroutines] Fix handling of dependent co_await in StmtProfiler

vitaut added a comment. > Do you need someone to commit this for you? Yes, please. I don't have commit rights. Repository: rC Clang https://reviews.llvm.org/D50002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

r338294 - [OpenEmbedded] Fix lib paths for OpenEmbedded targets

Author: mgrang Date: Mon Jul 30 12:44:13 2018 New Revision: 338294 URL: http://llvm.org/viewvc/llvm-project?rev=338294&view=rev Log: [OpenEmbedded] Fix lib paths for OpenEmbedded targets Summary: The lib paths are not correctly picked up for OpenEmbedded sysroots (like arm-oe-linux-gnueabi) for

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. After thinking about this for some more, I'm not sure this patch is worth doing in its current form. The minimal patch for allowing specializations of `allocator_traits` would be:

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL338294: [OpenEmbedded] Fix lib paths for OpenEmbedded targets (authored by mgrang, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48862?vs=15

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. I think we just ran into one such issue. We're using our own Clang that's usually following tip-of-tree and we recently switched to C++17, but that started failing on our macOS 10.12 bots with: Undefined symbols for architecture x86_64: "operator delete(void*, std:

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D41376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D49911: Summary:Add clang::reinitializes attribute

mboehme updated this revision to Diff 158051. mboehme added a comment. Various changes in response to reviewer comments. Repository: rC Clang https://reviews.llvm.org/D49911 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/Sema/SemaDeclAttr.cpp test/SemaCXX/attr

Re: r338291 - Remove trailing space

Oops.. sorry but now they have been committed.. On Mon, Jul 30, 2018 at 12:31 PM Aaron Ballman wrote: > > This is an extraordinary amount of churn for very little value, IMO. > The same goes for r338291. Were these changes discussed somewhere > before being committed? I worry about the negative im

[PATCH] D49865: Inform the AST of #pragma FENV_ACCESS use

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Parse/ParsePragma.cpp:619-623 +#if NOTYET // FIXME: Add this cli option when it makes sense. + case tok::OOS_DEFAULT: +FPC = getLangOpts().getDefault

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Quuxplusone added a comment. In https://reviews.llvm.org/D49317#1180852, @ldionne wrote: > After thinking about this for some more, I'm not sure this patch is worth > doing in its current form. The minimal patch for allowing specializations of > `allocator_traits` would be: > > 1. move the `__m

[PATCH] D49911: Summary:Add clang::reinitializes attribute

mboehme marked 3 inline comments as done. mboehme added a comment. > Should this attribute have some semantic checking that ensures the non-static > data members are accessed in the function that claims it reinitializes the > object? I think this would be hard to do in a way that provides meani

[PATCH] D49930: [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

echristo added a comment. The patch is fine, in general, couple of comments: a) Can you refactor this so the if conditionals are just two functions? Those functions are big enough already. b) I'm not quite sure why you're picking limited here, do you have an explanation? c) Can you split that p

  1   2   >