rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/Parse/ParsePragma.cpp:619-623
+#if NOTYET // FIXME: Add this cli option when it makes sense.
+ case tok::OOS_DEFAULT:
+ FPC = getLangOpts().getDefaultFENVAccessMode();
+ break;
+#endif
----------------
rsmith wrote:
> You need to do *something* in this case. Currently, `FPC` is read
> uninitialized a few lines below when this happens. How about just treating
> this as the same as `OFF` for now, since that is our default.
Drop the `#if NOTYET` part; we don't like having checked-in but commented-out
code. Just keep the FIXME comment.
================
Comment at: lib/Parse/ParsePragma.cpp:109
return;
- if (OOS == tok::OOS_ON)
+ if (OOS == tok::OOS_ON) {
PP.Diag(Tok, diag::warn_stdc_fenv_access_not_supported);
----------------
We also need to pass the pragma on to `Sema` when it's set to `OFF`.
https://reviews.llvm.org/D49865
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
