arphaman added inline comments.
================
Comment at: clangd/tool/ClangdMain.cpp:170
+static llvm::cl::opt<bool>
+ InMemoryCompileCommands("in-memory-compile-commands",
+ llvm::cl::desc("Use an in-memory compile
commands"),
----------------
ilya-biryukov wrote:
> The important distinction seems to be where the compile commands come from,
> maybe make the name centered on the fact that compile commands are read from
> the protocol rather from the filesystem?
>
> E.g. using named option values:
> `--compile_args_from={lsp|filesystem}`
> Or a boolean option:
> `--compile_args_from_lsp`
>
> WDYT?
Yeah, that looks better. I added this argument in the updated patch.
https://reviews.llvm.org/D49758
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
