sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Sorry, I thought I'd accepted this already!
Comment at: clangd/ClangdServer.cpp:467
+ };
+ WorkScheduler.runWithAST("Hover", File, Bind(Action, std::move(CB)));
+}
--
balazske updated this revision to Diff 154175.
balazske added a comment.
- Added comment into test StructuralEquivalenceRecordTest.DISABLED_Methods.
Repository:
rC Clang
https://reviews.llvm.org/D48628
Files:
lib/AST/ASTImporter.cpp
lib/AST/ASTStructuralEquivalence.cpp
unittests/AST/AS
balazske marked an inline comment as done.
balazske added inline comments.
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:489
+
+TEST_F(StructuralEquivalenceRecordTest, DISABLED_Methods) {
+ auto t = makeNamedDecls(
a_sidorin wrote:
> Could you add a co
WimLeflere updated this revision to Diff 154176.
WimLeflere added a comment.
Added the documentation to the header file.
Also had to update dump_format_style.py because it was not loading the
IncludeStyle header file.
Repository:
rC Clang
https://reviews.llvm.org/D48827
Files:
docs/ClangF
sammccall added a comment.
(Reasoning for not using SymbolCollector totally makes sense, thanks for the
breakdown!)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/clangd/QualityTests.cpp:218
+
+ // `findDecl` would return the implicit injected class for "Foo::Foo"; simply
+ // look for a constructor de
chill accepted this revision.
chill added a comment.
This revision is now accepted and ready to land.
LGTM. Please, wait a couple of days before committing to give a chance to
someone else to weigh in.
Repository:
rC Clang
https://reviews.llvm.org/D48916
__
Author: lei
Date: Wed Jul 4 21:32:01 2018
New Revision: 336308
URL: http://llvm.org/viewvc/llvm-project?rev=336308&view=rev
Log:
[Power9] Update fp128 as a valid homogenous aggregate base type
Update clang to treat fp128 as a valid base type for homogeneous aggregate
passing and returning.
Diff
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice fix!
Possible test: add a file with complicated preamble (billion laughs?) and
immediately schedule 5 preamble actions. They should all get a non-null
preamble and the pointers shou
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Very nice!
Comment at: clangd/ClangdUnit.cpp:327
CI.getFrontendOpts().SkipFunctionBodies = true;
+ // We don't want to write comments into PCH. They are racy and sl
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This seems like it might be a nontrivial performance hit (it's going to result
in `stat`ing all these files, right?).
Agreed it's important for correctness, it's possible someone wants th
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/clangd/ClangdTests.cpp:45
namespace {
+// FIXME: This is copied from CodeCompleteTests.cpp. Share the code instead.
+MATCHER_P(Named, Name, "
ioeric updated this revision to Diff 154182.
ioeric added a comment.
- Refactored findAnyDecl.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48933
Files:
clangd/Quality.cpp
unittests/clangd/QualityTests.cpp
unittests/clangd/TestTU.cpp
unittests/clangd/TestTU.h
Index:
Author: ioeric
Date: Thu Jul 5 01:14:04 2018
New Revision: 336318
URL: http://llvm.org/viewvc/llvm-project?rev=336318&view=rev
Log:
[clangd] Treat class constructor as in the same scope as the class in ranking.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, cfe-commits
Diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336318: [clangd] Treat class constructor as in the same
scope as the class in ranking. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48933?vs=154182&id=154183
Author: sammccall
Date: Thu Jul 5 01:26:53 2018
New Revision: 336320
URL: http://llvm.org/viewvc/llvm-project?rev=336320&view=rev
Log:
Revert "[clangd] FileDistance: temporarily disable in CodeComplete, it's
behaving badly"
The bad behavior seems to have been fixed by r336242 after all.
I thoug
ioeric updated this revision to Diff 154185.
ioeric added a comment.
-Rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48724
Files:
clangd/CodeComplete.cpp
Index: clangd/CodeComplete.cpp
===
--- clangd/Cod
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336321: [clangd] Log sema completion context kind and
query scopes. NFC (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48724?vs=154185&id=154186#toc
Repositor
Author: ioeric
Date: Thu Jul 5 01:29:33 2018
New Revision: 336321
URL: http://llvm.org/viewvc/llvm-project?rev=336321&view=rev
Log:
[clangd] Log sema completion context kind and query scopes. NFC
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, cfe-commits
Differential Revisi
martong updated this revision to Diff 154187.
martong added a comment.
`PrevDecl` is set after the `!SearchName` branch, as it had been done before.
This way original behaviour is kept as much as possible.
Repository:
rC Clang
https://reviews.llvm.org/D48773
Files:
lib/AST/ASTImporter.cpp
Author: rksimon
Date: Thu Jul 5 02:35:12 2018
New Revision: 336329
URL: http://llvm.org/viewvc/llvm-project?rev=336329&view=rev
Log:
Fix -Wunused-variable warning. NFCI.
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-extra/trunk/clangd/Quality.cpp
URL:
http://ll
Author: omtcyfz
Date: Thu Jul 5 02:37:26 2018
New Revision: 336330
URL: http://llvm.org/viewvc/llvm-project?rev=336330&view=rev
Log:
[NFS] Wipe trailing whitespaces
This patch is a preparation for another one containing meaningful
changes. This patch simply removes trailing whitespaces in few fi
whisperity added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:92
+ // Whether iterator is valid
+ bool Valid;
+
Seeing that in line 106 you consider this record immutable, you might want to
add a `const` on this field too.
===
Author: martong
Date: Thu Jul 5 02:51:13 2018
New Revision: 336332
URL: http://llvm.org/viewvc/llvm-project?rev=336332&view=rev
Log:
[ASTImporter] Fix import of objects with anonymous types
Summary:
Currently, anonymous types are merged into the same redecl chain even if they
are structurally in
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336332: [ASTImporter] Fix import of objects with anonymous
types (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48773?vs=154187&id=154192#toc
Repository:
rC
whisperity added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:317
+def MismatchedIteratorChecker : Checker<"MismatchedIterator">,
+ HelpText<"Check for use of iterators of different containers where iterators
of the same container are expecte
Hi Eric,
I get the following with this patch:
/proj/flexasic/app/clang/3.6/bin/clang++ -march=corei7
-DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
-Itools/clang/tools/extra/clangd -I../tools/clang/tools/extra/clangd
-I../tool
Ah, already fixed in r336329 I see.
On 07/05/2018 12:56 PM, Mikael Holmén via cfe-commits wrote:
Hi Eric,
I get the following with this patch:
/proj/flexasic/app/clang/3.6/bin/clang++ -march=corei7
-DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D_
ioeric created this revision.
ioeric added reviewers: akyrtzi, arphaman.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D48961
Files:
include/clang/Index/IndexDataConsumer.h
include/clang/Index/IndexSymbol.h
lib/Index/IndexSymbol.cpp
lib/Index/Ind
whisperity added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1061
+ // first reassign all iterator positions to the new container which
+ // are not past the container (thus not greater or equal to the
+ // current "end"
Unfortunately I'm not sure of a good way to validate this. The only way I was
able to even discover this was with manual instrumentation of D48788. There is
a future opportunity to better instrument the source to find these things in
the future that'll catch more issues like this one however.
sammccall added a comment.
I worry this is a trap: the indexing infrastructure here is designed so you can
run it as a frontendaction, on an ASTUnit, or by passing a set of top level
decls.
However the macro functionality necessarily only works when running as a
frontend action, so the same con
r.stahl updated this revision to Diff 154215.
r.stahl marked 2 inline comments as done.
r.stahl added a comment.
Alright, but then I would suggest to pass an invalid loc to the constructors
instead to make it more explicit and save a map lookup in the import function.
Repository:
rC Clang
ht
GBuella updated this revision to Diff 154216.
GBuella added a comment.
As suggested, I added test cases with all predicates (in r336346).
https://reviews.llvm.org/D48715
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx-builtins.c
test/CodeGen/avx512f-builtins.c
test/CodeGen/avx512vl-bu
GBuella added a comment.
ping @spatel
https://reviews.llvm.org/D48715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336347: [mips] Add '-mcrc', '-mno-crc'
options to enable/disable CRC ASE (authored by vstefanovic, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48169
Files:
include/clang/Driver/Op
Author: vstefanovic
Date: Thu Jul 5 06:10:23 2018
New Revision: 336347
URL: http://llvm.org/viewvc/llvm-project?rev=336347&view=rev
Log:
[mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE
'-mcrc' is shared with ARM.
'-mno-crc' is Mips-only (ARM uses '-mnocrc').
Differential revisi
On Thu, Jul 5, 2018 at 8:54 AM, Keane, Erich wrote:
> Unfortunately I'm not sure of a good way to validate this. The only way I
> was able to even discover this was with manual instrumentation of D48788.
> There is a future opportunity to better instrument the source to find these
> things in
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D48715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D48827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: gbuella
Date: Thu Jul 5 07:26:56 2018
New Revision: 336355
URL: http://llvm.org/viewvc/llvm-project?rev=336355&view=rev
Log:
[X86] Fix some vector cmp builtins - TRUE/FALSE predicates
This patch removes on optimization used with the TRUE/FALSE
predicates, as was suggested in https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336355: [X86] Fix some vector cmp builtins - TRUE/FALSE
predicates (authored by GBuella, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48715
Files:
lib/CodeGen/CGBuiltin.cpp
test/
deepak2427 updated this revision to Diff 154237.
deepak2427 added a comment.
Update the tests.
https://reviews.llvm.org/D48721
Files:
lib/CodeGen/CGStmt.cpp
test/CodeGen/pragma-do-while.cpp
Index: test/CodeGen/pragma-do-while.cpp
===
deepak2427 added a comment.
I have updated the test to not run the optimizer. The test I had added
previously for checking if the unroller is respecting the pragma is useful I
think. Not sure where that can be added though.
I guess it's independent of this patch anyway. If the patch and test is
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
hokein added a comment.
Seems to me you have a few comments unaddressed (and make sure you marked them
done when updating the patch).
Repository:
rC Clang
https://reviews.llvm.org/D48903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added a subscriber: cfe-commits.
The method only takes PPreprocessor and don't require structures that
might not be available (e.g. Sema and ASTContext) when CodeCompletionString
needs to be generated for macros.
Repository
simark added a comment.
In https://reviews.llvm.org/D48903#1153142, @hokein wrote:
> Seems to me you have a few comments unaddressed (and make sure you marked
> them done when updating the patch).
Ah damn I missed them, I'm not too used to how Phabricator displays things.
I'll do that.
Rep
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336358: [clang-move] ClangMoveTests: Remove dots in output
paths (authored by simark, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48951
Files
sammccall added a comment.
Could you give a little more context about how this will be used? (where the
completion items come from, and when the strings will get built)
Comment at: include/clang/Sema/CodeCompleteConsumer.h:921
bool I
Author: simark
Date: Thu Jul 5 07:53:17 2018
New Revision: 336358
URL: http://llvm.org/viewvc/llvm-project?rev=336358&view=rev
Log:
[clang-move] ClangMoveTests: Remove dots in output paths
Summary:
Following D48903 ([VirtualFileSystem] InMemoryFileSystem::status: Return
a Status with the request
bjope added inline comments.
Comment at: test/CodeGen/pragma-do-while.cpp:1
+// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s
+int test(int a[], int n) {
I think that we can simplify it to use one loop here (as a regression test that
we only put the label on
deepak2427 added a comment.
Yeah, you're right. Only one loop has to be checked in this case. I'll update
the test as per your suggestion. Thank you!
https://reviews.llvm.org/D48721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
Filed https://bugs.llvm.org/show_bug.cgi?id=38072 with an isolated test
case.
On Wed, Jul 4, 2018 at 4:18 PM Alexander Kornienko
wrote:
> We've started seeing assertion failures after this commit.
> assert.h assertion failed at
> llvm/tools/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:485 in sta
deepak2427 updated this revision to Diff 154244.
deepak2427 added a comment.
Updated with test from Bjorn Pettersson which is much more accurate and
clearer. Thanks!
https://reviews.llvm.org/D48721
Files:
lib/CodeGen/CGStmt.cpp
test/CodeGen/pragma-do-while.cpp
Index: test/CodeGen/pragma-
Anastasia added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3500
+if (auto *PtrTy = dyn_cast(PTy)) {
+ if (PtrTy->getAddressSpace() !=
+ ArgValue->getType()->getPointerAddressSpace()) {
arsenm wrote:
> Anastasia wrote:
> >
Author: erichkeane
Date: Thu Jul 5 08:52:58 2018
New Revision: 336364
URL: http://llvm.org/viewvc/llvm-project?rev=336364&view=rev
Log:
Fix __builtin_*_overflow when out-param isn't constexpr
As brought up on cfe-commits[1], r334650 causes the dependency of the
out parameter to the __builtin_*_o
Fixed in R336364. Thank you very much for the heads up!
From: Evgenii Stepanov [mailto:eugeni.stepa...@gmail.com]
Sent: Tuesday, July 3, 2018 12:59 PM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r334650 - Implement constexpr __builtin_*_overflow
Hi,
with this change, the following compiles
Author: ldionne
Date: Thu Jul 5 09:16:03 2018
New Revision: 336368
URL: http://llvm.org/viewvc/llvm-project?rev=336368&view=rev
Log:
[NFC] Add to the synopsis of
Summary:
It is part of the synopsis in the Standard and does include it,
but it was left out of the synopsis comment.
Reviewers: E
Author: ldionne
Date: Thu Jul 5 09:49:38 2018
New Revision: 336369
URL: http://llvm.org/viewvc/llvm-project?rev=336369&view=rev
Log:
[libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY
Summary:
We never actually mean to always inline a function -- all the uses of
the macr
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX336369: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by
_LIBCPP_INLINE_VISIBILITY (authored by ldionne, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://revie
mikerice added inline comments.
Comment at: include/clang/Driver/CC1Options.td:604
+ HelpText<"When creating a pch stop at this file. When using a pch start "
+ "after this file.">;
def fno_pch_timestamp : Flag<["-"], "fno-pch-timestamp">,
hans wrote
bjope added a comment.
In https://reviews.llvm.org/D48721#1153138, @deepak2427 wrote:
> I have updated the test to not run the optimizer. The test I had added
> previously for checking if the unroller is respecting the pragma is useful I
> think. Not sure where that can be added though.
> I g
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336379: [clang-cl, PCH] Implement support for MS-style PCH
through headers (authored by erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46652?vs=153067&id=154265#toc
Repo
Author: erichkeane
Date: Thu Jul 5 10:22:13 2018
New Revision: 336379
URL: http://llvm.org/viewvc/llvm-project?rev=336379&view=rev
Log:
[clang-cl, PCH] Implement support for MS-style PCH through headers
Implement support for MS-style PCH through headers.
This enables support for /Yc and /Yu whe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336379: [clang-cl, PCH] Implement support for MS-style PCH
through headers (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
Author: erichkeane
Date: Thu Jul 5 10:23:15 2018
New Revision: 336380
URL: http://llvm.org/viewvc/llvm-project?rev=336380&view=rev
Log:
Add PCH tests for R336379
I seemingly forgot the tests for this commit, added here.
Added:
cfe/trunk/test/PCH/Inputs/pch-through-use0.cpp (with props)
tks2103 created this revision.
tks2103 added reviewers: GorNishanov, modocache.
Currently clang looks up the coroutine_traits ClassTemplateDecl
everytime it looks up the promise type. This is unnecessary
as coroutine_traits doesn't change between promise type lookups.
This diff caches the corouti
Author: marshall
Date: Thu Jul 5 10:44:12 2018
New Revision: 336381
URL: http://llvm.org/viewvc/llvm-project?rev=336381&view=rev
Log:
Fix HTML blunder
Modified:
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/trunk/www/cxx2a_status.html
URL:
http://llvm.org/viewvc/llvm-project/libcxx/t
vstefanovic created this revision.
vstefanovic added a reviewer: atanasyan.
Herald added subscribers: cfe-commits, arichardson, sdardis.
'-mvirt'/'-mno-virt' enables/disables Virtualization ASE.
'-mginv'/'-mno-ginv' enables/disables GINV (Global Invalidate) ASE.
Repository:
rC Clang
https://r
jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.
LGTM after a few questions.
Comment at: include/clang/Analysis/Analyses/FormatString.h:265
+ enum class TypeKind { Unspecified, SizeT, PtrdiffT };
+ TypeKind TK = TypeKind::Unspe
aaron.ballman added a comment.
> This is acceptable because Darwin guarantees that, despite the watchOS ABI
> differences, sizeof(ptrdiff_t) == sizeof(NS[U]Integer)
Can you describe these ABI differences please? Also, does Darwin guarantee that
alignof(ptrdiff_t) == alignof(NS[U]Integer)?
Rep
modocache resigned from this revision.
modocache added a comment.
This LGTM but I'll just wait for @GorNishanov to accept the patch, just in case
I'm missing something. I'd be happy to commit this for you once Gor accepts! :)
Repository:
rC Clang
https://reviews.llvm.org/D48981
__
davide reopened this revision.
davide added a comment.
This revision is now accepted and ready to land.
The lldb bot started failing very recently and the blamelist hints at this
change.
http://green.lab.llvm.org/green/job/lldb-cmake//
Can you please take a look?
For your convenience, this
dexonsmith added a comment.
In https://reviews.llvm.org/D48892#1153473, @davide wrote:
> The lldb bot started failing very recently and the blamelist hints at this
> change.
>
> http://green.lab.llvm.org/green/job/lldb-cmake//
>
> Can you please take a look?
>
> For your convenience, this is
Author: ldionne
Date: Thu Jul 5 11:41:50 2018
New Revision: 336382
URL: http://llvm.org/viewvc/llvm-project?rev=336382&view=rev
Log:
Revert "[libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by
_LIBCPP_INLINE_VISIBILITY"
This reverts commit r336369. The commit had two problems:
1. __pbump was mark
ldionne added a comment.
I reverted this commit. Sorry for the blunder. I'll take a look at why LLDB's
tests are doing this.
Repository:
rCXX libc++
https://reviews.llvm.org/D48892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
On Thu, Jul 5, 2018 at 11:46 AM Louis Dionne via Phabricator
wrote:
>
> ldionne added a comment.
>
> I reverted this commit. Sorry for the blunder. I'll take a look at why LLDB's
> tests are doing this.
>
No need to revert this immediately. I can probably take a look and fix
what the lldb tests
On Thu, Jul 5, 2018 at 11:37 AM Duncan P. N. Exon Smith via
Phabricator wrote:
>
> dexonsmith added a comment.
>
> In https://reviews.llvm.org/D48892#1153473, @davide wrote:
>
> > The lldb bot started failing very recently and the blamelist hints at this
> > change.
> >
> > http://green.lab.llvm.
On Thu, Jul 5, 2018 at 11:49 AM Davide Italiano via llvm-commits
wrote:
>
> On Thu, Jul 5, 2018 at 11:37 AM Duncan P. N. Exon Smith via
> Phabricator wrote:
> >
> > dexonsmith added a comment.
> >
> > In https://reviews.llvm.org/D48892#1153473, @davide wrote:
> >
> > > The lldb bot started failin
malaperle updated this revision to Diff 154280.
malaperle marked 7 inline comments as done.
malaperle added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47846
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
malaperle added a comment.
Thanks a lot for the great comments (as always)!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
ioeric added a comment.
Thanks for the refactoring and the comments! They made it a lot easier to
understand the changes.
I'm focusing on how the changes would fit into the `ToolExecutor` framework in
the review and will leave tool-specific logics to another reviewer who I assume
would know th
starsid created this revision.
starsid added a reviewer: compnerd.
Herald added a subscriber: cfe-commits.
Depends on https://reviews.llvm.org/D48988.
Repository:
rC Clang
https://reviews.llvm.org/D48989
Files:
lib/Driver/ToolChains/Clang.cpp
tools/driver/cc1as_main.cpp
Index: tools/dr
starsid updated this revision to Diff 154285.
starsid added a comment.
include generator input file for flag property change
Repository:
rC Clang
https://reviews.llvm.org/D48989
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Clang.cpp
tools/driver/cc1as_main.cpp
Index:
Author: malaperle
Date: Thu Jul 5 12:35:01 2018
New Revision: 336386
URL: http://llvm.org/viewvc/llvm-project?rev=336386&view=rev
Log:
[clangd] Implementation of textDocument/documentSymbol
Summary:
An AST-based approach is used to retrieve the document symbols rather than an
in-memory index que
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336386: [clangd] Implementation of
textDocument/documentSymbol (authored by malaperle, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47846
File
arphaman marked an inline comment as done.
arphaman added a comment.
In https://reviews.llvm.org/D48852#1153415, @aaron.ballman wrote:
> > This is acceptable because Darwin guarantees that, despite the watchOS ABI
> > differences, sizeof(ptrdiff_t) == sizeof(NS[U]Integer)
>
> Can you describe th
arphaman updated this revision to Diff 154294.
arphaman marked an inline comment as done.
arphaman added a comment.
Address review comments.
https://reviews.llvm.org/D48852
Files:
include/clang/Analysis/Analyses/FormatString.h
lib/Analysis/PrintfFormatString.cpp
lib/Sema/SemaChecking.cpp
aaron.ballman added a comment.
In https://reviews.llvm.org/D48852#1153598, @arphaman wrote:
> In https://reviews.llvm.org/D48852#1153415, @aaron.ballman wrote:
>
> > > This is acceptable because Darwin guarantees that, despite the watchOS
> > > ABI differences, sizeof(ptrdiff_t) == sizeof(NS[U]I
apazos added inline comments.
Comment at: test/Sema/riscv-interrupt-attr.c:23
+ // expected-note
{{repeated RISC-V 'interrupt' attribute is here}}
+__attribute__((interrupt("user"))) void foo8() {}
+__attribute__((interrupt("s
Author: ctopper
Date: Thu Jul 5 13:38:31 2018
New Revision: 336388
URL: http://llvm.org/viewvc/llvm-project?rev=336388&view=rev
Log:
[X86] Use shufflevector instead of a select with a constant mask for
fmaddsub/fmsubadd IR emission.
Shufflevector is easier to generate and matches what the backe
aaron.ballman added inline comments.
Comment at: test/Sema/riscv-interrupt-attr.c:23
+ // expected-note
{{repeated RISC-V 'interrupt' attribute is here}}
+__attribute__((interrupt("user"))) void foo8() {}
+__attribute__((inter
acomminos updated this revision to Diff 154307.
acomminos added a comment.
Handle initialization expressions and dereferenced `this` in lambda captures.
An alternative to handling various kinds of explicit captures would be
propagating the source range for each lambda capture from the parser to
malaperle created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
Signed-off-by: Marc-Andre Laperle
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48996
Files:
docs/clangd.rst
Index: docs/clangd.rst
===
acomminos updated this revision to Diff 154313.
acomminos added a comment.
Add additional tests to ensure that explicit capture ranges are predicted
correctly.
Repository:
rC Clang
https://reviews.llvm.org/D48845
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaLambda.cpp
test/FixIt/fixi
apazos added inline comments.
Comment at: test/Sema/riscv-interrupt-attr.c:23
+ // expected-note
{{repeated RISC-V 'interrupt' attribute is here}}
+__attribute__((interrupt("user"))) void foo8() {}
+__attribute__((interrupt("s
alexshap added inline comments.
Comment at: lib/Sema/SemaLambda.cpp:1548
+ // Find the end of the explicit capture for use in fixits.
+ SourceLocation EndLoc;
+ if (From.isThisCapture() && From.isCopyCapture()) {
maybe these lines 1548 -1559 can be
alexshap added inline comments.
Comment at: lib/Sema/SemaLambda.cpp:1548
+ // Find the end of the explicit capture for use in fixits.
+ SourceLocation EndLoc;
+ if (From.isThisCapture() && From.isCopyCapture()) {
alexshap wrote:
> maybe these lines
simark marked 6 inline comments as done.
simark added inline comments.
Comment at: lib/Basic/VirtualFileSystem.cpp:516
+ explicit InMemoryFileAdaptor(InMemoryFile &Node, std::string RequestedName)
+ : Node(Node), RequestedName (std::move (RequestedName))
+ {}
1 - 100 of 121 matches
Mail list logo
