sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Very nice! ================ Comment at: clangd/ClangdUnit.cpp:327 CI.getFrontendOpts().SkipFunctionBodies = true; + // We don't want to write comments into PCH. They are racy and slow to read + // back. We rely on dynamic index for the comments instead. ---------------- nit: these are comment *locations* right? (Relevant because if we were writing the actual comments, we may actually want this on!) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48943 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
