sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

This seems like it might be a nontrivial performance hit (it's going to result 
in `stat`ing all these files, right?).
Agreed it's important for correctness, it's possible someone wants the 
performance/correctness tradeoff though.



================
Comment at: lib/Frontend/PrecompiledPreamble.cpp:71
+ // but there is no way to distinguish between those and the ones that can be
+ // spuriously added by '-isystem' (e.g. to avoid errors from those headers).
+ bool needSystemDependencies() override { return true; }
----------------
avoid errors --> suppress warnings?


Repository:
  rC Clang

https://reviews.llvm.org/D48946



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to