klimek accepted this revision.
klimek added inline comments.
Comment at: clangd/XRefs.cpp:559
+ //- auto& i = 1;
+ bool VisitDeclaratorDecl(DeclaratorDecl *D) {
+if (!D->getTypeSourceInfo() ||
klimek wrote:
> malaperle wrote:
> > klimek wrote:
> > > sammcca
whisperity added a comment.
Pinging this as the talk has stalled.
https://reviews.llvm.org/D45094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: lib/Basic/VirtualFileSystem.cpp:328
void OverlayFileSystem::pushOverlay(IntrusiveRefCntPtr FS) {
+ // FIXME: OverlayFS containing another one in its stack could be flattened.
FSList.push_back(FS);
ilya-biryukov wrote
klimek added a comment.
In https://reviews.llvm.org/D28462#1148732, @enyquist wrote:
> @klimek having gotten that out of the way, I do occasionally drink too much
> and have sudden urges to re-implement things from scratch. Close it if you
> need to, since I can't commit to anything, but it
chill added a comment.
Ping?
https://reviews.llvm.org/D46013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
This provides more structured information that embedders can use for rendering.
ClangdLSPServer continues to call render(), so NFC.
The patch is:
- trivial
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm.
Again, we might still want to measure the performance impact on files with
potentially large #include tree ;)
Comment at: clangd/FileDistance.cpp:26
+// /bar/foo
jolesiak marked 6 inline comments as done.
jolesiak added inline comments.
Comment at: lib/Format/FormatToken.h:247-248
+ /// If this is the first ObjC selector name in an ObjC method
+ /// definition or call, this contains the number of parts that whole selector
+ /// consist
jolesiak marked 6 inline comments as done.
jolesiak added a comment.
In https://reviews.llvm.org/D48716#1146796, @benhamilton wrote:
> > Count selector parts also for method declarations.
>
> What bug does this fix? Can you add a test which breaks before this change
> and is fixed by this change
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
jolesiak updated this revision to Diff 153689.
jolesiak added a comment.
Fix grammar mistakes.
Repository:
rC Clang
https://reviews.llvm.org/D48716
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
Index: lib/Format/TokenAnnotator.cpp
===
jolesiak added a comment.
In https://reviews.llvm.org/D48718#1146805, @benhamilton wrote:
> Can you add a test, please?
The test could look like:
a = [a aa:aa
aa:aa];
with appropriate column limit.
Right now, however, this would be formatted:
a =
[a aa:aa aa:aa
Author: sammccall
Date: Mon Jul 2 04:13:16 2018
New Revision: 336094
URL: http://llvm.org/viewvc/llvm-project?rev=336094&view=rev
Log:
[clangd] ClangdServer::codeComplete return CodeCompleteResult, not LSP struct.
Summary:
This provides more structured information that embedders can use for rend
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336094: [clangd] ClangdServer::codeComplete return
CodeCompleteResult, not LSP struct. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revie
WimLeflere created this revision.
WimLeflere added reviewers: krasimir, Typz.
Herald added a subscriber: cfe-commits.
Extend the Clang-Format IncludeCategories documentation by adding a link to the
supported regular expression standard (POSIX).
And extenting the example with a system header regex
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm with nit
Comment at: clang/lib/AST/MicrosoftMangle.cpp:3262
+ // Enforce our 32 bytes max, except wchar_t which gets 32 chars instead.
+ unsigned MaxBytesToWrite = SL->isW
Author: nico
Date: Mon Jul 2 05:31:20 2018
New Revision: 336097
URL: http://llvm.org/viewvc/llvm-project?rev=336097&view=rev
Log:
[ms] Fix mangling of char16_t and char32_t to be compatible with MSVC.
MSVC limits char16_t and char32_t string literal names to 32 bytes of character
data, not to 32
thakis added a comment.
Thanks, landed with nit addressed in r336097.
https://reviews.llvm.org/D48781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
baloghadamsoftware updated this revision to Diff 153698.
baloghadamsoftware added a comment.
Updated according to the comments and assertions added to fail the tests
without the fix.
https://reviews.llvm.org/D48764
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
Index: lib/StaticAna
baloghadamsoftware added a comment.
Hmm, then the only solution that comes to my mind is to link iterator positions
to container data instead of the container regions. I also have to store a link
to the class definition of the container in the container data for the
invalidation rules. Containe
kosarev created this revision.
kosarev added reviewers: SjoerdMeijer, jgreenhalgh, rengolin.
kosarev added a project: clang.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
This patch adds support for vrndi_f32() and vrndiq_f32() intrinsics in AArch32
mode and for
jolesiak updated this revision to Diff 153705.
jolesiak added a comment.
Improve condition.
Repository:
rC Clang
https://reviews.llvm.org/D48720
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestObjC.cpp
Inde
jolesiak updated this revision to Diff 153706.
jolesiak added a comment.
Rebase.
Repository:
rC Clang
https://reviews.llvm.org/D48720
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
==
jolesiak marked an inline comment as done.
jolesiak added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1411
+ // line).
+ if (Current.MatchingParen && Current.MatchingParen->Previous) {
+const FormatToken &CurrentScopeOpener = *Current.MatchingParen->Pre
krytarowski added a comment.
ping^3
Repository:
rL LLVM
https://reviews.llvm.org/D47814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: balazske
Date: Mon Jul 2 07:14:07 2018
New Revision: 336108
URL: http://llvm.org/viewvc/llvm-project?rev=336108&view=rev
Log:
Test commit access
Modified:
cfe/trunk/unittests/AST/ASTImporterTest.cpp
Modified: cfe/trunk/unittests/AST/ASTImporterTest.cpp
URL:
http://llvm.org/viewvc/l
Hi Richard,
This introduced test failures on Windows, but for some reason only in
32-bit builds: https://bugs.llvm.org/show_bug.cgi?id=38015
I don't know what's going on yet, just finished the bisection. Maybe
it reproduces in 32-bit linux builds too?
- Hans
On Fri, Jun 29, 2018 at 11:58 PM, R
ABataev added a comment.
I don't think that this is the intended behavior of the `#pragma clang loop`.
it is better to ask the author of this pragma is this correct or not.
Repository:
rC Clang
https://reviews.llvm.org/D48808
___
cfe-commits mai
hfinkel added a comment.
In https://reviews.llvm.org/D48808#1149534, @ABataev wrote:
> I don't think that this is the intended behavior of the `#pragma clang loop`.
> it is better to ask the author of this pragma is this correct or not.
It is the intended behavior that the memory accesses are
Meinersbur added a comment.
In https://reviews.llvm.org/D48808#1149534, @ABataev wrote:
> I don't think that this is the intended behavior of the `#pragma clang loop`.
> it is better to ask the author of this pragma is this correct or not.
I understand it as the intended behavior of the `assum
cryptoad created this revision.
cryptoad added reviewers: eugenis, alekseyshl.
Scudo works on PPC64 as is, so mark the architecture as supported for it. This
will also require a change to config-ix.cmake on the compiler-rt side.
Update the tests accordingly.
Repository:
rC Clang
https://revi
malaperle updated this revision to Diff 153737.
malaperle added a comment.
Tweak comment with FIXME.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48159
Files:
clangd/XRefs.cpp
unittests/clangd/TestTU.cpp
unittests/clangd/TestTU.h
unittests/clangd/XRefsTests.cpp
Index
malaperle added inline comments.
Comment at: clangd/XRefs.cpp:559
+ //- auto& i = 1;
+ bool VisitDeclaratorDecl(DeclaratorDecl *D) {
+if (!D->getTypeSourceInfo() ||
klimek wrote:
> klimek wrote:
> > malaperle wrote:
> > > klimek wrote:
> > > > sammccall wro
Author: malaperle
Date: Mon Jul 2 09:28:34 2018
New Revision: 336119
URL: http://llvm.org/viewvc/llvm-project?rev=336119&view=rev
Log:
[clangd] Implement hover for "auto" and "decltype"
Summary:
This allows hovering on keywords that refer to deduced types.
This should cover most useful cases. No
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336119: [clangd] Implement hover for "auto" and
"decltype" (authored by malaperle, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48159
Files:
malaperle updated this revision to Diff 153742.
malaperle added a comment.
Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47846
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/FindSymbols.cpp
c
NoQ added a comment.
That'd be a hell for you because when the container is updated you won't be
able to easily find iterators all that iterate over it. Normally what you want
to do is keep mapping iterators to container regions, and when the region dies,
"freeze" the data (make sure it can no
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D48716#1149293, @jolesiak wrote:
> General comment to changes https://reviews.llvm.org/D48716,
> https://reviews.llvm.org/D48718, https://reviews.llvm.org
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
> Sorry for the confusion. If you prefer me to add this test and modify in
> later commit I'll do it.
I see. Just mentioning what you did in the diff description is probably OK.
Re
jmorse added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D48072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: george.karpenkov
Date: Mon Jul 2 10:10:40 2018
New Revision: 336124
URL: http://llvm.org/viewvc/llvm-project?rev=336124&view=rev
Log:
[analyzer] [tests] Pass clang executable path to prefix-less executor scripts.
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
Modified: cfe/trunk/
Hi Michael, Hal,
Sorry it has been a while since I looked at this. My memory is a little
fuzzy. The intent of 'assume_safety' is to tell LAA to skip dependency
checking on loads and stores so the vectorizer doesn't stop as soon as it
sees both in a loop. At the time 'assume_safety' was implemented
Meinersbur added a comment.
In https://reviews.llvm.org/D48808#1149549, @hfinkel wrote:
> In https://reviews.llvm.org/D48808#1149534, @ABataev wrote:
>
> >
>
>
> Michael, can you please add a test with two inner loops, one where more than
> one is annotated, and one where only the outer loop is
a.sidorin added a comment.
Hello Gabor,
I have a strong feeling of duplication with attribute and flags merging move in
https://reviews.llvm.org/D47632. Maybe it is better to be resolved in that
review by using the same code for attr/flag merging for both newly-created and
mapped decls?
Repo
a.sidorin added a comment.
Whoops, sorry Balázs. Didn't look at the review author :(
Repository:
rC Clang
https://reviews.llvm.org/D48722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
hfinkel added a comment.
In https://reviews.llvm.org/D48808#1149828, @Meinersbur wrote:
> In https://reviews.llvm.org/D48808#1149549, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D48808#1149534, @ABataev wrote:
> >
> > >
> >
> >
> > Michael, can you please add a test with two inner loops, on
On 07/02/2018 12:27 PM, Tyler Nowicki wrote:
> Hi Michael, Hal,
>
> Sorry it has been a while since I looked at this. My memory is a
> little fuzzy. The intent of 'assume_safety' is to tell LAA to
> skip dependency checking on loads and stores so the vectorizer doesn't
> stop as soon as it sees bo
Meinersbur added a comment.
In https://reviews.llvm.org/D48808#1149845, @hfinkel wrote:
> We specifically defined the metadata to support nested loops. The LangRef
> says, "The llvm.mem.parallel_loop_access metadata refers to a loop
> identifier, or metadata containing a list of loop identifier
hfinkel added a comment.
In https://reviews.llvm.org/D48808#1149862, @Meinersbur wrote:
> In https://reviews.llvm.org/D48808#1149845, @hfinkel wrote:
>
> > We specifically defined the metadata to support nested loops. The LangRef
> > says, "The llvm.mem.parallel_loop_access metadata refers to a
Author: marshall
Date: Mon Jul 2 11:41:15 2018
New Revision: 336132
URL: http://llvm.org/viewvc/llvm-project?rev=336132&view=rev
Log:
Implement LWG 2946, 3075 and 3076. Reviewed as https://reviews.llvm.org/D48616
Added:
libcxx/trunk/test/std/strings/basic.string/string.cons/string_view_dedu
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1647
+ }
+}
+
Prazek wrote:
> rsmith wrote:
> > Prazek wrote:
> > > rjmccall wrote:
> > > > Prazek wrote:
> > > > > rjmccall wrote:
> > > > > > Incidentally, how do you protec
craig.topper added inline comments.
Comment at: test/Sema/attr-min-vector-width.c:8
+
+void f3(void) __attribute__((__min_vector_width__(128),
__min_vector_width__(256))); /* expected-warning {{attribute
'__min_vector_width__' is already applied with different parameters}} */
-
craig.topper updated this revision to Diff 153763.
craig.topper added a comment.
-Rebase the intrinsic headers and builtins file
-Add documentation for the attribute. Open to feedback on improvements here
-Add tests for wrong number of arguments to the attribute.
https://reviews.llvm.org/D48617
craig.topper added inline comments.
Comment at: include/clang/Basic/Attr.td:1949
+ let Args = [UnsignedArgument<"VectorWidth">];
+ let Subjects = SubjectList<[Function], ErrorDiag>;
+ let Documentation = [Undocumented];
aaron.ballman wrote:
> Should this apply
aaron.ballman added inline comments.
Comment at: test/Sema/attr-min-vector-width.c:8
+
+void f3(void) __attribute__((__min_vector_width__(128),
__min_vector_width__(256))); /* expected-warning {{attribute
'__min_vector_width__' is already applied with different parameters}} */
vsapsai added a comment.
In https://reviews.llvm.org/D48342#1148751, @mclow.lists wrote:
> I want to point out that this code (not -necessarily- this patch, but where
> it lives) needs to be rewritten.
>
> There is no prohibition on users specializing `allocator_traits` for their
> allocators,
vsapsai planned changes to this revision.
vsapsai added inline comments.
Comment at: libcxx/include/memory:1479
+struct __has_construct_missing
+: false_type
+{
vsapsai wrote:
> vsapsai wrote:
> > erik.pilkington wrote:
> > > vsapsai wrote:
> > > > erik.pilki
Author: prazek
Date: Mon Jul 2 12:21:36 2018
New Revision: 336137
URL: http://llvm.org/viewvc/llvm-project?rev=336137&view=rev
Log:
[CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers
Summary:
Emmiting new intrinsic that strips invariant.groups to make
devirtulization sound, as
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336137: [CodeGenCXX] Emit strip.invariant.group with
-fstrict-vtable-pointers (authored by Prazek, committed by ).
Change
Meinersbur updated this revision to Diff 153769.
Meinersbur added a comment.
- Allow multiple parallel annotations
Repository:
rC Clang
https://reviews.llvm.org/D48808
Files:
lib/CodeGen/CGLoopInfo.cpp
test/CodeGenCXX/pragma-loop-safety-nested.cpp
test/CodeGenCXX/pragma-loop-safety-out
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1949
+ let Args = [UnsignedArgument<"VectorWidth">];
+ let Subjects = SubjectList<[Function], ErrorDiag>;
+ let Documentation = [Undocumented];
craig.topper wrote:
> aaron.ballman wro
Quuxplusone added inline comments.
Comment at: libcxx/include/memory:1479
+struct __has_construct_missing
+: false_type
+{
vsapsai wrote:
> vsapsai wrote:
> > vsapsai wrote:
> > > erik.pilkington wrote:
> > > > vsapsai wrote:
> > > > > erik.pilkington wrote:
j10kay updated this revision to Diff 153773.
j10kay marked 3 inline comments as done.
j10kay added a comment.
Implemented the code review changes
Repository:
rL LLVM
https://reviews.llvm.org/D48601
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang/test/Driv
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX336141: [Win32] Overload ==, != for locale_t and long long
(authored by pirama, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48749?vs=153411&id=153778#toc
Repository:
rCXX lib
Author: pirama
Date: Mon Jul 2 13:11:15 2018
New Revision: 336141
URL: http://llvm.org/viewvc/llvm-project?rev=336141&view=rev
Log:
[Win32] Overload ==, != for locale_t and long long
Summary:
_is_chartype_l (needed for isxdigit_l) in MinGW compares locale_t and NULL.
NULL is 'long long' for 64-b
chandlerc added a comment.
FWIW, I looked at an early version of this patch and am generally happy with
the target-specific / IR-specific behavior aspects of it. Totally leaving the
detailed review of the attribute stuff to you Aaron, as you're already doing an
amazing job there. Minor clarific
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1949
+ let Args = [UnsignedArgument<"VectorWidth">];
+ let Subjects = SubjectList<[Function], ErrorDiag>;
+ let Documentation = [Undocumented];
chandlerc wrote:
> aaron.ballman wrote:
craig.topper updated this revision to Diff 153786.
craig.topper marked 4 inline comments as done.
craig.topper added a comment.
-Added a negative test
-Hopefully fixed all the grammatical/spelling errors.
-Attempted to clarify some more about prefer-vector-width and builtins.
https://reviews.llv
juliehockett updated this revision to Diff 153787.
juliehockett marked 12 inline comments as done.
juliehockett added a comment.
Refactoring second reduce code into the library, and adding bitcode
reader/writer support
https://reviews.llvm.org/D48341
Files:
clang-tools-extra/clang-doc/Bitcod
anniecherk updated this revision to Diff 153790.
anniecherk added a comment.
Updated the tests to more accurately check that the files that we expect to not
be generated by clang-doc with the public flag are in fact not being created.
The tests now run clang-doc over the test files with and with
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:249
+if (EnclosingScope.get().RefType == doc::InfoType::IT_function)
+ continue;
+
ioeric wrote:
> Are symbols declared in functions indexed by the tool
NoQ added inline comments.
Comment at: include/clang/Analysis/ConstructionContext.h:90
assert(Other);
return (Trigger == Other->Trigger);
}
Uhm. Will fix.
Repository:
rC Clang
https://reviews.llvm.org/D48681
__
steven_wu created this revision.
steven_wu added reviewers: arphaman, dexonsmith.
When clang required to infer target os version from --target option and
the os version is not specified in targets, check the host triple. If the
host and target are both macOS, use host triple to infer target os
ver
steven_wu added a comment.
Unfortunately, I wasn't able to write a test for this because the host triple
in the configuration can either be x86_64-apple-darwin* or
x86_64-apple-macosx*, but the one used passed by driver is always macosx one. I
can't reliably compare those two.
Repository:
r
juliehockett added a reviewer: ioeric.
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/ClangDoc.h:27
+struct ClangDocContext {
+tooling::ExecutionContext *ECtx;
Can we put this in `Representation.h`? Here, you have a potential ci
arphaman created this revision.
arphaman added a reviewer: jfb.
Herald added a subscriber: dexonsmith.
The '%tu'/'%td' as formatting specifiers have been used to print out the
NSInteger/NSUInteger values for a long time. Typically their ABI matches (i.e.
ptrdiff_t = NSInteger), but that's not th
Meinersbur updated this revision to Diff 153803.
Meinersbur added a comment.
- Adapt test file message.
Repository:
rC Clang
https://reviews.llvm.org/D48808
Files:
lib/CodeGen/CGLoopInfo.cpp
test/CodeGenCXX/pragma-loop-safety-nested.cpp
test/CodeGenCXX/pragma-loop-safety-outer.cpp
In
ahatanak updated this revision to Diff 153779.
ahatanak added a comment.
Herald added a subscriber: dexonsmith.
Implement the new rule defined here: http://wg21.link/p0968r0#2227. Produce a
diagnostic if a class is initialized with aggregate initialization and one of
its element's destructor is
shuaiwang created this revision.
Herald added a reviewer: george.karpenkov.
Herald added subscribers: cfe-commits, a.sidorin.
This gives better coverage to the check as ExprMutationAnalyzer is more
accurate comparing to isOnlyUsedAsConst.
Majority of wins come from const usage of member field, e.
steven_wu updated this revision to Diff 153814.
steven_wu added a comment.
Update patch. Use a better API.
Repository:
rC Clang
https://reviews.llvm.org/D48849
Files:
lib/Driver/ToolChains/Darwin.cpp
test/Driver/clang-g-opts.c
Index: test/Driver/clang-g-opts.c
=
Wawha updated this revision to Diff 153813.
Wawha added a comment.
Here the third version to manage break with lambda in Allman.
I implement the modification propose by klimek.
If a lambda is detected, the BlockParameterCount and ParameterCount are
increment one more time in order to avoid extra
steven_wu updated this revision to Diff 153816.
steven_wu added a comment.
Rebase the commit correctly
Repository:
rC Clang
https://reviews.llvm.org/D48849
Files:
lib/Driver/ToolChains/Darwin.cpp
test/Driver/clang-g-opts.c
Index: test/Driver/clang-g-opts.c
=
arphaman added a comment.
Hmm, the driver should not call `inferDeploymentTargetFromArch` when `-target`
is passed. Or am I missing something?
Repository:
rC Clang
https://reviews.llvm.org/D48849
___
cfe-commits mailing list
cfe-commits@lists.ll
steven_wu added a comment.
In https://reviews.llvm.org/D48849#1150246, @arphaman wrote:
> Hmm, the driver should not call `inferDeploymentTargetFromArch` when
> `-target` is passed. Or am I missing something?
Good call. This only handles the *-apple-darwin case. Maybe the same should
happen t
leonardchan updated this revision to Diff 153821.
leonardchan marked 10 inline comments as done.
leonardchan edited the summary of this revision.
leonardchan added a comment.
- Added tests
- Moved all conversion logic into `convert`
- Saturation is checked by checking the bits above the sign bit i
mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 336132.
https://reviews.llvm.org/D48616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
leonardchan added inline comments.
Comment at: include/clang/Basic/FixedPoint.h:31
+ SatNoPadding,
+};
+
ebevhan wrote:
> rjmccall wrote:
> > I figured you'd want this to be a struct which include the scale, width,
> > signed-ness, and saturating-ness; and then
steven_wu updated this revision to Diff 153822.
steven_wu added a comment.
handle *-apple-macosx target option
Repository:
rC Clang
https://reviews.llvm.org/D48849
Files:
lib/Driver/ToolChains/Darwin.cpp
test/Driver/clang-g-opts.c
test/Driver/target-triple-deployment.c
Index: test/Dr
anniecherk updated this revision to Diff 153825.
anniecherk marked 4 inline comments as done.
anniecherk added a comment.
Addressed Julie's comments
https://reviews.llvm.org/D48395
Files:
clang-tools-extra/clang-doc/ClangDoc.cpp
clang-tools-extra/clang-doc/ClangDoc.h
clang-tools-extra/cla
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp:68
: IILockGuard(nullptr), IIUniqueLock(nullptr),
- LockFn("lock"), UnlockFn("unlock"), SleepFn("sleep"), GetcFn("getc"),
- FgetsFn("fgets"), ReadFn("read"), RecvFn
Author: rsmith
Date: Mon Jul 2 16:25:22 2018
New Revision: 336153
URL: http://llvm.org/viewvc/llvm-project?rev=336153&view=rev
Log:
Per C++ [over.match.copy]p1, direct-initialization of a reference can
only invoke converting constructors of the reference's underlying type.
Modified:
cfe/trun
NoQ added a comment.
Uhm, so we had an alpha checker enabled all along? Thanks for patching this up!
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:308
// These checks are either enabled by the CString out-of-bounds checker
-// explicitly or the "basic" CSt
erik.pilkington added a comment.
In https://reviews.llvm.org/D48322#1148424, @rsmith wrote:
> Hmm, so this will mean that we can have internal linkage declarations marked
> `Used` for which there is no definition, and we need to not warn on that.
>
> I think it might be better to avoid marking t
arphaman added a comment.
Nit: Could you please try to extract the shared code into a function, e.g.
Optional overrideMacOSTripleDefaultVersion(const llvm::Triple
&Triple, ... OSTy, ... TheDriver) {
if (Triple.getOSMajorVersion())
return None;
llvm::Triple SystemTriple(llvm
Hello everyone,
Below are some buildbot numbers for the week of 6/17/2018 - 6/23/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
Hello everyone,
Below are some buildbot numbers for the last week of 6/24/2018 - 6/30/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
bjope added a comment.
I tried running
/clang -cc1 -O3 -funroll-loops -S -emit-llvm pragma-do-while-unroll.cpp -o -
-mllvm -print-after-all
and I get this
...
!2 = distinct !{!2, !3}
!3 = !{!"llvm.loop.unroll.count", i32 3}
!4 = !{!5, !5, i64 0}
!5 = !{!"int", !6, i64 0}
!6 = !{!
Author: epilk
Date: Mon Jul 2 17:23:18 2018
New Revision: 336157
URL: http://llvm.org/viewvc/llvm-project?rev=336157&view=rev
Log:
[demangler] Fix a MSVC alignment warning.
This should fix llvm.org/PR37944
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modified: libcxxabi/trunk/src/cxa_dem
Author: epilk
Date: Mon Jul 2 17:48:27 2018
New Revision: 336159
URL: http://llvm.org/viewvc/llvm-project?rev=336159&view=rev
Log:
Some buildbots were choking on std::max_align_t, try using the global alias.
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modified: libcxxabi/trunk/src/cxa_de
steven_wu updated this revision to Diff 153836.
steven_wu added a comment.
It is easier and cleaner if I just fold everything into getOSVersion.
Repository:
rC Clang
https://reviews.llvm.org/D48849
Files:
lib/Driver/ToolChains/Darwin.cpp
test/Driver/clang-g-opts.c
test/Driver/target-tr
1 - 100 of 115 matches
Mail list logo
