aaron.ballman added inline comments.
================
Comment at: test/Sema/attr-min-vector-width.c:8
+
+void f3(void) __attribute__((__min_vector_width__(128),
__min_vector_width__(256))); /* expected-warning {{attribute
'__min_vector_width__' is already applied with different parameters}} */
----------------
craig.topper wrote:
> aaron.ballman wrote:
> > Also missing tests for applying the attribute to the wrong subject and with
> > the incorrect number of arguments.
> How many possible subjects are there? And how many wrong subjects do you want
> me to test?
Lots of possible subjects, but testing just one will suffice as a failure test
case (you already covered the successful subject test cases). We've had issues
in the past where lacking this test coverage caused problems that cost a lot of
time to track down, so it's a checklist test item for me.
https://reviews.llvm.org/D48617
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
