hfinkel added a comment.

In https://reviews.llvm.org/D48808#1149534, @ABataev wrote:

> I don't think that this is the intended behavior of the `#pragma clang loop`. 
> it is better to ask the author of this pragma is this correct or not.


It is the intended behavior that the memory accesses are independent with 
respect to the outer (annotated) loop (even if those accesses are within an 
inner loop). They're not independent with respect to the inner loop unless that 
loop is also annotated. Thus, this looks correct.

Michael, can you please add a test with two inner loops, one where more than 
one is annotated, and one where only the outer loop is annotated? It's not 
clear to me that I->setMetadata will do the right thing here in the former case.


Repository:
  rC Clang

https://reviews.llvm.org/D48808



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to