ebevhan added inline comments.
Comment at: include/clang/AST/ASTContext.h:1954
+ llvm::APInt getFixedPointMin(QualType Ty) const;
+ llvm::APInt getFixedPointOne(QualType Ty) const;
rjmccall wrote:
> ebevhan wrote:
> > rjmccall wrote:
> > > Are these opaque bi
klimek added a comment.
In https://reviews.llvm.org/D44609#1143895, @Wawha wrote:
> Hello,
>
> after my last modification (require by previous comment), I do not see any
> feedback or validation for this patch.
> Is their something special to do in order to go forward on this patch?
>
> Lambd
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This is so great, thank you!
Comment at: clangd/XRefs.cpp:544
+/// Computes the deduced type at a given location by visiting the relevant
+/// nodes.
+class DeducedType
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:768
+if (CGF.getContext().getTargetInfo().unsignedFixedPointTypesHavePadding()
&&
+Ty->isUnsignedFixedPointType()) {
+ unsigned NumBits = CGF.getContext().getTypeSize(Ty);
ebevhan added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:768
+if (CGF.getContext().getTargetInfo().unsignedFixedPointTypesHavePadding()
&&
+Ty->isUnsignedFixedPointType()) {
+ unsigned NumBits = CGF.getContext().getTypeSize(Ty);
r
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Looks OK to me.
But file "test/CodeGen/vld_dup.c" looks weird/empty. I guess you're removing it?
https://reviews.llvm.org/D48440
___
balazske updated this revision to Diff 153015.
balazske added a comment.
Rebase to newest master.
Repository:
rC Clang
https://reviews.llvm.org/D47459
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The code looks good to me.
It'd be nicer if you can put ranking screenshots (before vs after) in the patch
summary.
Comment at: clangd/Quality.cpp:160
+case Keyword: /
kosarev added a comment.
Yep, this patch removes `vld_dup.c` as it duplicates part of what we have in
`arm-neon-vld.c`. Clicking 'Show File Contents' below the file displays its
contents. Thanks for reviewing!
https://reviews.llvm.org/D48440
___
c
sammccall added a comment.
This looks great! Would like to get your thoughts on reusing/not reusing
SymbolCollector.
Comment at: clangd/FindSymbols.cpp:181
+/// Finds document symbols in the main file of the AST.
+class DocumentSymbolsConsumer : public index::IndexDataConsumer
sammccall added a comment.
Added before/after
Comment at: clangd/Quality.cpp:160
+case Keyword: // Often relevant, but misses most signals.
+ Score *= 4; // FIXME: important keywords should have specific boosts.
break;
hokein wrote:
> I'm curi
baloghadamsoftware updated this revision to Diff 153023.
baloghadamsoftware added a comment.
Herald added a reviewer: george.karpenkov.
Herald added a subscriber: mikhail.ramalho.
Updated to work with the latest Constrain Manager patch.
https://reviews.llvm.org/D32642
Files:
lib/StaticAnalyze
hans added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4043-4044
+if (CCGenDiagnostics && A) {
+ SmallString<128> CrashDirectory;
+ CrashDirectory = A->getValue();
+ llvm::sys::path::append(CrashDirectory, Split.first);
zturner wro
EricWF marked 10 inline comments as done.
EricWF added inline comments.
Comment at: include/clang/AST/SourceLocExprScope.h:39
+//static_assert(foo() == __LINE__);
+return OldVal == nullptr || isa(DefaultExpr) ||
+ !OldVal->isInSameContext(EvalContext);
-
RKSimon closed this revision.
RKSimon added a comment.
This was committed at https://reviews.llvm.org/rL330571
Repository:
rL LLVM
https://reviews.llvm.org/D45619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
sammccall added inline comments.
Comment at: clangd/FileDistance.cpp:35
+: Opts(Opts) {
+ for (const auto &R : Roots) {
+auto Canonical = canonicalize(R.getKey());
Note there was a nasty bug in FileDistance::FileDistance that failed to
consider down edg
ilya-biryukov updated this revision to Diff 153028.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Move the namespace check to happen before canRequestComment call
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48211
Files:
clangd/CodeComplet
ilya-biryukov added inline comments.
Comment at: clangd/CodeCompletionStrings.cpp:172
// get this declaration, so we don't show documentation in that case.
if (Result.Kind != CodeCompletionResult::RK_Declaration)
return "";
sammccall wrote:
> while her
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335718: [clangd] Do not show namespace comments. (authored
by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48211
Files:
clang-too
Author: ibiryukov
Date: Wed Jun 27 02:47:20 2018
New Revision: 335718
URL: http://llvm.org/viewvc/llvm-project?rev=335718&view=rev
Log:
[clangd] Do not show namespace comments.
Summary:
Comments from namespaces that clangd produces are too noisy and often
not useful.
Namespaces have too many red
Szelethus added a comment.
In https://reviews.llvm.org/D48436#1144380, @NoQ wrote:
> I think we need to finish our dialog on who's responsible for initialization
> and why do we need to filter constructors at all, cause it's kinda hanging
> (i.e. https://reviews.llvm.org/D45532#inline-422673).
simon_tatham created this revision.
Herald added a subscriber: cfe-commits.
This option interposes a wrapper implementation of VirtualFileSystem
in front of the one in the CompilerInstance. The wrapper filesystem
differs from the standard one in that it tolerates backslashes as a
path separator ev
simon_tatham added a comment.
As I mentioned on llvm-dev, this is an unfinished draft. I'm interested in
review comments, but I already know things like 'needs more comments / tests /
careful error handling' :-)
Some 'known unknowns':
- I'm caching the results of every directory scan, to save
balazske created this revision.
Herald added a subscriber: cfe-commits.
Added structural equivalence check for C++ methods.
Improved structural equivalence tests.
Added related ASTImporter tests.
Repository:
rC Clang
https://reviews.llvm.org/D48628
Files:
lib/AST/ASTStructuralEquivalence.c
ilya-biryukov added a comment.
Sorry for the late response, was on vacation.
Have you considered doing the same filtering in ASTUnit's
`StoredDiagnosticConsumer`? It should not be more difficult and allows to avoid
changing the clang's diagnostic interfaces. That's what we do in clangd.
I wond
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:392
-if (T->isMemberPointerType()) {
- if (isMemberPointerUninit(FR, LocalChain))
+if (T->isPointerType() || T->isReferenceType()) {
+ if (isPointerOrRefere
yvvan added a comment.
The idea was to ignore everything including notes and remarks so that only
errors from system headers are still collected.
Changing consumer might be a possible way to go as well but it requires
changing (or wrapping) all consumers that we need to be affected. The advanta
Author: sammccall
Date: Wed Jun 27 04:43:54 2018
New Revision: 335723
URL: http://llvm.org/viewvc/llvm-project?rev=335723&view=rev
Log:
[clangd] Sema ranking tweaks: downrank keywords and injected names.
Summary:
Injected names being ranked too high was just a bug.
The high boost for keywords was
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335723: [clangd] Sema ranking tweaks: downrank keywords and
injected names. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D48631
Files:
lib/AST/ASTImporter.cpp
test/ASTMerge/std-initializer-list/Inputs/il.cpp
test/ASTMerge/std-initializer-list/test
Hi Reid,
Thanks for landing the workaround.
The fact that this test didn't not work means our completion inside
templates is broken on Windows by default. I'll try searching for ways to
fix it.
On Mon, Jun 18, 2018 at 9:00 PM Reid Kleckner wrote:
> And, as soon as I sent that, I realized what
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
Repository:
rC Clang
https://reviews.llvm.org/D48631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Author: nico
Date: Wed Jun 27 05:05:06 2018
New Revision: 335725
URL: http://llvm.org/viewvc/llvm-project?rev=335725&view=rev
Log:
Add regression test for PR37935.
Modified:
cfe/trunk/test/SemaCXX/cxx-deprecated.cpp
Modified: cfe/trunk/test/SemaCXX/cxx-deprecated.cpp
URL:
http://llvm.org/vi
Here's another regression that was introduced by the patch:
https://bugs.llvm.org/show_bug.cgi?id=37935 I landed a test for that in
r335725 (in case you're wondering why there's a new test failure when you
reland).
Thanks for working on this!
On Tue, Jun 26, 2018 at 9:03 AM Michael Kruse via cfe-
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48634
Files:
clangd/tool/ClangdMain.cpp
Index: clangd/tool/ClangdMain.cpp
==
yvvan added a comment.
But this one misses a way to set this flag for everything except libclang. We
can probably change that (Nikolai is in vacation till the end of summer so it's
probably my part now) and add some tests outside of Index for it (probably
Frontend)
Repository:
rC Clang
htt
a.sidorin requested changes to this revision.
a.sidorin added a comment.
This revision now requires changes to proceed.
Hi Balázs,
I think that the test changes unrelated to C++ method equivalence should be
moved into a separate patch.
Comment at: lib/AST/ASTStructuralEquival
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335726: [Analyzer] Moved RangeConstraintManager to header.
NFC. (authored by mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D48561
File
a.sidorin added a comment.
Hi Gabor,
Let's agree on `getImportedOrCreateDecl()` :) I think it is informative enough
but is still not too long.
Repository:
rC Clang
https://reviews.llvm.org/D47632
___
cfe-commits mailing list
cfe-commits@lists.l
Author: mramalho
Date: Wed Jun 27 05:42:48 2018
New Revision: 335726
URL: http://llvm.org/viewvc/llvm-project?rev=335726&view=rev
Log:
[Analyzer] Moved RangeConstraintManager to header. NFC.
Summary: While at it, added a dump method to RangeSet.
Reviewers: george.karpenkov, NoQ
Reviewed By: geo
thakis added a comment.
There are 2 other patches out there for the case sensitivity. Neither landed,
because the performance hit form this approach is pretty big, and it's not
necessary: You can either put the Win SDK into a ciopfs mount (example:
https://cs.chromium.org/chromium/src/build/vs_
rogfer01 updated this revision to Diff 153070.
rogfer01 added a comment.
ChangeLog:
- Use a `ConstantDataArray` instead of a struct of types.
- Use `LLVM_IS_TRIVIALLY_COPYABLE`
https://reviews.llvm.org/D48589
Files:
include/clang/CodeGen/CGFunctionInfo.h
lib/CodeGen/CGCall.cpp
Index: lib
mikerice updated this revision to Diff 153067.
mikerice marked 8 inline comments as done.
mikerice added a comment.
Thanks for the review. Updated based on comments.
https://reviews.llvm.org/D46652
Files:
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Driver/CC1Options.td
includ
mikerice added inline comments.
Comment at: include/clang/Driver/CC1Options.td:604
+ HelpText<"When creating a pch stop at this file. When using a pch start "
+ "after this file.">;
def fno_pch_timestamp : Flag<["-"], "fno-pch-timestamp">,
hans wrote
simon_tatham added a comment.
No, I haven't measured it. Partly because that was one of the (many) things I
was going to leave until after I //didn't// get feedback on the first draft
that discouraged me from the whole idea :-) and also because I've already
thought of one thing I can do to spee
trixirt added a comment.
Sorry for the delay, i will have something (hopefully) this weekend.
Repository:
rC Clang
https://reviews.llvm.org/D47554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: martong
Date: Wed Jun 27 06:32:50 2018
New Revision: 335731
URL: http://llvm.org/viewvc/llvm-project?rev=335731&view=rev
Log:
Re-apply: [ASTImporter] Import the whole redecl chain of functions
Summary:
With this patch when any `FunctionDecl` of a redeclaration chain is imported
then we br
martong added a comment.
The broken lldb tests are fixed with a minor change. We no longer load the
Decls from the
external source during the call of `DeclContext::containsDecl`. A new function
`DeclContext::containsDeclAndLoad` is added which does a load and calls
`containsDecl`.
Re-apply comm
rogfer01 added a comment.
@rjmccall because we do not want to impact the clients of `ABIArgInfo` I
thought of two possible approaches
1. extend `CGFunctionInfo` with a third trailing array (now it has two), with
as many elements as `ABIArgInfo` (call it `ABIArgExtraInfo`) then during the
creat
erik.pilkington added inline comments.
Comment at: libcxx/include/memory:1479
+struct __has_construct_missing
+: false_type
+{
vsapsai wrote:
> erik.pilkington wrote:
> > Shouldn't this be true_type?
> I see this is confusing and I'm still struggling how to e
labath added a comment.
In https://reviews.llvm.org/D47532#1144966, @martong wrote:
> The broken lldb tests are fixed with a minor change. We no longer load the
> Decls from the
> external source during the call of `DeclContext::containsDecl`. A new
> function
> `DeclContext::containsDeclAnd
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:488-491
// TODO: Dereferencing should be done according to the dynamic type.
while (Optional L = DerefdV.getAs()) {
DerefdV = State->getSVal(*L);
}
--
mclow.lists added inline comments.
Comment at:
test/std/strings/basic.string/string.ops/string_rfind/string_size.pass.cpp:161
+std::string s = " !";
+assert(s.rfind({"abc", 1}) == std::string::npos);
+}
These tests don't work in C++03; they'll need t
v.g.vassilev updated this revision to Diff 153086.
v.g.vassilev retitled this revision from "[ODRHash] Do not put elaborated types
in the TypeMap" to "[ODRHash] Rip out the registration of Type* in TypeMap".
v.g.vassilev added a comment.
Remove the TypeMap
https://reviews.llvm.org/D48524
Files
v.g.vassilev added a comment.
@rtrieu, your comment was along the lines of what I was thinking of. I have
updated the patch. Without testing it on large scale, I the current change
seems to work for us.
https://reviews.llvm.org/D48524
___
cfe-comm
Author: alexfh
Date: Wed Jun 27 07:30:55 2018
New Revision: 335736
URL: http://llvm.org/viewvc/llvm-project?rev=335736&view=rev
Log:
[clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is
mutated within a statement.
Summary:
(Originally started as a clang-tidy check but th
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE335736: [clang-tidy] Add ExprMutationAnalyzer, that
analyzes whether an expression is… (authored by alexfh, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45679?vs=151245&id=153087
alexfh added a comment.
Ping.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mramalho
Date: Wed Jun 27 07:39:41 2018
New Revision: 335739
URL: http://llvm.org/viewvc/llvm-project?rev=335739&view=rev
Log:
[analyzer] Fix string not being formatted with extra arguments
Signed-off-by: Mikhail Ramalho
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
Modified: c
Author: alexfh
Date: Wed Jun 27 07:56:12 2018
New Revision: 335740
URL: http://llvm.org/viewvc/llvm-project?rev=335740&view=rev
Log:
[analyzer] Allow registering custom statically-linked analyzer checkers
Summary:
Add an extension point to allow registration of statically-linked Clang Static
Anal
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335740: [analyzer] Allow registering custom
statically-linked analyzer checkers (authored by alexfh, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45718?vs=152317&id=153091#toc
Rep
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
I would like to see some test in non-strict mode that shows that
it is the child existence is what matters, e.g. with empty lines,
and maybe another one with all the content commented ou
mclow.lists updated this revision to Diff 153097.
mclow.lists added a comment.
Update the tests from 2946 - they are removed for C++03
https://reviews.llvm.org/D48616
Files:
include/memory
include/string
test/std/strings/basic.string/string.cons/copy_assignment.pass.cpp
test/std/strings
On 6/26/18 7:49 PM, Zachary Turner via cfe-commits wrote:
> Author: zturner
> Date: Tue Jun 26 19:49:22 2018
> New Revision: 335702
>
> URL: http://llvm.org/viewvc/llvm-project?rev=335702&view=rev
> Log:
> Fix warning about unhandled enumeration in switch.
>
> Modified:
> cfe/trunk/lib/Driver
Author: ctopper
Date: Wed Jun 27 08:57:57 2018
New Revision: 335745
URL: http://llvm.org/viewvc/llvm-project?rev=335745&view=rev
Log:
[X86] Rename llvm.x86.avx512.mask.fpclass.p* to exclude 'mask.' from the name
to match llvm.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/
benhamilton created this revision.
benhamilton added a reviewer: Wizard.
Herald added a subscriber: cfe-commits.
This PR adds a few acronyms related to hashing algorithms to the standard
list in `objc-property-declaration`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48652
F
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from some documentation nits.
Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:6
-Finds unused parameters and fixes them, so that `-Wunused-parameter` can be
-turned on.
+Finds unused
Author: thegameg
Date: Wed Jun 27 09:17:32 2018
New Revision: 335750
URL: http://llvm.org/viewvc/llvm-project?rev=335750&view=rev
Log:
[NEON] Remove empty test file from r335734
Fails on Green Dragon:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/50174/consoleFull
UNRESOL
Thanks for adding the regression test.
I'll wait for @erichkeane's work AttibuteList's linked list fix before
trying to re-commit.
Michael
2018-06-27 7:12 GMT-05:00 Nico Weber :
> Here's another regression that was introduced by the patch:
> https://bugs.llvm.org/show_bug.cgi?id=37935 I landed
benhamilton requested changes to this revision.
benhamilton added a comment.
This revision now requires changes to proceed.
It's really hard to understand reviews which change 4 different things.
I hate to ask, but can you split this up into the 4 fixes?
Repository:
rC Clang
https://reviews.
jolesiak added a comment.
In https://reviews.llvm.org/D48352#1145220, @benhamilton wrote:
> It's really hard to understand reviews which change 4 different things.
>
> I hate to ask, but can you split this up into the 4 fixes?
Sure, I'll split it tomorrow.
Repository:
rC Clang
https://revi
Author: mramalho
Date: Wed Jun 27 09:45:58 2018
New Revision: 335752
URL: http://llvm.org/viewvc/llvm-project?rev=335752&view=rev
Log:
Revert "[Analyzer] Moved RangeConstraintManager to header. NFC."
This broke a number of bots.
This reverts commit 5e1a89912d37a21c3b49ccf30600d7f498dffa9c.
Modi
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:392
-if (T->isMemberPointerType()) {
- if (isMemberPointerUninit(FR, LocalChain))
+if (T->isPointerType() || T->isReferenceType()) {
+ if (isPointerOrReferenceUni
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1949
+ let Args = [UnsignedArgument<"VectorWidth">];
+ let Subjects = SubjectList<[Function], ErrorDiag>;
+ let Documentation = [Undocumented];
-
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich, rsmith, ebevhan,
rjmccall.
leonardchan added a project: clang.
This patch proposes an abstract type that represents fixed point numbers,
similar to APInt or APSInt that was discussed in
https://revie
Author: jdevlieghere
Date: Wed Jun 27 10:31:59 2018
New Revision: 335757
URL: http://llvm.org/viewvc/llvm-project?rev=335757&view=rev
Log:
[DebugInfo] Emit ObjC methods as part of interface
As brought up during the discussion of the DWARF5 accelerator tables,
there is currently no way to associat
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335757: [DebugInfo] Emit ObjC methods as part of interface
(authored by JDevlieghere, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48241
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/Co
ashi1 updated this revision to Diff 153124.
ashi1 added a comment.
I've changed the string to a more meaningful name, and also added a lit test to
check that oclc_daz_opt_on.amdgcn.bc is used.
https://reviews.llvm.org/D48493
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/Inputs/hip_multi
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Thank you!! Please commit.
Comment at: test/Analysis/constraint_manager_negate_difference.c:95
+void negate_mixed(int m, int n) {
+ if (m -n > INT_MIN && m - n <= 0)
+return;
ldionne added a comment.
LGTM. All comments/questions are just for my education. Other things I did:
double-check that you changed all the functions changed by
https://cplusplus.github.io/LWG/lwg-defects.html#2946.
Comment at: include/memory:5647
+ typename __void_t::ty
thakis added a comment.
The things I pointed at only do case-insensitivity. I haven't seen anything
using backslashes in the builds I worked on. (Is that for -I flags?) I'd think
that the backslash bits can probably be implemented with less overhead.
Repository:
rC Clang
https://reviews.llv
ldionne added a comment.
More missed `noexcept`s.
Comment at: include/string:279
+template
+size_type find_first_of(const T& t, size_type pos = 0) const noexcept;
// C++17
size_type find_first_of(const value_type* s, size_type pos, size_type n)
const noexcep
ashi1 updated this revision to Diff 153127.
ashi1 added a comment.
Added diff with full context.
https://reviews.llvm.org/D48493
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/Inputs/hip_multiple_inputs/dev_lib/irif.amdgcn.bc
test/Driver/Inputs/hip_multiple_inputs/dev_lib/ockl.amdgcn.bc
ashi1 updated this revision to Diff 153131.
ashi1 added a comment.
Fix diff file
https://reviews.llvm.org/D48493
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/Inputs/hip_multiple_inputs/dev_lib/irif.amdgcn.bc
test/Driver/Inputs/hip_multiple_inputs/dev_lib/ockl.amdgcn.bc
test/Driver/
yaxunl added inline comments.
Comment at: test/Driver/hip-toolchain-flush-denorms.hip:6
+// RUN: %clang -### -target x86_64-linux-gnu \
+// RUN: -x hip --cuda-gpu-arch=gfx803 --cuda-gpu-arch=gfx900 \
+// RUN: --hip-device-lib-path=%S/Inputs/hip_multiple_inputs/dev_lib \
-
rjmccall added inline comments.
Comment at: include/clang/Basic/FixedPoint.h:11
+/// \file
+/// Defines the fixed point number interface.
+//
Referencing the standard here would be good, and maybe even excerpting the key
parts.
Comment at: inc
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:85
"ockl.amdgcn.bc", "irif.amdgcn.bc", "ocml.amdgcn.bc",
"oclc_finite_only_off.amdgcn.bc",
+ FlushDenormalControlBC,
we need to fix t
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp:24
+: ClangTidyCheck(Name, Context),
+ RawDisallowedSeedTypes(Options.get("DisallowedSeedTypes", "")) {
+ StringRef(RawDisallowedSeedTypes).split(DisallowedSeedTypes,
ashi1 updated this revision to Diff 153136.
ashi1 added a comment.
I've updated. Moved the bitcode files into hip_dev_lib and added test for both
on and off flush denorms to zero option.
https://reviews.llvm.org/D48493
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/Inputs/hip_dev_lib/iri
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:90
+ // by default.
+ bool SameFBits;
+
Sorry for the extremely late review, but this really needs to be renamed.
Please remember that other compiler maintainers are not experts in t
tra updated this revision to Diff 153138.
tra added a comment.
Make destructor registration conditional -- we generate no destructor with
-fcuda-rdc.
Updated the test to reflect changes in destructor registration.
https://reviews.llvm.org/D48613
Files:
clang/lib/CodeGen/CGCUDANV.cpp
clang/
Author: morehouse
Date: Wed Jun 27 11:24:46 2018
New Revision: 335762
URL: http://llvm.org/viewvc/llvm-project?rev=335762&view=rev
Log:
[UBSan] Add silence_unsigned_overflow flag.
Summary:
Setting UBSAN_OPTIONS=silence_unsigned_overflow=1 will silence all UIO
reports. This feature, combined with
ashi1 updated this revision to Diff 153140.
https://reviews.llvm.org/D48493
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc
test/Driver/Inputs/hip_dev_lib/ockl.amdgcn.bc
test/Driver/Inputs/hip_dev_lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc
test/Drive
vsapsai added inline comments.
Comment at: libcxx/include/memory:1479
+struct __has_construct_missing
+: false_type
+{
erik.pilkington wrote:
> vsapsai wrote:
> > erik.pilkington wrote:
> > > Shouldn't this be true_type?
> > I see this is confusing and I'm st
yaxunl added a comment.
better merge these two tests and rename it as hip-device-libs.hip. We can also
add other device lib tests to it later.
https://reviews.llvm.org/D48493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: tra
Date: Wed Jun 27 11:32:51 2018
New Revision: 335763
URL: http://llvm.org/viewvc/llvm-project?rev=335763&view=rev
Log:
[CUDA] Use atexit() to call module destructor.
This matches the way NVCC does it. Doing module cleanup at global
destructor phase used to work, but is, apparently, too
NoQ added a comment.
Aha, ok, yeah, we should have seen this coming. Whenever a checker tracks pairs
of objects, like containers and iterators, or strings objects and their
internal buffers (https://reviews.llvm.org/D48522), or return values and
out-parameters of the same function call (https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335763: [CUDA] Use atexit() to call module destructor.
(authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48613?vs=153138&id=153144#toc
Repository:
rC Clang
https:/
rjmccall added a comment.
In https://reviews.llvm.org/D48589#1144976, @rogfer01 wrote:
> @rjmccall because we do not want to impact the clients of `ABIArgInfo` I
> thought of two possible approaches
>
> 1. extend `CGFunctionInfo` with a third trailing array (now it has two), with
> as many elem
ashi1 updated this revision to Diff 153146.
ashi1 added a comment.
Merged checks for flush denorm on and off into single test hip-device-libs.hip
https://reviews.llvm.org/D48493
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc
test/Driver/Inputs/hip_dev_l
1 - 100 of 188 matches
Mail list logo
