yaxunl added inline comments.
================ Comment at: test/Driver/hip-toolchain-flush-denorms.hip:6 +// RUN: %clang -### -target x86_64-linux-gnu \ +// RUN: -x hip --cuda-gpu-arch=gfx803 --cuda-gpu-arch=gfx900 \ +// RUN: --hip-device-lib-path=%S/Inputs/hip_multiple_inputs/dev_lib \ ---------------- we only need test with one arch ================ Comment at: test/Driver/hip-toolchain-flush-denorms.hip:7 +// RUN: -x hip --cuda-gpu-arch=gfx803 --cuda-gpu-arch=gfx900 \ +// RUN: --hip-device-lib-path=%S/Inputs/hip_multiple_inputs/dev_lib \ +// RUN: -fcuda-flush-denormals-to-zero \ ---------------- better put the dummy bc files under test/Driver/Inputs/hip_dev_lib ================ Comment at: test/Driver/hip-toolchain-flush-denorms.hip:8 +// RUN: --hip-device-lib-path=%S/Inputs/hip_multiple_inputs/dev_lib \ +// RUN: -fcuda-flush-denormals-to-zero \ +// RUN: %S/Inputs/hip_multiple_inputs/b.hip \ ---------------- we also need to test the case without this option https://reviews.llvm.org/D48493 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
