[PATCH] D46449: remove references to nonexistent PragmaTable interface

mostynb created this revision. Herald added a subscriber: cfe-commits. There does not appear to be a PragmaTable interface in the repository, either on tip-of-tree or historically. Let's remove these references. Repository: rC Clang https://reviews.llvm.org/D46449 Files: clang/include/cl

[PATCH] D46450: [Driver] Add mips_Features_Group to Options to improve documentation sorting

vdelvecc created this revision. vdelvecc added reviewers: sdardis, atanasyan, rsmith. Herald added subscribers: cfe-commits, arichardson. Move all of the MIPS-only options into a new m_mips_Features_Group. Nearly all other targets have most target-specific options grouped, but MIPS does not. Th

[PATCH] D45774: [analyzer] cover more cases where a Loc can be bound to constants

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, thanks! I'll commit. https://reviews.llvm.org/D45774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145266. cmtice added a comment. Added comment to change in source code. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp test/Driver/fsanitize-blacklist.c Index: test/Driver/fsanitize-blacklist.c =

[PATCH] D46452: [sanitizer] Don't add --export-dynamic for Myriad

waltl created this revision. waltl added reviewers: vitalybuka, eugenis, alekseyshl. Herald added a subscriber: llvm-commits. This is to work around a bug in some versions of gnu ld, where --export-dynamic implies -shared even if -static is explicitly given. Myriad supports static linking only, so

[PATCH] D46464: [ThinLTO] Support opt remarks options with distributed ThinLTO backends

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: eraman, inglorion, mehdi_amini. Passes down the necessary code ge options to the LTO Config to enable -fdiagnostics-show-hotness and -fsave-optimization-record in the ThinLTO backend for a distributed build

[PATCH] D45774: [analyzer] cover more cases where a Loc can be bound to constants

NoQ added a comment. Two questions for the future: - Should we skip the initializer binding for local variables (and fields/elements of local variables) entirely? Cause we can load from them anyway. And keeping the Store small might be good for performance. - Just in case, do you accidentally

r331556 - [analyzer] Treat more const variables and fields as known contants.

Author: dergachev Date: Fri May 4 13:52:39 2018 New Revision: 331556 URL: http://llvm.org/viewvc/llvm-project?rev=331556&view=rev Log: [analyzer] Treat more const variables and fields as known contants. When loading from a variable or a field that is declared as constant, the analyzer will try t

[PATCH] D45774: [analyzer] cover more cases where a Loc can be bound to constants

This revision was automatically updated to reflect the committed changes. Closed by commit rC331556: [analyzer] Treat more const variables and fields as known contants. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D45774 Files: lib/StaticAnalyzer/Cor

[PATCH] D46471: [HIP] Add hip offload kind

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. There are quite differences in HIP action builder and action job creation, which justifies to define a separate offload kind. https://reviews.llvm.org/D46471 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib

[PATCH] D46472: [HIP] Support offloading by linkscript

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. To support linking device code in different source files, it is necessary to embed fat binary at host linking stage. This patch emits an external symbol for fat binary in host codegen, then embed the fat binary by lld through a

[PATCH] D46473: [HIP] Let clang-offload-bundler support HIP

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. When bundle/unbundle intermediate files for HIP, there may be multiple sub archs, therefore BoundArch needs to be included in the target and output file names for clang-offload-bundler. https://reviews.llvm.org/D46473 Files:

[PATCH] D46475: [HIP] Set proper triple and offload kind for the toolchain

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. Also introduce --hip-link option to indicate HIP for linking. https://reviews.llvm.org/D46475 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp

[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

NoQ added a comment. In https://reviews.llvm.org/D46159#1088050, @alexfh wrote: > As folks noted here, some users prefer to use clang-tidy as a frontend for > the static analyzer. If this helps them test experimental CSA features and > CSA maintainers are willing to accept bug reports and poten

[PATCH] D46476: [HIP] Add action builder

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. To support separate compile/link and linking across device IR in different source files, a new HIP action builder is introduced. Basically it compiles/links host and device code separately, and embed fat binary in host linking

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

yaxunl updated this revision to Diff 145297. yaxunl added a comment. clean up code and separate action builder to another review. https://reviews.llvm.org/D45212 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp lib/Driver/ToolChains/Cuda.h Index: lib/Driver/ToolChain

[PATCH] D46081: [analyzer] Expand conversion check to check more expressions for overflow and underflow

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yep, looks good. This limitation to `DeclRefExpr`s was super conservative. I'll follow up regarding the bugprone category in a week or so on the mailing lists. It's been a long-standing historical d

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:258-260 +Report->addNote(NoteBuf, +PathDiagnosticLocation::create(FieldChain.getEndOfChain(), + Context.get

[PATCH] D45174: non-zero-length bit-fields should make a class non-empty

rsmith marked an inline comment as done. rsmith added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46224: [analyzer] pr37209: Fix casts of glvalues to references.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC331558: [analyzer] pr37209: Fix casts of glvalues to references. (authored by dergachev, committed by ). Repository: rC

r331558 - [analyzer] pr37209: Fix casts of glvalues to references.

Author: dergachev Date: Fri May 4 14:39:25 2018 New Revision: 331558 URL: http://llvm.org/viewvc/llvm-project?rev=331558&view=rev Log: [analyzer] pr37209: Fix casts of glvalues to references. Many glvalue expressions aren't of their respective reference type - they are simply glvalues of their v

[PATCH] D46224: [analyzer] pr37209: Fix casts of glvalues to references.

NoQ added a comment. > i'll most likely try to investigate it more carefully, or at least see if it > causes regressions on large codebases, before committing Seemed fine, no visible change. I hope this means that i pattern-matched carefully enough. Repository: rC Clang https://reviews.llv

r331559 - [X86] Fix some inconsistent formatting in the first line of our intrinsics headers.

Author: ctopper Date: Fri May 4 14:45:25 2018 New Revision: 331559 URL: http://llvm.org/viewvc/llvm-project?rev=331559&view=rev Log: [X86] Fix some inconsistent formatting in the first line of our intrinsics headers. Some were too long and some were too short. Modified: cfe/trunk/lib/Heade

r331560 - [X86] Correct the attributes on the incssp and rdssp builtins to only have 'nothrow'

Author: ctopper Date: Fri May 4 14:56:43 2018 New Revision: 331560 URL: http://llvm.org/viewvc/llvm-project?rev=331560&view=rev Log: [X86] Correct the attributes on the incssp and rdssp builtins to only have 'nothrow' Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/inc

r331561 - [analyzer] pr18953: Split C++ zero-initialization from default initialization.

Author: dergachev Date: Fri May 4 14:56:51 2018 New Revision: 331561 URL: http://llvm.org/viewvc/llvm-project?rev=331561&view=rev Log: [analyzer] pr18953: Split C++ zero-initialization from default initialization. The bindDefault() API of the ProgramState allows setting a default value for reads

[PATCH] D46368: [analyzer] pr18953: Zeroing constructors, store binding extents, ASTRecordLayouts.

NoQ added a comment. > We could work around that by invalidating object contents every time we > detect something fishy. The only reasonable detection i can come up with > would be to detect if we have a coinciding binding (i.e. what the assertion > was previously protecting us from), eg.: > >

[PATCH] D46368: [analyzer] pr18953: Zeroing constructors, store binding extents, ASTRecordLayouts.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL331561: [analyzer] pr18953: Split C++ zero-initialization from default initialization. (authored by dergachev, committed b

[PATCH] D46415: [analyzer] pr36458: Fix retrieved value cast for symbolic void pointers.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC331562: [analyzer] pr36458: Fix retrieved value cast for symbolic void pointers. (authored by dergachev, committed by ).

r331562 - [analyzer] pr36458: Fix retrieved value cast for symbolic void pointers.

Author: dergachev Date: Fri May 4 15:11:12 2018 New Revision: 331562 URL: http://llvm.org/viewvc/llvm-project?rev=331562&view=rev Log: [analyzer] pr36458: Fix retrieved value cast for symbolic void pointers. C allows us to write any bytes into any memory region. When loading weird bytes from mem

[PATCH] D45241: [analyzer] Invalidate union regions properly. Don't hesitate to load the default binding later.

This revision was automatically updated to reflect the committed changes. Closed by commit rC331563: [analyzer] Invalidate union regions properly. Don't hesitate to load later. (authored by dergachev, committed by ). Herald added a subscriber: baloghadamsoftware. Repository: rC Clang https://r

r331563 - [analyzer] Invalidate union regions properly. Don't hesitate to load later.

Author: dergachev Date: Fri May 4 15:19:32 2018 New Revision: 331563 URL: http://llvm.org/viewvc/llvm-project?rev=331563&view=rev Log: [analyzer] Invalidate union regions properly. Don't hesitate to load later. We weren't invalidating our unions correctly. The previous behavior in invalidateRegi

[PATCH] D46464: [ThinLTO] Support opt remarks options with distributed ThinLTO backends

pcc added inline comments. Comment at: test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll:14 +; RUN: %clang -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc -fsave-optimization-record -fdiagnostics-show-hotness -o %t2.o -c +; RUN: cat %t2.opt.yaml.thin.0.yaml | FileChec

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

shuaiwang updated this revision to Diff 145313. shuaiwang added a comment. Revert "DeclRefExpr to volatile handling" part of last update. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45679 Files: clang-tidy/utils/CMakeLists.txt clang-tidy/utils/ExprMutationAnalyzer.cpp

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

shuaiwang marked 5 inline comments as done. shuaiwang added a comment. I've reverted the handling of DeclRefExpr to volatile after rethinking about it. The purpose of this analyzer is to find whether the given Expr is mutated within a scope, but doesn't really care about external changes. In oth

r331565 - [analyzer] Remove untested code in evalLoad.

Author: dergachev Date: Fri May 4 16:01:10 2018 New Revision: 331565 URL: http://llvm.org/viewvc/llvm-project?rev=331565&view=rev Log: [analyzer] Remove untested code in evalLoad. No functional change intended. Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp Modified: cfe/trunk/

[PATCH] D46176: Pull helper class Environment from clangFormat into libToolingCore [NFC]

ioeric updated this revision to Diff 145318. ioeric added a comment. - Create SourceManagerForFile instead of Environment; put it in SourceManager.h which seems to be a better place. Repository: rC Clang https://reviews.llvm.org/D46176 Files: include/clang/Basic/SourceManager.h lib/Basi

[PATCH] D46176: Add SourceManagerForFile helper which sets up SourceManager and dependencies for a single file with code snippet

ioeric added a comment. Thanks for the comment and suggestion! I've changed this to `SourceManagerForFile` and move it to SourceManager.h, which seems to be a more natural fit. `SourceManagerForFile` sounds like a sensible name to me, but I'm guess there might be a better name... Repository:

[PATCH] D46187: [Analyzer] getRegisteredCheckers(): handle debug checkers too.

NoQ added a comment. It seems that you're using debug checkers of the analyzer to gain some free tools for exploring the source code (such as displaying a call graph) for free, right? I believe we could also benefit from a method of extracting the analyzer's `clang -cc1` run-line from clang-ti

[PATCH] D46464: [ThinLTO] Support opt remarks options with distributed ThinLTO backends

tejohnson updated this revision to Diff 145321. tejohnson added a comment. Address comments Repository: rC Clang https://reviews.llvm.org/D46464 Files: lib/CodeGen/BackendUtil.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll Inde

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:8829 + return EvaluateComparisonBinaryOperator(Info, E, OnSuccess, [&]() { +return ExprEvaluatorBaseTy::VisitBinaryOperator(E); + }); It'd be clearer to call `VisitBinCmp` rather than `Visit

[PATCH] D46464: [ThinLTO] Support opt remarks options with distributed ThinLTO backends

tejohnson marked an inline comment as done. tejohnson added a comment. Fixed the output file as suggested. Also note that this test will fail and can't go in until after https://reviews.llvm.org/D46387 Repository: rC Clang https://reviews.llvm.org/D46464 __

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:971 + auto EmitCmpRes = [&](const VarDecl *VD) { +return CGF.CGM.GetAddrOfGlobalVar(VD); + }; rsmith wrote: > Perhaps directly emit the constant val

[PATCH] D46464: [ThinLTO] Support opt remarks options with distributed ThinLTO backends

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice added a comment. vsk: Are you asking me to put together a cfi blacklist to ship in the resource directory in the default install as part of this code review? Or is that something you want to see in a different code reivew? https://reviews.llvm.org/D46403 ___

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

pcc added a comment. We should be installing `compiler-rt/lib/cfi/cfi_blacklist.txt`, no? https://reviews.llvm.org/D46403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D46403#1088759, @pcc wrote: > We should be installing `compiler-rt/lib/cfi/cfi_blacklist.txt`, no? Oh, I see. This is already taken care of, then. @cmtice This looks fi

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

pcc accepted this revision. pcc added a comment. LGTM https://reviews.llvm.org/D46403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

pfultz2 added a comment. > In this sense bug reports against abandoned alpha checkers (which are, > unfortunately, the majority) aren't very useful. In most cases it's just too > easy to see how broken they are. Although the majority are like that, not all of them are. Some like the Conversion

[PATCH] D44934: [analyzer] Improve the modeling of `memset()`.

NoQ added a comment. Hmm, ok, it seems that i've just changed the API in https://reviews.llvm.org/D46368, and i should have thought about this use case. Well, at least i have some background understanding of these problems now. Sorry for not keeping eye on this problem. In https://reviews.llvm

r331570 - Add warning flag -Wordered-compare-function-pointers.

Author: efriedma Date: Fri May 4 17:09:51 2018 New Revision: 331570 URL: http://llvm.org/viewvc/llvm-project?rev=331570&view=rev Log: Add warning flag -Wordered-compare-function-pointers. The C standard doesn't allow comparisons like "f1 < f2" (where f1 and f2 are function pointers), but we allo

[PATCH] D46155: Add warning flag -Wordered-compare-function-pointers.

This revision was automatically updated to reflect the committed changes. Closed by commit rC331570: Add warning flag -Wordered-compare-function-pointers. (authored by efriedma, committed by ). Repository: rC Clang https://reviews.llvm.org/D46155 Files: include/clang/Basic/DiagnosticSemaKin

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

NoQ added a comment. Ok, i personally think this patch should go in. I think it makes it clear enough that an unsuspecting user would suspect something by reading the flag, and makes the feature hard enough to discover. And i'm happy to support anybody who's going to work on this stuff. -

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for copy/move constructor arguments

AntonBikineev updated this revision to Diff 145332. AntonBikineev added a comment. Herald added subscribers: aheejin, sbc100. I've moved setting noalias-attribute down to IR-function creation. This is needed in the context of emitting a constructor call when the definition of the constructor is

[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for copy/move constructor arguments

efriedma added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:2512 + if (D && isa(D) && + cast(D)->isCopyOrMoveConstructor()) +F->addParamAttr(1, llvm::Attribute::NoAlias); Why does it matter whether it's a copy constructor? The standard te

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rjmccall added inline comments. Comment at: include/clang/AST/ASTContext.h:1986 + /// This object needs to be initialized by Sema the first time it checks + /// a three-way comparison. + ComparisonCategories CompCategories; Is this comment accurate? Because i

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1485 + state = CheckOverlap(C, state, CE->getArg(2), Dst, srcExpr); + This crashes on the old tests for the checker. I guess that's because the normal `strcpy()` doesn't hav

[PATCH] D46485: Add python tool to dump and construct header maps

bruno created this revision. bruno added a reviewer: rsmith. Herald added a subscriber: mgorny. Header maps are binary files used by Xcode, which are used to map header names or paths to other locations. Clang has support for those since its inception, but there's not a lot of header map testing a

[PATCH] D43928: [analyzer] Correctly measure array size in security.insecureAPI.strcpy

NoQ added a comment. Sorry, i completely forgot about this one :( I think this patch needs `lit` tests, eg. tell the analyzer to analyze a simple strcpy() call on any `-target` with non-8-bit chars and see if it's still crashes or behaves incorrectly. Comment at: lib/StaticA

[libcxx] r331576 - [libcxx] [test] Fix whitespace, NFC.

Author: stl_msft Date: Fri May 4 18:40:27 2018 New Revision: 331576 URL: http://llvm.org/viewvc/llvm-project?rev=331576&view=rev Log: [libcxx] [test] Fix whitespace, NFC. Strip trailing whitespace and untabify. Modified: libcxx/trunk/test/std/iterators/stream.iterators/ostreambuf.iterator/

[libcxx] r331575 - [libcxx] [test] Fix MSVC x64 truncation warning.

Author: stl_msft Date: Fri May 4 18:40:24 2018 New Revision: 331575 URL: http://llvm.org/viewvc/llvm-project?rev=331575&view=rev Log: [libcxx] [test] Fix MSVC x64 truncation warning. warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data Requesting post-commit revi

r331578 - Fix a couple places that immediately called operator-> on the result of dyn_cast.

Author: ctopper Date: Fri May 4 18:58:26 2018 New Revision: 331578 URL: http://llvm.org/viewvc/llvm-project?rev=331578&view=rev Log: Fix a couple places that immediately called operator-> on the result of dyn_cast. It looks like it safe to just use cast for both cases. Modified: cfe/trunk/

[PATCH] D46487: [HIP] Diagnose unsupported host triple

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. https://reviews.llvm.org/D46487 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Driver.cpp test/Driver/cuda-bad-arch.cu Index: test/Driver/cuda-bad-arch.cu =

[PATCH] D46464: [ThinLTO] Support opt remarks options with distributed ThinLTO backends

tejohnson updated this revision to Diff 145348. tejohnson added a comment. Update test for change to pass -1 as the Task ID for distributed backends, and to reflect companion llvm change (https://reviews.llvm.org/D46488). Repository: rC Clang https://reviews.llvm.org/D46464 Files: lib/Code

[PATCH] D46464: [ThinLTO] Support opt remarks options with distributed ThinLTO backends

tejohnson added inline comments. Comment at: test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll:14 +; RUN: %clang -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc -fsave-optimization-record -fdiagnostics-show-hotness -o %t2.o -c +; RUN: cat %t2.opt.yaml.thin.0.yaml | Fi

[PATCH] D45174: non-zero-length bit-fields should make a class non-empty

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rC Clang https://reviews.llvm.org/D45174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D46464: [ThinLTO] Support opt remarks options with distributed ThinLTO backends

pcc accepted this revision. pcc added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D46464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46487: [HIP] Diagnose unsupported host triple

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D46487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D46471: [HIP] Add hip offload kind

rjmccall added a comment. Otherwise LGTM. Comment at: lib/Driver/Compilation.cpp:201 + // not compiled again if there are already failures. It is OK to abort the + // CUDA pipeline on errors. + if (A->isOffloading(Action::OFK_Cuda) || A->isOffloading(Action::OFK_HIP)) --

[PATCH] D46472: [HIP] Support offloading by linkscript

rjmccall added a comment. The IRGen aspects of this seem reasonable, modulo a comment change. I don't feel qualified to judge the driver change. Comment at: lib/CodeGen/CGCUDANV.cpp:317 + if (GpuBinaryFileName.empty() && !IsHIP) return nullptr; Is thi

[PATCH] D46473: [HIP] Let clang-offload-bundler support HIP

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D46473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D46489: [HIP] Let assembler output bitcode for amdgcn

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. amdgcn does not support linking of object files, therefore let assembler output bitcode for HIP for amdgcn. https://reviews.llvm.org/D46489 Files: lib/Driver/ToolChains/Clang.cpp Index: lib/Driver/ToolChains/Clang.cpp

[PATCH] D46475: [HIP] Set proper triple and offload kind for the toolchain

rjmccall added inline comments. Comment at: lib/Driver/Driver.cpp:554 + }) || + IsHIP) { const ToolChain *HostTC = C.getSingleOffloadToolChain(); It seems to me that it wouldn't be too hard to do your TODO here; it's basically just ch

[PATCH] D46489: [HIP] Let assembler output bitcode for amdgcn

rjmccall added a comment. I think the right solution here is to make a CompileJobAction with type TY_LLVM_BC in the first place. You should get the advice of a driver expert, though. https://reviews.llvm.org/D46489 ___ cfe-commits mailing list cf

[PATCH] D44934: [analyzer] Improve the modeling of `memset()`.

MTC added a comment. In https://reviews.llvm.org/D44934#1088771, @NoQ wrote: > Hmm, ok, it seems that i've just changed the API in > https://reviews.llvm.org/D46368, and i should have thought about this use > case. Well, at least i have some background understanding of these problems > now. So

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 18 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/ASTContext.h:1986 + /// This object needs to be initialized by Sema the first time it checks + /// a three-way comparison. + ComparisonCategories CompCategories; -

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 12 inline comments as done. EricWF added inline comments. Comment at: lib/Sema/SemaExpr.cpp:9825 +LHS = S.ImpCastExprToType(LHS.get(), IntType, CK_IntegralCast); +RHS = S.ImpCastExprToType(RHS.get(), IntType, CK_IntegralCast); +LHSType = RHSType = IntTyp

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rjmccall added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:71 + /// standard library. The key is a value of ComparisonCategoryResult. + mutable llvm::DenseMap Objects; + EricWF wrote: > rjmccall wrote: > > We expect this map to have at

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen updated this revision to Diff 145352. https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index: test/Analysis/bsd-string.c === --- /dev/null +++ test/Analysi

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1485 + state = CheckOverlap(C, state, CE->getArg(2), Dst, srcExpr); + NoQ wrote: > This crashes on the old tests for the checker. I guess that's because the > normal `s

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:964 +RHS = CGF.EmitAnyExpr(E->getRHS()).getAggregatePointer(); +break; + case TEK_Complex: It looks like we don't actually support any aggregate types here, which I think is fine beca

<    1   2