rjmccall added a comment.

The IRGen aspects of this seem reasonable, modulo a comment change.  I don't 
feel qualified to judge the driver change.



================
Comment at: lib/CodeGen/CGCUDANV.cpp:317
+  if (GpuBinaryFileName.empty() && !IsHIP)
     return nullptr;
 
----------------
Is this filename string only used for CUDA?  If so, please rename it to make 
that clear, or at least add a comment.


https://reviews.llvm.org/D46472



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to