rjmccall added a comment. Otherwise LGTM.
================ Comment at: lib/Driver/Compilation.cpp:201 + // not compiled again if there are already failures. It is OK to abort the + // CUDA pipeline on errors. + if (A->isOffloading(Action::OFK_Cuda) || A->isOffloading(Action::OFK_HIP)) ---------------- Mentioning only CUDA in the second clause makes me wonder whether it's *only* okay to abort a CUDA pipeline, not a HIP one. That is presumably not your intent. You could just drop "CUDA" there. https://reviews.llvm.org/D46471 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
