rjmccall added inline comments.
Comment at: AST/DeclCXX.cpp:1130
data().IsStandardLayout = false;
+ data().IsCXX11StandardLayout = false;
+}
`IsCXX11StandardLayout` should be based on `FieldRec->isCXX11StandardLayout()`,
I assume.
h
EricWF added a comment.
I'm also in favor of making this opt-out instead of opt-in, except for a
handful of functions like `unique_ptr::release` which may yield false
positives. However, for functions where discarding the return value is always a
bug, I don't see an issue in libc++ emitting a w
rjmccall added a comment.
Yes, if we think that the committee is likely to include questionable functions
on the `[[nodiscard]]` list which we don't want to warn about pre-C++17, then
it makes sense to have two internal macros, one for functions like `std::move`
that should be unconditionally w
tra created this revision.
tra added a reviewer: jlebar.
Herald added a subscriber: sanjoy.
We were already performing checks on non-template variables,
but the checks on templated ones were missing.
https://reviews.llvm.org/D45231
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaC
vlad.tsyrklevich updated this revision to Diff 140868.
vlad.tsyrklevich added a comment.
- Small test, doc updates
Repository:
rC Clang
https://reviews.llvm.org/D44801
Files:
docs/ShadowCallStack.rst
docs/index.rst
include/clang/Basic/Sanitizers.def
lib/CodeGen/CGDeclCXX.cpp
lib/Co
Author: vlad.tsyrklevich
Date: Tue Apr 3 15:33:53 2018
New Revision: 329122
URL: http://llvm.org/viewvc/llvm-project?rev=329122&view=rev
Log:
Add the -fsanitize=shadow-call-stack flag
Summary:
Add support for the -fsanitize=shadow-call-stack flag which causes clang
to add ShadowCallStack attribu
mzeren-vmw added a comment.
In https://reviews.llvm.org/D42034#1051965, @mzeren-vmw wrote:
> Update other verifyFormat implementations.
Ping?
Repository:
rC Clang
https://reviews.llvm.org/D42034
___
cfe-commits mailing list
cfe-commits@lists.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329122: Add the -fsanitize=shadow-call-stack flag (authored
by vlad.tsyrklevich, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44801
Files:
c
Author: tra
Date: Tue Apr 3 15:41:06 2018
New Revision: 329127
URL: http://llvm.org/viewvc/llvm-project?rev=329127&view=rev
Log:
[CUDA] Check initializers of instantiated template variables.
We were already performing checks on non-template variables,
but the checks on templated ones were missin
nemanjai added a comment.
In https://reviews.llvm.org/D44921#1050299, @joerg wrote:
> GCC supports -mbss-plt to get the legacy behavior. Not sure if anyone
> actually uses it though.
@spetrovic Is this something we want to implement?
https://reviews.llvm.org/D44921
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329127: [CUDA] Check initializers of instantiated template
variables. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45231?vs=140867&id=140871#toc
Repository:
rC
manojgupta created this revision.
manojgupta added a reviewer: mgorny.
1. Find GCC's LDPATH from the actual GCC config file.
2. Make library detection to take into account crossdev installed
cross-compiler gcc libraries even when a sysroot is specified.
3. Avoid picking libraries from a similar n
rinon created this revision.
rinon added reviewers: hans, rnk.
Herald added subscribers: cfe-commits, mgorny.
If LLVM_ENABLE_LIBXML2=OFF, we should not attempt to link clang against
libxml2.
Repository:
rC Clang
https://reviews.llvm.org/D45234
Files:
CMakeLists.txt
Index: CMakeLists.txt
Author: ahatanak
Date: Tue Apr 3 15:50:16 2018
New Revision: 329128
URL: http://llvm.org/viewvc/llvm-project?rev=329128&view=rev
Log:
[ObjC] Use the name specified by objc_runtime_name instead of the class
identifier.
This patch fixes a few places in CGObjCMac.cpp where the class
identifier was
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Perhaps we could add a comment for the first such occurrence of the cast
in each file explaining it.
Repository:
rCXX libc++
https://reviews.llvm.org/D45128
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329128: [ObjC] Use the name specified by objc_runtime_name
instead of the class (authored by ahatanak, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
manojgupta added a comment.
Michał, will appreciate if you can test this on your (multiple?) Gentoo
configurations.
Will work on updating the testcases after that.
To test it locally, I used the following :
$ cat test.cpp
#include
#include
int main() {
std::cout << " Hello, Worl
On 3 April 2018 at 14:30, Chandler Carruth wrote:
> On Tue, Apr 3, 2018 at 1:52 PM Alex Lorenz via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: arphaman
>> Date: Tue Apr 3 13:50:05 2018
>> New Revision: 329110
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=329110&view=rev
manojgupta added a reviewer: chandlerc.
manojgupta added a comment.
Chandler, I recall that you are also a Gentoo user so please take a look.
Repository:
rC Clang
https://reviews.llvm.org/D45233
___
cfe-commits mailing list
cfe-commits@lists.llvm
mgrang created this revision.
mgrang added a reviewer: asb.
Herald added subscribers: shiva0217, kito-cheng.
The logic was broken for Linux triples as it returns true in the switch for
Triple.isOSLinux().
Repository:
rC Clang
https://reviews.llvm.org/D45237
Files:
lib/Driver/ToolChains/Cl
On Tue, Apr 3, 2018 at 4:01 PM Alex L via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 3 April 2018 at 14:30, Chandler Carruth wrote:
>
>> On Tue, Apr 3, 2018 at 1:52 PM Alex Lorenz via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: arphaman
>>> Date: Tue Apr 3 13:50
mgrang added a comment.
@asb Should we keep frame pointer enabled for debug builds? Internally, for
ARM/Thumb we leave frame pointer ON if debug is enabled.
Repository:
rC Clang
https://reviews.llvm.org/D45237
___
cfe-commits mailing list
cfe-co
lebedev.ri added a comment.
In https://reviews.llvm.org/D44883#1054326, @thakis wrote:
> In https://reviews.llvm.org/D44883#1048751, @dblaikie wrote:
>
> > Historically Clang's policy on warnings was, I think, much more
> > conservative than it seems to be today. There was a strong desire not to
EricWF added a comment.
Ping.
https://reviews.llvm.org/D40218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
Ping. I would like to get a way for libc++ to detect this case before the next
release.
Repository:
rC Clang
https://reviews.llvm.org/D45015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
EricWF added a comment.
Have you verified that we're not losing test coverage here? That is, are you
sure we still have tests for the rvalue overloads in other test files?
Comment at:
libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp:41
+const VT v3(3);
+
EricWF added a comment.
Herald added a subscriber: christof.
I spoke to STL on the MSVC team a while ago, and he stated that if we produced
a paper describing why we need `#include_next` and the rational behind it, and
they would pass that on to the front-end team. They didn't guarantee that the
pcc created this revision.
pcc added reviewers: vlad.tsyrklevich, eugenis, kcc, t.p.northover, olista01.
Herald added subscribers: hiraditya, kristof.beyls, javed.absar, rengolin.
The implementation of shadow call stack on aarch64 is quite different to
the implementation on x86_64. Instead of rese
lewissbaker accepted this revision.
lewissbaker added a comment.
This revision is now accepted and ready to land.
The `coroutine_handle` type does not have a
`from_address()` or a `from_promise()` static functions in the same way that
the `coroutine_handle` implementation does.
Is this intention
efriedma created this revision.
efriedma added reviewers: compnerd, SjoerdMeijer, fhahn.
Herald added subscribers: kristof.beyls, javed.absar, mehdi_amini.
Currently, the interaction between the triple, the CPU, and the supported
features is a mess: the driver edits the triple to indicate the sup
Author: arphaman
Date: Tue Apr 3 19:11:20 2018
New Revision: 329141
URL: http://llvm.org/viewvc/llvm-project?rev=329141&view=rev
Log:
Split test/Driver/darwin-sdkroot.c into two tests
The test additions in r329110 are Darwin-specific, as they rely
on a code path that is reachabled when driver is
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
(1) We weren't invalidating our unions correctly. The previous behavior in
`invalidateRegionsWorker::VisitCluster()` was to //direct//-bind a
NoQ added inline comments.
Comment at: test/Analysis/unions.cpp:82
uu = vv;
-// FIXME: Should be true.
-clang_analyzer_eval(uu.i == 5); // expected-warning{{UNKNOWN}}
+clang_analyzer_eval(uu.i == 5); // expected-warning{{TRUE}}
}
This test got
Dor1s added a comment.
Friendly ping. We'll probably land it tomorrow anyway, as it blocks another fix
needed for llvm-cov, but having another pair of eyes to look at this would be
still helpful :)
Repository:
rC Clang
https://reviews.llvm.org/D45178
_
rsmith updated this revision to Diff 140896.
https://reviews.llvm.org/D45176
Files:
AST/ASTImporter.cpp
AST/DeclCXX.cpp
AST/RecordLayoutBuilder.cpp
CXX/drs/dr14xx.cpp
CXX/drs/dr16xx.cpp
CXX/drs/dr18xx.cpp
CXX/drs/dr21xx.cpp
CXX/drs/dr22xx.cpp
Layout/watchos-standard-layout.cpp
rsmith marked an inline comment as done.
rsmith added inline comments.
Comment at: AST/DeclCXX.cpp:1130
data().IsStandardLayout = false;
+ data().IsCXX11StandardLayout = false;
+}
rjmccall wrote:
> `IsCXX11StandardLayout` should be bas
rsmith updated this revision to Diff 140897.
rsmith marked an inline comment as done.
https://reviews.llvm.org/D45176
Files:
AST/ASTImporter.cpp
AST/DeclCXX.cpp
AST/RecordLayoutBuilder.cpp
CXX/drs/dr14xx.cpp
CXX/drs/dr16xx.cpp
CXX/drs/dr18xx.cpp
CXX/drs/dr21xx.cpp
CXX/drs/dr22xx.c
On 3 April 2018 at 13:07, Akira Hatanaka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Apr 1, 2018, at 6:00 PM, Richard Smith wrote:
>
> On 28 March 2018 at 14:13, Akira Hatanaka via cfe-commits lists.llvm.org> wrote:
>
>> Author: ahatanak
>> Date: Wed Mar 28 14:13:14 2018
>> New
smeenai added a comment.
Finally got a chance to dig into some of the failures this patch is causing.
Here's an example crasher (run with `clang -cc1 -triple i686-windows
-emit-llvm`):
struct Q {
Q(int);
~Q();
};
struct Z {};
struct A {
A(Q);
};
struct B : Z, A {
usi
smeenai planned changes to this revision.
smeenai added a comment.
This doesn't pass all tests right now, and I'll also need to change the test in
accordance with the review comments.
Repository:
rC Clang
https://reviews.llvm.org/D44619
___
cfe-
faisalv added a comment.
Thanks for working on this fairly embarrassing bug (let's fix this before the
week is over :)
Comment at: clang/lib/Sema/SemaDecl.cpp:12886
if (!IsInstantiation && FD && FD->isConstexpr() && !FD->isInvalidDecl() &&
+!isLambdaCallOperator(F
Author: ericwf
Date: Tue Apr 3 21:00:14 2018
New Revision: 329143
URL: http://llvm.org/viewvc/llvm-project?rev=329143&view=rev
Log:
Fix locale test data for GLIBC 2.27 and newer.
GLIBC 2.27 changed the locale data for fr_FR and ru_RU. In particular
they change the decimal and thousands separator
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay. LGTM. Thank you for putting the effort into maintaining both rules
simultaneously.
https://reviews.llvm.org/D45176
___
cfe-commits m
Author: ericwf
Date: Tue Apr 3 21:21:54 2018
New Revision: 329144
URL: http://llvm.org/viewvc/llvm-project?rev=329144&view=rev
Log:
Touch up tests for new header; fix module.modulemap.
This patch does some housekeeping for the new header.
It adds it to the module.modulemap, and the double_incl
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, LGTM with the reduced set of changes to the functionality.
Repository:
rC Clang
https://reviews.llvm.org/D44580
___
cfe-commits mail
EricWF added inline comments.
Comment at: include/experimental/coroutine:262
+struct noop_coroutine_promise {};
+
This whole thing should be wrapped in a `__has_builtin(__builtin_coro_noop)` so
the header still compiles with older clang versions.
===
rjmccall added a comment.
The other changes I see here seem reasonable, but please do split the patch.
Comment at: include/clang/Basic/Cuda.h:61
+ GFX900,
+ GFX902,
LAST,
Does this actually have anything to do with HIP? You have a lot of changes in
this
Author: ericwf
Date: Tue Apr 3 21:33:09 2018
New Revision: 329145
URL: http://llvm.org/viewvc/llvm-project?rev=329145&view=rev
Log:
Update Clang version on Appveyor bots
Modified:
libcxx/trunk/appveyor-reqs-install.cmd
Modified: libcxx/trunk/appveyor-reqs-install.cmd
URL:
http://llvm.org/v
Author: ericwf
Date: Tue Apr 3 21:39:38 2018
New Revision: 329148
URL: http://llvm.org/viewvc/llvm-project?rev=329148&view=rev
Log:
Fix undefined macro issue in locale tests
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/decimal_poi
Author: ericwf
Date: Tue Apr 3 21:48:26 2018
New Revision: 329149
URL: http://llvm.org/viewvc/llvm-project?rev=329149&view=rev
Log:
Fix undefined macro issue in locale tests; Try 2
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money
GorNishanov added a comment.
In https://reviews.llvm.org/D45121#1056408, @lewissbaker wrote:
> The `coroutine_handle` type does not have a
> `from_address()` or a `from_promise()` static functions in the same way that
> the `coroutine_handle` implementation does.
> Is this intentional or an ov
GorNishanov updated this revision to Diff 140903.
GorNishanov added a comment.
incorporated review feedback
https://reviews.llvm.org/D45121
Files:
include/experimental/coroutine
test/std/experimental/language.support/support.coroutines/coroutine.handle/coroutine.handle.noop/noop_coroutine.
Author: ericwf
Date: Tue Apr 3 23:31:21 2018
New Revision: 329151
URL: http://llvm.org/viewvc/llvm-project?rev=329151&view=rev
Log:
Fix typo in ASTStructuralEquivalence.cpp for UnaryTransform types.
Previously UnaryTransformType nodes were comparing the same node
for structural equivalence. This
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2135
+nextToken();
+if (FormatTok->Tok.is(tok::less))
+ NumOpenAngles++;
The UnwrappedLineParser is very much about error recovery. Implemented like
this, it will consume
dberris created this revision.
dberris added reviewers: echristo, devnexen.
Herald added a subscriber: emaste.
This change fixes http://llvm.org/PR36985 to define a single place in
CommonArgs.{h,cpp} where XRay runtime flags and link-time dependencies
are processed for all toolchains that support
lewissbaker added inline comments.
Comment at: include/experimental/coroutine:294
+
+inline _LIBCPP_ALWAYS_INLINE
+noop_coroutine_handle noop_coroutine() _NOEXCEPT {
EricWF wrote:
> This should just be `_LIBCPP_INLINE_VISIBILITY`. We try not to use
> `_LIBCPP_AL
101 - 156 of 156 matches
Mail list logo
