lewissbaker added inline comments.

================
Comment at: include/experimental/coroutine:294
+
+inline _LIBCPP_ALWAYS_INLINE
+noop_coroutine_handle noop_coroutine() _NOEXCEPT {
----------------
EricWF wrote:
> This should just be `_LIBCPP_INLINE_VISIBILITY`. We try not to use 
> `_LIBCPP_ALWAYS_INLINE` in new code.
Should the same change be applied to the other usages of 
`_LIBCPP_ALWAYS_INLINE` in this file?
Should some of them be marked `constexpr` to be consistent with 
`noop_coroutine_handle` member functions above?


https://reviews.llvm.org/D45121



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to