Author: sammccall
Date: Tue Nov 21 10:40:43 2017
New Revision: 318791
URL: http://llvm.org/viewvc/llvm-project?rev=318791&view=rev
Log:
[clangd] Add JSON tests with invalid unicode
Modified:
clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp
Modified: clang-tools-extra/trunk/unittest
Hi Sam,
Your change is causing the PS4 Windows bot to fail because your test includes a
divide by zero exception that the compiler is issuing an error for:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13639/
FAILED:
tools/clang/tools/extra/unittests
Hi Douglas,
Sorry about that! It's an encoding problem, I forgot there were encodings
other than UTF-8 :-)
I'll fix it.
Thanks for the heads up.
On Tue, Nov 21, 2017 at 7:56 PM, Yung, Douglas
wrote:
> Hi Sam,
>
> Your change is causing the PS4 Windows bot to fail because your test
> includes a
Author: sammccall
Date: Tue Nov 21 11:10:22 2017
New Revision: 318793
URL: http://llvm.org/viewvc/llvm-project?rev=318793&view=rev
Log:
[clangd] use u8 strings in tests to avoid problems on windows
Modified:
clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp
Modified: clang-tools-ext
lebedev.ri updated this revision to Diff 123827.
lebedev.ri marked an inline comment as done.
lebedev.ri retitled this revision from "[clang-tidy] Implement
readability-function-cognitive-complexity check" to "[clang-tidy] Implement
sonarsource-function-cognitive-complexity check".
lebedev.ri add
Hi Sam,
Thanks for looking into this. Just to clarify, the real issue is the divide by
zero errors. The encoding related messages are only warnings.
JSONExprTests.cpp(134): error C2124: divide or mod by zero
Douglas Yung
From: Sam McCall [mailto:sam.mcc...@gmail.com]
Sent: Tuesday, November 21
Author: aaronballman
Date: Tue Nov 21 11:22:34 2017
New Revision: 318794
URL: http://llvm.org/viewvc/llvm-project?rev=318794&view=rev
Log:
Add an AST matcher for hasDefaultArgument() to match on parameter declarations
that have a default value.
Patch by Julie Hockett.
Modified:
cfe/trunk/do
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r318794, thank you!
https://reviews.llvm.org/D40261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Tue Nov 21 11:25:38 2017
New Revision: 318796
URL: http://llvm.org/viewvc/llvm-project?rev=318796&view=rev
Log:
The offsetof macro is intended to work with subobjects rather than simple
identifiers designating a member, making the -Wextended-offsetof diagnostic
obsolet
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r318796.
https://reviews.llvm.org/D40267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: niravd
Date: Tue Nov 21 11:28:13 2017
New Revision: 318797
URL: http://llvm.org/viewvc/llvm-project?rev=318797&view=rev
Log:
Avoid unecessary opsize byte in segment move to memory
Segment moves to memory are always 16-bit. Remove invalid 32 and 64
bit variants.
Recommiting with missing c
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated this revision to Diff 123831.
tra added a comment.
Updated CUDA tests
https://reviews.llvm.org/D40275
Files:
clang/lib/Sema/SemaType.cpp
clang/test/SemaCUDA/call-stack-for-deferred-err.cu
clang/test/SemaCUDA/no-call-stack-for-immediate-errs.cu
clang/test/SemaCUDA/vla.cu
In
Author: sammccall
Date: Tue Nov 21 11:37:35 2017
New Revision: 318798
URL: http://llvm.org/viewvc/llvm-project?rev=318798&view=rev
Log:
[clangd] avoid divide by literal zero to satisfy msvc
Modified:
clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp
Modified: clang-tools-extra/trunk
Hi Douglas,
The unicode issue is fixed in r318793 and the div0 in r318798.
Sorry about that!
On Tue, Nov 21, 2017 at 8:20 PM, Yung, Douglas
wrote:
> Hi Sam,
>
>
>
> Thanks for looking into this. Just to clarify, the real issue is the
> divide by zero errors. The encoding related messages are onl
Hi Sam,
Thanks for the quick fixes! Fingers crossed that it all works now!
Douglas Yung
From: Sam McCall [mailto:sam.mcc...@gmail.com]
Sent: Tuesday, November 21, 2017 11:39
To: Yung, Douglas
Cc: cfe-commits
Subject: Re: [clang-tools-extra] r318774 - [clangd] Add parsing and value
inspection to
aaron.ballman added inline comments.
Comment at: lib/AST/ASTImporter.cpp:5622
+ SmallVector ToArgVec;
+ for (auto FromArg : E->getArgs()) {
+TypeSourceInfo *ToTI = Importer.Import(FromArg);
`const auto *`?
Comment at: lib/AST/ASTImporter.
tk1012 added a comment.
Hello Aleksei,
Unfortunately, I find the related problem with the unnamed structs/unions, even
if I apply https://reviews.llvm.org/D39886.
For example, in PostgreSQL, there is a part of code like below.
typedef struct { int a; } b;
struct { const char *x; } y;
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D40242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
mcgrathr added a comment.
test case?
Repository:
rL LLVM
https://reviews.llvm.org/D39831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
oren_ben_simhon marked 8 inline comments as done.
oren_ben_simhon added inline comments.
Comment at: include/clang/Driver/Options.td:1801
def mno_stackrealign : Flag<["-"], "mno-stackrealign">, Group;
+def mno_cet : Flag<["-"], "mno-cet">, Group;
+def mno_shstk : Flag<["-"], "mn
torarnv added a comment.
This seems to have hit a recent Xcode toolchain (Xcode 9.1 ?).
Xcode now complains that "[app name] was compiled with optimization - stepping
may behave oddly; variables may not be available.", when launching a debug
session, which seems to be the case, debugging is all
oren_ben_simhon updated this revision to Diff 123835.
oren_ben_simhon marked an inline comment as done.
oren_ben_simhon added a comment.
Implemented comments posted until 11/20 (Thanks Craig and Erich).
Repository:
rL LLVM
https://reviews.llvm.org/D40224
Files:
include/clang/Basic/Builtins
Yes, unfortnuately, i just have no time these days with my new role. Sorry.
I'm trying to keep up with reviews where i can, but i'm prioritizing those
that are absolutely blocked on me (and trying to hand those off).
On Tue, Nov 21, 2017 at 11:11 AM, Roman Lebedev via Phabricator <
revi...@revie
phosek updated this revision to Diff 123838.
phosek added a comment.
Added a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D39831
Files:
cmake/caches/Fuchsia-stage2.cmake
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Driver/
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D39831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
phosek created this revision.
Use this source use on Fuchsia where this is the officially way
to obtain randomness. This could be also used on other platforms
that already support getentropy such as *BSD or Linux.
Repository:
rL LLVM
https://reviews.llvm.org/D40319
Files:
include/__config
Petr Hosek via Phabricator writes:
> -# This is a "Does your linker support it?" option that only applies
> -# to x86-64 ELF targets. All Fuchsia target linkers do support it.
> -# For x86-64 Linux, it's supported by LLD and by GNU linkers since
> -# binutils 2.27, so one can hope that all Linu
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D40319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: bion
Date: Tue Nov 21 13:37:26 2017
New Revision: 318804
URL: http://llvm.org/viewvc/llvm-project?rev=318804&view=rev
Log:
Change (void) casts to TEST_IGNORE_NODISCARD, as requested by Eric. Reviewed as
https://reviews.llvm.org/D40065
Modified:
libcxx/trunk/test/std/algorithms/alg.n
BillyONeal closed this revision.
BillyONeal added a comment.
Committed r318804
https://reviews.llvm.org/D40065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo added a comment.
No objection from me about committing this now, although I have some minor
comments (that possibly can be taken care of without reposting and
re-reviewing). Still ok with @rnk?
Comment at: lib/Frontend/InitPreprocessor.cpp:686
+ else if ((TI.getTrip
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Yep, looks good
Repository:
rL LLVM
https://reviews.llvm.org/D39673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Nebiroth updated this revision to Diff 123848.
Nebiroth added a comment.
Removed some commented lines and temporary code
Streamlined and removed some code that overlaps/conflicts with code hover patch
so it's easier to merge (patch https://reviews.llvm.org/D35894)
https://reviews.llvm.org/D3842
I kept the CMake option, so by default the driver will use the value set
through CMake as before but individual targets can now set their platform
default.
On Tue, Nov 21, 2017 at 1:30 PM Rafael Avila de Espindola <
rafael.espind...@gmail.com> wrote:
> Petr Hosek via Phabricator writes:
>
>
> >
Author: bion
Date: Tue Nov 21 14:16:57 2017
New Revision: 318808
URL: http://llvm.org/viewvc/llvm-project?rev=318808&view=rev
Log:
Add missing test_macros.h inclusion.
Modified:
libcxx/trunk/test/std/re/re.grammar/excessive_brace_count.pass.cpp
Modified: libcxx/trunk/test/std/re/re.grammar/e
v.g.vassilev added a comment.
For the record: relanded in r306903.
https://reviews.llvm.org/D29951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo created this revision.
One can't replace vsscanf(_l) with a sscanf(_l) that doesn't take a va_list.
This has been untouched since it was added in SVN r140728, so apparently it
hasn't been used since. One reason for this mistake originally might have been
that there was no _vsscanf_l un
Author: aaronballman
Date: Tue Nov 21 14:24:13 2017
New Revision: 318809
URL: http://llvm.org/viewvc/llvm-project?rev=318809&view=rev
Log:
Silence some MSVC warnings about not all control paths returning a value; NFC.
Modified:
clang-tools-extra/trunk/clangd/JSONExpr.cpp
clang-tools-extra
Author: mstorsjo
Date: Tue Nov 21 14:41:15 2017
New Revision: 318810
URL: http://llvm.org/viewvc/llvm-project?rev=318810&view=rev
Log:
Remove a broken win32 locale function redirection
One can't replace vsscanf(_l) with a sscanf(_l) that doesn't
take a va_list.
This has been untouched since it w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318810: Remove a broken win32 locale function redirection
(authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D40323?vs=123851&id=123852#toc
Repository:
rL LLVM
https://reviews
BillyONeal created this revision.
In a17cd7c641c34b6c4bd4845a4d4fb590cb6c238c Marshall added assert(true) to the
vector::size tests, which break on C1XX:
D:\Contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(62):
error C2220: warning treat
Author: rtrieu
Date: Tue Nov 21 14:53:19 2017
New Revision: 318811
URL: http://llvm.org/viewvc/llvm-project?rev=318811&view=rev
Log:
[OpenMP] Fix tests after r318789
Update use of __tgt_target that had some 32bit types updated to 64bit.
Modified:
cfe/trunk/test/OpenMP/teams_distribute_parall
Author: bion
Date: Tue Nov 21 15:03:02 2017
New Revision: 318812
URL: http://llvm.org/viewvc/llvm-project?rev=318812&view=rev
Log:
Replace assert(true) in tests with actual asserts. Reviewed as
https://reviews.llvm.org/D40324
In a17cd7c641c34b6c4bd4845a4d4fb590cb6c238c Marshall added assert(true
BillyONeal closed this revision.
BillyONeal added a comment.
Committed r318812
https://reviews.llvm.org/D40324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett added a comment.
We're going to go with fuchsia-* for the module name, since the style applies
to the broader project. Also, there may be zircon-specific checks at some
point, so we want to leave the door open for that.
Comment at: clang-tidy/fuchsia/DefaultArgum
juliehockett updated this revision to Diff 123857.
juliehockett marked 6 inline comments as done.
juliehockett added a comment.
Disabled the fix-it for `getDefaultArgRange()` that returns an empty range and
for default args that come from a macro.
https://reviews.llvm.org/D40108
Files:
clang
Hi,
these failures were probably introduced by r318789, Richard Trieu should
have fixed them in r318811.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/20991
is already green ;-)
Jonas
Am 2017-11-21 17:37, schrieb Yung, Douglas via cfe-commits:
Hi Carlo,
I am probably missing something, but the patch has
-# This is a "Does your linker support it?" option that only applies
-# to x86-64 ELF targets. All Fuchsia target linkers do support it.
-# For x86-64 Linux, it's supported by LLD and by GNU linkers since
-# binutils 2.27, so one can hope that al
Wizard updated this revision to Diff 123860.
Wizard added a comment.
add doc to header file
https://reviews.llvm.org/D40325
Files:
clang-tidy/objc/AvoidSpinlockCheck.cpp
clang-tidy/objc/AvoidSpinlockCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTidyModule.cpp
docs/Release
Author: eugenezelenko
Date: Tue Nov 21 15:26:08 2017
New Revision: 318813
URL: http://llvm.org/viewvc/llvm-project?rev=318813&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/DeclarationName.h
That's the Fuchsia CMake cache file which is used to build Fuchsia
toolchain, it's not needed there anymore because Fuchsia Clang driver now
handles this. I haven't touched Clang's CMakeLists.txt which defines
the ENABLE_X86_RELAX_RELOCATIONS option.
On Tue, Nov 21, 2017 at 3:14 PM Rafael Avila de
Hi Douglas
Thanks for letting me know - I was not notified by bbot about this.
Thanks to Jonas too. I will keep looking at the bbot to see if this resurfaces.
Thanks!
-- Carlo
- Original message -From: Jonas Hahnfeld To: "Yung, Douglas" Cc: Carlo Bertolli , cfe-commits Subject: Re:
Petr Hosek writes:
> That's the Fuchsia CMake cache file which is used to build Fuchsia
> toolchain, it's not needed there anymore because Fuchsia Clang driver now
> handles this. I haven't touched Clang's CMakeLists.txt which defines
> the ENABLE_X86_RELAX_RELOCATIONS option.
Oops, I guess I sh
craig.topper updated this revision to Diff 123862.
craig.topper retitled this revision from "[Target] Keep the TargetOptions
feature list sorted instead of sorting during CodeGen" to "[Target] Make a copy
of TargetOptions feature list before sorting during CodeGen".
craig.topper edited the summar
Author: erichkeane
Date: Tue Nov 21 16:54:01 2017
New Revision: 318815
URL: http://llvm.org/viewvc/llvm-project?rev=318815&view=rev
Log:
[X86] Update CPUSupports code to reuse LLVM .def file [NFC]
Modified:
cfe/trunk/lib/Basic/Targets/X86.cpp
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified:
mclow.lists added a comment.
D'Oh - that was a paste that went wrong.
You are correct that `assert(c.size() == 3)` is correct.
However, what I was *trying* to fix were the lines before.
Pushing a `3` into a `vector` is not the best idea L#34 and L#53 should
both read `c.push_back(true);`
https
Author: phosek
Date: Tue Nov 21 17:38:31 2017
New Revision: 318816
URL: http://llvm.org/viewvc/llvm-project?rev=318816&view=rev
Log:
[Driver] Make the use of relax relocations a per target option
The support for relax relocations is dependent on the linker and
different toolchains within the same
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318816: [Driver] Make the use of relax relocations a per
target option (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D39831?vs=123838&id=123870#toc
Repository:
rL LLVM
http
dcoughlin added a comment.
For clang itself I think we also use a stage-2 clang to build the same version
of clang and make sure that it matches the stage-2 clang. This doesn't help for
the analyzer though.
Repository:
rL LLVM
https://reviews.llvm.org/D40073
_
We have a buildbot setup to uncover such cases of non-determinism:
http://lab.llvm.org:8011/builders/reverse-iteration
The idea is to iterate unordered containers in reverse to weed out
pointer ordering issues.
Another instance of non-determinism is relative ordering of elements
with the sam
EricWF added inline comments.
Comment at: include/new:274
+{
+return __launder(__p);
+}
The call should probably be qualified to `_VSTD::__launder`.
Comment at:
test/std/language.support/support.dynamic/ptr.launder/launder.nodiscard.fail.c
phosek created this revision.
Herald added a subscriber: mgorny.
It's used to determine whether terminal supports colors, but within LLVM
it's only used in handful of places and in Clang it's only used in AST
dumper, otherwise Clang relies on the -fcolor-diagnostics flag which we
pass explicitly f
mclow.lists added inline comments.
Comment at:
test/std/language.support/support.dynamic/ptr.launder/launder.nodiscard.fail.cpp:16
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
+// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7,
clang-3.8
+
EricWF added inline comments.
Comment at:
test/std/language.support/support.dynamic/ptr.launder/launder.nodiscard.fail.cpp:16
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
+// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7,
clang-3.8
+
mclow.lists updated this revision to Diff 123877.
mclow.lists added a comment.
`_VSTD::` qualify the call to `__launder`.
De-dup error messages in test.
https://reviews.llvm.org/D40144
Files:
include/__config
include/new
test/std/language.support/support.dynamic/ptr.launder/launder.nodis
glenjofe added a comment.
Thanks Eric. Can you commit on my behalf?
https://reviews.llvm.org/D35470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper added inline comments.
Comment at: include/clang/Basic/BuiltinsX86_64.def:63
TARGET_BUILTIN(__builtin_ia32_xsaves64, "vv*ULLi", "", "xsaves")
+TARGET_BUILTIN(__builtin_ia32_incsspq, "vULLi","u","shstk")
+TARGET_BUILTIN(__builtin_ia32_rdsspq, "ULLiULLi","Un","shstk")
Author: marshall
Date: Tue Nov 21 22:02:27 2017
New Revision: 318818
URL: http://llvm.org/viewvc/llvm-project?rev=318818&view=rev
Log:
Add some tests for operations on const associative containers. Part of LWG#2542
Modified:
libcxx/trunk/test/std/containers/associative/map/map.cons/compare.pa
nik added a comment.
Ping
https://reviews.llvm.org/D40072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 170 of 170 matches
Mail list logo
