aaron.ballman added inline comments.
================
Comment at: lib/AST/ASTImporter.cpp:5622
+ SmallVector<TypeSourceInfo *, 4> ToArgVec;
+ for (auto FromArg : E->getArgs()) {
+ TypeSourceInfo *ToTI = Importer.Import(FromArg);
----------------
`const auto *`?
================
Comment at: lib/AST/ASTImporter.cpp:5631
+ // Value is always false.
+ bool ToValue = (!E->isValueDependent()) ? E->getValue() : false;
+
----------------
Remove spurious parens.
================
Comment at: unittests/AST/ASTImporterTest.cpp:548
+ typeTraitExpr(hasType(asString("int")))))))));
+}
----------------
Please add a value-dependent test as well.
https://reviews.llvm.org/D39722
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
