Author: bion
Date: Tue Nov 21 15:03:02 2017
New Revision: 318812
URL: http://llvm.org/viewvc/llvm-project?rev=318812&view=rev
Log:
Replace assert(true) in tests with actual asserts. Reviewed as
https://reviews.llvm.org/D40324
In a17cd7c641c34b6c4bd4845a4d4fb590cb6c238c Marshall added assert(true) to the
vector<bool>::size tests, which break on C1XX:
D:\Contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(62):
error C2220: warning treated as error - no 'object' file generated
d:\contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(33)
: warning C6326: Potential comparison of a constant with another constant.
d:\contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(52)
: warning C6326: Potential comparison of a constant with another constant.
The corresponding test for vector::size asserts assert(c.size() == 3);, so I
changed it to do that here.
Modified:
libcxx/trunk/test/std/containers/sequences/vector.bool/size.pass.cpp
Modified: libcxx/trunk/test/std/containers/sequences/vector.bool/size.pass.cpp
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/containers/sequences/vector.bool/size.pass.cpp?rev=318812&r1=318811&r2=318812&view=diff
==============================================================================
--- libcxx/trunk/test/std/containers/sequences/vector.bool/size.pass.cpp
(original)
+++ libcxx/trunk/test/std/containers/sequences/vector.bool/size.pass.cpp Tue
Nov 21 15:03:02 2017
@@ -31,7 +31,7 @@ int main()
c.push_back(true);
assert(c.size() == 2);
c.push_back(C::value_type(3));
- assert(true);
+ assert(c.size() == 3);
c.erase(c.begin());
assert(c.size() == 2);
c.erase(c.begin());
@@ -50,7 +50,7 @@ int main()
c.push_back(true);
assert(c.size() == 2);
c.push_back(C::value_type(3));
- assert(true);
+ assert(c.size() == 3);
c.erase(c.begin());
assert(c.size() == 2);
c.erase(c.begin());
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
