sabel83 updated this revision to Diff 122324.
https://reviews.llvm.org/D38818
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/clang/Sema/Sema.h
include/clang/Sema/Tem
sabel83 marked an inline comment as done.
sabel83 added a comment.
I have moved the tests into their own directory in the last update.
Comment at: tools/CMakeLists.txt:37
add_clang_subdirectory(libclang)
+add_subdirectory(templight)
rsmith wrote:
> Did you mea
AlexVlx marked 2 inline comments as done.
AlexVlx added inline comments.
Comment at: include/clang/Basic/Attr.td:1328
+ ExprArgument<"Max", 1>,
StringArgument<"ISA", 1>];
let Documentation = [AMDGPUFlatWorkGroupSizeDocs];
kzhuravl w
sabel83 marked an inline comment as done.
sabel83 added a comment.
The last update of the patch also contains the changes to this pull request
based on comments from https://reviews.llvm.org/D5767.
https://reviews.llvm.org/D38818
___
cfe-commits ma
AlexVlx marked an inline comment as done.
AlexVlx added a comment.
In https://reviews.llvm.org/D39857#920814, @kzhuravl wrote:
> Hi Alex, can you rebase on top of trunk (I think you brought in some extra
> changes from hcc branch) and upload a full diff?
Hello Konstantine - apologies about tha
sabel83 updated this revision to Diff 122325.
sabel83 marked an inline comment as done.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/c
sabel83 added a comment.
In https://reviews.llvm.org/D5767#920085, @rsmith wrote:
> I'm not entirely sure what's happening with this and
> https://reviews.llvm.org/D38818, but the direction looks good to me, and I
> left a couple of comments on the other review thread.
This was the original p
Author: sammccall
Date: Thu Nov 9 13:45:27 2017
New Revision: 317838
URL: http://llvm.org/viewvc/llvm-project?rev=317838&view=rev
Log:
[clangd] Fix compilation database detection
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
Modified: clang-tools-extra/trunk/clangd/
george.karpenkov added a comment.
> I'm curious if the crash would turn into an assertion failure during
> getRawSVal() after https://reviews.llvm.org/D38801 is committed.
I guess we would see?
> If this problem is fixed on the checker side (it probably should be - the
> checker , we can proba
Author: george.karpenkov
Date: Thu Nov 9 13:49:38 2017
New Revision: 317839
URL: http://llvm.org/viewvc/llvm-project?rev=317839&view=rev
Log:
[analyzer] do not crash when trying to convert an APSInt to an unexpected type
This is the issue breaking the postgresql bot, purely by chance exposed
thr
AlexVlx updated this revision to Diff 122327.
https://reviews.llvm.org/D39857
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Index: lib/Sema/SemaDeclAttr.cpp
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317839: [analyzer] do not crash when trying to convert an
APSInt to an unexpected type (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39862?vs=122306&id=122328#toc
R
jdenny updated this revision to Diff 122329.
jdenny added a comment.
Hi Alexey. Thanks for your comments. This update should address them all.
https://reviews.llvm.org/D39859
Files:
lib/Sema/SemaExpr.cpp
test/OpenMP/parallel_firstprivate_messages.cpp
Index: test/OpenMP/parallel_firstpri
francisco.lopes added a comment.
I'm still in the process of construction a general jsonrpc client and didn't
start consuming clangd yet. But, I do have previous experience with libclang,
and I don't know whether clangd will be able to return completion results at
global scope (not necessarily
sammccall added a comment.
In https://reviews.llvm.org/D39738#921103, @francisco.lopes wrote:
> I'm still in the process of construction of a general jsonrpc/LSP client and
> didn't start consuming clangd yet.
If you concerns about clangd's responsiveness, I recommend testing using
VSCode, wh
francisco.lopes added a comment.
OK. I do agree serialization, etc, is a stumbling block on delivering large
results fast. I just wanted to warn on this because I've just seen ycmd devs
went through this, where sorting was one of the bottlenecks, like, to
`std::sort` 43k results instead of simp
nathawes planned changes to this revision.
nathawes added a comment.
In https://reviews.llvm.org/D39050#920451, @ioeric wrote:
> In https://reviews.llvm.org/D39050#900830, @arphaman wrote:
>
> > I think this patch should be split into a number of smaller patches to help
> > the review process.
>
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Yes, looks great. Thanks!
https://reviews.llvm.org/D39584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
sammccall updated this revision to Diff 122342.
sammccall added a comment.
Oops, sorting was backwards (test caught it, but I forgot to run it)
https://reviews.llvm.org/D39852
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/
dberris planned changes to this revision.
dberris added a comment.
In https://reviews.llvm.org/D39114#920591, @kubamracek wrote:
> > When linking the final binary, the XRay runtime can't seem to find the
> > `__{start,stop}_xray_{fn_idx,instr_map}` symbols. I've marked them weak,
> > but they s
Author: george.karpenkov
Date: Thu Nov 9 15:33:37 2017
New Revision: 317849
URL: http://llvm.org/viewvc/llvm-project?rev=317849&view=rev
Log:
[analyzer] [NFC] Minor ExprEngineC refactoring
Move a repeated block of code into a function.
Differential Revision: https://reviews.llvm.org/D39584
Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317849: [analyzer] [NFC] Minor ExprEngineC refactoring
(authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39584?vs=121814&id=122345#toc
Repository:
rL LLVM
https://re
jlebar added a comment.
I abdicate as a reviewer in favor of tra -- if he's happy, I'm happy.
https://reviews.llvm.org/D39502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dberris updated this revision to Diff 122352.
dberris retitled this revision from "[XRay] Initial XRay in Darwin Support" to
"[XRay][darwin] Initial XRay in Darwin Support".
dberris edited the summary of this revision.
dberris removed subscribers: echristo, pelikan.
dberris added a comment.
This r
kzhuravl created this revision.
Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng.
https://reviews.llvm.org/D39877
Files:
lib/Driver/ToolChains/AMDGPU.cpp
lib/Driver/ToolChains/AMDGPU.h
lib/Driver/ToolChains/Clang.cpp
Index: lib/Driver/ToolChains/Clang.cpp
==
kzhuravl created this revision.
Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng.
https://reviews.llvm.org/D39878
Files:
include/clang/Driver/Options.td
test/Driver/amdgpu-features.c
Index: test/Driver/amdgpu-features.c
===
kzhuravl created this revision.
Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng.
https://reviews.llvm.org/D39879
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/AMDGPU.cpp
test/Driver/amdgpu-features.c
Index: test/Driver/amdgpu-features.c
tra added inline comments.
Comment at: test/Driver/cuda-bail-out.cu:47
+// CHECK-HOST-ERROR: Error during compilation for host
+// CHECK-HOST-ERROR-NOT: Error during compilation for sm_35
steven_wu wrote:
> tra wrote:
> > steven_wu wrote:
> > > tra wrote:
> > > >
hfinkel added a comment.
In https://reviews.llvm.org/D39611#918654, @hfinkel wrote:
> In https://reviews.llvm.org/D39611#918275, @spatel wrote:
>
> > Patch updated:
> > I don't know if we have agreement on the behavior that we want yet,
>
>
> I just sent a note to the Austin group mailing list t
steven_wu added inline comments.
Comment at: test/Driver/cuda-bail-out.cu:47
+// CHECK-HOST-ERROR: Error during compilation for host
+// CHECK-HOST-ERROR-NOT: Error during compilation for sm_35
tra wrote:
> steven_wu wrote:
> > tra wrote:
> > > steven_wu wrote:
>
vsk updated this revision to Diff 122368.
vsk edited the summary of this revision.
vsk added a comment.
- Consider logical nots and some binary comparison operators in the hash, per
an offline conversation with @bogner
https://reviews.llvm.org/D39446
Files:
lib/CodeGen/CodeGenPGO.cpp
test/
steven_wu updated this revision to Diff 122372.
steven_wu added a comment.
I think I understand what you mean now. You want some cases when the
compilation doesn't failed on the first source it process.
I add a testcase which compiles for host + sm_35 + sim_60. I run the test
3 times and each tim
sammccall created this revision.
This allows us to limit the number of results we return and still allow them
to be surfaced by refining a query (https://reviews.llvm.org/D39852).
The initial algorithm is very conservative - it accepts a completion if the
filter is any case-insensitive sub-sequen
tra added inline comments.
Comment at: test/Driver/cuda-bail-out.cu:47
+// CHECK-HOST-ERROR: Error during compilation for host
+// CHECK-HOST-ERROR-NOT: Error during compilation for sm_35
steven_wu wrote:
> tra wrote:
> > steven_wu wrote:
> > > tra wrote:
> > > >
Author: eugenezelenko
Date: Thu Nov 9 16:59:22 2017
New Revision: 317854
URL: http://llvm.org/viewvc/llvm-project?rev=317854&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/ASTUnresolvedSet.h
steven_wu updated this revision to Diff 122376.
steven_wu added a comment.
Add more tests! The new tests can trigger two errors during the compilation
but only one should be emitted.
https://reviews.llvm.org/D39502
Files:
lib/Driver/Compilation.cpp
test/Driver/cuda-bail-out.cu
test/Driver
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM for CUDA-related functionality & tests. Thank you for the patch!
https://reviews.llvm.org/D39502
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: steven_wu
Date: Thu Nov 9 17:32:47 2017
New Revision: 317860
URL: http://llvm.org/viewvc/llvm-project?rev=317860&view=rev
Log:
[Driver] Make clang/cc conforms to UNIX standard
Summary:
This is basically reverting r261774 with a tweak for clang-cl. UNIX
standard states:
When c99 encounter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317860: [Driver] Make clang/cc conforms to UNIX standard
(authored by steven_wu).
Repository:
rL LLVM
https://reviews.llvm.org/D39502
Files:
cfe/trunk/lib/Driver/Compilation.cpp
cfe/trunk/test/Dri
On Nov 9, 2017, at 12:13, Reimar Döffinger wrote:
>
> Hello!
>
> On Wed, Nov 08, 2017 at 12:36:00PM -0800, Volodymyr Sapsai wrote:
>> Thanks for the patch, Reimar. Can you please add tests to ensure this
>> functionality doesn’t regress? As null character is required by the standard
>> (27.7.2
jakehehrlich updated this revision to Diff 122382.
jakehehrlich added a comment.
fixed typo
Repository:
rL LLVM
https://reviews.llvm.org/D39821
Files:
CMakeLists.txt
include/clang/Config/config.h.cmake
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
=
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1502-1503
+evaluated at compile-time;
+ - A dependent integral value which depends on one or more template arguments,
+be they type or non-type e.g. ``sizeof(T)`` within the scope of
+``
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/CopyConstructorInitCheck.cpp:69
+ (Ctor->getAccess() == AS_private || Ctor->isDeleted())) {
+NonCopyableBase = true;
+break;
xazax.hun wrote:
> aaron.ballman wrote:
> > What
tk1012 created this revision.
This patch fixes wrong conflict detections for unnamed structures.
Current ASTImporter mistakenly identifies two different unnamed structs as the
same one.
This is because ASTImporter checks the name of each RecordDecl for the conflict
identification and the both of
Author: ctopper
Date: Thu Nov 9 21:20:32 2017
New Revision: 317873
URL: http://llvm.org/viewvc/llvm-project?rev=317873&view=rev
Log:
[X86] Reduce the number of FMA builtins needed by the frontend by adding
negates to operands of the fmadd and fmaddsub builtins.
The backend should be able to com
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: dberris
Date: Thu Nov 9 21:50:13 2017
New Revision: 317875
URL: http://llvm.org/viewvc/llvm-project?rev=317875&view=rev
Log:
[XRay][darwin] Initial XRay in Darwin Support
Summary:
This change implements the changes required in both clang and
compiler-rt to allow building XRay-instrumente
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317875: [XRay][darwin] Initial XRay in Darwin Support
(authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D39114?vs=122352&id=122391#toc
Repository:
rL LLVM
https://reviews.llvm
kubamracek added inline comments.
Comment at: compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S:75
- .globl __xray_FunctionEntry
+ .globl ASM_TSAN_SYMBOL(__xray_FunctionEntry)
.align 16, 0x90
Since we want to use `ASM_TSAN_SYMBOL` outside
dberris added a comment.
Landing now, will deal with the test and dynamic/
Comment at: compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S:75
- .globl __xray_FunctionEntry
+ .globl ASM_TSAN_SYMBOL(__xray_FunctionEntry)
.align 16, 0x90
kuba
Author: dberris
Date: Thu Nov 9 23:00:55 2017
New Revision: 317877
URL: http://llvm.org/viewvc/llvm-project?rev=317877&view=rev
Log:
Revert "[XRay][darwin] Initial XRay in Darwin Support"
This reverts r317875.
Modified:
cfe/trunk/include/clang/Driver/XRayArgs.h
cfe/trunk/lib/Driver/Tool
dberris added a comment.
Reverted in https://reviews.llvm.org/rL317877 -- I'm going to try again next
week instead.
Repository:
rL LLVM
https://reviews.llvm.org/D39114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
NoQ added a comment.
In https://reviews.llvm.org/D39862#921075, @george.karpenkov wrote:
> Of course I'm new, but I disagree with this statement: in order to have a
> robust API, the function should not crash, unless the caller violates an
> explicit precondition.
> `getSVal` is just a functio
Quolyk updated this revision to Diff 122395.
Quolyk retitled this revision from "[clangd][WIP] -foptimization-record-file=
should imply -fsave-optimization-record" to "[clangd]
-foptimization-record-file= should imply -fsave-optimization-record".
Quolyk added a comment.
Added 1 test, I guess it'
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
> these kinds of tasks should have the same level of attention as others
Dunno really. I'm not sure anybody actually reads that doc instead of
accidentally finding the checker code by debugging how
101 - 156 of 156 matches
Mail list logo
