dberris planned changes to this revision.
dberris added a comment.
In https://reviews.llvm.org/D39114#920591, @kubamracek wrote:
> > When linking the final binary, the XRay runtime can't seem to find the
> > `__{start,stop}_xray_{fn_idx,instr_map}` symbols. I've marked them weak,
> > but they seem to either not be resolved when statically linking the binary.
> > The dynamic lib version of the XRay runtime isn't quite ready yet, but I'm
> > willing to try some things there.
> > There are also missing symbols from the sanitizer_common library that's
> > linked to from the `libclang_rt.xray_osx.a` produced by the compiler-rt
> > XRay build configuration.
> > Any further hints/thoughts on this would be great, @kubamracek (cc
> > @pelikan and @echristo)
>
> This is one of the reasons why a dynamic shared library works better. Using a
> dynamic library should solve this. What are the problems with that?
Nothing fundamentally wrong with doing that, except for the clang changes to
link correctly (which I still need to experiment with). Let me go that route
and report back.
I'll also split the patch up into smaller bits. The changes to the tests can be
a separate change. I'll back those out and re-upload.
Thanks!
https://reviews.llvm.org/D39114
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
