Author: jbcoe
Date: Wed Sep 6 00:33:32 2017
New Revision: 312622
URL: http://llvm.org/viewvc/llvm-project?rev=312622&view=rev
Log:
Fix __repr__ for Diagnostic in clang.cindex
Summary: Also move misplaced tests for exception specification to fix failing
Python tests.
Reviewers: hans, compnerd
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312622: Fix __repr__ for Diagnostic in clang.cindex
(authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D37490?vs=113896&id=113966#toc
Repository:
rL LLVM
https://reviews.llvm.org
Fine to remove it if it didn't change the test - it just wasn't clear to me
what exactly was being tested at the time so it was more "does this test
still work with/without -disable-llvm-passes".
No worries.
On Tue, Sep 5, 2017 at 10:58 PM Karl-Johan Karlsson via Phabricator <
revi...@reviews.llv
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D30295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added a comment.
In https://reviews.llvm.org/D37474#861206, @cameron314 wrote:
> I suppose we could do the overlay manually in all the tests that need it; I
> guess it depends on what the goal of the VFS support is. To my mind, it
> doesn't make sense that a file is placed in the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312623: Debug info: Fixed faulty debug locations for
attributed statements (authored by karka).
Changed prior to commit:
https://reviews.llvm.org/D37428?vs=113803&id=113968#toc
Repository:
rL LLVM
h
danielmarjamaki updated this revision to Diff 113969.
danielmarjamaki added a comment.
minor code cleanup
Repository:
rL LLVM
https://reviews.llvm.org/D36471
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
lib/StaticAnalyzer/Core/ExprEngineC.cpp
lib/StaticAna
danielmarjamaki added a comment.
This is not committed as far as I see.. do you have write permission or do you
want that I commit it?
https://reviews.llvm.org/D28148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
ilya-biryukov removed a reviewer: cfe-commits.
ilya-biryukov added subscribers: cfe-commits, klimek, bkramer.
ilya-biryukov added a comment.
- How are various preprocessor offests (and `SourceLocation` offsets) are
calculated? Do they account for `BOM` presence and ignore it?
- Are there potentia
minseong.kim added a comment.
I have updated the description with a hope for it to be more descriptive.
Kindly ping~
https://reviews.llvm.org/D35533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ioeric added inline comments.
Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:43
+class LocalRename : public RefactoringAction {
+ StringRef getCommand() const override { return "local-rename"; }
+
Shouldn't these be public?
Comm
arphaman added inline comments.
Comment at: tools/clang-refactor/ClangRefactor.cpp:103
+IsSelectionParsed = true;
+// FIXME: Support true selection ranges.
+StringRef Value = *Selection;
ioeric wrote:
> Is the test selection temporary before we have t
PriMee updated this revision to Diff 113979.
PriMee added a comment.
Diff file again updated. Created against the newest commit.
https://reviews.llvm.org/D37140
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
PriMee added inline comments.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:286
}
+if (TheLine->Last->is(tok::l_brace) &&
+TheLine->First != TheLine->Last &&
PriMee wrote:
> krasimir wrote:
> > No tests fail if this `if` statement gets remove
arphaman updated this revision to Diff 113981.
arphaman marked 3 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D36574
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
include/clang/Tooling/Refactoring/Refact
ilya-biryukov added a comment.
Looks good, just one major drawback to address. We shouldn't break clients by
default (see comment in `ClangdMain.cpp`).
And a minor comment about flag naming.
Comment at: clangd/tool/ClangdMain.cpp:30
+static llvm::cl::opt
+DisableSnippets("
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
One nit, otherwise LGTM! Thanks for fixing this!
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:938
llvm::APSInt Multiplicand(rightI.getBitWidth(), /*
brad.king abandoned this revision.
brad.king added a comment.
@rsmith thanks.
> If a node is not marked invalid, that does not imply the corresponding source
> code is valid.
Okay, that clears up my understanding.
> hook into the start and end of creating a function (so you can install your
>
Author: karka
Date: Wed Sep 6 03:12:32 2017
New Revision: 312627
URL: http://llvm.org/viewvc/llvm-project?rev=312627&view=rev
Log:
Corrected testcase to work with release build
The fault was introduced in r312623
Modified:
cfe/trunk/test/CodeGen/debug-info-attributed-stmt.c
Modified: cfe/t
Author: karka
Date: Wed Sep 6 01:47:18 2017
New Revision: 312623
URL: http://llvm.org/viewvc/llvm-project?rev=312623&view=rev
Log:
Debug info: Fixed faulty debug locations for attributed statements
Summary:
As the attributed statements are considered simple statements no
stoppoint was generated
NoQ added a comment.
I've seen this recently, and while i agree that the fix is correct, i'm not
entirely sure that the test cases are correct. As weird as this may sound, null
dereference is not an attempt to read from or write to memory address 0.
Instead, it is about using a null pointer as
LuMa created this revision.
Current description of flag AllowAllParametersOfDeclarationOnNextLine in
Clang-Format Style Options guide suggests that it is possible to format
function declaration, which fits in a single line (what is not supported in
current clang-format version). Also example is
ioeric added inline comments.
Comment at: tools/clang-refactor/ClangRefactor.cpp:103
+IsSelectionParsed = true;
+// FIXME: Support true selection ranges.
+StringRef Value = *Selection;
arphaman wrote:
> ioeric wrote:
> > Is the test selection temporar
r.stahl added a comment.
To be honest I was quite surprised that this change in behavior didn't cause
more test failures, because for detecting null dereferences the old behavior is
definitely more useful. Since it did not, I was convinced that this change is
desired.
We use the analyzer for f
johannes added a comment.
@teemperor ok for you? did phabricator make you a blocking reviewer because of
the affected code, or did I do that somehow?
https://reviews.llvm.org/D37383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
LuMa updated this revision to Diff 113995.
https://reviews.llvm.org/D37513
Files:
docs/ClangFormatStyleOptions.rst
Index: docs/ClangFormatStyleOptions.rst
===
--- docs/ClangFormatStyleOptions.rst
+++ docs/ClangFormatStyleOptions.
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
@johannes The blocking reviewer is because it touches clone detection code :)
Fine with me, I have some comments on things but nothing that affects this
review. LGTM!
https://reviews.l
Author: krobelus
Date: Wed Sep 6 06:11:13 2017
New Revision: 312631
URL: http://llvm.org/viewvc/llvm-project?rev=312631&view=rev
Log:
[AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor
Summary:
We need to specialize this because RecursiveASTVisitor visits template
template parameter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312631: [AST] Traverse templates in
LexicallyOrderedRecursiveASTVisitor (authored by krobelus).
Repository:
rL LLVM
https://reviews.llvm.org/D36998
Files:
cfe/trunk/include/clang/AST/LexicallyOrdere
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312633: [AST] Traverse CXXOperatorCallExpr in
LexicallyOrderedRecursiveASTVisitor (authored by krobelus).
Changed prior to commit:
https://reviews.llvm.org/D37200?vs=112951&id=113999#toc
Repository:
Author: krobelus
Date: Wed Sep 6 06:12:11 2017
New Revision: 312633
URL: http://llvm.org/viewvc/llvm-project?rev=312633&view=rev
Log:
[AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor
Summary:
This affects overloaded operators, which are represented by a
CXXOperatorCallEx
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/tool/run-clang-tidy.py:155
args.quiet)
-sys.stdout.write(' '.join(invocation) + '\n')
+sys.
LuMa updated this revision to Diff 113998.
https://reviews.llvm.org/D37513
Files:
docs/ClangFormatStyleOptions.rst
Index: docs/ClangFormatStyleOptions.rst
===
--- docs/ClangFormatStyleOptions.rst
+++ docs/ClangFormatStyleOptions.
Author: krobelus
Date: Wed Sep 6 06:20:51 2017
New Revision: 312634
URL: http://llvm.org/viewvc/llvm-project?rev=312634&view=rev
Log:
[AST] Add TableGen for StmtDataCollectors
Summary:
This adds an option "-gen-clang-data-collectors" to the Clang TableGen
that is used to generate StmtDataCollect
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312634: [AST] Add TableGen for StmtDataCollectors (authored
by krobelus).
Changed prior to commit:
https://reviews.llvm.org/D37383?vs=113547&id=114000#toc
Repository:
rL LLVM
https://reviews.llvm.or
djasper added a comment.
Note that these changes need to be made to the corresponding comments in
include/clang/Format/Format.h and then this file is auto-generated with
docs/tools/dump_format_style.py.
Comment at: docs/ClangFormatStyleOptions.rst:274
**AllowAllParametersOfD
ilya-biryukov added a comment.
See my comments.
Could you also `clang-format` the code please?
Comment at: clangd/ClangdServer.cpp:150
bool RunSynchronously,
+ std::string CompileCommands,
llvm::O
hintonda added a comment.
Now that 36971 has been committed, I believe you can just remove the
`find_first_existing_file` and `find_first_existing_vc_file` macro definitions
from this file.
https://reviews.llvm.org/D35533
___
cfe-commits mailing l
Eugene.Zelenko added a comment.
I think CMake output is good model for run-clang-tidy.
https://reviews.llvm.org/D37479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cameron314 added a comment.
Thanks for the response!
> How are various preprocessor offests (and SourceLocation offsets) are
> calculated? Do they account for BOM presence and ignore it?
Everything is in byte offsets; the `SourceLocation` after the BOM is not the
same as before the BOM. The le
cameron314 added a comment.
I'll change the overlay to only allow access to the PCH.
I agree that it would be nice to only read the PCH using real filesystem APIs
in order to be symmetrical, but this seems non-trivial. It also feels like a
step in the wrong direction -- ideally the VFS would ho
Author: abataev
Date: Wed Sep 6 07:49:58 2017
New Revision: 312638
URL: http://llvm.org/viewvc/llvm-project?rev=312638&view=rev
Log:
[OPENMP] Fix for PR34445: Reduction initializer segfaults at runtime in
move constructor.
Previously user-defined reduction initializer was considered as an
assign
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:376
+
+CompletionItem Item{InsertTextFormat::PlainText};
+
rwols wrote:
> ilya-biryukov wrote:
> > Implementations of this function in `PlainTextCompletionItemsCollector` and
> > `Snippet
rwols marked an inline comment as done.
rwols added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:33
+ "present plaintext completions."),
+llvm::cl::init(false));
+
ilya-biryukov wrote:
> After putti
Author: aaronballman
Date: Wed Sep 6 08:12:05 2017
New Revision: 312639
URL: http://llvm.org/viewvc/llvm-project?rev=312639&view=rev
Log:
Replacing "or" with "||" to appease MSVC.
Modified:
cfe/trunk/unittests/Tooling/LexicallyOrderedRecursiveASTVisitorTest.cpp
Modified:
cfe/trunk/unittest
pdouglas added a comment.
Hi,
This change is not building on Windows, because the Visual C++ compiler doesn't
support `or` (instead of `||`) by default. (See
https://msdn.microsoft.com/en-us/library/f355wky8.aspx#Operator%20Keyword%20for%20||)
C:\b\slave\clang-x86-windows-msvc2015\clang-x86
On Wed, Sep 6, 2017 at 11:22 AM, Philip Douglas via Phabricator via
cfe-commits wrote:
> pdouglas added a comment.
>
> Hi,
>
> This change is not building on Windows, because the Visual C++ compiler
> doesn't support `or` (instead of `||`) by default. (See
> https://msdn.microsoft.com/en-us/libr
SjoerdMeijer added a comment.
I am going to commit this within a few days. That looks reasonable to me given
that the comments in the last reviews were very minor (which I have of course
addressed already). Also, in case of issues, I am guessing fixes and/or
addition can be easily done post-com
cameron314 updated this revision to Diff 114016.
cameron314 added a comment.
Here's an updated patch that allows only the PCH to be accessed from the real
FS when a VSF is present. Tests still pass.
https://reviews.llvm.org/D37474
Files:
lib/Frontend/ASTUnit.cpp
unittests/Frontend/CMakeLis
Author: abataev
Date: Wed Sep 6 09:17:35 2017
New Revision: 312642
URL: http://llvm.org/viewvc/llvm-project?rev=312642&view=rev
Log:
[OPENMP] Fix for PR33922: New ident_t flags for
__kmpc_for_static_fini().
Added special flags for calls of __kmpc_for_static_fini(), like previous
ly for __kmpc_fo
pirama added a comment.
Ping...
https://reviews.llvm.org/D37302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wmi added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D37310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
iid_iunknown created this revision.
This is a patch proposal for PR34507.
Typo resolution can create new TypoExprs while transforming an expression.
These TypoExprs are not transformed, they are present in the resulting
expression and cause the `DelayedTypos.empty() && "Uncorrected typos!"`
as
jroelofs added a comment.
Sure. I'll commit it for you once this build/test cycle is finished.
https://reviews.llvm.org/D37493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
itessier added a comment.
In https://reviews.llvm.org/D37496#861746, @compnerd wrote:
> The change looks good. Can you please add some test cases for this? Or do
> existing test cases cover this already?
Should have added this to the description, but yes there are existing tests
that cover
hamzasood added a comment.
Ping
https://reviews.llvm.org/D36527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jroelofs
Date: Wed Sep 6 10:09:25 2017
New Revision: 312651
URL: http://llvm.org/viewvc/llvm-project?rev=312651&view=rev
Log:
Fix ARM bare metal driver to support atomics
The new bare metal support only supports the single thread model. This causes
the builtin atomic functions (e.g.: __a
jroelofs closed this revision.
jroelofs added a comment.
r312651
https://reviews.llvm.org/D37493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin added a comment.
Thanks Gabor! Some additional comments in line.
Comment at: include/clang/CrossTU/CrossTranslationUnit.h:118
+ ///
+ /// \return Returns a map with the loaded AST Units and the declarations
+ /// with the definitions.
Is this comme
mgrang added a comment.
Ping for reviews please.
https://reviews.llvm.org/D37400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
In https://reviews.llvm.org/D36410#856907, @bader wrote:
> In https://reviews.llvm.org/D36410#856716, @yaxunl wrote:
>
> > The captured variable is still passed by value. The address taking is on
> > the duplicate of the captured variable, not on the original variable.
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/no-half.cl:27
+ foo[0] = __builtin_load_halff(bar);
+// CHECK: [[HALF_VAL:%.*]] = load
+// CHECK: [[FULL_VAL:%.*]] = fpext half [[HALF_VAL]] to float
jvesely wrote:
> Anastasia wrote:
> > Minor
jvesely marked 2 inline comments as done.
jvesely added inline comments.
Comment at: test/CodeGenOpenCL/no-half.cl:27
+ foo[0] = __builtin_load_halff(bar);
+// CHECK: [[HALF_VAL:%.*]] = load
+// CHECK: [[FULL_VAL:%.*]] = fpext half [[HALF_VAL]] to float
Ana
Nebiroth updated this revision to Diff 114046.
Nebiroth added a comment.
Refactored switchSourceHeader function help from ilya
Added helper function to check for uppercase on current file.
https://reviews.llvm.org/D36150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/Cla
Nebiroth updated this revision to Diff 114048.
Nebiroth added a comment.
Remove unintentional file addition
Updating D36150: [clangd] LSP extension to switch between source/header file
ll#
https://reviews.llvm.org/D36
Nebiroth updated this revision to Diff 114054.
Nebiroth added a comment.
Some more code cleanup.
https://reviews.llvm.org/D36150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ProtocolHandlers.cpp
clangd/ProtocolHandlers.h
Index: clangd/Protoco
Author: rsmith
Date: Wed Sep 6 13:01:14 2017
New Revision: 312665
URL: http://llvm.org/viewvc/llvm-project?rev=312665&view=rev
Log:
[modules ts] Emit global variables in a module interface unit as part of that
unit, not in importers.
Modified:
cfe/trunk/include/clang/Serialization/ASTReader
inglorion updated this revision to Diff 114060.
inglorion added a comment.
removed accidentally left in include and reformatted mangled comment
https://reviews.llvm.org/D37529
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDebugInfo.h
clang/lib/CodeGen/CGStmt.cpp
clang/lib
mstorsjo created this revision.
This allows linking to e.g. msvcr120.dll or ucrtbase.dll instead of the
unversioned (and officially unsupported) msvcrt.dll. In GCC setups, this can be
overridden by using custom spec files, but this isn't supported in clang.
This is just an initial attempt at im
inglorion added inline comments.
Comment at: clang/lib/CodeGen/CGStmt.cpp:45
+ }
+ return IDL;
+}
rnk wrote:
> Does MSVC accept this? I think it will emit the copy ctor call in an -O0
> build.
I wrote this thinking that the right thing would happen under copy
rnk added a subscriber: echristo.
rnk added inline comments.
Comment at: clang/lib/CodeGen/CGStmt.cpp:38
+InhibitDebugLocation CodeGenFunction::EmitStmtStopPoint(const Stmt *S) {
+ InhibitDebugLocation IDL;
"Stop point" is a hold-over from the llvm.dbg.stoppoi
rnk added inline comments.
Comment at: clang/test/CodeGenCXX/debug-info-nested-exprs.cpp:12
+
+// NONEST: call i32 @{{.*}}bar{{.*}}, !dbg ![[LOC:[0-9]+]]
+// NONEST: call i32 @{{.*}}baz{{.*}}, !dbg ![[LOC]]
inglorion wrote:
> rnk wrote:
> > This is pretty painful
rnk added a comment.
What do you think of letting people spell this as `-lmsvcrt120`? We could
forward those options and suppress our implicit addition of `-lmsvcrt` if we
see `-lmsvcr*` anywhere.
Comment at: lib/Driver/ToolChains/MinGW.cpp:161
if (TC.getArch() == llvm
sylvestre.ledru created this revision.
https://reviews.llvm.org/D37531
Files:
docs/ClangFormatStyleOptions.rst
Index: docs/ClangFormatStyleOptions.rst
===
--- docs/ClangFormatStyleOptions.rst
+++ docs/ClangFormatStyleOptions.rst
Author: george.karpenkov
Date: Wed Sep 6 14:45:01 2017
New Revision: 312670
URL: http://llvm.org/viewvc/llvm-project?rev=312670&view=rev
Log:
[NFC] [CSA] Move AnyFunctionCall::getRuntimeDefinition implementation to cpp.
Differential Revision: https://reviews.llvm.org/D37499
Modified:
cfe/tr
Author: george.karpenkov
Date: Wed Sep 6 14:45:03 2017
New Revision: 312671
URL: http://llvm.org/viewvc/llvm-project?rev=312671&view=rev
Log:
[CSA] [NFC] Move AnalysisContext.h to AnalysisDeclContext.h
The implementation is in AnalysisDeclContext.cpp and the class is called
AnalysisDeclContext.
zturner added inline comments.
Comment at: clang/test/CodeGenCXX/debug-info-nested-exprs.cpp:44
+ int a = bar(x, y) +
+ baz(x, z) +
+ qux(y, z);
inglorion wrote:
> zturner wrote:
> > Can you make a function called `int foo()` and make this `int
inglorion added inline comments.
Comment at: clang/lib/CodeGen/CGStmt.cpp:45
+ }
+ return IDL;
+}
inglorion wrote:
> rnk wrote:
> > Does MSVC accept this? I think it will emit the copy ctor call in an -O0
> > build.
> I wrote this thinking that the right thing
inglorion created this revision.
Herald added a subscriber: aprantl.
Microsoft Visual Studio expects debug locations to correspond to
statements. We used to emit locations for expressions nested inside statements.
This would confuse the debugger, causing it to stop multiple times on the
same line
inglorion added inline comments.
Comment at: clang/test/CodeGenCXX/debug-info-nested-exprs.cpp:44
+ int a = bar(x, y) +
+ baz(x, z) +
+ qux(y, z);
zturner wrote:
> inglorion wrote:
> > zturner wrote:
> > > Can you make a function called `int fo
zturner added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.h:65
llvm::MDNode *CurInlinedAt = nullptr;
+ bool LocationEnabled = true;
llvm::DIType *VTablePtrType = nullptr;
Can you move this line up to put it next to another bool? Not a huge
zturner added inline comments.
Comment at: clang/test/CodeGenCXX/debug-info-nested-exprs.cpp:44
+ int a = bar(x, y) +
+ baz(x, z) +
+ qux(y, z);
inglorion wrote:
> zturner wrote:
> > inglorion wrote:
> > > zturner wrote:
> > > > Can you make a
zaks.anna added a comment.
Thanks for addressing the non-determinism!!!
The ExplodedNodeSet is predominantly used to hold very small sets and it is
used quite a bit in the analyzer. Maybe we could we use SmallSetVector here
instead?
https://reviews.llvm.org/D37400
_
dlj created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
Some container operations require ADL. For example, std::advance is
required to use specific operators, which will participate in ADL.
However, implementation details which rely on SFINAE should be care
mgrang updated this revision to Diff 114089.
mgrang added a comment.
Addressed comments.
https://reviews.llvm.org/D37400
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h
Index: include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h
mgrang added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h:407
class ExplodedNodeSet {
- typedef llvm::SmallPtrSet ImplTy;
+ typedef llvm::SmallSetVector ImplTy;
ImplTy Impl;
SmallSetVector size has to be a pow
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thank you!
Anna
https://reviews.llvm.org/D37400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: mgrang
Date: Wed Sep 6 15:54:59 2017
New Revision: 312677
URL: http://llvm.org/viewvc/llvm-project?rev=312677&view=rev
Log:
[StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode
Summary:
This fixes failures seen in the reverse iteration builder:
http://lab.llvm.org:801
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312677: [StaticAnalyzer] Fix failures due to the iteration
order of ExplodedNode (authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D37400?vs=114089&id=114091#toc
Repository:
rL
minseong.kim added a comment.
Hi~ @hintonda,
Using using find_first_existing_file in ADDLLVM.cmake solves the cases with
repo in conjunction with https://reviews.llvm.org/D35532. However, I am not
sure it can handle @modocache's git submodule cases
(https://reviews.llvm.org/D34955).
@modocach
inglorion updated this revision to Diff 114097.
inglorion marked 5 inline comments as done.
inglorion added a comment.
I limited the change to only calls, returns, and declarations. I also
updated the test case to include a multi-variable declaration, a while
loop, a for loop, and an if statement
hintonda added a comment.
In https://reviews.llvm.org/D35533#862798, @minseong.kim wrote:
> Hi~ @hintonda,
>
> Using using find_first_existing_file in ADDLLVM.cmake solves the cases with
> repo in conjunction with https://reviews.llvm.org/D35532. However, I am not
> sure it can handle @modocach
rsmith added a comment.
Looks good to me, but I'd like EricWF to also review.
Comment at: include/deque:1167-1168
allocator_type& __a = __alloc();
-for (iterator __i = begin(), __e = end(); __i != __e; ++__i)
-__alloc_traits::destroy(__a, _VSTD::addressof(*__i)
hintonda added a comment.
I just looked into both approaches and believe the one taken in AddLLVM.cmake
is correct and handles the submodule case correctly. It uses `git rev-parse
--git-dir` to find the location of the actual .git directory.
Please see https://reviews.llvm.org/D31985 for detai
rjmccall added inline comments.
Comment at: lib/CodeGen/CGAtomic.cpp:680
+ alignChars = std::max(alignChars, alignDecl);
+}
+
Just use EmitPointerWithAlignment instead of EmitScalarExpr to emit the pointer
operand.
Repository:
rL LLVM
https://revie
minseong.kim added a comment.
@hintonda, Absolutely. Incorporating @modocache's module changes into the
version in AddLLVM.cmake would solve the current version display issue for repo
and do not affect the process of other version control systems (e.g. git,
git-svn, svn, and git submodule).
h
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Headers/cuda_wrappers/new:79
+}
+__device__ void operator delete[](void *ptr, std::size_t sz) CUDA_NOEXCEPT {
+ ::operator delete(ptr);
I am extremely uncomfortable about the direction this patch series is going.
We have had two different RecursiveASTVisitors before (RecursiveASTVisitor
and DataRecursiveASTVisitor), and it was a maintenance nightmare:
frequently changes would be made to one of them and missed in the other
one, res
vsk created this revision.
The alignment check emits a ptrtoint instruction which can be reused in
the call to the diagnostic handler.
https://reviews.llvm.org/D37542
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGen/catch-undef-behavior.c
Index: test/CodeGen/catch-undef-behavior.c
=
vsk created this revision.
Adding these helpers will make a planned change simpler:
[ubsan] Defer pointer type checks, then try to skip the redundant ones
https://reviews.llvm.org/D37543
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
Index: lib/CodeGen/CodeGenFunction.h
=
1 - 100 of 120 matches
Mail list logo
