On Wed, Sep 6, 2017 at 11:22 AM, Philip Douglas via Phabricator via cfe-commits <cfe-commits@lists.llvm.org> wrote: > pdouglas added a comment. > > Hi, > > This change is not building on Windows, because the Visual C++ compiler > doesn't support `or` (instead of `||`) by default. (See > https://msdn.microsoft.com/en-us/library/f355wky8.aspx#Operator%20Keyword%20for%20||) > > > C:\b\slave\clang-x86-windows-msvc2015\clang-x86-windows-msvc2015\llvm\tools\clang\unittests\Tooling\LexicallyOrderedRecursiveASTVisitorTest.cpp(86): > error C2146: syntax error: missing ')' before identifier 'or' > > C:\b\slave\clang-x86-windows-msvc2015\clang-x86-windows-msvc2015\llvm\tools\clang\unittests\Tooling\LexicallyOrderedRecursiveASTVisitorTest.cpp(86): > error C2065: 'or': undeclared identifier > > C:\b\slave\clang-x86-windows-msvc2015\clang-x86-windows-msvc2015\llvm\tools\clang\unittests\Tooling\LexicallyOrderedRecursiveASTVisitorTest.cpp(86): > error C2143: syntax error: missing ';' before '<template-id>' > > C:\b\slave\clang-x86-windows-msvc2015\clang-x86-windows-msvc2015\llvm\tools\clang\unittests\Tooling\LexicallyOrderedRecursiveASTVisitorTest.cpp(73): > fatal error C1075: the left brace '{' was unmatched at the end of the file > > Full log: > http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/6980/steps/ninja%20check%201/logs/stdio
I corrected this in r312639. ~Aaron > > > Repository: > rL LLVM > > https://reviews.llvm.org/D36998 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
