Fine to remove it if it didn't change the test - it just wasn't clear to me what exactly was being tested at the time so it was more "does this test still work with/without -disable-llvm-passes".
No worries. On Tue, Sep 5, 2017 at 10:58 PM Karl-Johan Karlsson via Phabricator < revi...@reviews.llvm.org> wrote: > Ka-Ka added inline comments. > > > ================ > Comment at: test/CodeGen/debug-info-attributed-stmt.c:1 > +// RUN: %clang_cc1 -triple x86_64-unk-unk -disable-llvm-passes > -debug-info-kind=limited -emit-llvm %s -o - | FileCheck %s > + > ---------------- > echristo wrote: > > Since we're not optimizing or generating code you should be able to > remove the -disable-llvm-passes I believe. > I added the option -disable-llvm-passes as David Blaikie suggested it in > his original comment: > > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170904/202982.html > As I have mainly worked in llvm backends I'm not that familiar with the > clang -cc1 options. I have no opinion about this. I wait for you and David > Blaikie to decide if I should remove or keep the option > -disable-llvm-passes. > > > > https://reviews.llvm.org/D37428 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
