LLVM buildmaster will be restarted in few minutes

Hello everyone, LLVM buildmaster will be restarted in few minutes. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

ahatanak added a comment. Are users allowed to call these routines with a null pointer and a non-zero size? Or can we assume that if the size is known to be non-zero at compile time, the pointers are not null? I'm thinking we might miss optimization opportunities if it's not possible to mark t

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

chandlerc added a comment. In https://reviews.llvm.org/D30806#697372, @ahatanak wrote: > Are users allowed to call these routines with a null pointer and a non-zero > size? Or can we assume that if the size is known to be non-zero at compile > time, the pointers are not null? If the sizes are

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

majnemer added inline comments. Comment at: lib/AST/ASTContext.cpp:8786 +if (OverrideNonnull && OverrideNonnullArgs) + *OverrideNonnullArgs |= 1 << ArgTypes.size(); + `1U` to avoid overflow UB? Comment at: lib/CodeGen/CGCall.cpp:2082 +

[PATCH] D30792: Use callback for internalizing linked symbols.

JDevlieghere updated this revision to Diff 91282. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. - Reformat - Call helper rather than initializing the pass Repository: rL LLVM https://reviews.llvm.org/D30792 Files: include/clang/CodeGen/CodeGenAction.h inclu

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

chandlerc added inline comments. Comment at: lib/AST/ASTContext.cpp:8786 +if (OverrideNonnull && OverrideNonnullArgs) + *OverrideNonnullArgs |= 1 << ArgTypes.size(); + majnemer wrote: > `1U` to avoid overflow UB? I'd mildly prefer an assert (or rely on U

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

chandlerc updated this revision to Diff 91286. chandlerc added a comment. Update to fix subtle bugs in handling arguments. Thanks to David for the review comments that caused me to see the issue here. https://reviews.llvm.org/D30806 Files: include/clang/AST/ASTContext.h include/clang/Basic/

[PATCH] D30777: Added `applyAtomicChanges` function.

ioeric updated this revision to Diff 91288. ioeric marked 7 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D30777 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/Refactoring/AtomicChange.cpp unittests/Tooling/Refa

[PATCH] D30792: Use callback for internalizing linked symbols.

JDevlieghere updated this revision to Diff 91292. JDevlieghere added a comment. - Pass StringSet by const ref. Repository: rL LLVM https://reviews.llvm.org/D30792 Files: include/clang/CodeGen/CodeGenAction.h include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CodeGenAction.cpp lib/Fr

[PATCH] D30813: [clang-rename] Introduce an unittest skeleton for clang-rename.

hokein created this revision. Herald added a subscriber: mgorny. This will make references rename tests easier. https://reviews.llvm.org/D30813 Files: unittests/CMakeLists.txt unittests/clang-rename/CMakeLists.txt unittests/clang-rename/ClangRenameTests.cpp Index: unittests/clang-rename/

[PATCH] D30813: [clang-rename] Introduce an unittest skeleton for clang-rename.

hokein updated this revision to Diff 91296. hokein added a comment. Add missing license. https://reviews.llvm.org/D30813 Files: unittests/CMakeLists.txt unittests/clang-rename/CMakeLists.txt unittests/clang-rename/ClangRenameTests.cpp Index: unittests/clang-rename/ClangRenameTests.cpp ==

[PATCH] D30813: [clang-rename] Introduce an unittest skeleton for clang-rename.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg Comment at: unittests/clang-rename/ClangRenameTests.cpp:91 +"#include \"%s\"\n%s", HeaderName.c_str(), Expected.str().c_str()); +EXPECT_EQ(format(ExpectedCode)

[PATCH] D30183: Add -iframeworkwithsysroot compiler option

arphaman added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D30183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30813: [clang-rename] Introduce an unittest skeleton for clang-rename.

hokein marked an inline comment as done. hokein added inline comments. Comment at: unittests/clang-rename/ClangRenameTests.cpp:91 +"#include \"%s\"\n%s", HeaderName.c_str(), Expected.str().c_str()); +EXPECT_EQ(format(ExpectedCode), format(Actual)); + } --

[clang-tools-extra] r297450 - [clang-rename] Introduce an unittest skeleton for clang-rename.

Author: hokein Date: Fri Mar 10 04:30:14 2017 New Revision: 297450 URL: http://llvm.org/viewvc/llvm-project?rev=297450&view=rev Log: [clang-rename] Introduce an unittest skeleton for clang-rename. Summary: This will make references rename tests easier. Reviewers: ioeric Reviewed By: ioeric Sub

[PATCH] D30813: [clang-rename] Introduce an unittest skeleton for clang-rename.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL297450: [clang-rename] Introduce an unittest skeleton for clang-rename. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D30813?vs=91296&i

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix. Do you need someone to commit it for you? https://reviews.llvm.org/D29944 ___ cfe-commits mailing list cfe-commits@

[PATCH] D30766: Add support for attribute "enum_extensibility"

arphaman added inline comments. Comment at: include/clang/Basic/Attr.td:887 +def EnumExtensibility : InheritableAttr { + let Spellings = [GNU<"enum_extensibility">]; + let Subjects = SubjectList<[Enum]>; We might as well have a C++11 spelling in the `clang` nam

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

echuraev updated this revision to Diff 91305. echuraev marked 2 inline comments as done. https://reviews.llvm.org/D30643 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaInit.cpp test/SemaOpenCL/atomic-init.cl Index: test/SemaOpenCL/atomic-init.cl ===

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

echuraev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error<

[PATCH] D30810: Preserve vec3 type.

jaykang10 updated this revision to Diff 91306. jaykang10 added a comment. Added -f prefix to option name. https://reviews.llvm.org/D30810 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGExpr.cpp lib/Frontend/CompilerInvocation.cpp Index

[PATCH] D30810: Preserve vec3 type.

jaykang10 updated this revision to Diff 91307. jaykang10 added a comment. Fixed typo. https://reviews.llvm.org/D30810 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGExpr.cpp lib/Frontend/CompilerInvocation.cpp Index: lib/Frontend/Compi

[PATCH] D30816: [OpenCL] Added implicit conversion rank for overloading functions with vector data type in OpenCL

echuraev created this revision. Herald added a subscriber: yaxunl. I added a new rank to ImplicitConversionRank enum to resolve the function overload ambiguity with vector types. Rank of scalar types conversion is lower than vector splat. So, we can choose which function should we call. See test

[PATCH] D27753: [analyzer] alpha.security.DirtyScalar Checker

gerazo added a comment. > Stepping back a bit, what do you consider "dirty" vs "clean"? It seems that > you are looking for prove that the values are known to be within the bounds > of min and max int values. What happens if there is a comparison to an > unknown symbolic value? Should that be c

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

john.brawn updated this revision to Diff 91311. john.brawn added a comment. Rebase on top of recent driver changes. Repository: rL LLVM https://reviews.llvm.org/D30582 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/fast-math.c Index: test/Driver/fast-math.c =

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

redm123 added a comment. I guess so. I don't think I'm allowed to commit. So I would appreciate it. Which release version would that be in? 4.1 I guess? Thanks for your help! https://reviews.llvm.org/D29944 ___ cfe-commits mailing list cfe-commits

r297455 - [clang-format] Use a reference in loop variable; NFC

Author: krasimir Date: Fri Mar 10 07:09:29 2017 New Revision: 297455 URL: http://llvm.org/viewvc/llvm-project?rev=297455&view=rev Log: [clang-format] Use a reference in loop variable; NFC Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp Modified: cfe/trunk/lib/Format/UnwrappedLineParse

[PATCH] D30798: [analyzer] Turn suppress-c++-stdlib on by default

xazax.hun added a comment. In https://reviews.llvm.org/D30798#697115, @zaks.anna wrote: > I've committed the change, but would very much appreciate community feedback > here if if there is any! I agree with the change. Users are usually not interested in the results from the standard library,

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

echuraev updated this revision to Diff 91327. https://reviews.llvm.org/D28136 Files: lib/Headers/opencl-c.h test/SemaOpenCL/as_type.cl Index: test/SemaOpenCL/as_type.cl === --- test/SemaOpenCL/as_type.cl +++ test/SemaOpenCL/as_t

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

Abpostelnicu updated this revision to Diff 91330. Abpostelnicu marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D30487 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/For

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2666 return true; + if (Left.is(TT_InheritanceComma) && + Style.BreakBeforeInheritanceComma) Do these now fit on one line? Repository: rL LLVM https://reviews.llvm.org/D30487

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

Abpostelnicu added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:355 + if (Current.is(TT_InheritanceColon)) +State.Stack.back().NoLineBreak = true; djasper wrote: > Can you leave a comment here: > > // Don't break within the inheritan

[PATCH] D30798: [analyzer] Turn suppress-c++-stdlib on by default

NoQ added a comment. I'd like to clarify that in case of path-sensitive analysis there are actually three warning classes to consider. 1. Warnings that reside completely in system headers and indicate bugs in system headers, most likely falsely. 2. Warnings that originate from the main file and

[PATCH] D30798: [analyzer] Turn suppress-c++-stdlib on by default

a.sidorin added a comment. I have no any objection on this change. Repository: rL LLVM https://reviews.llvm.org/D30798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

echuraev added a comment. In https://reviews.llvm.org/D28136#634356, @Anastasia wrote: > This has been discussed during the initial review for the header: > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160425/157187.html > > The main issue is after preprocessing the header the origi

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

Abpostelnicu updated this revision to Diff 91334. Repository: rL LLVM https://reviews.llvm.org/D30487 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.c

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

kimgr added a comment. A few more 'inhertiance' left, otherwise spelling looks good to me :-) Comment at: lib/Format/TokenAnnotator.cpp:679 Tok->Type = TT_CtorInitializerComma; + else if (Contexts.back().InInhertianceList) +Tok->Type = TT_InheritanceComma;

Re: Patch for Bug 30413, including test case

Hi Akira, Thank you very much! Please let me know if I need to take any further steps beyond this email to cfe-commits in order for the patch and the unit test to be committed. Thanks, David > On Mar 9, 2017, at 4:46 PM, Akira Hatanaka wrote: > > Hi David, > > The patch looks good to me.

[PATCH] D30822: [clang-format] Indent the same amount a sequence of string literals

krasimir abandoned this revision. krasimir added a comment. this is nonsense https://reviews.llvm.org/D30822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

arphaman added a comment. In https://reviews.llvm.org/D29944#697587, @redm123 wrote: > I guess so. I don't think I'm allowed to commit. So I would appreciate it. Sure, I will commit it right now. > Which release version would that be in? 4.1 I guess? It will be in the next major release: 5.0

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

Abpostelnicu updated this revision to Diff 91335. Abpostelnicu marked an inline comment as done. Abpostelnicu added a comment. Fixed two spell errors. Repository: rL LLVM https://reviews.llvm.org/D30487 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Co

r297461 - [analyzer] Extend block in critical section check with C11 and Pthread APIs.

Author: xazax Date: Fri Mar 10 08:50:12 2017 New Revision: 297461 URL: http://llvm.org/viewvc/llvm-project?rev=297461&view=rev Log: [analyzer] Extend block in critical section check with C11 and Pthread APIs. Patch by Zoltan Daniel Torok! Differential Revision: https://reviews.llvm.org/D29567

r297465 - Print nested name specifiers for typedefs and type aliases

Author: arphaman Date: Fri Mar 10 09:04:58 2017 New Revision: 297465 URL: http://llvm.org/viewvc/llvm-project?rev=297465&view=rev Log: Print nested name specifiers for typedefs and type aliases Printing typedefs or type aliases using clang_getTypeSpelling() is missing the namespace they are defin

[PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL297465: Print nested name specifiers for typedefs and type aliases (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D29944?vs=88376&id=91342#toc Repository: rL LLVM https://

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error< ---

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL297467: [clang-format] Add option to break before inheritance separation operator in… (authored by Abpostelnicu). Changed prior to commit: https://reviews.llvm.org/D30487?vs=91335&id=91344#toc Reposito

r297468 - [OpenCL] Fix type compatibility check and generic AS mangling.

Author: stulova Date: Fri Mar 10 09:23:07 2017 New Revision: 297468 URL: http://llvm.org/viewvc/llvm-project?rev=297468&view=rev Log: [OpenCL] Fix type compatibility check and generic AS mangling. 1. Reimplemented conditional operator so that it checks compatibility of unqualified pointees of the

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. Could you please add your test here (probably goes to test/CodeGenOpenCL)? Comment at: include/clang/Driver/CC1Options.td:661 +def fpreserve_vec3_type : Flag<["-"], "fpreserve-vec3-type">, + HelpText<"Preserve 3-component vector type operations">; +

[PATCH] D30733: [Driver] Add arch-specific rpath for libc++

jroelofs added a comment. In https://reviews.llvm.org/D30733#697313, @Hahnfeld wrote: > In https://reviews.llvm.org/D30733#697108, @jroelofs wrote: > > > As I said on https://reviews.llvm.org/D30214, it is inappropriate to be > > installing libc++ in the resource directory... please **do not** d

[PATCH] D30830: [OpenCL] Fix extension guards for atomic functions

jprice created this revision. https://reviews.llvm.org/D30830 Files: lib/Headers/opencl-c.h Index: lib/Headers/opencl-c.h === --- lib/Headers/opencl-c.h +++ lib/Headers/opencl-c.h @@ -14395,10 +14395,10 @@ #if defined(cl_khr_g

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

Anastasia added a comment. In https://reviews.llvm.org/D28136#697673, @echuraev wrote: > In https://reviews.llvm.org/D28136#634356, @Anastasia wrote: > > > This has been discussed during the initial review for the header: > > > > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160425/

[PATCH] D30830: [OpenCL] Fix extension guards for atomic functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! This bit was poorly tested initially as there were simply too many things. I am wondering if we could improve these bits slowly by extending further lib/Headers/opencl-c.h. https

[PATCH] D30733: [Driver] Add arch-specific rpath for libc++

jroelofs added a comment. I'll also add that we had a BOF at EuroLLVM 2014, where this got support from the community and people generally thought it was a good plan... Just needed someone to follow through with it. We (wearing my CodeSourcery hat) said we would do so, but have been making slow

[PATCH] D30792: Use callback for internalizing linked symbols.

mehdi_amini added a comment. Off topic, but since this is a rev lock change with LLVM, you can to all of in a single revision with: http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo Repository: rL LLVM https://reviews.llvm.org/D30792

[PATCH] D30831: [ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands

gerazo created this revision. Do not drop the import of the whole function just because an asm statement in it has some missing symbolic names. https://reviews.llvm.org/D30831 Files: lib/AST/ASTImporter.cpp test/ASTMerge/asm/Inputs/asm-function.cpp test/ASTMerge/asm/test.cpp Index: tes

[PATCH] D30810: Preserve vec3 type.

jaykang10 updated this revision to Diff 91355. jaykang10 added a comment. Changed help text for option and Added test file. https://reviews.llvm.org/D30810 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGExpr.cpp lib/Frontend/CompilerInv

[PATCH] D30810: Preserve vec3 type.

jaykang10 added a comment. In https://reviews.llvm.org/D30810#697760, @Anastasia wrote: > Could you please add your test here (probably goes to test/CodeGenOpenCL)? Oops! I am so sorry. I missed it. I have updated it. https://reviews.llvm.org/D30810

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

bader added a comment. > Why do you think this is a bug? It seems to follow standard behavior in C to > promote char to int if required. Just like if you would have a C code: > > int as_int(int i); > void foo() { > char src = 1; > int dst = as_int(src); > } > > > This cod

[PATCH] D30834: [x86] these aren't the undefs you're looking for (PR32176)

spatel created this revision. Herald added a subscriber: mcrosier. x86 has undef SSE/AVX intrinsics that should represent a bogus register operand. This is not the same as LLVM's undef value which can take on multiple bit patterns. There are better solutions / follow-ups to this discussed here:

[PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

ributzka updated this revision to Diff 91371. ributzka added a comment. Remove the EC check completely. https://reviews.llvm.org/D30768 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index: unittests/Basic/VirtualF

r297485 - [mips][msa] Remove range checks for non-immediate sld.[bhwd] instructions

Author: petarj Date: Fri Mar 10 11:51:01 2017 New Revision: 297485 URL: http://llvm.org/viewvc/llvm-project?rev=297485&view=rev Log: [mips][msa] Remove range checks for non-immediate sld.[bhwd] instructions Removes immediate range checks for these instructions, since they have GPR rt as their inp

[PATCH] D30693: [mips][msa] Remove range checks for non-immediate sld.[bhwd] instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rL297485: [mips][msa] Remove range checks for non-immediate sld.[bhwd] instructions (authored by petarj). Changed prior to commit: https://reviews.llvm.org/D30693?vs=91158&id=91372#toc Repository: rL L

[PATCH] D30830: [OpenCL] Fix extension guards for atomic functions

jprice added a comment. Thanks - could you commit this on my behalf please? https://reviews.llvm.org/D30830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30837: [libcxx] Support for shared_ptr

erik.pilkington created this revision. This patch adds support for `shared_ptr` types, so that the following works: void Func(); void Del(void (*)()) std::shared_ptr x(Func, Del); Where previously this would fail to compile. In PR27566, the use case described for this was a shared pointe

[PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

mgehre updated this revision to Diff 91378. mgehre marked an inline comment as done. mgehre added a comment. Handle back-patches gotos and add test case Turned LocalScope::const_iterator::shared_parent from O(N^2) into O(N) time The combination with AddImplicitDtors will be added in a separate pat

[PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

mgehre added a comment. I'm sorry for the long delay! Regarding " I think it would also be good to (eventually) add CFGElements marking when the storage duration for underlying storage ends.": From what I understand, this only differs from the end of lifetime in case of objects with non-trivial

[PATCH] D30183: Add -iframeworkwithsysroot compiler option

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Hi Alex, Thanks for taking a look a this. LGTM Repository: rL LLVM https://reviews.llvm.org/D30183 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D30837: [libcxx] Support for shared_ptr

halyavin added a comment. But std::allocator is deprecated in C++17. I don't know a good solution, I just used int as an arbitrary type when I faced similar problem. https://reviews.llvm.org/D30837 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D30762: [ubsan] Add a nullability sanitizer

vsk marked 9 inline comments as done. vsk added a comment. The plan is to start off with -fsanitize=nullability, and then create a nullability-pedantic group later if it's really necessary. I think I've addressed all of the inline comments, and will upload a new diff shortly.

[PATCH] D30762: [ubsan] Add a nullability sanitizer

vsk updated this revision to Diff 91382. vsk marked 4 inline comments as done. vsk added a comment. - Rework documentation, add better code comments, and tighten up some check lines. https://reviews.llvm.org/D30762 Files: docs/UndefinedBehaviorSanitizer.rst include/clang/Basic/Sanitizers.d

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

mgorny added a comment. Another ping. Since 4.0.0 final has been tagged, I think we should get back to working on this. @compnerd, any suggestion how to proceed here? https://reviews.llvm.org/D26796 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D29851: [clang-tools-extra] [test] Fix test dependencies when using installed tools

mgorny added a comment. PIng. Repository: rL LLVM https://reviews.llvm.org/D29851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build

mgorny added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D30155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

mgorny marked 5 inline comments as done. mgorny added a comment. A gentle ping. https://reviews.llvm.org/D29542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24921: [cfe] [Headers] Fix inttypes.h macros visibility in C++ with C99-compliant libc

mgorny added a comment. Ping II. https://reviews.llvm.org/D24921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r297497 - Attempt to fix Windows buildbot.

Author: gkistanova Date: Fri Mar 10 13:34:15 2017 New Revision: 297497 URL: http://llvm.org/viewvc/llvm-project?rev=297497&view=rev Log: Attempt to fix Windows buildbot. Modified: cfe/trunk/test/Modules/dependency-dump-dependent-module.m cfe/trunk/test/Modules/dependency-dump.m Modified:

[PATCH] D30841: [clang-tidy] readability-misleading-indentation: fix chained if

fgross created this revision. Herald added a subscriber: JDevlieghere. Fixed erroneously flagging of chained if statements when styled like this: if (cond) { } else if (cond) { } else { } https://reviews.llvm.org/D30841 Files: clang-tidy/readability/MisleadingIndentationCheck.cpp

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk added a reviewer: rsmith. vsk added a comment. Ping. I appreciate that there are a lot of test changes to sift through here -- please let me know if I can make the patch easier to review in any way. https://reviews.llvm.org/D30283 ___ cfe-commi

[PATCH] D30837: [libcxx] Support for shared_ptr

erik.pilkington updated this revision to Diff 91385. erik.pilkington added a comment. This new patch replaces the allocator from `allocator` to `allocator`, I didn't realize `allocator` was deprecated. Thanks, Erik https://reviews.llvm.org/D30837 Files: include/memory test/std/utilities/m

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added a comment. Ping. https://reviews.llvm.org/D27387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r297468 - [OpenCL] Fix type compatibility check and generic AS mangling.

Hello Anastasia, Added test fails on one of our new builders: Failing Tests (1): Clang :: SemaOpenCL/overload_addrspace_resolution.cl http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/23/steps/test-check-all/logs/stdio Please have a look at it? Thanks Galina

[PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

bruno accepted this revision. bruno added inline comments. This revision is now accepted and ready to land. Comment at: lib/Basic/VirtualFileSystem.cpp:1873 vfs::directory_iterator I = FS->dir_begin(State->top()->getName(), EC); -if (EC) +if (EC && EC != std::errc::n

[PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

This revision was automatically updated to reflect the committed changes. Closed by commit rL297510: [VFS] Ignore broken symlinks in the directory iterator. (authored by ributzka). Changed prior to commit: https://reviews.llvm.org/D30768?vs=91371&id=91403#toc Repository: rL LLVM https://rev

[PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

ributzka added a comment. Thanks Bruno. Committed in r297510. Repository: rL LLVM https://reviews.llvm.org/D30768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30845: Fix array sizes where address space is not yet known

kzhuravl created this revision. Herald added a subscriber: wdng. For variables in generic address spaces, for example: unsigned char V[6442450944]; ... the address space is not yet known when we get into *getConstantArrayType*, it is 0. AMDGCN target's address space 0 has 32 bits pointers,

[PATCH] D30845: Fix array sizes where address space is not yet known

kzhuravl added a comment. I am not sure if this is the right way to fix it. https://reviews.llvm.org/D30845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26953: clang-format: handle formatting on constexpr if

outcoldman added a comment. The actual problem is with that clang-format does not know anything about c++17 features, because it does not set it in lang options. Not sure if that will fix constexpr problem as well, but I could solve some other problems with tools/clang

[PATCH] D30837: [libcxx] Support for shared_ptr

Quuxplusone added a comment. I notice that the Standard implies that std::unique_ptr will work only with *object types* T, and yet the "object" wording is missing from shared_ptr. > A unique pointer is an object that owns another *object* and manages that > other *object* through a pointer.

[PATCH] D30848: Implement DR 373 "Lookup on namespace qualified name in using-directive"

mgehre created this revision. 3.4.6 [basic.lookup.udir] paragraph 1: In a using-directive or namespace-alias-definition, during the lookup for a namespace-name or for a name in a nested-name-specifier, only namespace names are considered. https://reviews.llvm.org/D30848 Files: include/clang

[PATCH] D30848: Implement DR 373 "Lookup on namespace qualified name in using-directive"

mgehre updated this revision to Diff 91418. mgehre added a comment. clang-format https://reviews.llvm.org/D30848 Files: include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseDeclCXX.cpp lib/Parse/ParseExprCXX.cpp lib/Sema/SemaCXXScopeSpec.cpp test/CXX/drs/dr3xx.cpp

[PATCH] D30848: Implement DR 373 "Lookup on namespace qualified name in using-directive"

rsmith added inline comments. Comment at: test/CXX/drs/dr3xx.cpp:911 -namespace dr373 { // dr373: no - // FIXME: This is valid. - namespace X { int dr373; } // expected-note 2{{here}} +namespace dr373 { // dr373: yes + namespace X { int dr373; } This should

[PATCH] D30593: Add correct "-isystem"/"-isysroot" warning handling to static analysis' BugReporter.

kmarshall added a comment. NP, Anna. I filed a number of bugs for the false positives: - https://bugs.llvm.org/show_bug.cgi?id=32229 - https://bugs.llvm.org/show_bug.cgi?id=32232 - https://bugs.llvm.org/show_bug.cgi?id=32233 - https://bugs.llvm.org/show_bug.cgi?id=32234 - https://bugs.llvm.org/sh

[PATCH] D30848: Implement DR 373 "Lookup on namespace qualified name in using-directive"

mgehre updated this revision to Diff 91424. mgehre added a comment. Added clang version to test and regenerated cxx_dr_status.html https://reviews.llvm.org/D30848 Files: include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseDeclCXX.cpp lib/Parse/ParseExprCXX.cpp lib/Se

[PATCH] D30837: [libcxx] Support for shared_ptr

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. We can't just use an arbitrary allocator type for a number of reasons: - You just changed the type of the control block. That's ABI breaking. - `allocator` allocates ints, nothing els

r297530 - clang/test/SemaOpenCL/overload_addrspace_resolution.cl: Appease MS mangler to specify triple=x86_64-unknown.

Author: chapuni Date: Fri Mar 10 17:06:34 2017 New Revision: 297530 URL: http://llvm.org/viewvc/llvm-project?rev=297530&view=rev Log: clang/test/SemaOpenCL/overload_addrspace_resolution.cl: Appease MS mangler to specify triple=x86_64-unknown. Modified: cfe/trunk/test/SemaOpenCL/overload_addr

Re: [PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

Looks like this is failing on a number of bots... On Fri, Mar 10, 2017 at 1:37 PM Juergen Ributzka via Phabricator via cfe-commits wrote: > ributzka added a comment. > > Thanks Bruno. Committed in r297510. > > > Repository: > rL LLVM > > https://reviews.llvm.org/D30768 > > > >

[PATCH] D30776: [coroutines] Fix diagnostics depending on the first coroutine statement.

EricWF added a comment. In https://reviews.llvm.org/D30776#697258, @GorNishanov wrote: > In https://reviews.llvm.org/D30776#697233, @EricWF wrote: > > > Good to know. I'll update this tomorrow. > > > Well, that is just the thought. Possibly we can check for the types of > await_ready and await_s

Re: [PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

Nevermind, I see you've fixed. Thanks :) On Fri, Mar 10, 2017 at 3:21 PM Eric Christopher wrote: > Looks like this is failing on a number of bots... > > On Fri, Mar 10, 2017 at 1:37 PM Juergen Ributzka via Phabricator via > cfe-commits wrote: > > ributzka added a comment. > > Thanks Bruno. Comm

[PATCH] D30775: [coroutines] Refactor SuspendExpr to create just one OpaqueValue (almost NFC)

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This LGTM. https://reviews.llvm.org/D30775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r297511 - [VFS] Remove the Path variable from RealFSDirIter. NFC.

Author: ributzka Date: Fri Mar 10 15:23:29 2017 New Revision: 297511 URL: http://llvm.org/viewvc/llvm-project?rev=297511&view=rev Log: [VFS] Remove the Path variable from RealFSDirIter. NFC. This variable is set, but never used. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified:

  1   2   >