arphaman added inline comments.

================
Comment at: include/clang/Basic/Attr.td:887
+def EnumExtensibility : InheritableAttr {
+  let Spellings = [GNU<"enum_extensibility">];
+  let Subjects = SubjectList<[Enum]>;
----------------
We might as well have a C++11 spelling in the `clang` namespace as well.


================
Comment at: test/Sema/enum-attr.c:27
+
+enum __attribute__((enum_extensibility(arg1))) EnumInvalidArg { // 
expected-warning{{'enum_extensibility' attribute argument not supported: 
'arg1'}}
+  G
----------------
Should this be an error instead?


https://reviews.llvm.org/D30766



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to