ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land.
lg ================ Comment at: unittests/clang-rename/ClangRenameTests.cpp:91 + "#include \"%s\"\n%s", HeaderName.c_str(), Expected.str().c_str()); + EXPECT_EQ(format(ExpectedCode), format(Actual)); + } ---------------- I'd put EXPECT_EQ in test cases so that it would be easier to see which case fails. Maybe pull out a function for wrapping `Expected` and EXPECT_EQ on the formatted result and `format(Actual)`? https://reviews.llvm.org/D30813 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits