firolino marked 2 inline comments as done.
firolino added inline comments.
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:86
+
+ Diag << FixItHint::CreateReplacement(CommaRange, ";")
+ << FixItHint::CreateReplacement(AfterCommaToVarNameRange,
---
Author: bruno
Date: Mon Dec 12 17:06:58 2016
New Revision: 289487
URL: http://llvm.org/viewvc/llvm-project?rev=289487&view=rev
Log:
Revert "[Headers] Add #include_next for tgmath.h on Darwin"
Reverts r289181: it's currently breaking modules using simd.h in
10.12 SDK.
This reverts commit 6e73e346
ruiu added a comment.
Nico suggested I make change to CMake instead of Clang so that CMake adds
-Wl,-color-diagnostics if it detects the linker can accept that option. I think
that makes sense, so I'll look into it.
https://reviews.llvm.org/D27603
___
aprantl added inline comments.
Comment at: include/clang/Serialization/ASTBitCodes.h:322
+
+ /// \brief Record code for the signature that identifiers this AST file.
+ SIGNATURE,
FYI, could be fixed in a separate commit for the entire file: These uses o
Author: bruno
Date: Mon Dec 12 17:22:30 2016
New Revision: 289494
URL: http://llvm.org/viewvc/llvm-project?rev=289494&view=rev
Log:
Revert "[Modules] Make header inclusion order from umbrella dirs deterministic"
Reverts commit r289478.
This broke
http://lab.llvm.org:8011/builders/clang-ppc64be-l
firolino updated this revision to Diff 81154.
firolino marked an inline comment as done.
firolino added a comment.
Small improvments:
- SourceRange -> SourceLocation (malcolms last comment)
- added a few consts
https://reviews.llvm.org/D27621
Files:
clang-tidy/readability/CMakeLists.txt
cl
rsmith added a comment.
Please add a test to make sure this does not fire on C++17 decomposition
declarations:
void f() {
struct X { int a, b, c; };
auto [a, b, c] = X();
}
https://reviews.llvm.org/D27621
___
cfe-commits mailing list
c
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix a size_t-to-int truncation warning in error_code.pass.cpp.
This test was triggering MSVC x64 warning C4267
"conversion from 'size_t' to 'int', possible loss
rsmith added a comment.
Generally this seems reasonable to me. I don't see any particular need to split
this patch up into smaller pieces.
Comment at: include/clang/Serialization/ASTBitCodes.h:256
EXTENSION_BLOCK_ID,
+ DIAGNOSTIC_OPTIONS_BLOCK_ID
};
--
STL_MSFT retitled this revision from "[libcxx] [test] Fix a size_t-to-int
truncation warning in error_code.pass.cpp." to "[libcxx] [test] Fix
size_t-to-int truncation warnings in syserr.hash.".
STL_MSFT updated the summary for this revision.
STL_MSFT updated this revision to Diff 81160.
STL_MSFT
ahatanak added a comment.
This doesn't happen for objective-c block pointers. Sema::CheckCastAlign
returns early when the type isn't a PointerType (BlockPointerType isn't a
subclass of PointerType).
https://reviews.llvm.org/D27478
___
cfe-commits
smeenai added a comment.
Pinging above question.
https://reviews.llvm.org/D27153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith added inline comments.
Comment at: include/clang/Serialization/ASTBitCodes.h:256
EXTENSION_BLOCK_ID,
+ DIAGNOSTIC_OPTIONS_BLOCK_ID
};
rsmith wrote:
> Add a comment describing this block.
>
> Please also give this a name that describes
Author: ddcc
Date: Mon Dec 12 19:40:41 2016
New Revision: 289511
URL: http://llvm.org/viewvc/llvm-project?rev=289511&view=rev
Log:
[analyzer] Run clang-format and fix style
Summary: Split out formatting and style changes from D26061
Reviewers: zaks.anna, dcoughlin
Subscribers: cfe-commits
Diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289511: [analyzer] Run clang-format and fix style (authored
by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26691?vs=80128&id=81170#toc
Repository:
rL LLVM
https://reviews.llvm.org/D266
ddcc added a comment.
How does this look now?
https://reviews.llvm.org/D26061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
https://reviews.llvm.org/D26949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai planned changes to this revision.
smeenai added a comment.
Hidden visibility also requires extern template declarations to expand to
default visibility (as opposed to just default type visibility) to be feasible.
Will fix annotations there and add those to this diff.
https://reviews.ll
smeenai planned changes to this revision.
smeenai added a comment.
Hidden visibility also requires extern template declarations to expand to
default visibility (as opposed to just default type visibility) to be feasible.
Will fix annotations there and then roll that macro change into this diff.
Author: stl_msft
Date: Mon Dec 12 19:54:58 2016
New Revision: 289512
URL: http://llvm.org/viewvc/llvm-project?rev=289512&view=rev
Log:
[libcxx] [test] Fix size_t-to-int truncation warnings in syserr.hash.
After r289363, these tests were triggering MSVC x64 warning C4267
"conversion from 'size_t'
ahatanak updated this revision to Diff 81171.
ahatanak added a comment.
Rebase and ping.
https://reviews.llvm.org/D23096
Files:
lib/Sema/SemaTemplate.cpp
lib/Sema/SemaTemplateInstantiate.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/vartemplate-lambda.cpp
test/SemaTemplate/default-expr-ar
ahatanak updated this revision to Diff 81172.
ahatanak added a comment.
Rebase and ping.
https://reviews.llvm.org/D24969
Files:
lib/Sema/SemaTemplateInstantiateDecl.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/destructor.cpp
Index: test/SemaCXX/destructor.cpp
==
Author: smeenai
Date: Mon Dec 12 20:43:04 2016
New Revision: 289513
URL: http://llvm.org/viewvc/llvm-project?rev=289513&view=rev
Log:
[libc++abi] Mark failing test on Darwin as XFAIL
The macOS thread-local variable finalizer routines do not handle the
case where a termination function registers a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289513: [libc++abi] Mark failing test on Darwin as XFAIL
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D27434?vs=80344&id=81174#toc
Repository:
rL LLVM
https://reviews.llv
Author: compnerd
Date: Mon Dec 12 21:27:35 2016
New Revision: 289514
URL: http://llvm.org/viewvc/llvm-project?rev=289514&view=rev
Log:
CodeGen: clean up -Wpedantic warning (NFC)
lib/CodeGen/CGExpr.cpp:2511:2: warning: extra ';' [-Wpedantic]
};
^
Clean up warning from gcc 6.
Modified:
michael.sharpe updated this revision to Diff 81179.
michael.sharpe added a comment.
- Address review comments, check headers for C style headers
https://reviews.llvm.org/D27655
Files:
include/clang/Analysis/Analyses/ThreadSafetyTIL.h
include/clang/Basic/Linkage.h
include/clang/Basic/Targe
michael.sharpe added a comment.
In https://reviews.llvm.org/D27655#619307, @Eugene.Zelenko wrote:
> Did you enable analysis of headers in Clang-tidy?
I had not, thanks for the tip.
Comment at: lib/Lex/ModuleMap.cpp:35
#if defined(LLVM_ON_UNIX)
-#include
+#include
#endif
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
One important thing is missing. Please run this check on a large enough
codebase (LLVM + Clang is a good choice for testing most of kinds of checks
usually) and include a summary of
101 - 128 of 128 matches
Mail list logo
