[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added inline comments.


================
Comment at: include/clang/Serialization/ASTBitCodes.h:256
       EXTENSION_BLOCK_ID,
+      DIAGNOSTIC_OPTIONS_BLOCK_ID
     };
----------------
rsmith wrote:
> Add a comment describing this block.
> 
> Please also give this a name that describes its purpose (to hold records that 
> should not be part of the signature). The signature is not a diagnostic 
> option.
Also add a comma to the end of the line to avoid future additions to the enum 
from touching this line.


https://reviews.llvm.org/D27689



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits