michael.sharpe added a comment. In https://reviews.llvm.org/D27655#619307, @Eugene.Zelenko wrote:
> Did you enable analysis of headers in Clang-tidy? I had not, thanks for the tip. ================ Comment at: lib/Lex/ModuleMap.cpp:35 #if defined(LLVM_ON_UNIX) -#include <limits.h> +#include <climits> #endif ---------------- Eugene.Zelenko wrote: > Could limits be used instead? I built without this line on Ubuntu 16.04 without issue and I couldn't see where any limits were referenced from searching for _MAX or _MIN. I think there might be a benefit to running include-what-you-use on this file, but I don't have the tool set up and will be without access to my personal setup for a couple weeks at the end of the year. https://reviews.llvm.org/D27655 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
