nkakuev added a comment.
@alexfh I'll fix it in a separate review.
https://reviews.llvm.org/D26218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Tue Nov 8 02:28:19 2016
New Revision: 286222
URL: http://llvm.org/viewvc/llvm-project?rev=286222&view=rev
Log:
[clang-tidy] clang-analyzer-alpha* checks are not registered, so there's no
need to disable them
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMai
aymanmus updated the summary for this revision.
aymanmus updated this revision to Diff 77158.
aymanmus added a comment.
Fix spaces and indentations.
https://reviews.llvm.org/D26021
Files:
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/avx512fintrin.h
test/Code
On 8 November 2016 at 08:28, Alexander Kornienko via cfe-commits
wrote:
> [clang-tidy] clang-analyzer-alpha* checks are not registered, so there's no
> need to disable them
Oh, I was using clang-analyzer-alpha.cplusplus.VirtualCall.
Should clang-tidy have an option to enable experimental checks
malcolm.parsons added a comment.
In https://reviews.llvm.org/D25659#588663, @alexfh wrote:
> In https://reviews.llvm.org/D25659#588658, @alexfh wrote:
>
> > I think, silently choosing one of the checks may be confusing and
> > counter-intuitive. Should we just warn in case we see the same check
Author: vbyakovl
Date: Tue Nov 8 04:32:10 2016
New Revision: 286224
URL: http://llvm.org/viewvc/llvm-project?rev=286224&view=rev
Log:
Test commit of vbyakovl.
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
labath added a comment.
If noone objects, I am going to commit this tomorrow.
https://reviews.llvm.org/D25948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
igorb accepted this revision.
igorb added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Headers/avx512fintrin.h:9123
+ __m128 res=__A;
+ res[0] = (__U&1)? __B[0]:__W[0];
+ return res;
.
Comment at: lib/
omtcyfz added inline comments.
Comment at: clang-tidy/rename_check.py:89
- header_guard_old = module.upper() + '_' + check_name.upper().replace('-',
'_')
- header_guard_new = module.upper() + '_' +
check_name_new.upper().replace('-', '_')
+ header_guard_old = args.module.u
omtcyfz updated this revision to Diff 77168.
omtcyfz added a comment.
Addressing comments Alex made about line breaks.
https://reviews.llvm.org/D25074
Files:
clang-tidy/rename_check.py
Index: clang-tidy/rename_check.py
===
--- c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286228: [clang-tidy] Improve rename_check.py. (authored by
omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D25074?vs=77168&id=77169#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2507
Author: aymanmus
Date: Tue Nov 8 06:00:30 2016
New Revision: 286229
URL: http://llvm.org/viewvc/llvm-project?rev=286229&view=rev
Log:
[X86][AVX512][Clang] Add support for mask_{move|store|load}_s{s/d} and
int2mask/mask2int intrinsics.
Differential Revision: https://reviews.llvm.org/D26021
Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286229: [X86][AVX512][Clang] Add support for
mask_{move|store|load}_s{s/d} and… (authored by aymanmus).
Changed prior to commit:
https://reviews.llvm.org/D26021?vs=77158&id=77170#toc
Repository:
rL L
nemanjai added inline comments.
Comment at: include/clang/Basic/BuiltinsPPC.def:304
+BUILTIN(__builtin_vsx_lxvl, "V4ivC*Ui", "")
+BUILTIN(__builtin_vsx_lxvll, "V4ivC*Ui", "")
Also, in addition to guarding for 64-bit, these should be defined to take the
length
sebpop added a comment.
@mclow.lists, @EricWF, ok to commit the patch?
Thanks,
Sebastian
https://reviews.llvm.org/D24991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
In https://reviews.llvm.org/D26157#589033, @pekka.jaaskelainen wrote:
> The uses for the OpenCL logical address spaces that I know of are:
>
> 1. to differentiate local kernel arguments as their memory allocation is
> different (per WG if parallel WGs)
> 2. alias analysis
Author: jtony
Date: Mon Nov 7 22:15:45 2016
New Revision: 286205
URL: http://llvm.org/viewvc/llvm-project?rev=286205&view=rev
Log:
[PowerPC] Implement remaining vector comparison builtins.
vector bool char vec_cmpeq (vector bool char, vector bool char);
vector bool int vec_cmpeq (vector bool int
jtony added a comment.
A very small nit, the bracket does not match in the title, do you mean [PPC]
instead of [PPC}?
Repository:
rL LLVM
https://reviews.llvm.org/D26271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
jtony updated this revision to Diff 77190.
jtony added a comment.
Add -U99 option to git diff to show context for this patch.
https://reviews.llvm.org/D26282
Files:
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-altivec.c
test/CodeGen/builtins-ppc-quadword.c
test/CodeGen/builtins-p
fhahn added a comment.
Ping. It would be great if somebody could have a look at this patch. The
companion LLVM patch https://reviews.llvm.org/D25763
(https://reviews.llvm.org/D25763) has been accepted already.
https://reviews.llvm.org/D25764
___
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: omtcyfz
Date: Tue Nov 8 05:43:50 2016
New Revision: 286228
URL: http://llvm.org/viewvc/llvm-project?rev=286228&view=rev
Log:
[clang-tidy] Improve rename_check.py.
-Start using argparse instead of mimicking CLI parsing.
-PEPify the code.
-Decrease the number of imports by slightly cleanin
Alpha added inline comments.
Comment at: include/clang/Tooling/Core/Diagnostic.h:35
+ DiagnosticMessage(llvm::StringRef Message, const SourceManager &Sources,
+SourceLocation Loc);
+ std::string Message;
alexfh wrote:
> What are the constrai
Alpha updated this revision to Diff 77196.
Alpha added a comment.
Export effectively MainSourceFile.
Change CheckName field.
Add doxygen-style comments.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Files:
include/clang/Tooling/Core/Diagnostic.h
include/clang/Tooling/DiagnosticsYam
Author: djasper
Date: Tue Nov 8 10:11:33 2016
New Revision: 286243
URL: http://llvm.org/viewvc/llvm-project?rev=286243&view=rev
Log:
[clang-format] Remove (SourceManager, FileID) variants
In Format, remove the reformat() and clean() functions taking a SourceManager
and a FileID. Keep the version
xazax.hun updated the summary for this revision.
xazax.hun updated this revision to Diff 77199.
xazax.hun added a comment.
- Added a python script to merge gcov files.
- Fixed an error
- Multifile test is not added yet, will do so in the next update.
https://reviews.llvm.org/D25985
Files:
inc
alexfh added a comment.
In https://reviews.llvm.org/D25659#589081, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25659#588663, @alexfh wrote:
>
> > In https://reviews.llvm.org/D25659#588658, @alexfh wrote:
> >
> > > I think, silently choosing one of the checks may be confusing and
> > >
I'd instead ask Static Analyzer folks if they can graduate this check. What
is your experience with it? Do you feel it's good enough for mainstream?
On Nov 8, 2016 2:11 AM, "Malcolm Parsons" wrote:
> On 8 November 2016 at 08:28, Alexander Kornienko via cfe-commits
> wrote:
> > [clang-tidy] clan
arphaman updated this revision to Diff 77201.
arphaman added a comment.
The updated patch preserves the old behaviour in `-Wshadow-all`
Repository:
rL LLVM
https://reviews.llvm.org/D26278
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaCXX/warn-shadow-i
sdardis added a comment.
Ping.
https://reviews.llvm.org/D25866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:361
+def warn_decl_shadow_all :
+ Warning<"declaration shadows a %select{"
+ "local variable|"
Use the .Text accessor like we do here to avoid repeating the text:
```
def
malcolm.parsons added inline comments.
Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:57
"initializer for base class %0 is redundant")
- << Init->getTypeSourceInfo()->getType()
+ << Construct->getType()
<< FixItHint::Creat
malcolm.parsons added a comment.
In https://reviews.llvm.org/D25659#588658, @alexfh wrote:
> I think, silently choosing one of the checks may be confusing and
> counter-intuitive. Should we just warn in case we see the same check enabled
> by multiple aliases?
A warning is useful if the check
arphaman updated this revision to Diff 77205.
arphaman marked 2 inline comments as done.
arphaman added a comment.
The updated patch introduces a new warning group named
`-Wshadow-uncaptured-local` that was suggested by Reid.
Repository:
rL LLVM
https://reviews.llvm.org/D26278
Files:
incl
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM, sorry for the delay.
https://reviews.llvm.org/D25948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
hokein updated this revision to Diff 77208.
hokein marked 2 inline comments as done.
hokein added a comment.
Fix remaining comments.
https://reviews.llvm.org/D26236
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/test.h
test/clang-move/move-class.cpp
unit
On 8 November 2016 at 16:59, Alexander Kornienko wrote:
> On Nov 8, 2016 2:11 AM, "Malcolm Parsons" wrote:
>> Oh, I was using clang-analyzer-alpha.cplusplus.VirtualCall.
>>
>> Should clang-tidy have an option to enable experimental checks?
>
> I'd instead ask Static Analyzer folks if they can gra
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
rjmccall wrote:
> efriedma wrote:
> > Consider code like the following:
> >
> > int x = 0;
> > auto y1 =
Anastasia accepted this revision.
Anastasia added a comment.
Your code comment seem to describe the issue quite well. Even though I am still
inclined towards keeping the address spaces as long as possible and only
converting into physical memory segments on the backend really. I believe there
a
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D26278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with a few nits.
Comment at: clang-move/ClangMove.cpp:539
+ const FileEntry *FE = SM.getFileManager().getFile(
+ MakeAbsolutePath(OriginalRunningDirectory, OldFile))
smeenai added a comment.
In https://reviews.llvm.org/D26375#588949, @beanz wrote:
> This patch doesn't make sense to me.
>
> In an in-tree build `CMAKE_SOURCE_DIR` would be the LLVM source directory
> which shouldn't match your `CMAKE_BINARY_DIR`.
>
> In an out-of-tree build `CMAKE_SOURCE_DIR` w
Friendly ping:)
On Mon, Oct 31, 2016 at 10:16 PM, Branko Kokanovic
wrote:
> branko created this revision.
> branko added a reviewer: djasper.
> branko added a subscriber: cfe-commits.
> Herald added a subscriber: klimek.
>
> Actual regression was introduced in r272668. This revision fixes JS
> s
kastiglione created this revision.
kastiglione added a reviewer: cfe-commits.
Expose a warning flag for `warn_duplicate_protocol_def`. This allows control
over the severity of duplicate protocol definitions.
For example `-Werror=duplicate-protocol` or
`#pragma clang diagnostic ignored "-Wduplicat
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
With the suggestions above, this LGTM.
https://reviews.llvm.org/D26304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
yaxunl retitled this revision from "[WIP] Add support for non-zero null
pointers" to "Add support for non-zero null pointers".
yaxunl updated this revision to Diff 77210.
yaxunl added a comment.
Fixed list initialization of large struct which are mostly initialized by 0
through memset.
Added tes
Author: alexfh
Date: Tue Nov 8 12:12:56 2016
New Revision: 286257
URL: http://llvm.org/viewvc/llvm-project?rev=286257&view=rev
Log:
Remove mentions of clang-analyzer-alpha
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
clang-tools-extra/trunk/test/clang-tidy/static-analyzer.
Author: djasper
Date: Tue Nov 8 12:29:19 2016
New Revision: 286262
URL: http://llvm.org/viewvc/llvm-project?rev=286262&view=rev
Log:
Remove now unnecessary FormatRewriterContext.
Modified:
cfe/trunk/lib/Index/CommentToXML.cpp
Modified: cfe/trunk/lib/Index/CommentToXML.cpp
URL:
http://llvm.
Author: djasper
Date: Tue Nov 8 12:30:52 2016
New Revision: 286264
URL: http://llvm.org/viewvc/llvm-project?rev=286264&view=rev
Log:
Revert "Remove now unnecessary FormatRewriterContext."
This reverts commit r286262. I accidentally committed it without all of
the changes.
Modified:
cfe/trun
Hello Daniel,
This commit broke at least one of our builders:
http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/234
Please have a look at this?
Thanks
Galina
On Tue, Nov 8, 2016 at 8:11 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
bkramer updated this revision to Diff 77216.
bkramer added a comment.
Herald added subscribers: modocache, mgorny.
Update to head
https://reviews.llvm.org/D23130
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/GlobalNamesCheck.cpp
clang-tidy/google/GlobalNamesCheck.h
clang-tid
bkramer added a comment.
In https://reviews.llvm.org/D23130#588681, @alexfh wrote:
> Benjamin, what's the plan here?
I still think this check is useful, particularly for LLVM. I also don't think
any of the existing review comments still apply or have ever applied in the
first place, so I reba
tony-tye added inline comments.
Comment at: lib/CodeGen/CodeGenTypes.cpp:743
+auto NullPtr = CGM.getNullPtr(LLPT, T);
+return isa(NullPtr);
+ }
Is this correct if the target does not represent a NULL pointer as the address
with value 0? Or should this b
arphaman added a comment.
I'm not sure that it's required, but shouldn't we have also have a test that
checks for the usage of this flag as well? Adding a test case with `#pragma
clang diagnostic ignored "-Wduplicate-protocol"` and some code to a file like
"test/SemaObjC/check-dup-objc-decls-1.
danalbert added a comment.
> This macro (along with ANDROID) should always be defined for Android targets.
What if only `arm-linux-androideabi` (without a version) is specified? We
should be falling back to the old behavior (don't defined `__ANDROID_API__`)
when that happens since that's what e
kastiglione added a comment.
@arphaman I wondered whether this called for a test. I'm happy to add one just
like that.
https://reviews.llvm.org/D26406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:233
+ const DeclContext *DeclCtx, SourceLocation Loc) {
+ return SM.isBeforeInTranslationUnit(SM.getSpellingLoc(D->getLocation()),
+ SM
srhines added a comment.
In https://reviews.llvm.org/D26385#589534, @danalbert wrote:
> > This macro (along with ANDROID) should always be defined for Android
> > targets.
>
> What if only `arm-linux-androideabi` (without a version) is specified? We
> should be falling back to the old behavior
aaron.ballman added inline comments.
Comment at: clang-tidy/google/GlobalNamesCheck.cpp:77
+}
+diag(
+D->getLocStart(),
Is this formatting that clang-format generates?
Comment at: test/clang-tidy/google-global-names.cpp:13-14
+/
oh, sorry for missing this email.
I'll say "no" - I was hoping you'd audit it!
jyknight looked at it and gave me the suggestion to fail the attribute
parsing if, in the non-deprecated syntax, _any_ of the no_sanitize
modifiers are inapplicable to global vars.
On Tue, Oct 25, 2016 at 7:19 PM, Kost
eugenis added a comment.
This is a good change, but I don't think it is the right fix for PR30940.
Instead of handling this in the NDK, we should change *::getIRStackGuard to
fallback to __stack_chk_guard when targeting an old version.
https://reviews.llvm.org/D26385
___
yaxunl added inline comments.
Comment at: lib/CodeGen/CodeGenTypes.cpp:743
+auto NullPtr = CGM.getNullPtr(LLPT, T);
+return isa(NullPtr);
+ }
tony-tye wrote:
> Is this correct if the target does not represent a NULL pointer as the
> address with value 0
hokein updated this revision to Diff 77223.
hokein marked 2 inline comments as done.
hokein added a comment.
Update test to check old header.
https://reviews.llvm.org/D26236
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/test.h
test/clang-move/move-class.c
On Fri, Oct 14, 2016 at 3:55 PM, Douglas Katzman via cfe-commits
wrote:
> Author: dougk
> Date: Fri Oct 14 14:55:09 2016
> New Revision: 284272
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284272&view=rev
> Log:
> Implement no_sanitize_address for global vars
>
> Modified:
> cfe/trunk/incl
george.burgess.iv updated this revision to Diff 77222.
george.burgess.iv added a comment.
Rebased and made the `__builtin_object_size` code a tiny bit cleaner.
The blocks bugfix I mentioned will be up as a separate review in a few minutes.
:)
https://reviews.llvm.org/D14274
Files:
include/c
On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chandlerc
> Date: Thu Nov 3 12:42:32 2016
> New Revision: 285946
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285946&view=rev
> Log:
> Using release to free memory is at best confus
ddcc added a comment.
Even though there isn't a performance difference, I think it is semantically
clearer since it is explicit that the value is unneeded.
The interface of ProgramState provides a `contains()` function that calls into
`Contains()` of the underlying partial traits as part of its
Ah, I see - your follow up in 285950 mentions that this unique_ptr was
always null, so none of it really mattered/did anything.
On Tue, Nov 8, 2016 at 11:42 AM David Blaikie wrote:
> On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Autho
danalbert added a comment.
> It is defines with a value of 0. This allows you to actually do something
> better, IMO.
Can we stick with undefined? That's historically how things have been, and I'm
sure there's code out there depending on that (I had actually written a test
that would depend on
Author: djasper
Date: Tue Nov 8 13:47:19 2016
New Revision: 286279
URL: http://llvm.org/viewvc/llvm-project?rev=286279&view=rev
Log:
Remove FormatContext from libClang as it is now unused.
Modified:
cfe/trunk/include/clang/Index/CommentToXML.h
cfe/trunk/lib/Index/CommentToXML.cpp
Modifi
alexfh added a comment.
> and generally frowned upon in many codebases (e.g. LLVM)
Should it still be a part of google/? The old check was enforcing a part of the
Google C++ style guide, but the new one seems to be somewhat broader. Am I
mistaken?
https://reviews.llvm.org/D23130
__
Fixed in r286279.
On Tue, Nov 8, 2016 at 10:45 AM, Galina Kistanova
wrote:
> Hello Daniel,
>
> This commit broke at least one of our builders:
> http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/234
>
> Please have a look at this?
>
> Thanks
>
> Galina
>
> On Tue, Nov 8, 2016 a
ioeric updated this revision to Diff 77228.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D25771
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests
Author: hokein
Date: Tue Nov 8 13:55:13 2016
New Revision: 286281
URL: http://llvm.org/viewvc/llvm-project?rev=286281&view=rev
Log:
[clang-move] Move all code from old.h/cc directly when moving all class
declarations from old.h.
Summary: When moving all code to new.h/cc, these code also will b
kastiglione updated this revision to Diff 77232.
kastiglione added a comment.
Added test
https://reviews.llvm.org/D26406
Files:
include/clang/Basic/DiagnosticSemaKinds.td
test/Misc/warning-flags.c
test/SemaObjC/check-dup-objc-decls-1.m
Index: test/SemaObjC/check-dup-objc-decls-1.m
=
pcc added a comment.
Ping
https://reviews.llvm.org/D22296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rjmccall.
george.burgess.iv added a subscriber: cfe-commits.
https://reviews.llvm.org/D14274 makes our constexpr evaluator more aggressive
with some variables marked `const`. This changes how we behave on code like the
srhines added a comment.
In https://reviews.llvm.org/D26385#589589, @eugenis wrote:
> This is a good change, but I don't think it is the right fix for PR30940.
> Instead of handling this in the NDK, we should change *::getIRStackGuard to
> fallback to __stack_chk_guard when targeting an old ver
rSerge created this revision.
rSerge added reviewers: dberris, rengolin.
rSerge added subscribers: iid_iunknown, cfe-commits.
Herald added a subscriber: aemerson.
This patch adds XRay support in Clang for AArch64 target.
https://reviews.llvm.org/D26415
Files:
lib/Driver/Tools.cpp
test/Drive
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286281: [clang-move] Move all code from old.h/cc directly
when moving all class… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26236?vs=77223&id=77233#toc
Repository:
rL LL
hokein added a comment.
One more comment, otherwise looks good.
Comment at: change-namespace/ChangeNamespace.cpp:275
+ (DiffOldNsSplitted.empty() ? "-" : DiffOldNsSplitted.front()))
+ .str();
+ auto IsInMovedNs =
Using an invalid name `-` is not
srhines updated this revision to Diff 77236.
srhines added a comment.
Switched to conditionally defining __ANDROID_API__ instead.
https://reviews.llvm.org/D26385
Files:
lib/Basic/Targets.cpp
test/Driver/android-targets.cpp
Index: test/Driver/android-targets.cpp
danalbert accepted this revision.
danalbert added a reviewer: danalbert.
danalbert added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
pcc added a comment.
Ping
https://reviews.llvm.org/D24431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis accepted this revision.
eugenis added a reviewer: eugenis.
eugenis added a comment.
LGTM
https://reviews.llvm.org/D26385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 77238.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Added isNullPtrZero to TargetCodeGenInfo.
https://reviews.llvm.org/D26196
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExprAgg.cpp
lib/CodeGen/CGExprConstant.cpp
lib/CodeGen/CGExp
On Tue, Nov 8, 2016 at 11:27 AM, Douglas Katzman wrote:
> oh, sorry for missing this email.
> I'll say "no" - I was hoping you'd audit it!
>
We do indeed have this practice for post-commit audit, but only for the
authors or active maintainers of the piece of code in question.
I afraid I do not f
On Tue, Nov 8, 2016 at 3:52 PM, Kostya Serebryany via cfe-commits
wrote:
>
>
> On Tue, Nov 8, 2016 at 11:27 AM, Douglas Katzman wrote:
>>
>> oh, sorry for missing this email.
>> I'll say "no" - I was hoping you'd audit it!
>
>
> We do indeed have this practice for post-commit audit, but only for
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
yaxunl wrote:
> rjmccall wrote:
> > efriedma wrote:
> > > Consider code
nkakuev created this revision.
nkakuev added reviewers: malcolm.parsons, alexfh.
nkakuev added a subscriber: cfe-commits.
Currently clang-tidy doesn't provide a practical way to suppress diagnostics
from headers you don't have control over. If using a function defined in such
header causes a fal
efriedma added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
yaxunl wrote:
> yaxunl wrote:
> > rjmccall wrote:
> > > efriedma wrote:
> > > > Consider code like the followin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286295: Define __ANDROID_API__ for all Android builds.
(authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D26385?vs=77236&id=77250#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: srhines
Date: Tue Nov 8 15:23:26 2016
New Revision: 286295
URL: http://llvm.org/viewvc/llvm-project?rev=286295&view=rev
Log:
Define __ANDROID_API__ for all Android builds.
Summary:
Bug: https://llvm.org/bugs/show_bug.cgi?id=30940
This macro (along with __ANDROID__) should always be defi
srhines added a comment.
Ugh, phabricator dropped my updated commit message, so that is completely wrong
now. Oh well. I guess I will just use repo/gerrit for staging things in the
future (and get consensus there) before asking for any upstream reviews.
Repository:
rL LLVM
https://reviews.l
Eugene.Zelenko added a comment.
I think will be good idea to mention this in documentation and release notes.
https://reviews.llvm.org/D26418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1340
+ return C;
+return getNullPtr(PT, DestType);
}
efriedma wrote:
> yaxunl wrote:
> > yaxunl wrote:
> > > rjmccall wrote:
srhines created this revision.
srhines added subscribers: danalbert, eugenis, pirama, cfe-commits.
Herald added a subscriber: tberghammer.
This reverts commit a8804ddd9fe71304b28e5b834d134fe93e568ee0.
https://reviews.llvm.org/D26422
Files:
lib/Basic/Targets.cpp
test/Driver/android-targets.c
1 - 100 of 159 matches
Mail list logo
