omtcyfz added inline comments.
================
Comment at: clang-tidy/rename_check.py:89
- header_guard_old = module.upper() + '_' + check_name.upper().replace('-',
'_')
- header_guard_new = module.upper() + '_' +
check_name_new.upper().replace('-', '_')
+ header_guard_old = args.module.upper() + '_' + \
+ args.old_check_name.upper().replace('-', '_')
----------------
alexfh wrote:
> Does PEP8 have any preferences with regard to using a terminating backslash
> over enclosing an expression that needs to be wrapped in parentheses? If no,
> I'd better use parentheses.
Hm, apparently it [[
https://www.python.org/dev/peps/pep-0008/#maximum-line-length | does ]].
> The preferred way of wrapping long lines is by using Python's implied line
> continuation inside parentheses, brackets and braces. Long lines can be
> broken over multiple lines by wrapping expressions in parentheses. These
> should be used in preference to using a backslash for line continuation.
Didn't know it, though. Thank you for pointing it out!
https://reviews.llvm.org/D25074
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
