ABataev added a comment.
Add a test
Comment at: include/clang/AST/Stmt.h:697
+ SourceLocation ellipsisLoc, SourceLocation colonLoc,
+ Stmt *SubStmt=nullptr)
: SwitchCase(CaseStmtClass, caseLoc, colonLoc) {
I don't think you need this ne
Author: eladcohen
Date: Mon Oct 31 03:21:54 2016
New Revision: 285548
URL: http://llvm.org/viewvc/llvm-project?rev=285548&view=rev
Log:
[Modules] Add a command line option for loading the clang builtins modulemap.
-fbuiltin-module-map loads the clang builtins modulemap file. (This is
equivalent t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285548: [Modules] Add a command line option for loading the
clang builtins modulemap. (authored by eladcohen).
Changed prior to commit:
https://reviews.llvm.org/D25767?vs=75133&id=76355#toc
Repository:
eladcohen added a comment.
Thanks for the review! committed r285548.
Repository:
rL LLVM
https://reviews.llvm.org/D25767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Mon Oct 31 03:28:29 2016
New Revision: 285549
URL: http://llvm.org/viewvc/llvm-project?rev=285549&view=rev
Log:
[change-namespace] fix namespace specifiers of template arguments.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
clang-tools-extra/
Author: rogfer01
Date: Mon Oct 31 03:47:53 2016
New Revision: 285550
URL: http://llvm.org/viewvc/llvm-project?rev=285550&view=rev
Log:
Change from "XFAIL: libcpp-no-exceptions" to "UNSUPPORTED:
libcpp-no-exceptions" tests that only check exceptions and nothing else
This is a follow up of D24562.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285550: Change from "XFAIL: libcpp-no-exceptions" to
"UNSUPPORTED: libcpp-no… (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26075?vs=76190&id=76360#toc
Repository:
rL LLV
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D26132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ABataev added inline comments.
Comment at: include/clang/AST/ExprCXX.h:4265
+ CoawaitDependentExpr(SourceLocation KeywordLoc, QualType Ty, Expr *Op,
+ UnresolvedSet<16> OperatorCandidates)
+ : Expr(CoawaitDependentExprClass, Ty, VK_RValue, OK_Ordinary,
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
This is another followup of https://reviews.llvm.org/D24562
These tests are of the form
try {
action-that-may-throw
assert(!exceptional-condition)
a
rmaprath added inline comments.
Comment at: test/std/strings/basic.string/string.access/at.pass.cpp:41
+const S& cs = s;
+if (pos < cs.size())
+{
For the cases where an exception //should've been// thrown, are we not entering
the **undefined** domain
Author: mzuckerm
Date: Mon Oct 31 04:37:59 2016
New Revision: 28
URL: http://llvm.org/viewvc/llvm-project?rev=28&view=rev
Log:
[x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage
Commit on behalf of mharoush
After LGTM and check all:
This patch enables usage of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL28: [x86][inline-asm] Introducing (AVX512) k0-k7
registers for inline-asm usage (authored by mzuckerm).
Changed prior to commit:
https://reviews.llvm.org/D25011?vs=72787&id=76370#toc
Repository:
rogfer01 added inline comments.
Comment at: test/std/strings/basic.string/string.access/at.pass.cpp:41
+const S& cs = s;
+if (pos < cs.size())
+{
rmaprath wrote:
> For the cases where an exception //should've been// thrown, are we not
> entering the
Alpha created this revision.
Alpha added reviewers: alexfh, klimek, djasper.
Alpha added a subscriber: cfe-commits.
Herald added subscribers: fhahn, mgorny.
Add a field indicating the associated check for every replacement to the YAML
report generated with the '-export-fixes' option.
Update clang
rmaprath added inline comments.
Comment at: test/std/strings/basic.string/string.access/at.pass.cpp:41
+const S& cs = s;
+if (pos < cs.size())
+{
rogfer01 wrote:
> rmaprath wrote:
> > For the cases where an exception //should've been// thrown, are we
Author: mzuckerm
Date: Mon Oct 31 05:12:36 2016
New Revision: 285556
URL: http://llvm.org/viewvc/llvm-project?rev=285556&view=rev
Log:
Revert reviosion 28
Removed:
cfe/trunk/test/CodeGen/avx512-inline-asm-kregisters-basics.c
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/tru
Author: bader
Date: Mon Oct 31 05:26:31 2016
New Revision: 285557
URL: http://llvm.org/viewvc/llvm-project?rev=285557&view=rev
Log:
[OpenCL] Setting constant address space for array initializers
Summary: Setting constant address space for global constants used for
memcpy-initialization of arrays
bader added a comment.
Committed at 285557 with updated tests.
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh, klimek.
malcolm.parsons added subscribers: cfe-commits, danielmarjamaki.
Herald added a subscriber: mgorny.
Fixes PR27872
https://reviews.llvm.org/D26138
Files:
clang-tidy/modernize/CMakeLists.txt
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
These files have two styles of tests
// First style
try {
action
assert(something-expected);
} catch ( exception ) {
assert(false);
}
// Seco
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip these tests under libcpp-no-exceptions.
https://reviews.llvm.org/D26141
Files:
test/std/numerics/rand/rand.device/ctor.pass.cpp
test/std/numerics/rand/rand
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
In these tests there are some paths that explicitly throw, so use
the TEST_THROW macro that was proposed for this and then skip the tests
that may enter the throwing p
EricWF created this revision.
EricWF added reviewers: rsmith, silvas, manmanren.
EricWF added a subscriber: cfe-commits.
When merging definitions with ModulesLocalVisibility enabled it's important to
make deleted definitions implicitly inline, otherwise they'll be diagnosed as a
redefinition.
EricWF updated this revision to Diff 76384.
EricWF added a comment.
Add test case.
https://reviews.llvm.org/D26143
Files:
lib/Sema/SemaDeclCXX.cpp
test/Modules/Inputs/merge-decl-context/a.h
Index: test/Modules/Inputs/merge-decl-context/a.h
=
Author: rafael
Date: Mon Oct 31 06:47:37 2016
New Revision: 285561
URL: http://llvm.org/viewvc/llvm-project?rev=285561&view=rev
Log:
Fix this test when we have clang-offload-bundler.exe.
Modified:
cfe/trunk/test/Driver/openmp-offload.c
Modified: cfe/trunk/test/Driver/openmp-offload.c
URL:
h
sdardis updated the summary for this revision.
sdardis updated this revision to Diff 76385.
sdardis added a comment.
Split out a variant of tryVectorConvertAndSplat called
tryGCCVectorConvertAndSplat. This variant checks the types more strictly than
tryVectorConvertAndSplat and handles implicit
Author: mzuckerm
Date: Mon Oct 31 07:05:41 2016
New Revision: 285563
URL: http://llvm.org/viewvc/llvm-project?rev=285563&view=rev
Log:
[x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage
Commit on behalf of mharoush
After LGTM and check all:
This patch enables usage o
EricWF marked 10 inline comments as done.
EricWF added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:237-244
+static UnresolvedSet<16> lookupOperatorCoawaitCall(Sema &SemaRef, Scope *S,
+ SourceLocation Loc,
+
EricWF updated this revision to Diff 76386.
EricWF added a comment.
Mark some review comments as complete.
https://reviews.llvm.org/D26057
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/StmtNodes.
sammccall added a comment.
Thanks Daniel.
I don't have commit access, could you land this?
https://reviews.llvm.org/D26132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:237-244
+static UnresolvedSet<16> lookupOperatorCoawaitCall(Sema &SemaRef, Scope *S,
+ SourceLocation Loc,
+ E
vleschuk created this revision.
vleschuk added reviewers: mehdi_amini, echristo, dblaikie, aprantl.
vleschuk added a subscriber: cfe-commits.
Mark C11 _Atomic variables with DW_TAG_atomic_type tag.
This is the simplest way to achieve the goal: modifying Qualifiers results in
much more changes an
EricWF added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:237-244
+static UnresolvedSet<16> lookupOperatorCoawaitCall(Sema &SemaRef, Scope *S,
+ SourceLocation Loc,
+ Ex
Author: mzuckerm
Date: Mon Oct 31 07:49:36 2016
New Revision: 285565
URL: http://llvm.org/viewvc/llvm-project?rev=285565&view=rev
Log:
revert r285563 fail in test CodeGen/avx512-inline-asm-kregisters-basics.c
Removed:
cfe/trunk/test/CodeGen/avx512-inline-asm-kregisters-basics.c
Modified:
EricWF updated this revision to Diff 76390.
EricWF marked an inline comment as done.
EricWF added a comment.
- Use `MultiExprArg` in place of `MutableArrayRef`.
Thanks for looking at this @ABataev!
https://reviews.llvm.org/D26057
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/Recursi
Author: djasper
Date: Mon Oct 31 08:18:25 2016
New Revision: 285569
URL: http://llvm.org/viewvc/llvm-project?rev=285569&view=rev
Log:
clang-format: [JS] Fix missing space after 'yield'.
Before:
class X {
delete(val) {
return null;
}
* gen() {
yield[1, 2];
}
* gen
Author: djasper
Date: Mon Oct 31 08:23:00 2016
New Revision: 285570
URL: http://llvm.org/viewvc/llvm-project?rev=285570&view=rev
Log:
Skip over AnnotatedLines with >50 levels of nesting; don't format them.
Reasoning:
- ExpressionParser uses a lot of stack for these, bad in some environments.
- Ou
djasper closed this revision.
djasper added a comment.
Committed as r285570.
https://reviews.llvm.org/D26132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Under -fno-exceptions TEST_THROW becomes abort / __builtin_abort which returns
void. This causes a type mismatch in the conditional operator when testing the
library
sepavloff created this revision.
sepavloff added a subscriber: cfe-commits.
This change adds to the method isThisDeclarationADefinition additional
conditions under which a function declaration becomes a definition.
These includes the case of a declaration that does not have a function
body because
logan updated this revision to Diff 76394.
logan added a comment.
Refine assertions to address the comments from mclow.lists.
https://reviews.llvm.org/D24085
Files:
src/cxa_personality.cpp
test/lit.cfg
test/lit.site.cfg.in
test/native/arm-linux-eabi/lit.local.cfg
test/native/arm-linux
EricWF added a comment.
Is `ON` the right default for ARM? If so please apply the inline comment to fix
the default settings.. Otherwise this LGTM.
Comment at: CMakeLists.txt:117
option(LIBCXXABI_ENABLE_WERROR "Fail and stop if a warning is triggered." OFF)
option(LIBCXXABI_
EricWF planned changes to this revision.
EricWF added a comment.
I think there's a better way to do this. The implicitly created initial and
final suspend also require the overload set for operator co_await, so I think
a better approach would be to store the lookup results inside `FunctionDecl`
EricWF added inline comments.
Comment at: CMakeLists.txt:117
option(LIBCXXABI_ENABLE_WERROR "Fail and stop if a warning is triggered." OFF)
option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." OFF)
option(LIBCXXABI_USE_COMPILER_RT "Use compiler-rt instead of l
logan added a comment.
Hi @EricWF and @mclow.lists:
Do you have any comments?
https://reviews.llvm.org/D24082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D26147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: ericwf
Date: Mon Oct 31 09:14:04 2016
New Revision: 285571
URL: http://llvm.org/viewvc/llvm-project?rev=285571&view=rev
Log:
Spell libcxxabi-no-threads correctly
Modified:
libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp
Modified: libcxxabi/trunk/test/cxa_thread_atexit_test.pass.
Author: rogfer01
Date: Mon Oct 31 09:14:13 2016
New Revision: 285572
URL: http://llvm.org/viewvc/llvm-project?rev=285572&view=rev
Log:
Fix archetypes.hpp under libcpp-no-extensions and std level < 14
Under -fno-exceptions TEST_THROW becomes abort / __builtin_abort which returns
void. This causes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285572: Fix archetypes.hpp under libcpp-no-extensions and
std level < 14 (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26147?vs=76393&id=76399#toc
Repository:
rL LLVM
ht
Author: mzuckerm
Date: Mon Oct 31 09:16:57 2016
New Revision: 285573
URL: http://llvm.org/viewvc/llvm-project?rev=285573&view=rev
Log:
second attempt at r285565.
Added:
cfe/trunk/test/CodeGen/avx512-inline-asm-kregisters-basics.c
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/tr
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:467
+StringRef getName(const NamedDecl *ND) {
+ if (!ND->getIdentifier())
+return StringRef();
This logic could be improved as:
```
if (const auto *ID = ND->getIdentifier(
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
https://reviews.llvm.org/D26138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG modulo comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:498
+auto addDeclRefs = [this, Block,
+DeclRefs](const SmallVectorImpl &Matc
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Sorry for the delay. Feel free to ping earlier.
One more comment, otherwise looks good.
Comment at: docs/clang-tidy/checks/modernize-use-auto.rst:163
+The check handles ``st
Author: uweigand
Date: Mon Oct 31 09:38:05 2016
New Revision: 285578
URL: http://llvm.org/viewvc/llvm-project?rev=285578&view=rev
Log:
[SystemZ] Add -march=archX aliases
For compatibility with other compilers on the platform, allow specifying
levels of the z/Architecture instead of model names wi
malcolm.parsons updated this revision to Diff 76404.
malcolm.parsons added a comment.
Change doc to say "C-style casts".
https://reviews.llvm.org/D25316
Files:
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize/UseAutoCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/moderniz
Author: malcolm.parsons
Date: Mon Oct 31 09:43:37 2016
New Revision: 285579
URL: http://llvm.org/viewvc/llvm-project?rev=285579&view=rev
Log:
[clang-tidy] Enhance modernize-use-auto to casts
Summary:
Extend modernize-use-auto to cases when a variable is assigned with a cast.
e.g.
Type *Ptr1 = dy
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Removing from my dashboard. Ping me once you have a new patch.
Repository:
rL LLVM
https://reviews.llvm.org/D22725
___
cfe-commits m
Author: malcolm.parsons
Date: Mon Oct 31 09:48:49 2016
New Revision: 285581
URL: http://llvm.org/viewvc/llvm-project?rev=285581&view=rev
Log:
Fix link to check
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285579: [clang-tidy] Enhance modernize-use-auto to casts
(authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25316?vs=76404&id=76405#toc
Repository:
rL LLVM
https://rev
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, howard.hinnant, ikudrin, mclow.lists.
smeenai added a subscriber: cfe-commits.
Mach-O defaults to two-level namespaces, so `calloc` cannot be
interpositoned. Override it via the default malloc zone instead.
Note: `DYLD_FORC
malcolm.parsons updated this revision to Diff 76410.
malcolm.parsons added a comment.
Add to release notes.
https://reviews.llvm.org/D26138
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDeleteCheck.cpp
clang-tidy/moderniz
Author: smeenai
Date: Mon Oct 31 10:09:10 2016
New Revision: 285582
URL: http://llvm.org/viewvc/llvm-project?rev=285582&view=rev
Log:
[libc++] Add configuration define for off_t functions
Create this define in __config and use it elsewhere, instead of checking
the operating system/library defines
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285582: [libc++] Add configuration define for off_t
functions (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D25741?vs=75142&id=76411#toc
Repository:
rL LLVM
https://review
Author: malcolm.parsons
Date: Mon Oct 31 10:15:00 2016
New Revision: 285583
URL: http://llvm.org/viewvc/llvm-project?rev=285583&view=rev
Log:
Add -frtti for Windows buildbot.
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-auto-cast-remove-stars.cpp
clang-tools-extra/trun
How/what output are these producing if they're meant to fail ("not" in the
test line) anyway?
& these tests should probably check the diagnostic result to be more
precise than "Clang exited with a non-zero exit code".
On Thu, Oct 27, 2016 at 1:54 AM Dean Michael Berris via cfe-commits <
cfe-commi
On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Thu Oct 27 08:30:51 2016
> New Revision: 285289
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285289&view=rev
> Log:
> [Sema] -Wunused-variable warning for array variables
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285585: [x86][inline-asm] Add support for curly brackets
escape using "%" in extended… (authored by mzuckerm).
Changed prior to commit:
https://reviews.llvm.org/D25012?vs=73602&id=76415#toc
Repository:
Author: mzuckerm
Date: Mon Oct 31 10:27:54 2016
New Revision: 285585
URL: http://llvm.org/viewvc/llvm-project?rev=285585&view=rev
Log:
[x86][inline-asm] Add support for curly brackets escape using "%" in extended
inline asm.
Commit on behalf of mharoush
After LGTM and check all:
This patch is
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
On Thu, Oct 27, 2016 at 6:02 AM Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> bkramer accepted this revision.
> bkramer added a comment.
> This revision is now accepted and ready to land.
>
> This makes sense. While variable definitions in a header are weird, the
> warning
aaron.ballman added a reviewer: lukasza.
aaron.ballman added a subscriber: lukasza.
aaron.ballman added a comment.
I think this is the right way to go, but I know that @klimek and @lukasza have
been working on `hasDeclaration()` issues recently, so I am wondering what
their thoughts are as well.
malcolm.parsons updated this revision to Diff 76418.
malcolm.parsons added a comment.
Rebase.
https://reviews.llvm.org/D25898
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmartPtrCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/modernize-make-shared.rst
Author: malcolm.parsons
Date: Mon Oct 31 10:48:01 2016
New Revision: 285589
URL: http://llvm.org/viewvc/llvm-project?rev=285589&view=rev
Log:
[clang-tidy] Enhance modernize-make-unique to handle unique_ptr.reset()
Summary:
Avoid naked new in unique_ptr.reset() by using make_unique
Fixes http://l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285589: [clang-tidy] Enhance modernize-make-unique to handle
unique_ptr.reset() (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25898?vs=76418&id=76419#toc
Repository:
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
LGTM with inline comments addressed.
Comment at: test/CodeGen/debug-info-atomic.c:3
+
+// CHECK: !DIDerivedType(tag: DW_TAG_const_type
+// CHECK: !DIDerivedType(tag: DW_TAG
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
malcolm.parsons added a comment.
ping.
https://reviews.llvm.org/D25659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
"Use delete" makes me think of the `delete` operator. I'd suggest one of these
names:
- modernize-use-equals-delete
- modernize-use-deleted-special-members
- modernize-delete-special-members
(feel free to suggest a better alternative).
Comment at: cla
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26138#583561, @alexfh wrote:
> "Use delete" makes me think of the `delete` operator. I'd suggest one of
> these names:
I chose modernize-use-delete as there's already modernize-use-default.
"Use default" makes me think of the `defau
Hi David,
On Reid's patch for this (D25581), Richard said, "This takes the alignment in
bits? That's so ridiculously dumb that I would feel bad about accepting this
patch unless it comes with a warning for people writing the obvious-but-wrong
__builtin_alloca_with_align(sizeof(T), alignof(T))".
malcolm.parsons added a comment.
ping @alexfh.
https://reviews.llvm.org/D25406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
LGTM
https://reviews.llvm.org/D26141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285591: [x86][inline-asm][AVX512][llvm][PART-2] (authored by
mzuckerm).
Changed prior to commit:
https://reviews.llvm.org/D25062?vs=75278&id=76429#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
malcolm.parsons updated this revision to Diff 76431.
malcolm.parsons added a comment.
Rename to modernize-use-equals-delete.
Add comment.
https://reviews.llvm.org/D26138
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseEqualsD
malcolm.parsons updated this revision to Diff 76433.
malcolm.parsons added a comment.
Sort headers and CMakeLists.txt.
https://reviews.llvm.org/D26138
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseEqualsDeleteCheck.cpp
cl
aaron.ballman added a comment.
Does this check properly work in the presence of macros? Those are sometimes
more common in casting operations, so a few explicit tests would be good (those
tests could be follow-on work if it turns out that this check doesn't play
nicely with macros).
Author: majnemer
Date: Mon Oct 31 11:48:30 2016
New Revision: 285595
URL: http://llvm.org/viewvc/llvm-project?rev=285595&view=rev
Log:
Use toCharUnitsFromBits instead of TargetInfo::getCharWidth
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
lukasza added a comment.
FWIW, a non-owner LGTM:
- CXXNewExpr seems very similar to CallExpr, so it makes sense that
hasDeclaration would behave similarily for both of these expressions (i.e.
matching the "callee")
- The issues we've been trying to work through in
https://reviews.llvm.org/D243
vleschuk added inline comments.
Comment at: test/CodeGen/debug-info-atomic.c:3
+
+// CHECK: !DIDerivedType(tag: DW_TAG_const_type
+// CHECK: !DIDerivedType(tag: DW_TAG_atomic_type
aprantl wrote:
> Why do we need the const here?
I thought it would be better to mak
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:404
+[](const Expr *Expr) { return Expr->getType(); },
+"use auto when initializing with new to avoid "
+"duplicating the type name");
vleschuk updated this revision to Diff 76441.
vleschuk added a comment.
Made test more strict: it now checks that variable i is atomic.
https://reviews.llvm.org/D26145
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-atomic.c
Index: test/CodeGen/debug-info-atomic.c
=
Author: malcolm.parsons
Date: Mon Oct 31 12:17:45 2016
New Revision: 285601
URL: http://llvm.org/viewvc/llvm-project?rev=285601&view=rev
Log:
Add modernize-use-auto tests for casts inside macros
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-auto-cast-remove-stars.cpp
cl
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks! Could you please address the last comment before committing?
Comment at: test/CodeGenOpenCL/convergent.cl:54
+// CHECK: tail call spir_func void @f()
+// CHECK-NOT: call spir_func void @non_convfun()
+//
Author: mzuckerm
Date: Mon Oct 31 12:23:52 2016
New Revision: 285604
URL: http://llvm.org/viewvc/llvm-project?rev=285604&view=rev
Log:
[x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints
for extended inline assembly, enabling use of AVX512 masked vectorized
instructions
Anastasia added a comment.
Additional discussions:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161024/175373.html
https://reviews.llvm.org/D25343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Anastasia closed this revision.
Anastasia added a comment.
Committed in r285395
https://reviews.llvm.org/D25935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285604: [x86][inline-asm][AVX512][clang][PART-1] Introducing
"k" and "Yk" constraints… (authored by mzuckerm).
Changed prior to commit:
https://reviews.llvm.org/D25063?vs=75542&id=76445#toc
Repository:
Author: dergachev
Date: Mon Oct 31 12:27:26 2016
New Revision: 285605
URL: http://llvm.org/viewvc/llvm-project?rev=285605&view=rev
Log:
[analyzer] MacOSXAPIChecker: Disallow dispatch_once_t in ivars and heap.
Unlike global/static variables, calloc etc. functions that allocate ObjC
objects behave
1 - 100 of 199 matches
Mail list logo
