On Thu, Oct 27, 2016 at 6:02 AM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> bkramer accepted this revision. > bkramer added a comment. > This revision is now accepted and ready to land. > > This makes sense. While variable definitions in a header are weird, the > warning that they're unused isn't adding any value. > I'm not sure that's true - the warning will then fire for users of the header that don't use the variable... I'd like to know about the mistake ahead of time to avoid breaking my users. (yes, certain headers could require their variables to be used - but that is a slightly niche requirement that could be addressed with a ((used)) attribute) Also - does the same thing apply to static functions in headers? - Dave > > > https://reviews.llvm.org/D25990 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
