Author: ericwf
Date: Thu Oct 27 13:43:28 2016
New Revision: 285331
URL: http://llvm.org/viewvc/llvm-project?rev=285331&view=rev
Log:
[coroutines] Add diagnostics for copy/move assignment operators and functions
with deduced return types.
Summary: The title says it all. Additionally this patch re
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
As a unique_ptr or shared_ptr that has been moved from is guaranteed to be null,
we only warn if the pointer is dereferenced.
https://reviews.llvm.org/D26041
Files:
clang-tidy/misc/UseAft
sfantao added a comment.
A PR was generated as requested by Hal explaining why we do not generate jobs
for NVPTX targets yet.
https://llvm.org/bugs/show_bug.cgi?id=30812
https://reviews.llvm.org/D21845
___
cfe-commits mailing list
cfe-commits@list
joerg added a comment.
The __ namespace is shared between all parts of the implementation, not just
the compiler. The convention in the past was that compiler keywords will end in
a __ as well, but calling conventions and Objective C broke that convention. I
still think it is something that sho
Hello everyone,
LLVM buildmaster will be updated and restarted at 3 PM Pacific time today.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
timshen marked an inline comment as done.
timshen added inline comments.
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374
std::cmatch m;
const char s[] = "tournament";
+assert(std::regex_match(s, m, std::regex("tour|to|tournament")));
loladiro added a comment.
I came across a situation again where this would be useful to have. I know this
was approved, but looking it looks like I wanted @majnemer to have another look.
https://reviews.llvm.org/D13330
___
cfe-commits mailing list
timshen updated this revision to Diff 76088.
timshen added a comment.
Added http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#2273 as
comments.
https://reviews.llvm.org/D26026
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp
Index: libcxx/test/st
loladiro added a comment.
Since this was approved, I'll rebase and commit.
Repository:
rL LLVM
https://reviews.llvm.org/D13419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
loladiro added a comment.
Ok then, will commit.
Repository:
rL LLVM
https://reviews.llvm.org/D24372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jwhowarth added a comment.
In https://reviews.llvm.org/D25932#581167, @mehdi_amini wrote:
> I just verified that I reproduce with -flto and an previous clang version.
This issue will only be triggered if you build with
"-DCMAKE_INSTALL_PREFIX:PATH=/sw/opt/llvm-4.0" to place llvm in a buried
s
falho updated this revision to Diff 76072.
falho marked an inline comment as done.
falho added a comment.
in cpp diagnostics message: comma changed back to semicolon, + curly braces
removed
testfiles corrected accordingly
https://reviews.llvm.org/D22346
Files:
clang-tidy/cert/CERTTidyModule.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for working on this!
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
falho added a comment.
Cool! Thank you for the reviews!
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz added a comment.
This looks like it is in the direction I would expect. Please let me know once
the final patch is ready.
Comment at: lib/Driver/Tools.cpp:2021
std::string Plugin =
- ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so";
+
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL285060. Please specify "Differential
revision: " as last line of commit message.
https://reviews.llvm.org/D25657
___
cfe-commits mailing li
loladiro updated this revision to Diff 76094.
loladiro added a comment.
Rebased patch
Repository:
rL LLVM
https://reviews.llvm.org/D13419
Files:
lib/AST/Decl.cpp
lib/AST/DeclCXX.cpp
test/CodeGenCXX/visibility.cpp
Index: test/CodeGenCXX/visibility.cpp
==
loladiro added a comment.
Hmm, the rebased version of this introduces new errors in
`test/Modules/cxx-templates.cpp`. That test didn't exist when I wrote this code
and I'm not familiar with templates. @rsmith could you take a look, error is:
error: 'error' diagnostics seen but not expected:
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM.
Comment at: test/Analysis/number-object-conversion.m:98
+
+#define NULL_INSIDE_MACRO NULL
+void test_NULL_inside_macro(NSNumber *p) {
This is great! And a good catch.
https://reviews.llvm.org/
EricWF updated this revision to Diff 76095.
EricWF added a comment.
- Disallow classes with inherited constructors
- Add tests under `test/CXX/drs/dr15xx.cpp`
I still only implemented this change in C++1z, please let me know if you want
me to backport the DR.
https://reviews.llvm.org/D25654
F
Author: rsmith
Date: Thu Oct 27 15:55:56 2016
New Revision: 285341
URL: http://llvm.org/viewvc/llvm-project?rev=285341&view=rev
Log:
Add documentation describing the components of a complete toolchain including
Clang.
Added:
cfe/trunk/docs/Toolchain.rst
Modified:
cfe/trunk/docs/UsersManu
majnemer added a comment.
I think this looks good but I'd like @rsmith to take a look.
https://reviews.llvm.org/D13330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
>> Actually, I always test first on real code, and it seemed to be inlined. But
>> now, even if I
>> removed the pragma it was not inlined.
Looks like this patch is interfering with this inlining suppression. We had
many false positives without it. Mainly, the analy
chandlerc added a comment.
I don't get it.
There is nothing "RUNTIMES" about it. And this variable is actually used to
produce real libraries: libclang, etc.
It's just the LIBDIR_SUFFIX. That's it. The reason it is called
CLANG_LIBDIR_SUFFIX and set from LLVM_LIBDIR_SUFFIX is to support using
loladiro set the repository for this revision to rL LLVM.
loladiro updated this revision to Diff 76102.
loladiro added a comment.
Rebased on current master.
Repository:
rL LLVM
https://reviews.llvm.org/D13330
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/cl
mgorny added a comment.
In https://reviews.llvm.org/D23752#581416, @chandlerc wrote:
> I don't get it.
>
> There is nothing "RUNTIMES" about it. And this variable is actually used to
> produce real libraries: libclang, etc.
>
> It's just the LIBDIR_SUFFIX. That's it. The reason it is called
> C
Author: stl_msft
Date: Thu Oct 27 16:25:12 2016
New Revision: 285346
URL: http://llvm.org/viewvc/llvm-project?rev=285346&view=rev
Log:
[PATCH] D25483: [libcxx] [test] Fix non-Standard assumptions about how many
elements are allocated
Modified:
libcxx/trunk/test/std/containers/sequences/deque
chandlerc added a comment.
In https://reviews.llvm.org/D23752#581427, @mgorny wrote:
> In https://reviews.llvm.org/D23752#581416, @chandlerc wrote:
>
> > I don't get it.
> >
> > There is nothing "RUNTIMES" about it. And this variable is actually used to
> > produce real libraries: libclang, etc.
STL_MSFT closed this revision.
STL_MSFT added a comment.
Committed r285346. Thanks!!
https://reviews.llvm.org/D25483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On 27 Oct 2016, at 13:25, Erik Verbruggen wrote:
>
> Eh? Preprocessor::IsFileLexer(const IncludeStackInfo &) is static and doesn't
> need 'this'... Apparently MSVC mistakingly confuses that method with the
> non-static Preprocessor::IsFileLexer() method?
You’re not kidding, its incredibly a
mgorny added a comment.
This really doesn't solve the problems we have. We don't want to build and
install two almost-identical copies of compiler-rt and clang headers, when we
can just build one and make clang use it.
https://reviews.llvm.org/D23752
chandlerc added a comment.
In https://reviews.llvm.org/D23752#581436, @mgorny wrote:
> This really doesn't solve the problems we have. We don't want to build and
> install two almost-identical copies of compiler-rt and clang headers, when we
> can just build one and make clang use it.
However
Author: zaks
Date: Thu Oct 27 16:38:44 2016
New Revision: 285349
URL: http://llvm.org/viewvc/llvm-project?rev=285349&view=rev
Log:
[docs] Update the TSan and MSan docs to refer to the new no_sanitize attribute
TSan and MSan were the only remaining sanitizers referring to the deprecated
attribute
This revision was automatically updated to reflect the committed changes.
timshen marked an inline comment as done.
Closed by commit rL285352: [libcxx] Make regex_match backtrack when search
fails (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D26026?vs=76088&id=76109#
Author: timshen
Date: Thu Oct 27 16:40:34 2016
New Revision: 285352
URL: http://llvm.org/viewvc/llvm-project?rev=285352&view=rev
Log:
[libcxx] Make regex_match backtrack when search fails
Summary:
Fixes PR19851.
alg.re.match/ecma.pass.cpp still XFAILS on linux, but after commenting out
locale-rel
rnk added a comment.
Remember the fight over _Atomic with MSVC's STL? The fallacy of the
implementer's namespace is that there is only one implementer.
https://llvm.org/bugs/show_bug.cgi?id=19043
We should prefer adding `__attribute__`s and `__declspec`s instead of keywords
when possible.
htt
erichkeane added a comment.
In https://reviews.llvm.org/D25204#581469, @rnk wrote:
> Remember the fight over _Atomic with MSVC's STL? The fallacy of the
> implementer's namespace is that there is only one implementer.
> https://llvm.org/bugs/show_bug.cgi?id=19043
>
> We should prefer adding `__
dberris added a comment.
It was in the .cpp file, and was mostly trailing whitespace. This is what I did:
curl
https://reviews.llvm.org/file/data/d72xn56ybspvx3ovex36/PHID-FILE-vzd63mvia62eq7e32iho/D24799.diff
| git apply - -p0 --whitespace=fix
And I got the following:
:6: trailing whites
rnk added a comment.
In https://reviews.llvm.org/D25204#581477, @erichkeane wrote:
> In general, I can see the benefit of this rule, however in the case of
> calling conventions, I would think that keeping them all orthogonal is
> important. Having "most" calling conventions work one way, and
rsmith created this revision.
rsmith added reviewers: mclow.lists, EricWF.
rsmith added a subscriber: cfe-commits.
rsmith set the repository for this revision to rL LLVM.
Clang would like to enable some language-version-specific functionality only if
the installed C++ standard library supports it
erichkeane updated this revision to Diff 76117.
erichkeane added a comment.
Remove single-underscore version of _regcall kw.
https://reviews.llvm.org/D25204
Files:
include/clang-c/Index.h
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clan
jlebar updated this revision to Diff 76118.
jlebar added a comment.
Add WillHaveBody flag.
https://reviews.llvm.org/D25640
Files:
clang/include/clang/AST/Decl.h
clang/lib/AST/Decl.cpp
clang/lib/Sema/SemaDecl.cpp
clang/test/SemaCUDA/gnu-inline.cu
Index: clang/test/SemaCUDA/gnu-inline.cu
jlebar added a comment.
OK, I can add new flags with the best of 'em.
I got rid of a super ugly hack I found that was working around the same problem
I was trying to work around here. (And I verified that if I don't call
setWillHaveBody, a testcase fails.) I can split this out into two patche
Author: rtrieu
Date: Thu Oct 27 19:15:24 2016
New Revision: 285370
URL: http://llvm.org/viewvc/llvm-project?rev=285370&view=rev
Log:
Fix a crash on invalid code.
The diagnostic was attempting to access the QualType of a TypeDecl by calling
TypeDecl::getTypeForDecl. However, the Type pointer stor
spyffe created this revision.
spyffe added reviewers: bruno, akyrtzi, a.sidorin.
spyffe added a subscriber: cfe-commits.
When the `ASTImporter`imports a source location, it avoids importing macro
expansions by calling `getSpellingLoc()`. That's great in most cases, but for
macros defined in the
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added subscribers: cfe-commits, rsmith.
Herald added a subscriber: mehdi_amini.
This patch has two primary changes:
1. Defines a new AST node `CoawaitDependentExpr` for representing co_await
expressions while the p
EricWF updated this revision to Diff 76157.
EricWF added a comment.
- Remove old FIXME
- Correct doc for CoawaitDependentExpr.
https://reviews.llvm.org/D26057
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/DiagnosticSemaKinds.td
include/cl
EricWF added inline comments.
Comment at: lib/AST/ExprClassification.cpp:191
case Expr::DesignatedInitUpdateExprClass:
+ // FIXME How should we classify co_await expressions while they're still
+ // dependent?
@rsmith: What's the correct way to classify this
syzaara updated this revision to Diff 76110.
syzaara added a comment.
Remove extra blank line.
https://reviews.llvm.org/D26002
Files:
include/clang/Basic/BuiltinsPPC.def
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-p9vector.c
Index: test/CodeGen/builtins-ppc-p9vector.c
===
Author: bruno
Date: Thu Oct 27 21:30:45 2016
New Revision: 285377
URL: http://llvm.org/viewvc/llvm-project?rev=285377&view=rev
Log:
[Modules] Add testcase for builtins used in umbrella headers
This used to work before r284797 + r285152, which exposed something
interesting; some users include buil
Author: bruno
Date: Thu Oct 27 21:37:04 2016
New Revision: 285378
URL: http://llvm.org/viewvc/llvm-project?rev=285378&view=rev
Log:
[Modules] Make test from r285377 darwin specific
Appease buildbots:
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/55876
Modified:
cfe/trunk/test/Mod
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added subscribers: cfe-commits, rgov, NoQ, xazax.hun.
Herald added a subscriber: mgorny.
SimpleConstraintManager is difficult to use, and makes assumptions about
capabilities of the constraint manager. This patch refacto
EricWF created this revision.
EricWF added reviewers: rsmith, mclow.lists.
EricWF added subscribers: cfe-commits, rsmith.
This patch presents an alternative approach to adding a <__version> header and
including it from <__config>.
Instead of using a `<__version>` header this patch adds a `__libc
EricWF added a comment.
@rsmith I would really like to avoid the cost of an additional include in
`<__config>`. Would something like https://reviews.llvm.org/D26062 work instead?
Repository:
rL LLVM
https://reviews.llvm.org/D26044
___
cfe-commit
ddcc added a comment.
To summarize, here is a list of changes:
- General
- Fixed some issues with formatting (`clang-format`)
- Fixed inconsistent capitalization following camel case style guidelines
- `ConstraintManager.h`
- Renamed `assumeWithinInclusiveRange*()` to `assumeInclusiveRange
loladiro added a comment.
I found a bug in this which I need to fix, but while I'm at it, in doing more
testing on this, I came across the following corner case:
template
struct static_separate_template {
typedef T element;
static T *a_static_field;
};
extern template struct
rsmith added a comment.
This is perfect for my needs, thanks!
https://reviews.llvm.org/D26062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks great, thanks.
Comment at: clang/lib/Sema/SemaDecl.cpp:5762-5768
-#ifndef NDEBUG
- // AST quite reasonably asserts that it's working on a function
- // definition. W
sepavloff created this revision.
sepavloff added a subscriber: cfe-commits.
Clang makes check for function redefinition after it merged the new
declaration with the existing one. As a result, it produces poor
diagnostics in the case of a friend function defined inline, as in
the code:
void func
Author: ericwf
Date: Fri Oct 28 01:06:50 2016
New Revision: 285382
URL: http://llvm.org/viewvc/llvm-project?rev=285382&view=rev
Log:
Add __libcpp_version file and __libcpp_library_version function.
This patch does two seperate things. First it adds a file called
"__libcpp_version" which only cont
Hahnfeld added a comment.
I think these changes have been contributed to trunk in multiple commits so
this can be closed?
https://reviews.llvm.org/D9888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
EricWF closed this revision.
EricWF added a comment.
r285382.
https://reviews.llvm.org/D26062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Fri Oct 28 01:09:44 2016
New Revision: 285383
URL: http://llvm.org/viewvc/llvm-project?rev=285383&view=rev
Log:
Update mac ABI list
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
libcxx/trunk/lib/abi/x86_64-apple-darwin16.0.abilist
Modified: libcxx/trunk/lib/abi/CHANGE
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
An alternative solution has been committed.
Repository:
rL LLVM
https://reviews.llvm.org/D26044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF updated this revision to Diff 76167.
EricWF added a comment.
- Suppress diagnostics caused during the initial name lookup for
`await_transform`, `return_value` and `return_void` since these diagnostics
will get re-emitted if we actually build the calls.
- add more tests.
https://reviews
EricWF added a comment.
Sorry no progress yet. I've been working on bigger bugs relating to our
handling of file times. Once I get those worked out I'll fix this.
https://reviews.llvm.org/D22452
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Author: ericwf
Date: Fri Oct 28 01:40:29 2016
New Revision: 285384
URL: http://llvm.org/viewvc/llvm-project?rev=285384&view=rev
Log:
Add more tests for optional
Modified:
libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/U.pass.cpp
libcxx/trunk/test/std/utili
101 - 168 of 168 matches
Mail list logo
