mgorny added a comment. In https://reviews.llvm.org/D23752#581416, @chandlerc wrote:
> I don't get it. > > There is nothing "RUNTIMES" about it. And this variable is actually used to > produce real libraries: libclang, etc. > > It's just the LIBDIR_SUFFIX. That's it. The reason it is called > CLANG_LIBDIR_SUFFIX and set from LLVM_LIBDIR_SUFFIX is to support using the > CMake build of Clang in a standalone mode where there *isn't* a > LLVM_LIBDIR_SUFFIX and instead the CLANG_LIBDIR_SUFFIX needs to be set > directly. > > So I'm really not understanding what benefit this change is bringing. > > And the other comment in the CMake file that the CLANG_LIBDIR_SUFFIX must > exactly match whatever LLVM_LIBDIR_SUFFIX is remains, AFAICT, 100% correct. That is 100% incorrect. LLVM_LIBDIR_SUFFIX is used almost everywhere, mostly because it goes implicitly through LLVM's CMake macros. CLANG_LIBDIR_SUFFIX is truly only used to set the paths in the sources. https://reviews.llvm.org/D23752 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
