EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM modulo inline comments.
Comment at: CMakeLists.txt:310
@@ -309,4 +309,3 @@
-# Remove flags that may have snuck in.
-remove_flags(-DNDEBUG -UNDEBUG -D_DEBUG
-
alexshap added a subscriber: alexshap.
Comment at: clang-rename/RenamingAction.cpp:74
@@ +73,3 @@
+ // FIXME: As for clang-rename, adding a replacement fails IFF either the
+ // AST node has been matched multiple times (which shouldn't happen in
+ // reality, need t
omtcyfz added inline comments.
Comment at: clang-rename/RenamingAction.cpp:74
@@ +73,3 @@
+ // FIXME: As for clang-rename, adding a replacement fails IFF either the
+ // AST node has been matched multiple times (which shouldn't happen in
+ // reality, need to fix th
alexshap added inline comments.
Comment at: clang-rename/RenamingAction.cpp:74
@@ +73,3 @@
+ // FIXME: As for clang-rename, adding a replacement fails IFF either the
+ // AST node has been matched multiple times (which shouldn't happen in
+ // reality, need to fix t
mgorny created this revision.
mgorny added reviewers: rafael, theraven, ismail.
mgorny added a subscriber: cfe-commits.
Assume OpenSUSE distribution only when /etc/SuSE-release indicates OpenSUSE,
rather than for any SUSE distribution. This reverts the behavior change from
rL185537 which -- alon
ismail added a comment.
This will break SLES11 and later so it's not OK. Also note that SLES10 is not
supported anymore.
https://reviews.llvm.org/D24954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
hokein updated this revision to Diff 72608.
hokein added a comment.
Address review comments
https://reviews.llvm.org/D24928
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
Index: unittests/ASTMatchers/AST
dvyukov added a comment.
LGTM
Any other comments? Or I will submit it tomorrow.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:7
@@ +6,3 @@
+// RUN: %clangxx_asan -std=c++11 -lpthread -O3 %s -o %t && %run %t 2>&1 |
FileCheck %s
+// RUN: %clangxx_asan -std=c++1
eladcohen added a comment.
ping
https://reviews.llvm.org/D24752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL282474: [ASTMatcher] Clarify isStaticStorageClass and
hasStaticStorageDuration… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24928?vs
Author: hokein
Date: Tue Sep 27 02:53:20 2016
New Revision: 282474
URL: http://llvm.org/viewvc/llvm-project?rev=282474&view=rev
Log:
[ASTMatcher] Clarify isStaticStorageClass and hasStaticStorageDuration
documents.
Reviewers: aaron.ballman
Subscribers: klimek, cfe-commits
Differential Revision
Author: mgorny
Date: Tue Sep 27 02:55:26 2016
New Revision: 282475
URL: http://llvm.org/viewvc/llvm-project?rev=282475&view=rev
Log:
[cmake] Strip possibly-inherited compiler flags in in-tree build only
Strip the set of flags (including debug defs, -m32) that could
be inherited from top-level LLV
This revision was automatically updated to reflect the committed changes.
mgorny marked an inline comment as done.
Closed by commit rL282475: [cmake] Strip possibly-inherited compiler flags in
in-tree build only (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24809?vs=7
mgorny marked an inline comment as done.
mgorny added a comment.
Thanks for the review. Tested and committing now.
Comment at: CMakeLists.txt:310
@@ -309,4 +309,3 @@
-# Remove flags that may have snuck in.
-remove_flags(-DNDEBUG -UNDEBUG -D_DEBUG
- -stdlib=libc++ -
Author: hokein
Date: Tue Sep 27 02:58:52 2016
New Revision: 282476
URL: http://llvm.org/viewvc/llvm-project?rev=282476&view=rev
Log:
[clang-tidy] Use isStaticStorageClass ast matcher.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp
Modi
Author: hokein
Date: Tue Sep 27 03:01:04 2016
New Revision: 282477
URL: http://llvm.org/viewvc/llvm-project?rev=282477&view=rev
Log:
[clang-move] Use isStaticStorageClass matcher.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
Modified: clang-tools-extra/trunk/clang-move/ClangMov
hokein updated this revision to Diff 72613.
hokein added a comment.
Rebase to master
https://reviews.llvm.org/D24922
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_template.json
test/clang-move/Inputs/test.cpp
a.sidorin updated the summary for this revision.
a.sidorin added reviewers: ABataev, aaron.ballman.
a.sidorin updated this revision to Diff 72614.
a.sidorin added a comment.
Merge patch https://reviews.llvm.org/D24807 to both fix segmentation fault and
provide a test for it.
https://reviews.llv
omtcyfz added inline comments.
Comment at: clang-rename/RenamingAction.cpp:74
@@ +73,3 @@
+ // FIXME: As for clang-rename, adding a replacement fails IFF either the
+ // AST node has been matched multiple times (which shouldn't happen in
+ // reality, need to fix th
omtcyfz updated this revision to Diff 72616.
omtcyfz added a comment.
Slightly change wording.
https://reviews.llvm.org/D24914
Files:
clang-rename/RenamingAction.cpp
Index: clang-rename/RenamingAction.cpp
===
--- clang-rename/Re
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:33
@@ +32,3 @@
+ auto EC = llvm::sys::fs::make_absolute(InitialDirectory, AbsolutePath);
+ assert(!EC);
+ (void)EC;
This doesn't seems to be good error handling... maybe also print an error
mes
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D24719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
danielmarjamaki added a comment.
Compiling 2064 projects resulted in 904 warnings
Here are the results:
https://drive.google.com/file/d/0BykPmWrCOxt2N04tYl8zVHA3MXc/view?usp=sharing
The results looks acceptable imho. The code looks intentional in many cases so
I believe there are users that wil
ABataev added inline comments.
Comment at: lib/AST/ASTImporter.cpp:3414
@@ +3413,3 @@
+ // FriendDecl is not a NamedDecl so we cannot use localUncachedLookup.
+ CXXRecordDecl *RD = cast(DC);
+ FriendDecl *ImportedFriend = RD->getFirstFriend();
CXXRecordDecl *RD
mgorny retitled this revision from "[ToolChains] Do not assume OpenSUSE for
other SUSE variants" to "[ToolChains] Disable OpenSUSE rules for SLES10".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 72609.
mgorny added a comment.
Does this one look better for you
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:62
@@ +61,3 @@
+ return MakeAbsolutePath(SourceManager, FileEntry->getName()) ==
+ AbsoluteFilePath;
+}
ioeric wrote:
> To generalize the function, maybe also remove dots in `AbsoluteFileP
hokein updated this revision to Diff 72619.
hokein marked 8 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D24922
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
test/clang-move/Inputs/database_
xazax.hun added inline comments.
Comment at: test/clang-tidy/readability-misleading-indentation.cpp:16
@@ +15,3 @@
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: wrong indentation,
'else' belongs to 'if(cond2)' statement
+ // CHECK-FIXES: {{^}} // commen
Author: hokein
Date: Tue Sep 27 05:43:38 2016
New Revision: 282480
URL: http://llvm.org/viewvc/llvm-project?rev=282480&view=rev
Log:
[include-fixer] Add customized editor settings documents.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D24719
Modi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282480: [include-fixer] Add customized editor settings
documents. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24719?vs=71792&id=72623#toc
Repository:
rL LLVM
https://rev
Author: nemanjai
Date: Tue Sep 27 05:45:22 2016
New Revision: 282481
URL: http://llvm.org/viewvc/llvm-project?rev=282481&view=rev
Log:
[Power9] Builtins for ELF v.2 ABI conformance - front end portion
This patch corresponds to review:
https://reviews.llvm.org/D24397
It adds the __POWER9_VECTOR__
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 282481.
Repository:
rL LLVM
https://reviews.llvm.org/D24397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:177-178
@@ +176,4 @@
+ /// - are insertions at the same offset and applying them in either order
+ /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the
+ /// other
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:177-178
@@ +176,4 @@
+ /// - are insertions at the same offset and applying them in either order
+ /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the
+ /// other
a.sidorin updated this revision to Diff 72625.
a.sidorin added a comment.
Address review comments; add accidentally missed file.
https://reviews.llvm.org/D14326
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/DeclFriend.h
lib/AST/ASTImporter.cpp
lib/Serialization/ASTReaderStmt.
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp:195
@@ +194,3 @@
+if (Optional S = I->getAs()) {
+ if (isa(S->getStmt()))
+return S->getStmt();
Maybe I would prefer something like !isa which is a
zizhar created this revision.
zizhar added a reviewer: rnk.
zizhar added a subscriber: cfe-commits.
zizhar set the repository for this revision to rL LLVM.
A test for the patch in https://reviews.llvm.org/D24957
Repository:
rL LLVM
https://reviews.llvm.org/D24958
Files:
test/CodeGen/ms-inli
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:177-178
@@ +176,4 @@
+ /// - are insertions at the same offset and applying them in either order
+ /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the
+ /// other
Author: mgorny
Date: Tue Sep 27 07:15:35 2016
New Revision: 282483
URL: http://llvm.org/viewvc/llvm-project?rev=282483&view=rev
Log:
[cmake] Add linker option "-Wl,-z,defs" in standalone build
Add the "-Wl,-z,defs" linker option that is used to prevent
underlinking. It is already used by LLVM its
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282483: [cmake] Add linker option "-Wl,-z,defs" in
standalone build (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24119?vs=69944&id=72632#toc
Repository:
rL LLVM
https://r
Author: aaronballman
Date: Tue Sep 27 07:17:05 2016
New Revision: 282484
URL: http://llvm.org/viewvc/llvm-project?rev=282484&view=rev
Log:
Silencing a Sphinx diagnostic with options, again.
Warning, treated as error:
/opt/llvm/build.attributes.src/tools/clang/docs/CommandGuide/clang.rst:413:
WAR
ioeric updated this revision to Diff 72635.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Replace dummy binary with unit test with dummy environemnt + fake codebase.
https://reviews.llvm.org/D24380
Files:
CMakeLists.txt
migrate-tool/AffectedFilesFinder.h
migrate-tool/
Author: ioeric
Date: Tue Sep 27 07:54:48 2016
New Revision: 282486
URL: http://llvm.org/viewvc/llvm-project?rev=282486&view=rev
Log:
Workaround ASTMatcher crashes. Added some more test cases.
Summary:
- UsingDecl matcher crashed when `UsingShadowDecl` has no parent map.
Workaround by moving pare
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282486: Workaround ASTMatcher crashes. Added some more test
cases. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24862?vs=72284&id=72640#toc
Repository:
rL LLVM
https://re
aymanmus created this revision.
aymanmus added reviewers: m_zuckerman, igorb, delena.
aymanmus added a subscriber: cfe-commits.
- "//_mm512_cmp_pd_mask//" Intrinsics, where = {eq, le, lt, neq, nle,
nlt, ord, unord}.
- //_mm512_cvtepi32lo_pd, _mm512_mask_cvtepi32lo_pd, _mm512_cvtepu32lo_pd,
_mm5
ioeric added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+ Replacements Rs(R);
+ Replacements ShiftedRs(getReplacementInChangedCode(R));
+ Replacements ShiftedReplaces;
+
ioeric updated this revision to Diff 72642.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24800
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
igorb accepted this revision.
igorb added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
r282433 added LLVM_ATTRIBUTE_ALWAYS_INLINE to the StringRef(const char *)
constructor. This causes the size of the stack frame for
RegistryMaps::RegistryMaps
rmaprath added a subscriber: rmaprath.
Comment at: libcxx/trunk/CMakeLists.txt:329
@@ +328,3 @@
+ ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND
+ NOT LLVM_USE_SANITIZER)
+set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
Perh
mboehme abandoned this revision.
mboehme added a comment.
Abandoning after discussion with klimek.
https://reviews.llvm.org/D24962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aymanmus
Date: Tue Sep 27 09:06:32 2016
New Revision: 282488
URL: http://llvm.org/viewvc/llvm-project?rev=282488&view=rev
Log:
[avx512] Add aliases to some missing avx512 intrinsics.
Differential Revision:https: //reviews.llvm.org/D24961
Modified:
cfe/trunk/lib/Headers/avx512fintrin.
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D24963
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
==
zlei added inline comments.
Comment at: libcxx/trunk/CMakeLists.txt:329
@@ +328,3 @@
+ ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND
+ NOT LLVM_USE_SANITIZER)
+set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
rmaprath wrote:
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
ioeric abandoned this revision.
ioeric added a comment.
Abandon in favor of https://reviews.llvm.org/D24800
https://reviews.llvm.org/D24717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rmaprath added inline comments.
Comment at: src/config.h:22
@@ +21,3 @@
+
+#if defined(__GNUC__) || defined(__clang__)
+#define _LIBCXXABI_PRAGMA(_parameter_) _Pragma(#_parameter_)
EricWF wrote:
> What's the point of defining `_LIBCXXABI_WARNING`? It's unused and
rmaprath added inline comments.
Comment at: libcxx/trunk/CMakeLists.txt:329
@@ +328,3 @@
+ ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND
+ NOT LLVM_USE_SANITIZER)
+set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
zlei wrote:
malcolm.parsons created this revision.
malcolm.parsons added reviewers: alexfh, aaron.ballman, omtcyfz.
malcolm.parsons added subscribers: cfe-commits, mgehre.
Herald added a subscriber: nemanjai.
Handle classes with default constructors that are defaulted or are not
present in the AST.
Classes wi
rmaprath updated this revision to Diff 72653.
rmaprath added a comment.
Herald added subscribers: mgorny, beanz.
Address review comments from @compnerd and @EricWF.
https://reviews.llvm.org/D24864
Files:
CMakeLists.txt
src/config.h
src/cxa_exception.cpp
src/cxa_exception_storage.cpp
s
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM with two minor nits.
Comment at: lib/AST/ASTImporter.cpp:5563-5564
@@ +5562,4 @@
+const TemplateArgumentLoc *FromArgArray = E->getTemplateArgs();
+for (unsigned i = 0, e = E->getNumTemplateArgs();
On Tue, Sep 27, 2016 at 12:15:35PM -, Michal Gorny via cfe-commits wrote:
> Author: mgorny
> Date: Tue Sep 27 07:15:35 2016
> New Revision: 282483
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282483&view=rev
> Log:
> [cmake] Add linker option "-Wl,-z,defs" in standalone build
>
> Add the
Author: aymanmus
Date: Tue Sep 27 10:37:31 2016
New Revision: 282492
URL: http://llvm.org/viewvc/llvm-project?rev=282492&view=rev
Log:
Update to commit r282488, fix the buildboot failure.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Modified: cfe/trunk/lib/Headers/avx512fintrin.h
URL:
ht
klimek added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+llvm::Expected
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+ Replacements Rs(R);
+ Replacements RsShiftedByReplaces(getReplacementInChangedCode(R));
+ Repla
ioeric added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+llvm::Expected
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+ Replacements Rs(R);
+ Replacements RsShiftedByReplaces(getReplacementInChangedCode(R));
+ Repla
ioeric updated this revision to Diff 72666.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24800
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
ahatanak created this revision.
ahatanak added reviewers: doug.gregor, rsmith.
ahatanak added a subscriber: cfe-commits.
This fixes PR30361.
clang was failing to compile the test case because it was passing "~C1"
instead of "~C1" to FindInstantiatedDecl and RebuildMemberExpr.
https://reviews.ll
Author: anemet
Date: Tue Sep 27 11:15:21 2016
New Revision: 282500
URL: http://llvm.org/viewvc/llvm-project?rev=282500&view=rev
Log:
Adapt to LLVM optimization remark interface change. NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL
Author: anemet
Date: Tue Sep 27 11:39:27 2016
New Revision: 282504
URL: http://llvm.org/viewvc/llvm-project?rev=282504&view=rev
Log:
Revert "Adapt to LLVM optimization remark interface change. NFC"
This reverts commit r282500.
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/
bruno added a subscriber: bruno.
Comment at: lib/Headers/module.modulemap:133
@@ -131,2 +132,3 @@
explicit module aes {
+ export sse2
header "__wmmintrin_aes.h"
The mmx case above makes sense to me, but I find conceptually odd that we need
to re-
bruno added a subscriber: bruno.
bruno added a comment.
Hi Daniel,
This is very nice.
In https://reviews.llvm.org/D24861#553606, @danielmarjamaki wrote:
> Compiling 2064 projects resulted in 904 warnings
>
> Here are the results:
> https://drive.google.com/file/d/0BykPmWrCOxt2N04tYl8zVHA3MXc/v
mgehre added a comment.
Thank your very much for your comments!
Let me try to give me reasoning for those points:
1. But it's missing some pieces, like test cases
I though about how to test this, having no semantic meaning itself.
I could look at the AST dump, but it does not even show the
rules
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
I have no further comments.
https://reviews.llvm.org/D24278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
mgehre updated this revision to Diff 72677.
mgehre added a comment.
Rename the struct that was introduced in the test. Note that I need to keep the
function Bug30487,
because that is where the false-positive warning was emitted.
https://reviews.llvm.org/D24848
Files:
clang-tidy/utils/TypeTra
On Tue, Sep 27, 2016 at 2:05 PM, Matthias Gehre wrote:
> mgehre updated this revision to Diff 72677.
> mgehre added a comment.
>
> Rename the struct that was introduced in the test. Note that I need to keep
> the function Bug30487,
> because that is where the false-positive warning was emitted.
Anastasia added inline comments.
Comment at: include/clang/Basic/OpenCLOptions.h:39
@@ +38,3 @@
+
+ void set(llvm::StringRef Ext, bool Enable = true) {
+assert(!Ext.empty() && "Extension is empty.");
yaxunl wrote:
> Better add a comments for this function abo
aaron.ballman added a comment.
In https://reviews.llvm.org/D24886#554130, @mgehre wrote:
> Thank your very much for your comments!
> Let me try to give me reasoning for those points:
>
> 1. But it's missing some pieces, like test cases I though about how to test
> this, having no semantic meani
jlebar created this revision.
jlebar added a reviewer: rsmith.
jlebar added subscribers: cfe-commits, jhen, tra.
These cause us to consider all functions in-between to be __host__
__device__.
You can nest these pragmas; you just can't have more 'end's than
'begin's.
https://reviews.llvm.org/D249
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
This matches the idiom we use for our other CUDA wrapper headers.
https://reviews.llvm.org/D24978
Files:
clang/lib/Frontend/CompilerInvocation.cpp
clan
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, cfe-commits.
Currently we declare our inline __device__ math functions in namespace
std. But libstdc++ and libc++ declare these functions in an inline
namespace inside namespace std. We need to match this
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/functions.cpp:7
@@ -6,3 +6,3 @@
-int max(int a, int b) { // expected-warning{{Detected code clone.}}
+int max(int a, int b) { // expected-warning{{Clone of this code was detected}}
log();
"w
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, jhen.
Herald added subscribers: mgorny, beanz.
We do this by wrapping and .
Tests are in the test-suite. support to come separately.
https://reviews.llvm.org/D24979
Files:
clang/lib/Driver/To
mgorny reopened this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
I'm starting to regret that I've committed this. It breaks horribly any
pure-LLVM build, i.e. without linking to libgcc_s. It seems that the build
system is completely unprepared to link to co
Author: mgorny
Date: Tue Sep 27 13:54:02 2016
New Revision: 282524
URL: http://llvm.org/viewvc/llvm-project?rev=282524&view=rev
Log:
Revert r282483 - [cmake] Add linker option "-Wl,-z,defs" in standalone build
Revert r282483 as it causes build failures due to missing symbols when
not linking to -
malcolm.parsons added a subscriber: malcolm.parsons.
malcolm.parsons added a comment.
In https://reviews.llvm.org/D24886#554130, @mgehre wrote:
> 2. Also, I suspect we will want this attribute to also be written on types I
> was thinking about a case were that was useful, and didn't find any. Wh
rmaprath added a comment.
In https://reviews.llvm.org/D24119#554234, @mgorny wrote:
> I'm starting to regret that I've committed this. It breaks horribly any
> pure-LLVM build, i.e. without linking to libgcc_s. It seems that the build
> system is completely unprepared to link to compiler-rt or
malcolm.parsons added a comment.
In https://reviews.llvm.org/D24848#554145, @mgehre wrote:
> Rename the struct that was introduced in the test. Note that I need to keep
> the function Bug30487,
> because that is where the false-positive warning was emitted.
https://reviews.llvm.org/D24965 wil
alexshap added inline comments.
Comment at: clang-rename/RenamingAction.cpp:74
@@ +73,3 @@
+ // FIXME: An error might happen here if USRLocFinder finds the symbol
+ // twice or if the symbol happens to be in a header included multiple
+ // times independently. Such
omtcyfz added inline comments.
Comment at: clang-rename/RenamingAction.cpp:74
@@ +73,3 @@
+ // FIXME: An error might happen here if USRLocFinder finds the symbol
+ // twice or if the symbol happens to be in a header included multiple
+ // times independently. Such e
tra added a comment.
LGTM. Should we add new pragma description to docs/LanguageExtensions.rst ?
https://reviews.llvm.org/D24975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: matze
Date: Tue Sep 27 14:38:59 2016
New Revision: 282533
URL: http://llvm.org/viewvc/llvm-project?rev=282533&view=rev
Log:
Adapt to LLVM EnableStatistics() change.
Modified:
cfe/trunk/lib/Frontend/CompilerInstance.cpp
cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
Mo
mgorny added a comment.
In https://reviews.llvm.org/D24119#554251, @rmaprath wrote:
> Doesn't `-DLIBCXXABI_USE_LLVM_UNWINDER=ON` make it possible to build without
> `libgcc_s`? Or is this something else?
It's supposed to but it doesn't add the necessary libraries when linking
libc++.so.
Rep
arphaman created this revision.
arphaman added a reviewer: vsk.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a regression introduced in r262697 that changed the way the
coverage regions for switch are constructed. The PGO ins
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
That is way too much knowledge about details of standard library implementation.
If it changes, I suspect users will end up with a rather uninformative error.
Is there a way to produce somewhat more s
rmaprath created this revision.
rmaprath added reviewers: jroelofs, compnerd, logan.
rmaprath added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
The EHABI unwinder is thread-agnostic, SJLJ unwinder and the DWARF unwinder
have a couple of `pthread` dependencies.
This patch
jlebar added a comment.
> That is way too much knowledge about details of standard library
> implementation.
Honestly I think this looks a lot scarier than it is. Or, to be specific, I
think we are already relying on implementation details much more implicit and
fragile than what is explicit
tra added a subscriber: echristo.
tra added a comment.
This looks like fix-includes and it may be somewhat shaky if users start
messing with include paths. You may want to get @echristo's input on that. I'
personally would prefer to force-include these files. I suspect it will not
change things
tra added a comment.
OK.
https://reviews.llvm.org/D24977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
It makes sense to inherit the current region's counter when we see a new
switch. That should fix the 0 execution count we see on the condition.
Repository:
rL LLVM
https://revi
jlebar added a comment.
> I' personally would prefer to force-include these files. I suspect it will
> not change things much as we already include a lot.
We have already had bugs filed by users whose root cause was that we #included
more things than nvcc #includes. I know exact compatibility
1 - 100 of 149 matches
Mail list logo
