omtcyfz added inline comments. ================ Comment at: clang-rename/RenamingAction.cpp:74 @@ +73,3 @@ + // FIXME: An error might happen here if USRLocFinder finds the symbol + // twice or if the symbol happens to be in a header included multiple + // times independently. Such error doesn't mean clang-rename failure and ---------------- alexshap wrote: > My concerns were about wording, the new version looks good to me. > I think the long-term fix would be to improve the interface of the class > Replacements, > but it's clearly not in the scope of this patch (the other tools have the > same issue), > so to me your diff is OK. Eric actually has a patch for that: https://reviews.llvm.org/D24800
https://reviews.llvm.org/D24914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
